From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02787C43603 for ; Sat, 14 Dec 2019 02:32:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C9F872253D for ; Sat, 14 Dec 2019 02:32:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576290744; bh=Eqc89Omw2jaNSyVCeKQpbJEzJvaQOE+Lhw+SBNFW1as=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=FcO0FJOXWFMMd+3hxoFY/eyK9zGuRrV+KZ62SbPJVbfGdabI9JE6F7LgORvbZC4Yd RYMZfN3VcIZrRac8Ts34j0MznHuVqpR+RWgeyV3POBjRHA1RQIVXtt7m2/MDxqFRGk Dhy7yQsS8SFIlvMdL8dYHUf2iwFG5kzJSD1AOnAw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726422AbfLNCcY (ORCPT ); Fri, 13 Dec 2019 21:32:24 -0500 Received: from mail.kernel.org ([198.145.29.99]:47278 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726046AbfLNCcY (ORCPT ); Fri, 13 Dec 2019 21:32:24 -0500 Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DE4E724671; Sat, 14 Dec 2019 02:32:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576290743; bh=Eqc89Omw2jaNSyVCeKQpbJEzJvaQOE+Lhw+SBNFW1as=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=jZkbjakqLdjtzYgUNB/HYiBz3IBx4bt7kPaHKKN2tdiyTsc/jpOHeRDwVOQnR+K6Q su3Hi4gSfXWdv4OJ7ZXcgYPwxPVXUMKtoBZHIGiQEZLm+cCpc8+qFZUjagsB56r0Gw XQYDJVWfe4jc6/Tz2U9yjeSzMr2sPxMdZ4YluL8Q= Received: by mail-wr1-f45.google.com with SMTP id b6so812910wrq.0; Fri, 13 Dec 2019 18:32:22 -0800 (PST) X-Gm-Message-State: APjAAAXC8vFip97N4hbjqo/xPgZO86PeUuCoASHLumyE4GCxj/1l1N6/ FTz9D88rTYXgplYFcHorQSsB+rjjDjHExbxB7tk= X-Google-Smtp-Source: APXvYqydbgYkBfEkSoHYnoVFyJ9oQyanZL22yafvKiwGMvhkX5QHDVviEUybs0JIej2bMIEu5E4NYaiS2pFxFoLorOM= X-Received: by 2002:adf:81e3:: with SMTP id 90mr15946921wra.23.1576290741171; Fri, 13 Dec 2019 18:32:21 -0800 (PST) MIME-Version: 1.0 References: <20191213125414.90725-1-boris.brezillon@collabora.com> <20191213125414.90725-6-boris.brezillon@collabora.com> <20191213152332.GF4860@pendragon.ideasonboard.com> <20191213162550.59730f89@collabora.com> In-Reply-To: <20191213162550.59730f89@collabora.com> From: Chen-Yu Tsai Date: Sat, 14 Dec 2019 10:32:12 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 5/7] media: dt-bindings: rockchip: Document RK3399 Video Decoder bindings To: Boris Brezillon Cc: Laurent Pinchart , Mauro Carvalho Chehab , Hans Verkuil , Sakari Ailus , Linux Media Mailing List , Rob Herring , Mark Rutland , devicetree , Tomasz Figa , Nicolas Dufresne , kernel@collabora.com, Paul Kocialkowski , Ezequiel Garcia , Jonas Karlman , "open list:ARM/Rockchip SoC..." , Heiko Stuebner Content-Type: text/plain; charset="UTF-8" Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Sat, Dec 14, 2019 at 4:38 AM Boris Brezillon wrote: > > On Fri, 13 Dec 2019 17:23:32 +0200 > Laurent Pinchart wrote: > > > Hi Boris, > > > > Thank you for the patch. > > > > On Fri, Dec 13, 2019 at 01:54:12PM +0100, Boris Brezillon wrote: > > > Document the Rockchip RK3399 Video Decoder bindings. > > > > > > Signed-off-by: Boris Brezillon > > > --- > > > Changes in v3: > > > * Fix dtbs_check failures > > > --- > > > .../bindings/media/rockchip,vdec.yaml | 71 +++++++++++++++++++ > > > 1 file changed, 71 insertions(+) > > > create mode 100644 Documentation/devicetree/bindings/media/rockchip,vdec.yaml > > > > > > diff --git a/Documentation/devicetree/bindings/media/rockchip,vdec.yaml b/Documentation/devicetree/bindings/media/rockchip,vdec.yaml > > > new file mode 100644 > > > index 000000000000..7167c3d6a389 > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/media/rockchip,vdec.yaml > > > @@ -0,0 +1,71 @@ > > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > > > +%YAML 1.2 > > > +--- > > > +$id: http://devicetree.org/schemas/media/rockchip,vdec.yaml# > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > + > > > +title: Rockchip Video Decoder (VDec) Device Tree Bindings > > > + > > > +maintainers: > > > + - Heiko Stuebner > > > + > > > +description: |- > > > + The Rockchip rk3399 has a stateless Video Decoder that can decodes H.264, > > > + HEVC an VP9 streams. > > > + > > > +properties: > > > + compatible: > > > + const: rockchip,rk3399-vdec > > > + > > > + reg: > > > + maxItems: 1 > > > + > > > + interrupts: > > > + maxItems: 1 > > > + > > > + clocks: > > > + items: > > > + - description: The Video Decoder AXI interface clock > > > + - description: The Video Decoder AHB interface clock > > > + - description: The Video Decoded CABAC clock > > > + - description: The Video Decoder core clock > > > + > > > + clock-names: > > > + items: > > > + - const: aclk > > > > How about calling it "axi" ? None of the other clock names have "clk". > > > > > + - const: iface > > > > And "ahb" here, as the AXI interface clock is also an interface clock ? > > Sure, I can do that. Another possibility: "master" for the AXI clock, and "slave" for the AHB clock. The AXI interface is likely the DMA master, while the AHB interface is a slave interface for the control registers. This is mostly based on hints from the crypto block. ChenYu From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chen-Yu Tsai Subject: Re: [PATCH v3 5/7] media: dt-bindings: rockchip: Document RK3399 Video Decoder bindings Date: Sat, 14 Dec 2019 10:32:12 +0800 Message-ID: References: <20191213125414.90725-1-boris.brezillon@collabora.com> <20191213125414.90725-6-boris.brezillon@collabora.com> <20191213152332.GF4860@pendragon.ideasonboard.com> <20191213162550.59730f89@collabora.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20191213162550.59730f89-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+glpar-linux-rockchip=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Boris Brezillon Cc: Mark Rutland , devicetree , kernel-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org, Heiko Stuebner , Jonas Karlman , Tomasz Figa , Paul Kocialkowski , "open list:ARM/Rockchip SoC..." , Rob Herring , Sakari Ailus , Laurent Pinchart , Nicolas Dufresne , Hans Verkuil , Mauro Carvalho Chehab , Ezequiel Garcia , Linux Media Mailing List List-Id: linux-rockchip.vger.kernel.org On Sat, Dec 14, 2019 at 4:38 AM Boris Brezillon wrote: > > On Fri, 13 Dec 2019 17:23:32 +0200 > Laurent Pinchart wrote: > > > Hi Boris, > > > > Thank you for the patch. > > > > On Fri, Dec 13, 2019 at 01:54:12PM +0100, Boris Brezillon wrote: > > > Document the Rockchip RK3399 Video Decoder bindings. > > > > > > Signed-off-by: Boris Brezillon > > > --- > > > Changes in v3: > > > * Fix dtbs_check failures > > > --- > > > .../bindings/media/rockchip,vdec.yaml | 71 +++++++++++++++++++ > > > 1 file changed, 71 insertions(+) > > > create mode 100644 Documentation/devicetree/bindings/media/rockchip,vdec.yaml > > > > > > diff --git a/Documentation/devicetree/bindings/media/rockchip,vdec.yaml b/Documentation/devicetree/bindings/media/rockchip,vdec.yaml > > > new file mode 100644 > > > index 000000000000..7167c3d6a389 > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/media/rockchip,vdec.yaml > > > @@ -0,0 +1,71 @@ > > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > > > +%YAML 1.2 > > > +--- > > > +$id: http://devicetree.org/schemas/media/rockchip,vdec.yaml# > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > + > > > +title: Rockchip Video Decoder (VDec) Device Tree Bindings > > > + > > > +maintainers: > > > + - Heiko Stuebner > > > + > > > +description: |- > > > + The Rockchip rk3399 has a stateless Video Decoder that can decodes H.264, > > > + HEVC an VP9 streams. > > > + > > > +properties: > > > + compatible: > > > + const: rockchip,rk3399-vdec > > > + > > > + reg: > > > + maxItems: 1 > > > + > > > + interrupts: > > > + maxItems: 1 > > > + > > > + clocks: > > > + items: > > > + - description: The Video Decoder AXI interface clock > > > + - description: The Video Decoder AHB interface clock > > > + - description: The Video Decoded CABAC clock > > > + - description: The Video Decoder core clock > > > + > > > + clock-names: > > > + items: > > > + - const: aclk > > > > How about calling it "axi" ? None of the other clock names have "clk". > > > > > + - const: iface > > > > And "ahb" here, as the AXI interface clock is also an interface clock ? > > Sure, I can do that. Another possibility: "master" for the AXI clock, and "slave" for the AHB clock. The AXI interface is likely the DMA master, while the AHB interface is a slave interface for the control registers. This is mostly based on hints from the crypto block. ChenYu