From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C72E4C433E0 for ; Wed, 30 Dec 2020 03:30:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 98A6E20799 for ; Wed, 30 Dec 2020 03:30:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726300AbgL3Dae convert rfc822-to-8bit (ORCPT ); Tue, 29 Dec 2020 22:30:34 -0500 Received: from mail-lf1-f43.google.com ([209.85.167.43]:34035 "EHLO mail-lf1-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726190AbgL3Dad (ORCPT ); Tue, 29 Dec 2020 22:30:33 -0500 Received: by mail-lf1-f43.google.com with SMTP id o19so35062009lfo.1; Tue, 29 Dec 2020 19:30:16 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=sX2LDQEGW3G5clQ2nn9TM9i6s3O9DrPEgTBFsaiQlJA=; b=q34noouhR0KtAl0CHQIqxJYlGM1ydk2y+MFGi9pumjpb612p8I2G2Synw107KJfNxH kbYqMEWbXvAaW72WK5ZFbbRI+Vyv+hHDBoE/a+zkksVeolFQypQSQnmZo3MfkBgxeJJj 9Qqj669HfrvYXQ0cQ3hYIUF31sZMfERYyFzJ8xWKcnAumOiAWEW3HptYtnTVCKD/Lh/M csSW/uW3D7D3FBgiQOmC6QWh5wl8LB7MPig6oFTSVsglQ6T1n11uvKdTc8IUewvwpLJQ AtgcgmH//5vCdthH3dHiFUewX2Ox5hFeY+eYsxyUOb6Io2pTpwYIN8MWg23GKl9Ld6Cv VXHQ== X-Gm-Message-State: AOAM530/JRBtsrGNJF7lBrxNYQ8wNQkLZaLd41MPac3So2enBZZW0h8X f5VCi8SE5J4ByLHHepNayg1DoyrXHUjw7g== X-Google-Smtp-Source: ABdhPJzKQKjLu9ZBtpQC/6WKqZUqvYjfvsHUlzWVSX7kjlWzY5NtOD3lRL7kCflG908umw+aNeRq/A== X-Received: by 2002:a05:651c:2121:: with SMTP id a33mr25408307ljq.381.1609298990924; Tue, 29 Dec 2020 19:29:50 -0800 (PST) Received: from mail-lf1-f54.google.com (mail-lf1-f54.google.com. [209.85.167.54]) by smtp.gmail.com with ESMTPSA id v21sm7093276ljk.73.2020.12.29.19.29.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 29 Dec 2020 19:29:50 -0800 (PST) Received: by mail-lf1-f54.google.com with SMTP id o13so35011903lfr.3; Tue, 29 Dec 2020 19:29:50 -0800 (PST) X-Received: by 2002:a2e:8852:: with SMTP id z18mr27532558ljj.94.1609298990194; Tue, 29 Dec 2020 19:29:50 -0800 (PST) MIME-Version: 1.0 References: <20201218195033.2301127-1-contact@paulk.fr> <3035881.9zrMQt1rZd@jernej-laptop> In-Reply-To: <3035881.9zrMQt1rZd@jernej-laptop> From: Chen-Yu Tsai Date: Wed, 30 Dec 2020 11:29:39 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] ARM: dts: sun8i-v3s: Add CSI0 MCLK pin definition To: Jernej Skrabec Cc: devicetree , linux-arm-kernel , linux-kernel , Paul Kocialkowski , Maxime Ripard Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 22, 2020 at 4:17 PM Jernej Škrabec wrote: > > Hi! > > Dne petek, 18. december 2020 ob 20:50:33 CET je Paul Kocialkowski napisal(a): > > This adds a device-tree definition for the CSI0 MCLK pin, > > which can be used for feeding MIPI CSI-2 sensors. > > > > Signed-off-by: Paul Kocialkowski > > Is this used anywhere? Current policy is to add pin definitions only if any > user exists. IIRC we sort of loosened that requirement with the use of /omit-if-no-ref/. The A20 dtsi file has a whole bunch of pins defined that are not directly used but are available for users to reference, especially in overlays. The "-@" parameter for the device tree compiler, used to build overlay compatible DTBs, makes the compiler ignore /omit-if-no-ref/ and include all the nodes. ChenYu > Best regards, > Jernej > > > --- > > arch/arm/boot/dts/sun8i-v3s.dtsi | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/arch/arm/boot/dts/sun8i-v3s.dtsi > > b/arch/arm/boot/dts/sun8i-v3s.dtsi index a9f5795d4e57..bff822b9fa01 100644 > > --- a/arch/arm/boot/dts/sun8i-v3s.dtsi > > +++ b/arch/arm/boot/dts/sun8i-v3s.dtsi > > @@ -337,6 +337,12 @@ pio: pinctrl@1c20800 { > > interrupt-controller; > > #interrupt-cells = <3>; > > > > + /omit-if-no-ref/ > > + csi0_mclk_pin: csi0-mclk-pin { > > + pins = "PE20"; > > + function = "csi_mipi"; > > + }; > > + > > /omit-if-no-ref/ > > csi1_8bit_pins: csi1-8bit-pins { > > pins = "PE0", "PE2", "PE3", > "PE8", "PE9", > > > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58A37C433DB for ; Wed, 30 Dec 2020 03:31:39 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1034520798 for ; Wed, 30 Dec 2020 03:31:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1034520798 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=csie.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=b3bFoo0OH5GBI3hNZWqADjDa/6xGTBt1GC7qLUXqRvo=; b=mri5KMQcip1QrPCskSYnPVp5l xq1bQ2hpMMcmG6aIRMGN2osW6/9ZZ85Y8iPSP9mBnNjs5iK9cJUmee2v6fekGsJBsDwHWfe1P3euK 064XJG0Htd0gmNHmem49GTBHerC0c9MwM5DtmLKevuOJnDmVzGBkgll40R9zulECXBOVBtFCT+igB /bSVNStoSy7bQKEQpPFVbbRuFWgRi2goCQ8q/1uFOFgMAwHislv8E6oyspRO/SCrulT8DcvAOz5NU GddgmvoM15mt4wKC4S7vqTM4yABrb9iZP66k4jH+SmIxumw6/fZFBWt9qHEAN0maOI4PU/lkcnYqk oNlhcjSiQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kuSBQ-0000VE-LG; Wed, 30 Dec 2020 03:29:56 +0000 Received: from mail-lf1-f43.google.com ([209.85.167.43]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kuSBO-0000Uk-9Q for linux-arm-kernel@lists.infradead.org; Wed, 30 Dec 2020 03:29:55 +0000 Received: by mail-lf1-f43.google.com with SMTP id x20so34933379lfe.12 for ; Tue, 29 Dec 2020 19:29:52 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=sX2LDQEGW3G5clQ2nn9TM9i6s3O9DrPEgTBFsaiQlJA=; b=dX1K30Wo6OfcUGeY2M/dBVDftC3q62mjmLYMYIRsFbCGPxeObQiOEoJE8F4YUOw65t 0PT5uaJO/4ZfjaGImXDRY4aQMYQ6mzW2WH7lNc6ljywDOk4AGSA9BACgcTVEtfs1WKX8 DYx8S+3GBUzNbXKt7MUZj7T9KIYuoDTXssT2ngevXtFMzYSCLD8mAi8hm+iCcHec2o4D VvDYquvTuH/3WpBghSvGhkHChEjB5Qs4bF6Rda5AUC2cEOlRccKL2Ba0gHRYGECx11y6 LiKa5NB6ihjaQOltYWXwCOBm2hAjkErxvdT85ReNUFsCHuCdajl258JUf4rNYdPXNcYL Wuxg== X-Gm-Message-State: AOAM533m3ZnzknbNIbJrbVa6MZJeZFxTxlaKsloPkKZUNTvxM17V5jGx GadfQzr05lTqTeu/L91Wd67cPMfVUdo0Mg== X-Google-Smtp-Source: ABdhPJzglMPLuaIY23VQhp82HCxKiO8cNG/tUGiX0tPq//svjuO0imT/2t5iWNYJrXxqsbv3B1cGXw== X-Received: by 2002:ac2:50d0:: with SMTP id h16mr20741369lfm.300.1609298990808; Tue, 29 Dec 2020 19:29:50 -0800 (PST) Received: from mail-lf1-f48.google.com (mail-lf1-f48.google.com. [209.85.167.48]) by smtp.gmail.com with ESMTPSA id o11sm5813875lfi.267.2020.12.29.19.29.50 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 29 Dec 2020 19:29:50 -0800 (PST) Received: by mail-lf1-f48.google.com with SMTP id b26so34962839lff.9 for ; Tue, 29 Dec 2020 19:29:50 -0800 (PST) X-Received: by 2002:a2e:8852:: with SMTP id z18mr27532558ljj.94.1609298990194; Tue, 29 Dec 2020 19:29:50 -0800 (PST) MIME-Version: 1.0 References: <20201218195033.2301127-1-contact@paulk.fr> <3035881.9zrMQt1rZd@jernej-laptop> In-Reply-To: <3035881.9zrMQt1rZd@jernej-laptop> From: Chen-Yu Tsai Date: Wed, 30 Dec 2020 11:29:39 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] ARM: dts: sun8i-v3s: Add CSI0 MCLK pin definition To: Jernej Skrabec X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201229_222954_354094_792FBDBE X-CRM114-Status: GOOD ( 18.79 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Maxime Ripard , devicetree , linux-kernel , linux-arm-kernel , Paul Kocialkowski Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVHVlLCBEZWMgMjIsIDIwMjAgYXQgNDoxNyBQTSBKZXJuZWogxaBrcmFiZWMgPGplcm5lai5z a3JhYmVjQHNpb2wubmV0PiB3cm90ZToKPgo+IEhpIQo+Cj4gRG5lIHBldGVrLCAxOC4gZGVjZW1i ZXIgMjAyMCBvYiAyMDo1MDozMyBDRVQgamUgUGF1bCBLb2NpYWxrb3dza2kgbmFwaXNhbChhKToK PiA+IFRoaXMgYWRkcyBhIGRldmljZS10cmVlIGRlZmluaXRpb24gZm9yIHRoZSBDU0kwIE1DTEsg cGluLAo+ID4gd2hpY2ggY2FuIGJlIHVzZWQgZm9yIGZlZWRpbmcgTUlQSSBDU0ktMiBzZW5zb3Jz Lgo+ID4KPiA+IFNpZ25lZC1vZmYtYnk6IFBhdWwgS29jaWFsa293c2tpIDxjb250YWN0QHBhdWxr LmZyPgo+Cj4gSXMgdGhpcyB1c2VkIGFueXdoZXJlPyBDdXJyZW50IHBvbGljeSBpcyB0byBhZGQg cGluIGRlZmluaXRpb25zIG9ubHkgaWYgYW55Cj4gdXNlciBleGlzdHMuCgpJSVJDIHdlIHNvcnQg b2YgbG9vc2VuZWQgdGhhdCByZXF1aXJlbWVudCB3aXRoIHRoZSB1c2Ugb2YgL29taXQtaWYtbm8t cmVmLy4KVGhlIEEyMCBkdHNpIGZpbGUgaGFzIGEgd2hvbGUgYnVuY2ggb2YgcGlucyBkZWZpbmVk IHRoYXQgYXJlIG5vdCBkaXJlY3RseQp1c2VkIGJ1dCBhcmUgYXZhaWxhYmxlIGZvciB1c2VycyB0 byByZWZlcmVuY2UsIGVzcGVjaWFsbHkgaW4gb3ZlcmxheXMuClRoZSAiLUAiIHBhcmFtZXRlciBm b3IgdGhlIGRldmljZSB0cmVlIGNvbXBpbGVyLCB1c2VkIHRvIGJ1aWxkIG92ZXJsYXkKY29tcGF0 aWJsZSBEVEJzLCBtYWtlcyB0aGUgY29tcGlsZXIgaWdub3JlIC9vbWl0LWlmLW5vLXJlZi8gYW5k IGluY2x1ZGUKYWxsIHRoZSBub2Rlcy4KCkNoZW5ZdQoKPiBCZXN0IHJlZ2FyZHMsCj4gSmVybmVq Cj4KPiA+IC0tLQo+ID4gIGFyY2gvYXJtL2Jvb3QvZHRzL3N1bjhpLXYzcy5kdHNpIHwgNiArKysr KysKPiA+ICAxIGZpbGUgY2hhbmdlZCwgNiBpbnNlcnRpb25zKCspCj4gPgo+ID4gZGlmZiAtLWdp dCBhL2FyY2gvYXJtL2Jvb3QvZHRzL3N1bjhpLXYzcy5kdHNpCj4gPiBiL2FyY2gvYXJtL2Jvb3Qv ZHRzL3N1bjhpLXYzcy5kdHNpIGluZGV4IGE5ZjU3OTVkNGU1Ny4uYmZmODIyYjlmYTAxIDEwMDY0 NAo+ID4gLS0tIGEvYXJjaC9hcm0vYm9vdC9kdHMvc3VuOGktdjNzLmR0c2kKPiA+ICsrKyBiL2Fy Y2gvYXJtL2Jvb3QvZHRzL3N1bjhpLXYzcy5kdHNpCj4gPiBAQCAtMzM3LDYgKzMzNywxMiBAQCBw aW86IHBpbmN0cmxAMWMyMDgwMCB7Cj4gPiAgICAgICAgICAgICAgICAgICAgICAgaW50ZXJydXB0 LWNvbnRyb2xsZXI7Cj4gPiAgICAgICAgICAgICAgICAgICAgICAgI2ludGVycnVwdC1jZWxscyA9 IDwzPjsKPiA+Cj4gPiArICAgICAgICAgICAgICAgICAgICAgL29taXQtaWYtbm8tcmVmLwo+ID4g KyAgICAgICAgICAgICAgICAgICAgIGNzaTBfbWNsa19waW46IGNzaTAtbWNsay1waW4gewo+ID4g KyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcGlucyA9ICJQRTIwIjsKPiA+ICsgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIGZ1bmN0aW9uID0gImNzaV9taXBpIjsKPiA+ICsgICAgICAg ICAgICAgICAgICAgICB9Owo+ID4gKwo+ID4gICAgICAgICAgICAgICAgICAgICAgIC9vbWl0LWlm LW5vLXJlZi8KPiA+ICAgICAgICAgICAgICAgICAgICAgICBjc2kxXzhiaXRfcGluczogY3NpMS04 Yml0LXBpbnMgewo+ID4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcGlucyA9ICJQRTAi LCAiUEUyIiwgIlBFMyIsCj4gIlBFOCIsICJQRTkiLAo+Cj4KPgo+CgpfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcg bGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmlu ZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==