From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC1E4C4BA0B for ; Wed, 26 Feb 2020 03:35:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 87FFA2082F for ; Wed, 26 Feb 2020 03:35:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726674AbgBZDfW convert rfc822-to-8bit (ORCPT ); Tue, 25 Feb 2020 22:35:22 -0500 Received: from mail-ed1-f68.google.com ([209.85.208.68]:33295 "EHLO mail-ed1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725837AbgBZDfW (ORCPT ); Tue, 25 Feb 2020 22:35:22 -0500 Received: by mail-ed1-f68.google.com with SMTP id r21so2027341edq.0 for ; Tue, 25 Feb 2020 19:35:20 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=UXofy6EkwfdL30O9+SzmICCU7Qa0hak4F21CzXTG5yo=; b=BI1nSrWF+/FFZ8+JmAkwrTwZ8uTUsT8k+xakqDm1vdUr9g4Ie6I4hDaKKnlZCNpDA9 VUmUjog7h0R4Hq4xpMXupUP75nYeP4S2qMNngmoAE3gjWTQnNWh/7lf8pKwwctAIKclc Y/GuhSKlOk0f4Odr5CSZwNSzHXaGPdu6QYtjf520lqWkdz8yMT8QmMJp9lr4VAE0QvWt Zu2ttEU3wScy1HXqytXc4bgEihS+AgQytPmE6Hv+K/nn65pexYnD8+8jtP56QLoiXM5B xQ/JaWGxEVBl0OrNihdVu4h4r5339oBoKCUYgbWwVNeXKS7+oJ9J7rGx4wAfegZfPttk T74w== X-Gm-Message-State: APjAAAUNa0WF/gb7IB9t+Bcls6N3MkcvBsNneY/t3RH1WmIzLPSS3xde afwUBECc00CSVGiQxT61QYUnZcrKPFU= X-Google-Smtp-Source: APXvYqx4+2ePU5zGnoq/1CYaKRmOjBBiEnB4X0GTffeXg9sDRzZBLtI9rw1h3LVcUXcSLr20RFSYQw== X-Received: by 2002:a50:d0d2:: with SMTP id g18mr413334edf.37.1582687801348; Tue, 25 Feb 2020 19:30:01 -0800 (PST) Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com. [209.85.128.50]) by smtp.gmail.com with ESMTPSA id e22sm24448edq.75.2020.02.25.19.30.00 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 25 Feb 2020 19:30:01 -0800 (PST) Received: by mail-wm1-f50.google.com with SMTP id c84so1410129wme.4 for ; Tue, 25 Feb 2020 19:30:00 -0800 (PST) X-Received: by 2002:a05:600c:10d2:: with SMTP id l18mr2582096wmd.122.1582687800441; Tue, 25 Feb 2020 19:30:00 -0800 (PST) MIME-Version: 1.0 References: <20200224173901.174016-1-jernej.skrabec@siol.net> <20200225083448.6upblnctjjrbarje@gilmour.lan> <12462592.uLZWGnKmhe@jernej-laptop> In-Reply-To: <12462592.uLZWGnKmhe@jernej-laptop> From: Chen-Yu Tsai Date: Wed, 26 Feb 2020 11:29:48 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 6/7] drm/sun4i: de2: Don't return de2_fmt_info struct To: =?UTF-8?Q?Jernej_=C5=A0krabec?= Cc: Maxime Ripard , David Airlie , Daniel Vetter , dri-devel , linux-arm-kernel , linux-kernel Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 26, 2020 at 2:50 AM Jernej Škrabec wrote: > > Hi! > > Dne torek, 25. februar 2020 ob 09:52:18 CET je Chen-Yu Tsai napisal(a): > > On Tue, Feb 25, 2020 at 4:35 PM Maxime Ripard wrote: > > > Hi, > > > > > > On Mon, Feb 24, 2020 at 06:39:00PM +0100, Jernej Skrabec wrote: > > > > Now that de2_fmt_info contains only DRM <-> HW format mapping, it > > > > doesn't make sense to return pointer to structure when searching by DRM > > > > format. Rework that to return only HW format instead. > > > > > > > > This doesn't make any functional change. > > > > > > > > Signed-off-by: Jernej Skrabec > > > > --- > > > > > > > > drivers/gpu/drm/sun4i/sun8i_mixer.c | 15 +++++++++++---- > > > > drivers/gpu/drm/sun4i/sun8i_mixer.h | 7 +------ > > > > drivers/gpu/drm/sun4i/sun8i_ui_layer.c | 10 +++++----- > > > > drivers/gpu/drm/sun4i/sun8i_vi_layer.c | 12 ++++++------ > > > > 4 files changed, 23 insertions(+), 21 deletions(-) > > > > > > > > diff --git a/drivers/gpu/drm/sun4i/sun8i_mixer.c > > > > b/drivers/gpu/drm/sun4i/sun8i_mixer.c index e078ec96de2d..56cc037fd312 > > > > 100644 > > > > --- a/drivers/gpu/drm/sun4i/sun8i_mixer.c > > > > +++ b/drivers/gpu/drm/sun4i/sun8i_mixer.c > > > > @@ -27,6 +27,11 @@ > > > > > > > > #include "sun8i_vi_layer.h" > > > > #include "sunxi_engine.h" > > > > > > > > +struct de2_fmt_info { > > > > + u32 drm_fmt; > > > > + u32 de2_fmt; > > > > +}; > > > > + > > > > > > > > static const struct de2_fmt_info de2_formats[] = { > > > > > > > > { > > > > > > > > .drm_fmt = DRM_FORMAT_ARGB8888, > > > > > > > > @@ -230,15 +235,17 @@ static const struct de2_fmt_info de2_formats[] = { > > > > > > > > }, > > > > > > > > }; > > > > > > > > -const struct de2_fmt_info *sun8i_mixer_format_info(u32 format) > > > > +int sun8i_mixer_drm_format_to_hw(u32 format, u32 *hw_format) > > > > > > > > { > > > > > > > > unsigned int i; > > > > > > > > for (i = 0; i < ARRAY_SIZE(de2_formats); ++i) > > > > > > > > - if (de2_formats[i].drm_fmt == format) > > > > - return &de2_formats[i]; > > > > + if (de2_formats[i].drm_fmt == format) { > > > > + *hw_format = de2_formats[i].de2_fmt; > > > > + return 0; > > > > + } > > > > > > > > - return NULL; > > > > + return -EINVAL; > > > > > > > > } > > > > > > I'm not too sure about that one. It breaks the consistency with the > > > other functions, and I don't really see a particular benefit to it? > > > > I don't have strong opinion about this patch. It can be dropped. > > > I guess we could just define an "invalid" value, and have the function > > return that if can't find a match? I'm guessing 0x0 is valid, so maybe > > 0xffffffff or 0xdeadbeef ? > > > > That would keep consistency with everything else all the while > > removing the level of indirection you wanted to. > > I modeled this after > static int sun4i_backend_drm_format_to_layer(u32 format, u32 *mode); > from sun4i_backend.c. > > What consistency do you have in mind? Directly returning values (or error codes) instead of passing in a pointer for data to be returned. I assumed that was what Maxime was referring to. ChenYu > > > > ChenYu > > > > > The rest of the series is > > > Acked-by: Maxime Ripard > > Thanks! > > Best regards, > Jernej > > > > > > > Maxime > > > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B7B2C4BA0A for ; Wed, 26 Feb 2020 03:30:18 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6CA8D2082F for ; Wed, 26 Feb 2020 03:30:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="B/abDRxZ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6CA8D2082F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=csie.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=h07DY1FOqPu/z1i5dmARsGidsBOfqAxBppYfZ5mMLJU=; b=B/abDRxZjjcWhS K+JFu2fglMIxfqzahVMCjHd87qs6zy8itIB2BNNpDUeEieSbWvxwVjeY8XIuwgtoS7v2OwzXlyN2V l+uB1wMEdymfNB8J3EUA6b0NO+Ya+oInIkGgz16/n1LEMIneeVdyKb9oTTOwHqMQfpjyCRiuXACDL cK7NlUPdGFOmmIopnB9hOSZbC+cl81rVBMhb4i8Gy1xuTDI7xmXVviQc8sNFZ85ibV6fN8fS2PiJz JAGy5P9U3wfD4Br9XeXTsKX9t5NQ/0kz/0TXprbRGY0GD5EJyduIcnPtHV33E6OfrI5K7eNjve0vI 7Tf/0jKTJ2GSuDQ+XMVA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j6nOh-00032e-UC; Wed, 26 Feb 2020 03:30:07 +0000 Received: from mail-ed1-f68.google.com ([209.85.208.68]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1j6nOd-0002FJ-PP for linux-arm-kernel@lists.infradead.org; Wed, 26 Feb 2020 03:30:05 +0000 Received: by mail-ed1-f68.google.com with SMTP id dc19so1941838edb.10 for ; Tue, 25 Feb 2020 19:30:03 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=UXofy6EkwfdL30O9+SzmICCU7Qa0hak4F21CzXTG5yo=; b=i2O+2cfsy70O3mP6Xkh7xMOk/RuqYNu8USs2sAdTIx2inT85e1zf2AblSV20Sp9bE2 1kxrJ2XnlOE+XR5T4zI9hBkWCLSpAk1Am0w0P7RK/wFTJUrWfULiAlh22gYuK8Jc0fI3 BEQ132c9FhcNihEu1dP4vidHTCnQX397yOF2Gjn31N/nK91TmkpnHTQSn65lEDrmjjdV 367T1OuNGlWD+koeZRo4yYAcaVpu9o/4MkIEWaMxcSMTGkM0j5OtCY7QIbnvCJXfrWJg qfSgS0Ex3TnoDw59FHt5Q73tXRCFfFjrPFMoyGC5GBUkY4JLpq4ftwpI/bZxuNHAVrEQ +0mw== X-Gm-Message-State: APjAAAWS2bfWWauHzHahJ0enn7o4DbWVChR6Tr4wwcHxBMl+POwxZEsi 6UMHGEkskyT1uLF/+JC0UJ8qfgt3ZBs= X-Google-Smtp-Source: APXvYqyWv4fYACdYBACtIfJnYVmcILAxQFQF6QZbTGoZtL1NU0TYAT9XoUTyaxjuqo1Xvgh2WROr9Q== X-Received: by 2002:a50:f70d:: with SMTP id g13mr2217595edn.80.1582687801309; Tue, 25 Feb 2020 19:30:01 -0800 (PST) Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com. [209.85.128.50]) by smtp.gmail.com with ESMTPSA id r7sm26632eds.32.2020.02.25.19.30.00 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 25 Feb 2020 19:30:01 -0800 (PST) Received: by mail-wm1-f50.google.com with SMTP id m3so1439133wmi.0 for ; Tue, 25 Feb 2020 19:30:00 -0800 (PST) X-Received: by 2002:a05:600c:10d2:: with SMTP id l18mr2582096wmd.122.1582687800441; Tue, 25 Feb 2020 19:30:00 -0800 (PST) MIME-Version: 1.0 References: <20200224173901.174016-1-jernej.skrabec@siol.net> <20200225083448.6upblnctjjrbarje@gilmour.lan> <12462592.uLZWGnKmhe@jernej-laptop> In-Reply-To: <12462592.uLZWGnKmhe@jernej-laptop> From: Chen-Yu Tsai Date: Wed, 26 Feb 2020 11:29:48 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 6/7] drm/sun4i: de2: Don't return de2_fmt_info struct To: =?UTF-8?Q?Jernej_=C5=A0krabec?= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200225_193003_829472_33F618C4 X-CRM114-Status: GOOD ( 29.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , linux-kernel , dri-devel , Maxime Ripard , Daniel Vetter , linux-arm-kernel Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gV2VkLCBGZWIgMjYsIDIwMjAgYXQgMjo1MCBBTSBKZXJuZWogxaBrcmFiZWMgPGplcm5lai5z a3JhYmVjQHNpb2wubmV0PiB3cm90ZToKPgo+IEhpIQo+Cj4gRG5lIHRvcmVrLCAyNS4gZmVicnVh ciAyMDIwIG9iIDA5OjUyOjE4IENFVCBqZSBDaGVuLVl1IFRzYWkgbmFwaXNhbChhKToKPiA+IE9u IFR1ZSwgRmViIDI1LCAyMDIwIGF0IDQ6MzUgUE0gTWF4aW1lIFJpcGFyZCA8bWF4aW1lQGNlcm5v LnRlY2g+IHdyb3RlOgo+ID4gPiBIaSwKPiA+ID4KPiA+ID4gT24gTW9uLCBGZWIgMjQsIDIwMjAg YXQgMDY6Mzk6MDBQTSArMDEwMCwgSmVybmVqIFNrcmFiZWMgd3JvdGU6Cj4gPiA+ID4gTm93IHRo YXQgZGUyX2ZtdF9pbmZvIGNvbnRhaW5zIG9ubHkgRFJNIDwtPiBIVyBmb3JtYXQgbWFwcGluZywg aXQKPiA+ID4gPiBkb2Vzbid0IG1ha2Ugc2Vuc2UgdG8gcmV0dXJuIHBvaW50ZXIgdG8gc3RydWN0 dXJlIHdoZW4gc2VhcmNoaW5nIGJ5IERSTQo+ID4gPiA+IGZvcm1hdC4gUmV3b3JrIHRoYXQgdG8g cmV0dXJuIG9ubHkgSFcgZm9ybWF0IGluc3RlYWQuCj4gPiA+ID4KPiA+ID4gPiBUaGlzIGRvZXNu J3QgbWFrZSBhbnkgZnVuY3Rpb25hbCBjaGFuZ2UuCj4gPiA+ID4KPiA+ID4gPiBTaWduZWQtb2Zm LWJ5OiBKZXJuZWogU2tyYWJlYyA8amVybmVqLnNrcmFiZWNAc2lvbC5uZXQ+Cj4gPiA+ID4gLS0t Cj4gPiA+ID4KPiA+ID4gPiAgZHJpdmVycy9ncHUvZHJtL3N1bjRpL3N1bjhpX21peGVyLmMgICAg fCAxNSArKysrKysrKysrKy0tLS0KPiA+ID4gPiAgZHJpdmVycy9ncHUvZHJtL3N1bjRpL3N1bjhp X21peGVyLmggICAgfCAgNyArLS0tLS0tCj4gPiA+ID4gIGRyaXZlcnMvZ3B1L2RybS9zdW40aS9z dW44aV91aV9sYXllci5jIHwgMTAgKysrKystLS0tLQo+ID4gPiA+ICBkcml2ZXJzL2dwdS9kcm0v c3VuNGkvc3VuOGlfdmlfbGF5ZXIuYyB8IDEyICsrKysrKy0tLS0tLQo+ID4gPiA+ICA0IGZpbGVz IGNoYW5nZWQsIDIzIGluc2VydGlvbnMoKyksIDIxIGRlbGV0aW9ucygtKQo+ID4gPiA+Cj4gPiA+ ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9zdW40aS9zdW44aV9taXhlci5jCj4gPiA+ ID4gYi9kcml2ZXJzL2dwdS9kcm0vc3VuNGkvc3VuOGlfbWl4ZXIuYyBpbmRleCBlMDc4ZWM5NmRl MmQuLjU2Y2MwMzdmZDMxMgo+ID4gPiA+IDEwMDY0NAo+ID4gPiA+IC0tLSBhL2RyaXZlcnMvZ3B1 L2RybS9zdW40aS9zdW44aV9taXhlci5jCj4gPiA+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL3N1 bjRpL3N1bjhpX21peGVyLmMKPiA+ID4gPiBAQCAtMjcsNiArMjcsMTEgQEAKPiA+ID4gPgo+ID4g PiA+ICAjaW5jbHVkZSAic3VuOGlfdmlfbGF5ZXIuaCIKPiA+ID4gPiAgI2luY2x1ZGUgInN1bnhp X2VuZ2luZS5oIgo+ID4gPiA+Cj4gPiA+ID4gK3N0cnVjdCBkZTJfZm10X2luZm8gewo+ID4gPiA+ ICsgICAgIHUzMiAgICAgZHJtX2ZtdDsKPiA+ID4gPiArICAgICB1MzIgICAgIGRlMl9mbXQ7Cj4g PiA+ID4gK307Cj4gPiA+ID4gKwo+ID4gPiA+Cj4gPiA+ID4gIHN0YXRpYyBjb25zdCBzdHJ1Y3Qg ZGUyX2ZtdF9pbmZvIGRlMl9mb3JtYXRzW10gPSB7Cj4gPiA+ID4KPiA+ID4gPiAgICAgICB7Cj4g PiA+ID4KPiA+ID4gPiAgICAgICAgICAgICAgIC5kcm1fZm10ID0gRFJNX0ZPUk1BVF9BUkdCODg4 OCwKPiA+ID4gPgo+ID4gPiA+IEBAIC0yMzAsMTUgKzIzNSwxNyBAQCBzdGF0aWMgY29uc3Qgc3Ry dWN0IGRlMl9mbXRfaW5mbyBkZTJfZm9ybWF0c1tdID0gewo+ID4gPiA+Cj4gPiA+ID4gICAgICAg fSwKPiA+ID4gPgo+ID4gPiA+ICB9Owo+ID4gPiA+Cj4gPiA+ID4gLWNvbnN0IHN0cnVjdCBkZTJf Zm10X2luZm8gKnN1bjhpX21peGVyX2Zvcm1hdF9pbmZvKHUzMiBmb3JtYXQpCj4gPiA+ID4gK2lu dCBzdW44aV9taXhlcl9kcm1fZm9ybWF0X3RvX2h3KHUzMiBmb3JtYXQsIHUzMiAqaHdfZm9ybWF0 KQo+ID4gPiA+Cj4gPiA+ID4gIHsKPiA+ID4gPgo+ID4gPiA+ICAgICAgIHVuc2lnbmVkIGludCBp Owo+ID4gPiA+Cj4gPiA+ID4gICAgICAgZm9yIChpID0gMDsgaSA8IEFSUkFZX1NJWkUoZGUyX2Zv cm1hdHMpOyArK2kpCj4gPiA+ID4KPiA+ID4gPiAtICAgICAgICAgICAgIGlmIChkZTJfZm9ybWF0 c1tpXS5kcm1fZm10ID09IGZvcm1hdCkKPiA+ID4gPiAtICAgICAgICAgICAgICAgICAgICAgcmV0 dXJuICZkZTJfZm9ybWF0c1tpXTsKPiA+ID4gPiArICAgICAgICAgICAgIGlmIChkZTJfZm9ybWF0 c1tpXS5kcm1fZm10ID09IGZvcm1hdCkgewo+ID4gPiA+ICsgICAgICAgICAgICAgICAgICAgICAq aHdfZm9ybWF0ID0gZGUyX2Zvcm1hdHNbaV0uZGUyX2ZtdDsKPiA+ID4gPiArICAgICAgICAgICAg ICAgICAgICAgcmV0dXJuIDA7Cj4gPiA+ID4gKyAgICAgICAgICAgICB9Cj4gPiA+ID4KPiA+ID4g PiAtICAgICByZXR1cm4gTlVMTDsKPiA+ID4gPiArICAgICByZXR1cm4gLUVJTlZBTDsKPiA+ID4g Pgo+ID4gPiA+ICB9Cj4gPiA+Cj4gPiA+IEknbSBub3QgdG9vIHN1cmUgYWJvdXQgdGhhdCBvbmUu IEl0IGJyZWFrcyB0aGUgY29uc2lzdGVuY3kgd2l0aCB0aGUKPiA+ID4gb3RoZXIgZnVuY3Rpb25z LCBhbmQgSSBkb24ndCByZWFsbHkgc2VlIGEgcGFydGljdWxhciBiZW5lZml0IHRvIGl0Pwo+ID4K Pgo+IEkgZG9uJ3QgaGF2ZSBzdHJvbmcgb3BpbmlvbiBhYm91dCB0aGlzIHBhdGNoLiBJdCBjYW4g YmUgZHJvcHBlZC4KPgo+ID4gSSBndWVzcyB3ZSBjb3VsZCBqdXN0IGRlZmluZSBhbiAiaW52YWxp ZCIgdmFsdWUsIGFuZCBoYXZlIHRoZSBmdW5jdGlvbgo+ID4gcmV0dXJuIHRoYXQgaWYgY2FuJ3Qg ZmluZCBhIG1hdGNoPyBJJ20gZ3Vlc3NpbmcgMHgwIGlzIHZhbGlkLCBzbyBtYXliZQo+ID4gMHhm ZmZmZmZmZiBvciAweGRlYWRiZWVmID8KPiA+Cj4gPiBUaGF0IHdvdWxkIGtlZXAgY29uc2lzdGVu Y3kgd2l0aCBldmVyeXRoaW5nIGVsc2UgYWxsIHRoZSB3aGlsZQo+ID4gcmVtb3ZpbmcgdGhlIGxl dmVsIG9mIGluZGlyZWN0aW9uIHlvdSB3YW50ZWQgdG8uCj4KPiBJIG1vZGVsZWQgdGhpcyBhZnRl cgo+IHN0YXRpYyBpbnQgc3VuNGlfYmFja2VuZF9kcm1fZm9ybWF0X3RvX2xheWVyKHUzMiBmb3Jt YXQsIHUzMiAqbW9kZSk7Cj4gZnJvbSBzdW40aV9iYWNrZW5kLmMuCj4KPiBXaGF0IGNvbnNpc3Rl bmN5IGRvIHlvdSBoYXZlIGluIG1pbmQ/CgpEaXJlY3RseSByZXR1cm5pbmcgdmFsdWVzIChvciBl cnJvciBjb2RlcykgaW5zdGVhZCBvZiBwYXNzaW5nIGluIGEgcG9pbnRlcgpmb3IgZGF0YSB0byBi ZSByZXR1cm5lZC4gSSBhc3N1bWVkIHRoYXQgd2FzIHdoYXQgTWF4aW1lIHdhcyByZWZlcnJpbmcg dG8uCgpDaGVuWXUKCj4gPgo+ID4gQ2hlbll1Cj4gPgo+ID4gPiBUaGUgcmVzdCBvZiB0aGUgc2Vy aWVzIGlzCj4gPiA+IEFja2VkLWJ5OiBNYXhpbWUgUmlwYXJkIDxtcmlwYXJkQGtlcm5lbC5vcmc+ Cj4KPiBUaGFua3MhCj4KPiBCZXN0IHJlZ2FyZHMsCj4gSmVybmVqCj4KPiA+ID4KPiA+ID4gTWF4 aW1lCj4KPgo+Cj4KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMu aW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZv L2xpbnV4LWFybS1rZXJuZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6B72C4BA0B for ; Wed, 26 Feb 2020 03:30:05 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 60EAB2082F for ; Wed, 26 Feb 2020 03:30:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 60EAB2082F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=csie.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 15DE96E0E3; Wed, 26 Feb 2020 03:30:04 +0000 (UTC) Received: from mail-ed1-f68.google.com (mail-ed1-f68.google.com [209.85.208.68]) by gabe.freedesktop.org (Postfix) with ESMTPS id DD7D76E0E3 for ; Wed, 26 Feb 2020 03:30:02 +0000 (UTC) Received: by mail-ed1-f68.google.com with SMTP id g19so1937227eds.11 for ; Tue, 25 Feb 2020 19:30:02 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=UXofy6EkwfdL30O9+SzmICCU7Qa0hak4F21CzXTG5yo=; b=Z2stooSrDQFBpQXQY9WdKOQKnsHxpIEfnGRLIJF2BHEn6hdnytX9aDe+FRj3nKayBz RFix4xe05EDxQht0Xa9aboiCCNJcR0ST/qEW694XpDqdm5njwbBofHfYdKCRZ/CQ89C1 QSqs1rZuJ1dZmhiuXJt81Vri+uSlQ8H2WWIoRFomy1vrRMDPDnN6v6e4eaenFSq4T9me bp6eDpk8cds2nGLx4WGokzqf/ed12SM0eTbVgLV6b3FwA+pNGIRSpaQ0j/qZJYcGkfSc 8JgI2A2VlzHEl/uLjM5yLmBFxzUwyK5XUlJsIAVDNktAINzKBcKjPPCzmCrmBT60ledZ oIjg== X-Gm-Message-State: APjAAAWsd18sTd8BzLJm+0kL1qts1Tx0SnT6i7hR+79FBiRiNfV1paVe uaEZJfRUFlR80TH1xUHke7xGWzxpbEw= X-Google-Smtp-Source: APXvYqy+fp0XkLln5PDHhjK4VbF1mnayIq98EOVkBYUdNKB4Tn2TWx75kUji7F69MvQzrbKihSkS5Q== X-Received: by 2002:a05:6402:30ba:: with SMTP id df26mr2114697edb.382.1582687801145; Tue, 25 Feb 2020 19:30:01 -0800 (PST) Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com. [209.85.128.53]) by smtp.gmail.com with ESMTPSA id q8sm18085edc.59.2020.02.25.19.30.00 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 25 Feb 2020 19:30:00 -0800 (PST) Received: by mail-wm1-f53.google.com with SMTP id a5so1388277wmb.0 for ; Tue, 25 Feb 2020 19:30:00 -0800 (PST) X-Received: by 2002:a05:600c:10d2:: with SMTP id l18mr2582096wmd.122.1582687800441; Tue, 25 Feb 2020 19:30:00 -0800 (PST) MIME-Version: 1.0 References: <20200224173901.174016-1-jernej.skrabec@siol.net> <20200225083448.6upblnctjjrbarje@gilmour.lan> <12462592.uLZWGnKmhe@jernej-laptop> In-Reply-To: <12462592.uLZWGnKmhe@jernej-laptop> From: Chen-Yu Tsai Date: Wed, 26 Feb 2020 11:29:48 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 6/7] drm/sun4i: de2: Don't return de2_fmt_info struct To: =?UTF-8?Q?Jernej_=C5=A0krabec?= X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , linux-kernel , dri-devel , Maxime Ripard , linux-arm-kernel Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" T24gV2VkLCBGZWIgMjYsIDIwMjAgYXQgMjo1MCBBTSBKZXJuZWogxaBrcmFiZWMgPGplcm5lai5z a3JhYmVjQHNpb2wubmV0PiB3cm90ZToKPgo+IEhpIQo+Cj4gRG5lIHRvcmVrLCAyNS4gZmVicnVh ciAyMDIwIG9iIDA5OjUyOjE4IENFVCBqZSBDaGVuLVl1IFRzYWkgbmFwaXNhbChhKToKPiA+IE9u IFR1ZSwgRmViIDI1LCAyMDIwIGF0IDQ6MzUgUE0gTWF4aW1lIFJpcGFyZCA8bWF4aW1lQGNlcm5v LnRlY2g+IHdyb3RlOgo+ID4gPiBIaSwKPiA+ID4KPiA+ID4gT24gTW9uLCBGZWIgMjQsIDIwMjAg YXQgMDY6Mzk6MDBQTSArMDEwMCwgSmVybmVqIFNrcmFiZWMgd3JvdGU6Cj4gPiA+ID4gTm93IHRo YXQgZGUyX2ZtdF9pbmZvIGNvbnRhaW5zIG9ubHkgRFJNIDwtPiBIVyBmb3JtYXQgbWFwcGluZywg aXQKPiA+ID4gPiBkb2Vzbid0IG1ha2Ugc2Vuc2UgdG8gcmV0dXJuIHBvaW50ZXIgdG8gc3RydWN0 dXJlIHdoZW4gc2VhcmNoaW5nIGJ5IERSTQo+ID4gPiA+IGZvcm1hdC4gUmV3b3JrIHRoYXQgdG8g cmV0dXJuIG9ubHkgSFcgZm9ybWF0IGluc3RlYWQuCj4gPiA+ID4KPiA+ID4gPiBUaGlzIGRvZXNu J3QgbWFrZSBhbnkgZnVuY3Rpb25hbCBjaGFuZ2UuCj4gPiA+ID4KPiA+ID4gPiBTaWduZWQtb2Zm LWJ5OiBKZXJuZWogU2tyYWJlYyA8amVybmVqLnNrcmFiZWNAc2lvbC5uZXQ+Cj4gPiA+ID4gLS0t Cj4gPiA+ID4KPiA+ID4gPiAgZHJpdmVycy9ncHUvZHJtL3N1bjRpL3N1bjhpX21peGVyLmMgICAg fCAxNSArKysrKysrKysrKy0tLS0KPiA+ID4gPiAgZHJpdmVycy9ncHUvZHJtL3N1bjRpL3N1bjhp X21peGVyLmggICAgfCAgNyArLS0tLS0tCj4gPiA+ID4gIGRyaXZlcnMvZ3B1L2RybS9zdW40aS9z dW44aV91aV9sYXllci5jIHwgMTAgKysrKystLS0tLQo+ID4gPiA+ICBkcml2ZXJzL2dwdS9kcm0v c3VuNGkvc3VuOGlfdmlfbGF5ZXIuYyB8IDEyICsrKysrKy0tLS0tLQo+ID4gPiA+ICA0IGZpbGVz IGNoYW5nZWQsIDIzIGluc2VydGlvbnMoKyksIDIxIGRlbGV0aW9ucygtKQo+ID4gPiA+Cj4gPiA+ ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9zdW40aS9zdW44aV9taXhlci5jCj4gPiA+ ID4gYi9kcml2ZXJzL2dwdS9kcm0vc3VuNGkvc3VuOGlfbWl4ZXIuYyBpbmRleCBlMDc4ZWM5NmRl MmQuLjU2Y2MwMzdmZDMxMgo+ID4gPiA+IDEwMDY0NAo+ID4gPiA+IC0tLSBhL2RyaXZlcnMvZ3B1 L2RybS9zdW40aS9zdW44aV9taXhlci5jCj4gPiA+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL3N1 bjRpL3N1bjhpX21peGVyLmMKPiA+ID4gPiBAQCAtMjcsNiArMjcsMTEgQEAKPiA+ID4gPgo+ID4g PiA+ICAjaW5jbHVkZSAic3VuOGlfdmlfbGF5ZXIuaCIKPiA+ID4gPiAgI2luY2x1ZGUgInN1bnhp X2VuZ2luZS5oIgo+ID4gPiA+Cj4gPiA+ID4gK3N0cnVjdCBkZTJfZm10X2luZm8gewo+ID4gPiA+ ICsgICAgIHUzMiAgICAgZHJtX2ZtdDsKPiA+ID4gPiArICAgICB1MzIgICAgIGRlMl9mbXQ7Cj4g PiA+ID4gK307Cj4gPiA+ID4gKwo+ID4gPiA+Cj4gPiA+ID4gIHN0YXRpYyBjb25zdCBzdHJ1Y3Qg ZGUyX2ZtdF9pbmZvIGRlMl9mb3JtYXRzW10gPSB7Cj4gPiA+ID4KPiA+ID4gPiAgICAgICB7Cj4g PiA+ID4KPiA+ID4gPiAgICAgICAgICAgICAgIC5kcm1fZm10ID0gRFJNX0ZPUk1BVF9BUkdCODg4 OCwKPiA+ID4gPgo+ID4gPiA+IEBAIC0yMzAsMTUgKzIzNSwxNyBAQCBzdGF0aWMgY29uc3Qgc3Ry dWN0IGRlMl9mbXRfaW5mbyBkZTJfZm9ybWF0c1tdID0gewo+ID4gPiA+Cj4gPiA+ID4gICAgICAg fSwKPiA+ID4gPgo+ID4gPiA+ICB9Owo+ID4gPiA+Cj4gPiA+ID4gLWNvbnN0IHN0cnVjdCBkZTJf Zm10X2luZm8gKnN1bjhpX21peGVyX2Zvcm1hdF9pbmZvKHUzMiBmb3JtYXQpCj4gPiA+ID4gK2lu dCBzdW44aV9taXhlcl9kcm1fZm9ybWF0X3RvX2h3KHUzMiBmb3JtYXQsIHUzMiAqaHdfZm9ybWF0 KQo+ID4gPiA+Cj4gPiA+ID4gIHsKPiA+ID4gPgo+ID4gPiA+ICAgICAgIHVuc2lnbmVkIGludCBp Owo+ID4gPiA+Cj4gPiA+ID4gICAgICAgZm9yIChpID0gMDsgaSA8IEFSUkFZX1NJWkUoZGUyX2Zv cm1hdHMpOyArK2kpCj4gPiA+ID4KPiA+ID4gPiAtICAgICAgICAgICAgIGlmIChkZTJfZm9ybWF0 c1tpXS5kcm1fZm10ID09IGZvcm1hdCkKPiA+ID4gPiAtICAgICAgICAgICAgICAgICAgICAgcmV0 dXJuICZkZTJfZm9ybWF0c1tpXTsKPiA+ID4gPiArICAgICAgICAgICAgIGlmIChkZTJfZm9ybWF0 c1tpXS5kcm1fZm10ID09IGZvcm1hdCkgewo+ID4gPiA+ICsgICAgICAgICAgICAgICAgICAgICAq aHdfZm9ybWF0ID0gZGUyX2Zvcm1hdHNbaV0uZGUyX2ZtdDsKPiA+ID4gPiArICAgICAgICAgICAg ICAgICAgICAgcmV0dXJuIDA7Cj4gPiA+ID4gKyAgICAgICAgICAgICB9Cj4gPiA+ID4KPiA+ID4g PiAtICAgICByZXR1cm4gTlVMTDsKPiA+ID4gPiArICAgICByZXR1cm4gLUVJTlZBTDsKPiA+ID4g Pgo+ID4gPiA+ICB9Cj4gPiA+Cj4gPiA+IEknbSBub3QgdG9vIHN1cmUgYWJvdXQgdGhhdCBvbmUu IEl0IGJyZWFrcyB0aGUgY29uc2lzdGVuY3kgd2l0aCB0aGUKPiA+ID4gb3RoZXIgZnVuY3Rpb25z LCBhbmQgSSBkb24ndCByZWFsbHkgc2VlIGEgcGFydGljdWxhciBiZW5lZml0IHRvIGl0Pwo+ID4K Pgo+IEkgZG9uJ3QgaGF2ZSBzdHJvbmcgb3BpbmlvbiBhYm91dCB0aGlzIHBhdGNoLiBJdCBjYW4g YmUgZHJvcHBlZC4KPgo+ID4gSSBndWVzcyB3ZSBjb3VsZCBqdXN0IGRlZmluZSBhbiAiaW52YWxp ZCIgdmFsdWUsIGFuZCBoYXZlIHRoZSBmdW5jdGlvbgo+ID4gcmV0dXJuIHRoYXQgaWYgY2FuJ3Qg ZmluZCBhIG1hdGNoPyBJJ20gZ3Vlc3NpbmcgMHgwIGlzIHZhbGlkLCBzbyBtYXliZQo+ID4gMHhm ZmZmZmZmZiBvciAweGRlYWRiZWVmID8KPiA+Cj4gPiBUaGF0IHdvdWxkIGtlZXAgY29uc2lzdGVu Y3kgd2l0aCBldmVyeXRoaW5nIGVsc2UgYWxsIHRoZSB3aGlsZQo+ID4gcmVtb3ZpbmcgdGhlIGxl dmVsIG9mIGluZGlyZWN0aW9uIHlvdSB3YW50ZWQgdG8uCj4KPiBJIG1vZGVsZWQgdGhpcyBhZnRl cgo+IHN0YXRpYyBpbnQgc3VuNGlfYmFja2VuZF9kcm1fZm9ybWF0X3RvX2xheWVyKHUzMiBmb3Jt YXQsIHUzMiAqbW9kZSk7Cj4gZnJvbSBzdW40aV9iYWNrZW5kLmMuCj4KPiBXaGF0IGNvbnNpc3Rl bmN5IGRvIHlvdSBoYXZlIGluIG1pbmQ/CgpEaXJlY3RseSByZXR1cm5pbmcgdmFsdWVzIChvciBl cnJvciBjb2RlcykgaW5zdGVhZCBvZiBwYXNzaW5nIGluIGEgcG9pbnRlcgpmb3IgZGF0YSB0byBi ZSByZXR1cm5lZC4gSSBhc3N1bWVkIHRoYXQgd2FzIHdoYXQgTWF4aW1lIHdhcyByZWZlcnJpbmcg dG8uCgpDaGVuWXUKCj4gPgo+ID4gQ2hlbll1Cj4gPgo+ID4gPiBUaGUgcmVzdCBvZiB0aGUgc2Vy aWVzIGlzCj4gPiA+IEFja2VkLWJ5OiBNYXhpbWUgUmlwYXJkIDxtcmlwYXJkQGtlcm5lbC5vcmc+ Cj4KPiBUaGFua3MhCj4KPiBCZXN0IHJlZ2FyZHMsCj4gSmVybmVqCj4KPiA+ID4KPiA+ID4gTWF4 aW1lCj4KPgo+Cj4KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3Jn Cmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs Cg==