From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.9 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9898DC4741F for ; Mon, 28 Sep 2020 04:40:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6ED4B23998 for ; Mon, 28 Sep 2020 04:40:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726477AbgI1EkT convert rfc822-to-8bit (ORCPT ); Mon, 28 Sep 2020 00:40:19 -0400 Received: from mail-lf1-f66.google.com ([209.85.167.66]:34956 "EHLO mail-lf1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725298AbgI1EkT (ORCPT ); Mon, 28 Sep 2020 00:40:19 -0400 Received: by mail-lf1-f66.google.com with SMTP id w11so9547523lfn.2; Sun, 27 Sep 2020 21:40:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=MDGs++4RRj95+aWDmWU1XgAa7yuF3b9Kk32dL6Y6dKY=; b=RMaLD1pT0naQFcX2KPEjSln+wAzyUKLeOtBq60M0q9J6/CWRzFvjjshBOW6J0nUYop SFx56O4YdbYysuXNTPWvBW53jAiJCcgOICQK2D3sVgs4Dqa5VstdC8sSjHQgw4+3efVp Qs7ltY6ugJQgif3L1/dE4Qw80lbrvezZnBo6MVOM4I/RzHp7oLY5oCpEY5EPYNhExv8e Pi3heJyEcbzjfcHpTOypvtdX0YYsa5MmObIw3vP7wOEQQYnPe4tmzJv0koujZfrSfkeT hGzz9+kjWchryNnKHW8EykTHwpjI4lk4h1+zYttRrdK32b1SD5wUG/LsNK5vgPbCto1U 0lFQ== X-Gm-Message-State: AOAM531uKh+s36OyiQ3QwtiIQwm3qQkPY4xVtojCfhcopnG+rOm+tvdx WUQIE6NfMP58L6tXH0d6eE6zahJl4i/o3A== X-Google-Smtp-Source: ABdhPJwFRuf1qyI6IM5JBhnbubAqXnQu5bO1PtjZzsD/Zb9z0m15HrfnL5DxlqNYLmMs66/YvDe0eA== X-Received: by 2002:a05:6512:31c4:: with SMTP id j4mr2928208lfe.323.1601268016425; Sun, 27 Sep 2020 21:40:16 -0700 (PDT) Received: from mail-lf1-f53.google.com (mail-lf1-f53.google.com. [209.85.167.53]) by smtp.gmail.com with ESMTPSA id t23sm5703104ljc.125.2020.09.27.21.40.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 27 Sep 2020 21:40:16 -0700 (PDT) Received: by mail-lf1-f53.google.com with SMTP id z19so9520685lfr.4; Sun, 27 Sep 2020 21:40:16 -0700 (PDT) X-Received: by 2002:a19:dd5:: with SMTP id 204mr3065459lfn.551.1601268015876; Sun, 27 Sep 2020 21:40:15 -0700 (PDT) MIME-Version: 1.0 References: <20200927192912.46323-1-peron.clem@gmail.com> <20200927192912.46323-2-peron.clem@gmail.com> In-Reply-To: <20200927192912.46323-2-peron.clem@gmail.com> From: Chen-Yu Tsai Date: Mon, 28 Sep 2020 12:40:04 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [linux-sunxi] [PATCH v5 01/20] ASoC: sun4i-i2s: Add support for H6 I2S To: =?UTF-8?B?Q2zDqW1lbnQgUMOpcm9u?= Cc: Maxime Ripard , Rob Herring , Mark Brown , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Marcus Cooper , Jernej Skrabec , Linux-ALSA , devicetree , linux-arm-kernel , linux-kernel , linux-sunxi Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 28, 2020 at 3:29 AM Clément Péron wrote: > > From: Jernej Skrabec > > H6 I2S is very similar to that in H3, except it supports up to 16 > channels. > > Signed-off-by: Jernej Skrabec > Signed-off-by: Marcus Cooper > Signed-off-by: Clément Péron > --- > sound/soc/sunxi/sun4i-i2s.c | 224 ++++++++++++++++++++++++++++++++++++ > 1 file changed, 224 insertions(+) > > diff --git a/sound/soc/sunxi/sun4i-i2s.c b/sound/soc/sunxi/sun4i-i2s.c > index f23ff29e7c1d..2baf6c276280 100644 > --- a/sound/soc/sunxi/sun4i-i2s.c > +++ b/sound/soc/sunxi/sun4i-i2s.c > @@ -124,6 +124,21 @@ > #define SUN8I_I2S_RX_CHAN_SEL_REG 0x54 > #define SUN8I_I2S_RX_CHAN_MAP_REG 0x58 > > +/* Defines required for sun50i-h6 support */ > +#define SUN50I_H6_I2S_TX_CHAN_SEL_OFFSET_MASK GENMASK(21, 20) > +#define SUN50I_H6_I2S_TX_CHAN_SEL_OFFSET(offset) ((offset) << 20) > +#define SUN50I_H6_I2S_TX_CHAN_SEL_MASK GENMASK(19, 16) > +#define SUN50I_H6_I2S_TX_CHAN_SEL(chan) ((chan - 1) << 16) > +#define SUN50I_H6_I2S_TX_CHAN_EN_MASK GENMASK(15, 0) > +#define SUN50I_H6_I2S_TX_CHAN_EN(num_chan) (((1 << num_chan) - 1)) > + > +#define SUN50I_H6_I2S_TX_CHAN_MAP0_REG 0x44 > +#define SUN50I_H6_I2S_TX_CHAN_MAP1_REG 0x48 > + > +#define SUN50I_H6_I2S_RX_CHAN_SEL_REG 0x64 > +#define SUN50I_H6_I2S_RX_CHAN_MAP0_REG 0x68 > +#define SUN50I_H6_I2S_RX_CHAN_MAP1_REG 0x6C > + > struct sun4i_i2s; > > /** > @@ -474,6 +489,62 @@ static int sun8i_i2s_set_chan_cfg(const struct sun4i_i2s *i2s, > return 0; > } > > +static int sun50i_h6_i2s_set_chan_cfg(const struct sun4i_i2s *i2s, > + const struct snd_pcm_hw_params *params) > +{ > + unsigned int channels = params_channels(params); > + unsigned int slots = channels; > + unsigned int lrck_period; > + > + if (i2s->slots) > + slots = i2s->slots; > + > + /* Map the channels for playback and capture */ > + regmap_write(i2s->regmap, SUN50I_H6_I2S_TX_CHAN_MAP1_REG, 0x76543210); > + regmap_write(i2s->regmap, SUN50I_H6_I2S_RX_CHAN_MAP1_REG, 0x76543210); Nit, since it supports up to 16 channels, you might want to map all 16 of them now, instead of having to come back and fix it later. Code wise, this patch is Reviewed-by: Chen-Yu Tsai I don't have a scope nor logic analyzer, so I wasn't able to participate in the LRCK discussion. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0892FC2D0A8 for ; Mon, 28 Sep 2020 04:41:20 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BFF5323998 for ; Mon, 28 Sep 2020 04:41:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="FvP5TX57" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BFF5323998 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=csie.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 5A4B9170D; Mon, 28 Sep 2020 06:40:27 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 5A4B9170D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1601268077; bh=5cAnfZpulTGW80o13infgg6CNHHEX6bfKprcBLns928=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=FvP5TX57F/YQxE4n9ia5tGnMhZ99FMmVboUPXWWQ20SrXcawIj7PFG3e3p83lckl/ 9neMT8CFbFmAKh4f5X5Wa6gRAjHvkK6ZGizZNcGMsdb6B4W532xxDHiHsoDS6f9Za5 HiLMBemWg51QKcu4EdxG1Iu4j9eUuO1uekTKoj+E= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id C74D5F801ED; Mon, 28 Sep 2020 06:40:26 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 31F21F801F9; Mon, 28 Sep 2020 06:40:25 +0200 (CEST) Received: from mail-lj1-f194.google.com (mail-lj1-f194.google.com [209.85.208.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 6A615F800FD for ; Mon, 28 Sep 2020 06:40:17 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 6A615F800FD Received: by mail-lj1-f194.google.com with SMTP id a15so7197418ljk.2 for ; Sun, 27 Sep 2020 21:40:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=MDGs++4RRj95+aWDmWU1XgAa7yuF3b9Kk32dL6Y6dKY=; b=fxtm9xxmGB1Dw3y6s4Pz+PNn+jPHjg7/lSHNMOCXZNCCb1+oNiei+zxKjVz4c5jqwr nJO2qpqYjgVfCZibSmErvg7uqxp4L1NflPIsMp2wwpZSkNzkGTKIZTYthxuDseMQad22 /utScCgHvVfDkT4fPUGst0/CGOD+mhrJOKl3wvS/FQuNvjESit3idZQeZY2v7DhhOYov UmSgRyek5nzLyH5xLptNudflL3ziB9oYvBNlFk/20B9sr5y6Y//A7k90XG6YJ9LUAOPv hWhwiHn0mq36Lmk1617EaourukugXiy+eUS6gWc2ed8rprxl8Y89zQwVaQQhKbu6tMMK Ocug== X-Gm-Message-State: AOAM5331YOOtm7GqwHd/DXLYMS+QnlPP1ZcLZ4MofVUhs+iMZgqP9Fgw wbgeT9p8NwEeyKJqEaGxgB637lcwsPczFg== X-Google-Smtp-Source: ABdhPJw46l+WVFjEs/6KR92bNkTg3WplYbSPqt6gLH8ZWmsMDm/zjguOs4D49euGfIeUynUq8FcrbQ== X-Received: by 2002:a2e:9cc2:: with SMTP id g2mr4517081ljj.77.1601268016630; Sun, 27 Sep 2020 21:40:16 -0700 (PDT) Received: from mail-lf1-f46.google.com (mail-lf1-f46.google.com. [209.85.167.46]) by smtp.gmail.com with ESMTPSA id j23sm5691890ljh.96.2020.09.27.21.40.16 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 27 Sep 2020 21:40:16 -0700 (PDT) Received: by mail-lf1-f46.google.com with SMTP id b22so9481526lfs.13 for ; Sun, 27 Sep 2020 21:40:16 -0700 (PDT) X-Received: by 2002:a19:dd5:: with SMTP id 204mr3065459lfn.551.1601268015876; Sun, 27 Sep 2020 21:40:15 -0700 (PDT) MIME-Version: 1.0 References: <20200927192912.46323-1-peron.clem@gmail.com> <20200927192912.46323-2-peron.clem@gmail.com> In-Reply-To: <20200927192912.46323-2-peron.clem@gmail.com> From: Chen-Yu Tsai Date: Mon, 28 Sep 2020 12:40:04 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [linux-sunxi] [PATCH v5 01/20] ASoC: sun4i-i2s: Add support for H6 I2S To: =?UTF-8?B?Q2zDqW1lbnQgUMOpcm9u?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Cc: devicetree , Jernej Skrabec , Linux-ALSA , linux-kernel , Takashi Iwai , Rob Herring , Liam Girdwood , Marcus Cooper , linux-sunxi , Mark Brown , Maxime Ripard , linux-arm-kernel X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Mon, Sep 28, 2020 at 3:29 AM Cl=C3=A9ment P=C3=A9ron wrote: > > From: Jernej Skrabec > > H6 I2S is very similar to that in H3, except it supports up to 16 > channels. > > Signed-off-by: Jernej Skrabec > Signed-off-by: Marcus Cooper > Signed-off-by: Cl=C3=A9ment P=C3=A9ron > --- > sound/soc/sunxi/sun4i-i2s.c | 224 ++++++++++++++++++++++++++++++++++++ > 1 file changed, 224 insertions(+) > > diff --git a/sound/soc/sunxi/sun4i-i2s.c b/sound/soc/sunxi/sun4i-i2s.c > index f23ff29e7c1d..2baf6c276280 100644 > --- a/sound/soc/sunxi/sun4i-i2s.c > +++ b/sound/soc/sunxi/sun4i-i2s.c > @@ -124,6 +124,21 @@ > #define SUN8I_I2S_RX_CHAN_SEL_REG 0x54 > #define SUN8I_I2S_RX_CHAN_MAP_REG 0x58 > > +/* Defines required for sun50i-h6 support */ > +#define SUN50I_H6_I2S_TX_CHAN_SEL_OFFSET_MASK GENMASK(21, 20) > +#define SUN50I_H6_I2S_TX_CHAN_SEL_OFFSET(offset) ((offset) << 20) > +#define SUN50I_H6_I2S_TX_CHAN_SEL_MASK GENMASK(19, 16) > +#define SUN50I_H6_I2S_TX_CHAN_SEL(chan) ((chan - 1) << 16= ) > +#define SUN50I_H6_I2S_TX_CHAN_EN_MASK GENMASK(15, 0) > +#define SUN50I_H6_I2S_TX_CHAN_EN(num_chan) (((1 << num_chan) - 1)) > + > +#define SUN50I_H6_I2S_TX_CHAN_MAP0_REG 0x44 > +#define SUN50I_H6_I2S_TX_CHAN_MAP1_REG 0x48 > + > +#define SUN50I_H6_I2S_RX_CHAN_SEL_REG 0x64 > +#define SUN50I_H6_I2S_RX_CHAN_MAP0_REG 0x68 > +#define SUN50I_H6_I2S_RX_CHAN_MAP1_REG 0x6C > + > struct sun4i_i2s; > > /** > @@ -474,6 +489,62 @@ static int sun8i_i2s_set_chan_cfg(const struct sun4i= _i2s *i2s, > return 0; > } > > +static int sun50i_h6_i2s_set_chan_cfg(const struct sun4i_i2s *i2s, > + const struct snd_pcm_hw_params *par= ams) > +{ > + unsigned int channels =3D params_channels(params); > + unsigned int slots =3D channels; > + unsigned int lrck_period; > + > + if (i2s->slots) > + slots =3D i2s->slots; > + > + /* Map the channels for playback and capture */ > + regmap_write(i2s->regmap, SUN50I_H6_I2S_TX_CHAN_MAP1_REG, 0x76543= 210); > + regmap_write(i2s->regmap, SUN50I_H6_I2S_RX_CHAN_MAP1_REG, 0x76543= 210); Nit, since it supports up to 16 channels, you might want to map all 16 of t= hem now, instead of having to come back and fix it later. Code wise, this patch is Reviewed-by: Chen-Yu Tsai I don't have a scope nor logic analyzer, so I wasn't able to participate in= the LRCK discussion. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D12A4C2D0A8 for ; Mon, 28 Sep 2020 04:41:33 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7FE3F23998 for ; Mon, 28 Sep 2020 04:41:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="YKLH52Rt" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7FE3F23998 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=csie.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=GD9gDFwNzBfloMPwUyVSekQu7Udf5PZufSViiHGqanc=; b=YKLH52RtFXWkeXV2sQyl0/3Ek s/xrW1TqPXLJAweYNa7NHU/FZCjSi3ZH4fK1n8U1E4zpNHygeQ83Ur0Z58/sGOsgJtzkgjcy8Qt6k f8QLxdkNuVUqnQiGCtLXpdkIEjpuugmkCfAh969aZr7jH3kvPOfmQm8/LVNVqJEJYr74UUejvupYU UCWrgfT3dLFKHb8w+iBZclBnN1piDIwmyxl0Hi7efUGdoTycJbdMmFjdHjyG5otaAluPmfJvmyNha XibpatrEXMuu+UuhPIf4AIYlRuQyfikDIzdStdPGW1R6vPBGlJsccj2voBMYbkEGXim5NEzo9FLFw J1ZmXircA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kMkxY-0000fP-Fs; Mon, 28 Sep 2020 04:40:20 +0000 Received: from mail-lj1-f196.google.com ([209.85.208.196]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kMkxW-0000en-FR for linux-arm-kernel@lists.infradead.org; Mon, 28 Sep 2020 04:40:19 +0000 Received: by mail-lj1-f196.google.com with SMTP id a15so7197414ljk.2 for ; Sun, 27 Sep 2020 21:40:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=MDGs++4RRj95+aWDmWU1XgAa7yuF3b9Kk32dL6Y6dKY=; b=RY2h4mSCKWtVoi4vRQobMGeKbWWYwfvH+FjvpnrNyNyDHj+HV901xqaqeAILuiMQt5 HtN24sacbl6NtCookX2EPu4jvV/88O+6sOuo8l50muveB8nQuAuxtgECIGwlGsTJWktH ATS66pfZMiSfa2W++F3PO2mVlWrks5f3E/2A+gXTUsbucBwuG5Rfr5DCkD+ttJ7I5ygH W1xsaFP06Kc5LOq/EvJhST1Q3+TKEfGx8nsBYuwHALaUL4SRfa2iF92KwopGJdggEy9b Fu6dxTCfSIpyB+DArk/JqY6SJNBaMjkeVlOPWCXXTjStu88bkmVcwdEvNXfaWjbfu9KQ UH/A== X-Gm-Message-State: AOAM530ZaCZtmaSopmEpcQNNuMKFXZl+hPAnph97XyllNiJLFZFXxXFh hEYnRwCWGvN/wkAnUSh29CiX+HdY7CnbgA== X-Google-Smtp-Source: ABdhPJyarVE8N9AxrPAgBXLluiUXJQheUWdUhvz2P3u7TFHylmcMetq9ur9znjPEk2kEZAGsPv2BcQ== X-Received: by 2002:a2e:810a:: with SMTP id d10mr4408164ljg.302.1601268016459; Sun, 27 Sep 2020 21:40:16 -0700 (PDT) Received: from mail-lf1-f42.google.com (mail-lf1-f42.google.com. [209.85.167.42]) by smtp.gmail.com with ESMTPSA id f19sm2696285lfs.85.2020.09.27.21.40.16 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 27 Sep 2020 21:40:16 -0700 (PDT) Received: by mail-lf1-f42.google.com with SMTP id x69so9518140lff.3 for ; Sun, 27 Sep 2020 21:40:16 -0700 (PDT) X-Received: by 2002:a19:dd5:: with SMTP id 204mr3065459lfn.551.1601268015876; Sun, 27 Sep 2020 21:40:15 -0700 (PDT) MIME-Version: 1.0 References: <20200927192912.46323-1-peron.clem@gmail.com> <20200927192912.46323-2-peron.clem@gmail.com> In-Reply-To: <20200927192912.46323-2-peron.clem@gmail.com> From: Chen-Yu Tsai Date: Mon, 28 Sep 2020 12:40:04 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [linux-sunxi] [PATCH v5 01/20] ASoC: sun4i-i2s: Add support for H6 I2S To: =?UTF-8?B?Q2zDqW1lbnQgUMOpcm9u?= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200928_004018_573538_2C862FE9 X-CRM114-Status: GOOD ( 23.06 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree , Jernej Skrabec , Linux-ALSA , linux-kernel , Takashi Iwai , Rob Herring , Liam Girdwood , Marcus Cooper , linux-sunxi , Mark Brown , Maxime Ripard , Jaroslav Kysela , linux-arm-kernel Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gTW9uLCBTZXAgMjgsIDIwMjAgYXQgMzoyOSBBTSBDbMOpbWVudCBQw6lyb24gPHBlcm9uLmNs ZW1AZ21haWwuY29tPiB3cm90ZToKPgo+IEZyb206IEplcm5laiBTa3JhYmVjIDxqZXJuZWouc2ty YWJlY0BzaW9sLm5ldD4KPgo+IEg2IEkyUyBpcyB2ZXJ5IHNpbWlsYXIgdG8gdGhhdCBpbiBIMywg ZXhjZXB0IGl0IHN1cHBvcnRzIHVwIHRvIDE2Cj4gY2hhbm5lbHMuCj4KPiBTaWduZWQtb2ZmLWJ5 OiBKZXJuZWogU2tyYWJlYyA8amVybmVqLnNrcmFiZWNAc2lvbC5uZXQ+Cj4gU2lnbmVkLW9mZi1i eTogTWFyY3VzIENvb3BlciA8Y29kZWtpcHBlckBnbWFpbC5jb20+Cj4gU2lnbmVkLW9mZi1ieTog Q2zDqW1lbnQgUMOpcm9uIDxwZXJvbi5jbGVtQGdtYWlsLmNvbT4KPiAtLS0KPiAgc291bmQvc29j L3N1bnhpL3N1bjRpLWkycy5jIHwgMjI0ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysr KysrKwo+ICAxIGZpbGUgY2hhbmdlZCwgMjI0IGluc2VydGlvbnMoKykKPgo+IGRpZmYgLS1naXQg YS9zb3VuZC9zb2Mvc3VueGkvc3VuNGktaTJzLmMgYi9zb3VuZC9zb2Mvc3VueGkvc3VuNGktaTJz LmMKPiBpbmRleCBmMjNmZjI5ZTdjMWQuLjJiYWY2YzI3NjI4MCAxMDA2NDQKPiAtLS0gYS9zb3Vu ZC9zb2Mvc3VueGkvc3VuNGktaTJzLmMKPiArKysgYi9zb3VuZC9zb2Mvc3VueGkvc3VuNGktaTJz LmMKPiBAQCAtMTI0LDYgKzEyNCwyMSBAQAo+ICAjZGVmaW5lIFNVTjhJX0kyU19SWF9DSEFOX1NF TF9SRUcgICAgICAweDU0Cj4gICNkZWZpbmUgU1VOOElfSTJTX1JYX0NIQU5fTUFQX1JFRyAgICAg IDB4NTgKPgo+ICsvKiBEZWZpbmVzIHJlcXVpcmVkIGZvciBzdW41MGktaDYgc3VwcG9ydCAqLwo+ ICsjZGVmaW5lIFNVTjUwSV9INl9JMlNfVFhfQ0hBTl9TRUxfT0ZGU0VUX01BU0sgIEdFTk1BU0so MjEsIDIwKQo+ICsjZGVmaW5lIFNVTjUwSV9INl9JMlNfVFhfQ0hBTl9TRUxfT0ZGU0VUKG9mZnNl dCkgICAgICAgKChvZmZzZXQpIDw8IDIwKQo+ICsjZGVmaW5lIFNVTjUwSV9INl9JMlNfVFhfQ0hB Tl9TRUxfTUFTSyAgICAgICAgIEdFTk1BU0soMTksIDE2KQo+ICsjZGVmaW5lIFNVTjUwSV9INl9J MlNfVFhfQ0hBTl9TRUwoY2hhbikgICAgICAgICAgICAgICAgKChjaGFuIC0gMSkgPDwgMTYpCj4g KyNkZWZpbmUgU1VONTBJX0g2X0kyU19UWF9DSEFOX0VOX01BU0sgICAgICAgICAgR0VOTUFTSygx NSwgMCkKPiArI2RlZmluZSBTVU41MElfSDZfSTJTX1RYX0NIQU5fRU4obnVtX2NoYW4pICAgICAo KCgxIDw8IG51bV9jaGFuKSAtIDEpKQo+ICsKPiArI2RlZmluZSBTVU41MElfSDZfSTJTX1RYX0NI QU5fTUFQMF9SRUcgMHg0NAo+ICsjZGVmaW5lIFNVTjUwSV9INl9JMlNfVFhfQ0hBTl9NQVAxX1JF RyAweDQ4Cj4gKwo+ICsjZGVmaW5lIFNVTjUwSV9INl9JMlNfUlhfQ0hBTl9TRUxfUkVHICAweDY0 Cj4gKyNkZWZpbmUgU1VONTBJX0g2X0kyU19SWF9DSEFOX01BUDBfUkVHIDB4NjgKPiArI2RlZmlu ZSBTVU41MElfSDZfSTJTX1JYX0NIQU5fTUFQMV9SRUcgMHg2Qwo+ICsKPiAgc3RydWN0IHN1bjRp X2kyczsKPgo+ICAvKioKPiBAQCAtNDc0LDYgKzQ4OSw2MiBAQCBzdGF0aWMgaW50IHN1bjhpX2ky c19zZXRfY2hhbl9jZmcoY29uc3Qgc3RydWN0IHN1bjRpX2kycyAqaTJzLAo+ICAgICAgICAgcmV0 dXJuIDA7Cj4gIH0KPgo+ICtzdGF0aWMgaW50IHN1bjUwaV9oNl9pMnNfc2V0X2NoYW5fY2ZnKGNv bnN0IHN0cnVjdCBzdW40aV9pMnMgKmkycywKPiArICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIGNvbnN0IHN0cnVjdCBzbmRfcGNtX2h3X3BhcmFtcyAqcGFyYW1zKQo+ICt7Cj4g KyAgICAgICB1bnNpZ25lZCBpbnQgY2hhbm5lbHMgPSBwYXJhbXNfY2hhbm5lbHMocGFyYW1zKTsK PiArICAgICAgIHVuc2lnbmVkIGludCBzbG90cyA9IGNoYW5uZWxzOwo+ICsgICAgICAgdW5zaWdu ZWQgaW50IGxyY2tfcGVyaW9kOwo+ICsKPiArICAgICAgIGlmIChpMnMtPnNsb3RzKQo+ICsgICAg ICAgICAgICAgICBzbG90cyA9IGkycy0+c2xvdHM7Cj4gKwo+ICsgICAgICAgLyogTWFwIHRoZSBj aGFubmVscyBmb3IgcGxheWJhY2sgYW5kIGNhcHR1cmUgKi8KPiArICAgICAgIHJlZ21hcF93cml0 ZShpMnMtPnJlZ21hcCwgU1VONTBJX0g2X0kyU19UWF9DSEFOX01BUDFfUkVHLCAweDc2NTQzMjEw KTsKPiArICAgICAgIHJlZ21hcF93cml0ZShpMnMtPnJlZ21hcCwgU1VONTBJX0g2X0kyU19SWF9D SEFOX01BUDFfUkVHLCAweDc2NTQzMjEwKTsKCk5pdCwgc2luY2UgaXQgc3VwcG9ydHMgdXAgdG8g MTYgY2hhbm5lbHMsIHlvdSBtaWdodCB3YW50IHRvIG1hcCBhbGwgMTYgb2YgdGhlbQpub3csIGlu c3RlYWQgb2YgaGF2aW5nIHRvIGNvbWUgYmFjayBhbmQgZml4IGl0IGxhdGVyLgoKQ29kZSB3aXNl LCB0aGlzIHBhdGNoIGlzCgpSZXZpZXdlZC1ieTogQ2hlbi1ZdSBUc2FpIDx3ZW5zQGNzaWUub3Jn PgoKSSBkb24ndCBoYXZlIGEgc2NvcGUgbm9yIGxvZ2ljIGFuYWx5emVyLCBzbyBJIHdhc24ndCBh YmxlIHRvIHBhcnRpY2lwYXRlIGluIHRoZQpMUkNLIGRpc2N1c3Npb24uCgpfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxp bmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3Rz LmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==