From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751115AbdBFHSF (ORCPT ); Mon, 6 Feb 2017 02:18:05 -0500 Received: from smtp.csie.ntu.edu.tw ([140.112.30.61]:38464 "EHLO smtp.csie.ntu.edu.tw" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750924AbdBFHSE (ORCPT ); Mon, 6 Feb 2017 02:18:04 -0500 MIME-Version: 1.0 In-Reply-To: <1da35c92609058bff5e2b4d56d8940c2919f594d.1486320544.git-series.maxime.ripard@free-electrons.com> References: <1da35c92609058bff5e2b4d56d8940c2919f594d.1486320544.git-series.maxime.ripard@free-electrons.com> From: Chen-Yu Tsai Date: Mon, 6 Feb 2017 15:17:40 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 4/9] ARM: sun5i: Add UART2 pin group To: Maxime Ripard Cc: Chen-Yu Tsai , linux-arm-kernel , linux-kernel Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 6, 2017 at 2:49 AM, Maxime Ripard wrote: > There's one UART2 pin group that can be used across all sun5i SoCs. > However, the A10s already has one pin group for that controller. > > Change the index of the one in the A10s DTSI, and add the common one to > sun5i.dtsi Kind of goes against the tradition of not adding stuff no one uses? Perhaps add a comment instead? I'm OK either way though. > > Signed-off-by: Maxime Ripard Acked-by: Chen-Yu Tsai From mboxrd@z Thu Jan 1 00:00:00 1970 From: wens@csie.org (Chen-Yu Tsai) Date: Mon, 6 Feb 2017 15:17:40 +0800 Subject: [PATCH 4/9] ARM: sun5i: Add UART2 pin group In-Reply-To: <1da35c92609058bff5e2b4d56d8940c2919f594d.1486320544.git-series.maxime.ripard@free-electrons.com> References: <1da35c92609058bff5e2b4d56d8940c2919f594d.1486320544.git-series.maxime.ripard@free-electrons.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon, Feb 6, 2017 at 2:49 AM, Maxime Ripard wrote: > There's one UART2 pin group that can be used across all sun5i SoCs. > However, the A10s already has one pin group for that controller. > > Change the index of the one in the A10s DTSI, and add the common one to > sun5i.dtsi Kind of goes against the tradition of not adding stuff no one uses? Perhaps add a comment instead? I'm OK either way though. > > Signed-off-by: Maxime Ripard Acked-by: Chen-Yu Tsai