From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751926AbeFEQCp (ORCPT ); Tue, 5 Jun 2018 12:02:45 -0400 Received: from mail-wm0-f65.google.com ([74.125.82.65]:35875 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751745AbeFEQCo (ORCPT ); Tue, 5 Jun 2018 12:02:44 -0400 X-Google-Smtp-Source: ADUXVKLefzWX4JrG0GqxJ3f+JOdG2mdQhEu0cG9LKqusXxmf9UfcqXSN06qNwOTgZc6BLDkcDlPsRA== MIME-Version: 1.0 In-Reply-To: <20180605071139.osu2pgpg3ychdxln@flea> References: <20180601151701.sshwfdbflic6mybv@flea> <20180605071139.osu2pgpg3ychdxln@flea> From: Chen-Yu Tsai Date: Wed, 6 Jun 2018 00:02:20 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH V2 2/2] arm: dts: sunxi: Add missing cooling device properties for CPUs To: Maxime Ripard Cc: Viresh Kumar , arm-soc , Rob Herring , Mark Rutland , Vincent Guittot , ionela.voinescu@arm.com, Daniel Lezcano , chris.redpath@arm.com, devicetree , linux-arm-kernel , linux-kernel Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 5, 2018 at 3:11 PM, Maxime Ripard wrote: > On Tue, Jun 05, 2018 at 10:17:49AM +0530, Viresh Kumar wrote: >> The cooling device properties, like "#cooling-cells" and >> "dynamic-power-coefficient", should either be present for all the CPUs >> of a cluster or none. If these are present only for a subset of CPUs of >> a cluster then things will start falling apart as soon as the CPUs are >> brought online in a different order. For example, this will happen >> because the operating system looks for such properties in the CPU node >> it is trying to bring up, so that it can register a cooling device. >> >> Add such missing properties. >> >> Fix other missing properties (clocks, OPP, clock latency) as well to >> make it all work. >> >> Signed-off-by: Viresh Kumar > > Applied both, thanks! Please fix the "ARM" prefix when applying. :) ChenYu From mboxrd@z Thu Jan 1 00:00:00 1970 From: wens@csie.org (Chen-Yu Tsai) Date: Wed, 6 Jun 2018 00:02:20 +0800 Subject: [PATCH V2 2/2] arm: dts: sunxi: Add missing cooling device properties for CPUs In-Reply-To: <20180605071139.osu2pgpg3ychdxln@flea> References: <20180601151701.sshwfdbflic6mybv@flea> <20180605071139.osu2pgpg3ychdxln@flea> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, Jun 5, 2018 at 3:11 PM, Maxime Ripard wrote: > On Tue, Jun 05, 2018 at 10:17:49AM +0530, Viresh Kumar wrote: >> The cooling device properties, like "#cooling-cells" and >> "dynamic-power-coefficient", should either be present for all the CPUs >> of a cluster or none. If these are present only for a subset of CPUs of >> a cluster then things will start falling apart as soon as the CPUs are >> brought online in a different order. For example, this will happen >> because the operating system looks for such properties in the CPU node >> it is trying to bring up, so that it can register a cooling device. >> >> Add such missing properties. >> >> Fix other missing properties (clocks, OPP, clock latency) as well to >> make it all work. >> >> Signed-off-by: Viresh Kumar > > Applied both, thanks! Please fix the "ARM" prefix when applying. :) ChenYu