From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DDA00C4727E for ; Mon, 28 Sep 2020 06:49:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9D247235F7 for ; Mon, 28 Sep 2020 06:49:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726513AbgI1Gtz convert rfc822-to-8bit (ORCPT ); Mon, 28 Sep 2020 02:49:55 -0400 Received: from mail-lf1-f68.google.com ([209.85.167.68]:43582 "EHLO mail-lf1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725308AbgI1Gtz (ORCPT ); Mon, 28 Sep 2020 02:49:55 -0400 Received: by mail-lf1-f68.google.com with SMTP id y2so9781374lfy.10; Sun, 27 Sep 2020 23:49:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=0sGL25OAFSU0NyKSRPgNVNAwmqv5+p5DkVqXN1iipGQ=; b=gx9pt8PIqOctv0xrkT0a3bsf2hIF7LeZcAdGExSU0l+EHQddMdM4Lu3PaW5bUD+AFh IDGTRbpB8MFVzgXceMq3HxgEVOGW1cD4MD7c0AEuIDRVedT6alwrcDP/XHvPi+W2ZPGi O+OOqZhLkafaJ0PI5nkLsHTH4kCKExrzzmyLaZ1Z/zbzkCaqFEPjnmpEOpIJTl15E3C+ LeOtJZuMgjMGGPxUhx+NwPOUGYOFDjVHq6vK0WqZIwq/QC9S0VWMAvSHqsb3BxM8g/tx yLVfRXR4ZUPZ1zJsHnK8mTJN+e6Zxbu41DfLCf8IGm/kCkNMkyHIKxT7NMqxVE73dHBw hgpg== X-Gm-Message-State: AOAM532bjOvJjRhwdoQmGFoXn8DRGscFU3jfxm7J8Qby3v4Qac8EPPbj uvggfRyd6U92WN6BVdq13E4KTKLcefna6Q== X-Google-Smtp-Source: ABdhPJxr2KdcevdyBWBZg5qfoPKpPLappMl8Gt5cnBjrpGRpo9h80VCTMYV70kbWMLFb2I6E7jQXvg== X-Received: by 2002:a19:ac49:: with SMTP id r9mr3081451lfc.582.1601275792800; Sun, 27 Sep 2020 23:49:52 -0700 (PDT) Received: from mail-lj1-f170.google.com (mail-lj1-f170.google.com. [209.85.208.170]) by smtp.gmail.com with ESMTPSA id r15sm2710211lfn.259.2020.09.27.23.49.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 27 Sep 2020 23:49:52 -0700 (PDT) Received: by mail-lj1-f170.google.com with SMTP id u21so104178ljl.6; Sun, 27 Sep 2020 23:49:52 -0700 (PDT) X-Received: by 2002:a2e:a550:: with SMTP id e16mr4737780ljn.125.1601275792241; Sun, 27 Sep 2020 23:49:52 -0700 (PDT) MIME-Version: 1.0 References: <20200927192912.46323-1-peron.clem@gmail.com> <20200927192912.46323-8-peron.clem@gmail.com> In-Reply-To: <20200927192912.46323-8-peron.clem@gmail.com> From: Chen-Yu Tsai Date: Mon, 28 Sep 2020 14:49:40 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [linux-sunxi] [PATCH v5 07/20] ASoC: sun4i-i2s: Fix sun8i volatile regs To: =?UTF-8?B?Q2zDqW1lbnQgUMOpcm9u?= Cc: Maxime Ripard , Rob Herring , Mark Brown , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Marcus Cooper , Jernej Skrabec , Linux-ALSA , devicetree , linux-arm-kernel , linux-kernel , linux-sunxi Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 28, 2020 at 3:29 AM Clément Péron wrote: > > The FIFO TX reg is volatile and sun8i i2s register > mapping is different from sun4i. > > Even if in this case it's doesn't create an issue, > Avoid setting some regs that are undefined in sun8i. > > Signed-off-by: Clément Péron > Acked-by: Maxime Ripard Reviewed-by: Chen-Yu Tsai From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DEC10C2D0A8 for ; Mon, 28 Sep 2020 06:50:58 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D399323119 for ; Mon, 28 Sep 2020 06:50:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="I4JvZuy9" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D399323119 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=csie.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 536F21B09; Mon, 28 Sep 2020 08:50:06 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 536F21B09 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1601275856; bh=0sGL25OAFSU0NyKSRPgNVNAwmqv5+p5DkVqXN1iipGQ=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=I4JvZuy91qNzryf8cBrV3nBedhUKbkGnvGlO6sxBpYEiYhnd6iIMMuRRyAfbDByrj +RQZoXHfWG18cX+YfBFwtK0pJCccPnsIGheeP+6cjFJlUtPrNC+FrGfOilwSDFS92B pac4kVt83ut4QEbDh8KWBJSKauHIs3fXE/PQrEWU= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id BE21BF80115; Mon, 28 Sep 2020 08:50:05 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 02DB6F801F9; Mon, 28 Sep 2020 08:50:03 +0200 (CEST) Received: from mail-lj1-f193.google.com (mail-lj1-f193.google.com [209.85.208.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id C6C5FF800FD for ; Mon, 28 Sep 2020 08:49:53 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz C6C5FF800FD Received: by mail-lj1-f193.google.com with SMTP id n25so110307ljj.4 for ; Sun, 27 Sep 2020 23:49:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=0sGL25OAFSU0NyKSRPgNVNAwmqv5+p5DkVqXN1iipGQ=; b=MQuk3NgdRH5X5iAiqUNfabqV4AD0WDbckysMy0BvnssCUm9m/UwBZRHtM1eZSdGup1 K3eGiCATxwLx5JJyiG5W9afXSYLppb5+5XiFdAPvYFFRTY2wRE42Pi9R7XMOFQoRvcQe fUJzZyb/5gt0HJQrRp9lkxQSpNXBdFPesUmU8rcFdXlVDzGSmyxPZfGFIAwFvB+AXS5W EuzSOHXsF4TfIZG+kQxeOA+buSyKO383DSRbqh177dHbuU011oQwLob5yaqGgAIv/242 cZsxax9drfhGX0K2F/RGE6GgvaS6PDU9dFww6DiwAdE037nPdic/GIKP6c6GMqFNG+HO JJMQ== X-Gm-Message-State: AOAM530j4ZkUqB6cQHWcE7T+mj66E/LL2Xk0nS9qRFVQ06WrC2A0foNT ugH/GCUqHf8MNYOgCs0c+RHWnsEHkJ1nPA== X-Google-Smtp-Source: ABdhPJzxMdiB1Z5Fxu4sH5m5L+t2dElBcobnJjiCIyHWxKdCn6IMmpMqPbRrAVkPvl6HUz8anzZ0wg== X-Received: by 2002:a2e:8607:: with SMTP id a7mr2110lji.122.1601275792765; Sun, 27 Sep 2020 23:49:52 -0700 (PDT) Received: from mail-lj1-f172.google.com (mail-lj1-f172.google.com. [209.85.208.172]) by smtp.gmail.com with ESMTPSA id t12sm2741323lfk.26.2020.09.27.23.49.52 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 27 Sep 2020 23:49:52 -0700 (PDT) Received: by mail-lj1-f172.google.com with SMTP id s205so103376lja.7 for ; Sun, 27 Sep 2020 23:49:52 -0700 (PDT) X-Received: by 2002:a2e:a550:: with SMTP id e16mr4737780ljn.125.1601275792241; Sun, 27 Sep 2020 23:49:52 -0700 (PDT) MIME-Version: 1.0 References: <20200927192912.46323-1-peron.clem@gmail.com> <20200927192912.46323-8-peron.clem@gmail.com> In-Reply-To: <20200927192912.46323-8-peron.clem@gmail.com> From: Chen-Yu Tsai Date: Mon, 28 Sep 2020 14:49:40 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [linux-sunxi] [PATCH v5 07/20] ASoC: sun4i-i2s: Fix sun8i volatile regs To: =?UTF-8?B?Q2zDqW1lbnQgUMOpcm9u?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Cc: devicetree , Jernej Skrabec , Linux-ALSA , linux-kernel , Takashi Iwai , Rob Herring , Liam Girdwood , Marcus Cooper , linux-sunxi , Mark Brown , Maxime Ripard , linux-arm-kernel X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Mon, Sep 28, 2020 at 3:29 AM Cl=C3=A9ment P=C3=A9ron wrote: > > The FIFO TX reg is volatile and sun8i i2s register > mapping is different from sun4i. > > Even if in this case it's doesn't create an issue, > Avoid setting some regs that are undefined in sun8i. > > Signed-off-by: Cl=C3=A9ment P=C3=A9ron > Acked-by: Maxime Ripard Reviewed-by: Chen-Yu Tsai From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A910C2D0A8 for ; Mon, 28 Sep 2020 06:51:20 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 10BE92311C for ; Mon, 28 Sep 2020 06:51:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="sERK+DnZ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 10BE92311C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=csie.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ylTek7c4ImWU2w4noaOtNvIppa09fcHfrUp3z8ntRW0=; b=sERK+DnZukdM99NTmqY0E6/g7 14nnZMWjfKSgbKIhE+jJLQAX/sboLNE+LHFRdZx0HuNFNrkHIKvYJePWJNrGIKlY5no0J/xYHkaJo bWC6nS17Y//70gAtz6FDs7fkHSpPc3yjDcfWa3p31o+1KHxksMCHrrBgkDkRrdPBVGufSSflIidIw WRmJVC1aC5rzvhpabPSkhcb/f534x7LmT79XWNk/IaQv9IB98BMlubYPJrsE9qKRtW4dswSIqsVkJ RUu+YgkxfHOCef0SeKuOjKf/uL4dFEYBme1x/d3FMTYMQUjIRm6QZJwIFBZllL9dN8nlwF+vdmu4v AGzppZobQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kMmyz-0005Xx-6X; Mon, 28 Sep 2020 06:49:57 +0000 Received: from mail-lj1-f195.google.com ([209.85.208.195]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kMmyw-0005X4-Nx for linux-arm-kernel@lists.infradead.org; Mon, 28 Sep 2020 06:49:55 +0000 Received: by mail-lj1-f195.google.com with SMTP id a15so116561ljk.2 for ; Sun, 27 Sep 2020 23:49:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=0sGL25OAFSU0NyKSRPgNVNAwmqv5+p5DkVqXN1iipGQ=; b=gHKzape9d8DUYPSRSp90oyU0LQPLEdZqSr1x92kAYEG16CTHIZHwwP7AssCe1EpZSy wbdYHvX9Z4iZ+gvBX+vJN+wwce+9BAijrQtMSyZbfP6mIaNzfxSKCB2V24IGXOBH+7T0 4z9oPLNeardUcp/ks2Zi4RbIVBH1DMD4Ll3qxtv5HFreTVFEBcLIfWzpDtUzKun6KnzX dZ15Yz3G2PzcKyCJWygAwQIqK2G9HckBCDTsrhcC3jZqpq5wkWZKDV3NqQbaOIZGvUUX QnYxgChDo/AGdJ50J5d+0kQhl6Bb2ki9B3Xe3eOnWPov+pwYppZcSKF/3fvRucnRkCmg xukw== X-Gm-Message-State: AOAM531WZsekgF3mLxc1QKKRS5GPD7H5B052a+ho//g0SUvk/KoUuYy/ 6weCEYAVcYfSjgAHhizSkAkqnoaDQznbMg== X-Google-Smtp-Source: ABdhPJz+mlA/kG3zFPTCNXID2ah1JYQVfwWs41UqfLgXpLysk5R8Jx98LNlaNzcZNBag5erN8y/Fnw== X-Received: by 2002:a05:651c:111:: with SMTP id a17mr579ljb.240.1601275792934; Sun, 27 Sep 2020 23:49:52 -0700 (PDT) Received: from mail-lj1-f174.google.com (mail-lj1-f174.google.com. [209.85.208.174]) by smtp.gmail.com with ESMTPSA id l11sm2706569lfk.113.2020.09.27.23.49.52 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 27 Sep 2020 23:49:52 -0700 (PDT) Received: by mail-lj1-f174.google.com with SMTP id a15so116517ljk.2 for ; Sun, 27 Sep 2020 23:49:52 -0700 (PDT) X-Received: by 2002:a2e:a550:: with SMTP id e16mr4737780ljn.125.1601275792241; Sun, 27 Sep 2020 23:49:52 -0700 (PDT) MIME-Version: 1.0 References: <20200927192912.46323-1-peron.clem@gmail.com> <20200927192912.46323-8-peron.clem@gmail.com> In-Reply-To: <20200927192912.46323-8-peron.clem@gmail.com> From: Chen-Yu Tsai Date: Mon, 28 Sep 2020 14:49:40 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [linux-sunxi] [PATCH v5 07/20] ASoC: sun4i-i2s: Fix sun8i volatile regs To: =?UTF-8?B?Q2zDqW1lbnQgUMOpcm9u?= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200928_024954_787596_5C40C99C X-CRM114-Status: GOOD ( 12.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree , Jernej Skrabec , Linux-ALSA , linux-kernel , Takashi Iwai , Rob Herring , Liam Girdwood , Marcus Cooper , linux-sunxi , Mark Brown , Maxime Ripard , Jaroslav Kysela , linux-arm-kernel Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gTW9uLCBTZXAgMjgsIDIwMjAgYXQgMzoyOSBBTSBDbMOpbWVudCBQw6lyb24gPHBlcm9uLmNs ZW1AZ21haWwuY29tPiB3cm90ZToKPgo+IFRoZSBGSUZPIFRYIHJlZyBpcyB2b2xhdGlsZSBhbmQg c3VuOGkgaTJzIHJlZ2lzdGVyCj4gbWFwcGluZyBpcyBkaWZmZXJlbnQgZnJvbSBzdW40aS4KPgo+ IEV2ZW4gaWYgaW4gdGhpcyBjYXNlIGl0J3MgZG9lc24ndCBjcmVhdGUgYW4gaXNzdWUsCj4gQXZv aWQgc2V0dGluZyBzb21lIHJlZ3MgdGhhdCBhcmUgdW5kZWZpbmVkIGluIHN1bjhpLgo+Cj4gU2ln bmVkLW9mZi1ieTogQ2zDqW1lbnQgUMOpcm9uIDxwZXJvbi5jbGVtQGdtYWlsLmNvbT4KPiBBY2tl ZC1ieTogTWF4aW1lIFJpcGFyZCA8bXJpcGFyZEBrZXJuZWwub3JnPgoKUmV2aWV3ZWQtYnk6IENo ZW4tWXUgVHNhaSA8d2Vuc0Bjc2llLm9yZz4KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFy bS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9t YWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK