From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752230AbdCVEHS (ORCPT ); Wed, 22 Mar 2017 00:07:18 -0400 Received: from smtp.csie.ntu.edu.tw ([140.112.30.61]:39984 "EHLO smtp.csie.ntu.edu.tw" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752056AbdCVEHP (ORCPT ); Wed, 22 Mar 2017 00:07:15 -0400 MIME-Version: 1.0 In-Reply-To: <20170319045039.6163-1-f.fainelli@gmail.com> References: <20170319045039.6163-1-f.fainelli@gmail.com> From: Chen-Yu Tsai Date: Wed, 22 Mar 2017 12:06:49 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] ARM: dts: sun7i: lamobo-r1: Fix CPU port RGMII settings To: Florian Fainelli Cc: linux-arm-kernel@vger.kernel.org, mo.ucina@gmail.com, Rob Herring , Mark Rutland , Russell King , Maxime Ripard , Chen-Yu Tsai , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "moderated list:ARM PORT" , open list Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Florian, On Sun, Mar 19, 2017 at 12:50 PM, Florian Fainelli wrote: > The CPU port of the BCM53125 is configured with RGMII (no delays) but > this should actually be RGMII with transmit delay (rgmii-txid) because > STMMAC takes care of inserting the transmitter delay. This fixes > occasional packet loss encountered. > > Fixes: d7b9eaff5f0c ("ARM: dts: sun7i: Add BCM53125 switch nodes to the lamobo-r1 board") > Reported-by: Hartmut Knaack > Signed-off-by: Florian Fainelli > --- > arch/arm/boot/dts/sun7i-a20-lamobo-r1.dts | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/sun7i-a20-lamobo-r1.dts b/arch/arm/boot/dts/sun7i-a20-lamobo-r1.dts > index 72ec0d5ae052..bbf1c8cbaac6 100644 > --- a/arch/arm/boot/dts/sun7i-a20-lamobo-r1.dts > +++ b/arch/arm/boot/dts/sun7i-a20-lamobo-r1.dts > @@ -167,7 +167,7 @@ > reg = <8>; > label = "cpu"; > ethernet = <&gmac>; > - phy-mode = "rgmii"; > + phy-mode = "rgmii-txid"; Just to clarify, the DT binding says: * "rgmii-txid" (RGMII with internal TX delay provided by the PHY, the MAC should not add an TX delay in this case) I'm assuming this applies from the device node's point of view? In this case the "PHY" is STMMAC, and the "MAC" is the switch chip? Is that right? Thanks ChenYu > fixed-link { > speed = <1000>; > full-duplex; > -- > 2.9.3 > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chen-Yu Tsai Subject: Re: [PATCH] ARM: dts: sun7i: lamobo-r1: Fix CPU port RGMII settings Date: Wed, 22 Mar 2017 12:06:49 +0800 Message-ID: References: <20170319045039.6163-1-f.fainelli@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: <20170319045039.6163-1-f.fainelli@gmail.com> Sender: linux-kernel-owner@vger.kernel.org To: Florian Fainelli Cc: linux-arm-kernel@vger.kernel.org, mo.ucina@gmail.com, Rob Herring , Mark Rutland , Russell King , Maxime Ripard , Chen-Yu Tsai , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "moderated list:ARM PORT" , open list List-Id: devicetree@vger.kernel.org Hi Florian, On Sun, Mar 19, 2017 at 12:50 PM, Florian Fainelli wrote: > The CPU port of the BCM53125 is configured with RGMII (no delays) but > this should actually be RGMII with transmit delay (rgmii-txid) because > STMMAC takes care of inserting the transmitter delay. This fixes > occasional packet loss encountered. > > Fixes: d7b9eaff5f0c ("ARM: dts: sun7i: Add BCM53125 switch nodes to the lamobo-r1 board") > Reported-by: Hartmut Knaack > Signed-off-by: Florian Fainelli > --- > arch/arm/boot/dts/sun7i-a20-lamobo-r1.dts | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/sun7i-a20-lamobo-r1.dts b/arch/arm/boot/dts/sun7i-a20-lamobo-r1.dts > index 72ec0d5ae052..bbf1c8cbaac6 100644 > --- a/arch/arm/boot/dts/sun7i-a20-lamobo-r1.dts > +++ b/arch/arm/boot/dts/sun7i-a20-lamobo-r1.dts > @@ -167,7 +167,7 @@ > reg = <8>; > label = "cpu"; > ethernet = <&gmac>; > - phy-mode = "rgmii"; > + phy-mode = "rgmii-txid"; Just to clarify, the DT binding says: * "rgmii-txid" (RGMII with internal TX delay provided by the PHY, the MAC should not add an TX delay in this case) I'm assuming this applies from the device node's point of view? In this case the "PHY" is STMMAC, and the "MAC" is the switch chip? Is that right? Thanks ChenYu > fixed-link { > speed = <1000>; > full-duplex; > -- > 2.9.3 > From mboxrd@z Thu Jan 1 00:00:00 1970 From: wens@csie.org (Chen-Yu Tsai) Date: Wed, 22 Mar 2017 12:06:49 +0800 Subject: [PATCH] ARM: dts: sun7i: lamobo-r1: Fix CPU port RGMII settings In-Reply-To: <20170319045039.6163-1-f.fainelli@gmail.com> References: <20170319045039.6163-1-f.fainelli@gmail.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Florian, On Sun, Mar 19, 2017 at 12:50 PM, Florian Fainelli wrote: > The CPU port of the BCM53125 is configured with RGMII (no delays) but > this should actually be RGMII with transmit delay (rgmii-txid) because > STMMAC takes care of inserting the transmitter delay. This fixes > occasional packet loss encountered. > > Fixes: d7b9eaff5f0c ("ARM: dts: sun7i: Add BCM53125 switch nodes to the lamobo-r1 board") > Reported-by: Hartmut Knaack > Signed-off-by: Florian Fainelli > --- > arch/arm/boot/dts/sun7i-a20-lamobo-r1.dts | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/sun7i-a20-lamobo-r1.dts b/arch/arm/boot/dts/sun7i-a20-lamobo-r1.dts > index 72ec0d5ae052..bbf1c8cbaac6 100644 > --- a/arch/arm/boot/dts/sun7i-a20-lamobo-r1.dts > +++ b/arch/arm/boot/dts/sun7i-a20-lamobo-r1.dts > @@ -167,7 +167,7 @@ > reg = <8>; > label = "cpu"; > ethernet = <&gmac>; > - phy-mode = "rgmii"; > + phy-mode = "rgmii-txid"; Just to clarify, the DT binding says: * "rgmii-txid" (RGMII with internal TX delay provided by the PHY, the MAC should not add an TX delay in this case) I'm assuming this applies from the device node's point of view? In this case the "PHY" is STMMAC, and the "MAC" is the switch chip? Is that right? Thanks ChenYu > fixed-link { > speed = <1000>; > full-duplex; > -- > 2.9.3 >