From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0C2DC47254 for ; Tue, 5 May 2020 07:52:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A8E32206CC for ; Tue, 5 May 2020 07:52:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728415AbgEEHwo (ORCPT ); Tue, 5 May 2020 03:52:44 -0400 Received: from mail-lf1-f66.google.com ([209.85.167.66]:42873 "EHLO mail-lf1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725915AbgEEHwn (ORCPT ); Tue, 5 May 2020 03:52:43 -0400 Received: by mail-lf1-f66.google.com with SMTP id j14so562972lfg.9; Tue, 05 May 2020 00:52:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=0Y7Rnj17ii//R53Od+I3NriqOZPosXNwE7MSov+XlfY=; b=iy49VVYBUEbHpP6UrgjpJkUZ9YmV5EQ0njhXfazLAr96Fa7bWKaXJxqeMRFvMk7znX yWa7dAw3lCInQVa6tMN7Z03OsyZM7coB/EH6B8I+Q5rPLovDVAW5xiyf0Gc8fc8wj29F udlf2182CL+thE+BtNaFK7CPPkaJDpP/RqITce+h2GRgLw+9NGmIaqzZQZz5I1ee0ltG eKaEHip6bByoxEIB8x3kRo4lnYuFmtGB6fsHX1kA29hdNB4Cxb+buBUdAJqmgyTW405N M+ZZM+0+CVgGm44HMghlvGRZaGERJ2QzkyOuQ5CxrwRjWZiyA7b9L5UYg88lG0AFtfHC vnvg== X-Gm-Message-State: AGi0PubbOec2tJWWyU2o3Br+KsmJ9+uZApxPMu0gEiTIYO4LpyfFevvw 3U1cWc6ND+R5rbdxvZglf66OaomwZC0= X-Google-Smtp-Source: APiQypKUJ47EMGE/ZFOvAQXjtRPtwqdPUM00s4u5xHsW9UqgxbtxmVXW8hY7TmeX9lb3F+2KGB550g== X-Received: by 2002:a05:6512:108f:: with SMTP id j15mr831965lfg.19.1588665159309; Tue, 05 May 2020 00:52:39 -0700 (PDT) Received: from mail-lf1-f48.google.com (mail-lf1-f48.google.com. [209.85.167.48]) by smtp.gmail.com with ESMTPSA id u21sm1043048ljo.61.2020.05.05.00.52.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 05 May 2020 00:52:38 -0700 (PDT) Received: by mail-lf1-f48.google.com with SMTP id a4so552747lfh.12; Tue, 05 May 2020 00:52:38 -0700 (PDT) X-Received: by 2002:ac2:5290:: with SMTP id q16mr830193lfm.108.1588665158225; Tue, 05 May 2020 00:52:38 -0700 (PDT) MIME-Version: 1.0 References: <20200505075034.168296-1-christophe.jaillet@wanadoo.fr> In-Reply-To: <20200505075034.168296-1-christophe.jaillet@wanadoo.fr> From: Chen-Yu Tsai Date: Tue, 5 May 2020 15:52:25 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] media: sun8i: Fix an error handling path in 'deinterlace_runtime_resume()' To: Christophe JAILLET Cc: Jernej Skrabec , Mauro Carvalho Chehab , Maxime Ripard , Hans Verkuil , Linux Media Mailing List , linux-arm-kernel , linux-kernel , kernel-janitors@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 5, 2020 at 3:50 PM Christophe JAILLET wrote: > > It is spurious to call 'clk_disable_unprepare()' when > 'clk_prepare_enable()' has not been called yet. > Re-order the error handling path to avoid it. > > Fixes: a4260ea49547 ("media: sun4i: Add H3 deinterlace driver") > Signed-off-by: Christophe JAILLET Acked-by: Chen-Yu Tsai From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chen-Yu Tsai Date: Tue, 05 May 2020 07:52:25 +0000 Subject: Re: [PATCH] media: sun8i: Fix an error handling path in 'deinterlace_runtime_resume()' Message-Id: List-Id: References: <20200505075034.168296-1-christophe.jaillet@wanadoo.fr> In-Reply-To: <20200505075034.168296-1-christophe.jaillet@wanadoo.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Christophe JAILLET Cc: Jernej Skrabec , kernel-janitors@vger.kernel.org, linux-kernel , Maxime Ripard , Hans Verkuil , Mauro Carvalho Chehab , linux-arm-kernel , Linux Media Mailing List On Tue, May 5, 2020 at 3:50 PM Christophe JAILLET wrote: > > It is spurious to call 'clk_disable_unprepare()' when > 'clk_prepare_enable()' has not been called yet. > Re-order the error handling path to avoid it. > > Fixes: a4260ea49547 ("media: sun4i: Add H3 deinterlace driver") > Signed-off-by: Christophe JAILLET Acked-by: Chen-Yu Tsai From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7CEA3C47256 for ; Tue, 5 May 2020 07:52:45 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3F68420721 for ; Tue, 5 May 2020 07:52:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="TrFQxBpr" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3F68420721 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=csie.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=fdhQFIruyQL9JKqMMdajnTJQQhbmeTQtQnhS6T6J8c8=; b=TrFQxBprT/Nw5i zkCqm2nGt2LoO0NjIISSUjL/eeckbiqRivjfuNiFYLw86uKKh9C28nWGoeMmALXFbdHWFbB74eIpG +3yJ90a30rGnO9gNLfhZD6YsKZLW2it2hzAN36fKUKtl58Uf9drF+LLZSfWvRT+Bsz7tStY3DA5bA xgNzQ5M2RWXmTLuzNUvPkhig+1nZO901Fp5Sf2psYCXiMwr4wao5s/Jo9StEtnowqQCTkxXpwJLKb odZuBhnj01fEDPNwd9QUofPRgZ8kESD1+VaBQZBMRmzD9wWcKHiAZB3UvBCEYbDAOKn3iHjAh6DA3 bDXJdYq11k3cLDDOE81g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jVsNg-0002Ro-CW; Tue, 05 May 2020 07:52:44 +0000 Received: from mail-lj1-f194.google.com ([209.85.208.194]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jVsNd-0002R0-8R for linux-arm-kernel@lists.infradead.org; Tue, 05 May 2020 07:52:42 +0000 Received: by mail-lj1-f194.google.com with SMTP id f11so611589ljp.1 for ; Tue, 05 May 2020 00:52:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=0Y7Rnj17ii//R53Od+I3NriqOZPosXNwE7MSov+XlfY=; b=oz/5NvSUg7cL+uyyM7gpOR34h5qInGaOpipLOTEdGAP09GkqqfeN5s4wIrKklxMLpu D0ZsXgC8ajS9c/Zda1CKpS+hnBFFtZ357pqe5q2XjB/4PTpokDkDuPyYhUpGUSX3XC8f 18b+cNd2i4RvOKbk+iwqgHwfdMftdIq2+66hEMwYB60BNML7mVwbElPjxVACuGFsS4vv l/GWSRw+0Drp3M/OokgC2tXn9uxLCf2xekxfdiel1PQMBXvuobXzroh9OZ0teEICbtq8 HVYaseMvdQ/x8UCqXIuuKWlqKYyvWmik2KOBtBStENVVViPqTGYTX0Q3A8p18HJAQDjz 49wg== X-Gm-Message-State: AGi0PuZZP9ANUVVYlTKR9I4j26EpGQzpi3AePAnrgHBTNm4yYGYWc+jY mWiD43qpc4DcA1V9itpNS9eaFD8BWuY= X-Google-Smtp-Source: APiQypKcj24GtO7hF+3+XVInTi9oI+FeUYZ1XhmsSd0UtYS4IuDkkG22FcwJDarGyT9sqKlcftM6OA== X-Received: by 2002:a2e:8949:: with SMTP id b9mr1060686ljk.108.1588665159036; Tue, 05 May 2020 00:52:39 -0700 (PDT) Received: from mail-lf1-f42.google.com (mail-lf1-f42.google.com. [209.85.167.42]) by smtp.gmail.com with ESMTPSA id s8sm1259038lfd.61.2020.05.05.00.52.38 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 05 May 2020 00:52:38 -0700 (PDT) Received: by mail-lf1-f42.google.com with SMTP id a9so564884lfb.8 for ; Tue, 05 May 2020 00:52:38 -0700 (PDT) X-Received: by 2002:ac2:5290:: with SMTP id q16mr830193lfm.108.1588665158225; Tue, 05 May 2020 00:52:38 -0700 (PDT) MIME-Version: 1.0 References: <20200505075034.168296-1-christophe.jaillet@wanadoo.fr> In-Reply-To: <20200505075034.168296-1-christophe.jaillet@wanadoo.fr> From: Chen-Yu Tsai Date: Tue, 5 May 2020 15:52:25 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] media: sun8i: Fix an error handling path in 'deinterlace_runtime_resume()' To: Christophe JAILLET X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200505_005241_301306_45EE23C9 X-CRM114-Status: GOOD ( 12.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jernej Skrabec , kernel-janitors@vger.kernel.org, linux-kernel , Maxime Ripard , Hans Verkuil , Mauro Carvalho Chehab , linux-arm-kernel , Linux Media Mailing List Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, May 5, 2020 at 3:50 PM Christophe JAILLET wrote: > > It is spurious to call 'clk_disable_unprepare()' when > 'clk_prepare_enable()' has not been called yet. > Re-order the error handling path to avoid it. > > Fixes: a4260ea49547 ("media: sun4i: Add H3 deinterlace driver") > Signed-off-by: Christophe JAILLET Acked-by: Chen-Yu Tsai _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel