From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753674AbeDSMpq convert rfc822-to-8bit (ORCPT ); Thu, 19 Apr 2018 08:45:46 -0400 Received: from mail-wr0-f193.google.com ([209.85.128.193]:44002 "EHLO mail-wr0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753569AbeDSMpi (ORCPT ); Thu, 19 Apr 2018 08:45:38 -0400 X-Google-Smtp-Source: AIpwx48R4nT4mi0aizGAHHJXJqwJFcd/iyxmT++NrP27NVs5LsRxQMqgLg+OnKPmWa0CUTGpinGh2Q== MIME-Version: 1.0 In-Reply-To: <58ce9e3b-00ee-87d2-f05b-b9f1414d1cfa@micronovasrl.com> References: <20180419093225.614-1-wens@csie.org> <20180419093225.614-5-wens@csie.org> <58ce9e3b-00ee-87d2-f05b-b9f1414d1cfa@micronovasrl.com> From: Chen-Yu Tsai Date: Thu, 19 Apr 2018 20:45:14 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 4/6] drm/panel: simple: Add support for Banana Pi 7" S070WV20-CT16 panel To: Giulio Benetti Cc: Maxime Ripard , David Airlie , Thierry Reding , Rob Herring , Mark Rutland , dri-devel , linux-arm-kernel , linux-kernel , devicetree , Jonathan Liu Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 19, 2018 at 8:31 PM, Giulio Benetti wrote: > Hi, > > Il 19/04/2018 11:32, Chen-Yu Tsai ha scritto: >> >> This panel is marketed as Banana Pi 7" LCD display. On the back is >> a sticker denoting the model name S070WV20-CT16. > > > Judging from the code, the real vendor should be CDTech. > Take a look at their website: > http://www.cdtech-lcd.com/en/standardscreen.html > > I point you my patch for inserting another similar panel: > https://patchwork.freedesktop.org/patch/211914/ > > Maybe it would make sense to use CDTech as the vendor, > because maybe Bananapi resells only it. > Or maybe it is a custom panel done for them, > but the same is for other panels I've submitted patches. > Micronova srl custom, but vendor is CDTech. > > What do you think? That might be true. But for people without access to the vendors, this is horribly hard to figure out. People are only going to look at whatever marking there is on the LCD panel, and whatever the seller says. This panel has the model number stickered on, but the PCB attached to it only has the Banana Pi logo. And given it's a custom piece, probably OEM or ODM, the real manufacturer matters less. You don't mention "Foxconn" as the vendor of the iPhone, do you? ChenYu > > -- > Giulio Benetti > CTO > > MICRONOVA SRL > Sede: Via A. Niedda 3 - 35010 Vigonza (PD) > Tel. 049/8931563 - Fax 049/8931346 > Cod.Fiscale - P.IVA 02663420285 > Capitale Sociale € 26.000 i.v. > Iscritta al Reg. Imprese di Padova N. 02663420285 > Numero R.E.A. 258642 > > >> >> This is a 7" 800x480 panel connected through a 24-bit RGB interface. >> However the panel only does 262k colors. >> >> Signed-off-by: Chen-Yu Tsai >> --- >> .../display/panel/bananapi,s070wv20-ct16.txt | 7 ++++++ >> drivers/gpu/drm/panel/panel-simple.c | 25 +++++++++++++++++++ >> 2 files changed, 32 insertions(+) >> create mode 100644 >> Documentation/devicetree/bindings/display/panel/bananapi,s070wv20-ct16.txt >> >> diff --git >> a/Documentation/devicetree/bindings/display/panel/bananapi,s070wv20-ct16.txt >> b/Documentation/devicetree/bindings/display/panel/bananapi,s070wv20-ct16.txt >> new file mode 100644 >> index 000000000000..2ec35ce36e9a >> --- /dev/null >> +++ >> b/Documentation/devicetree/bindings/display/panel/bananapi,s070wv20-ct16.txt >> @@ -0,0 +1,7 @@ >> +Banana Pi 7" (S070WV20-CT16) TFT LCD Panel >> + >> +Required properties: >> +- compatible: should be "bananapi,s070wv20-ct16" >> + >> +This binding is compatible with the simple-panel binding, which is >> specified >> +in simple-panel.txt in this directory. >> diff --git a/drivers/gpu/drm/panel/panel-simple.c >> b/drivers/gpu/drm/panel/panel-simple.c >> index cbf1ab404ee7..9bc037f74d6c 100644 >> --- a/drivers/gpu/drm/panel/panel-simple.c >> +++ b/drivers/gpu/drm/panel/panel-simple.c >> @@ -745,6 +745,28 @@ static const struct panel_desc avic_tm070ddh03 = { >> }, >> }; >> +static const struct drm_display_mode bananapi_s070wv20_ct16_mode = { >> + .clock = 30000, >> + .hdisplay = 800, >> + .hsync_start = 800 + 40, >> + .hsync_end = 800 + 40 + 48, >> + .htotal = 800 + 40 + 48 + 40, >> + .vdisplay = 480, >> + .vsync_start = 480 + 13, >> + .vsync_end = 480 + 13 + 3, >> + .vtotal = 480 + 13 + 3 + 29, >> +}; >> + >> +static const struct panel_desc bananapi_s070wv20_ct16 = { >> + .modes = &bananapi_s070wv20_ct16_mode, >> + .num_modes = 1, >> + .bpc = 6, >> + .size = { >> + .width = 154, >> + .height = 86, >> + }, >> +}; >> + >> static const struct drm_display_mode boe_nv101wxmn51_modes[] = { >> { >> .clock = 71900, >> @@ -2112,6 +2134,9 @@ static const struct of_device_id platform_of_match[] >> = { >> }, { >> .compatible = "avic,tm070ddh03", >> .data = &avic_tm070ddh03, >> + }, { >> + .compatible = "bananapi,s070wv20-ct16", >> + .data = &bananapi_s070wv20_ct16, >> }, { >> .compatible = "boe,nv101wxmn51", >> .data = &boe_nv101wxmn51, >> > > > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chen-Yu Tsai Subject: Re: [PATCH 4/6] drm/panel: simple: Add support for Banana Pi 7" S070WV20-CT16 panel Date: Thu, 19 Apr 2018 20:45:14 +0800 Message-ID: References: <20180419093225.614-1-wens@csie.org> <20180419093225.614-5-wens@csie.org> <58ce9e3b-00ee-87d2-f05b-b9f1414d1cfa@micronovasrl.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <58ce9e3b-00ee-87d2-f05b-b9f1414d1cfa@micronovasrl.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Giulio Benetti Cc: Mark Rutland , devicetree , Jonathan Liu , Rob Herring , Maxime Ripard , linux-kernel , dri-devel , David Airlie , Thierry Reding , linux-arm-kernel List-Id: devicetree@vger.kernel.org T24gVGh1LCBBcHIgMTksIDIwMTggYXQgODozMSBQTSwgR2l1bGlvIEJlbmV0dGkKPGdpdWxpby5i ZW5ldHRpQG1pY3Jvbm92YXNybC5jb20+IHdyb3RlOgo+IEhpLAo+Cj4gSWwgMTkvMDQvMjAxOCAx MTozMiwgQ2hlbi1ZdSBUc2FpIGhhIHNjcml0dG86Cj4+Cj4+IFRoaXMgcGFuZWwgaXMgbWFya2V0 ZWQgYXMgQmFuYW5hIFBpIDciIExDRCBkaXNwbGF5LiBPbiB0aGUgYmFjayBpcwo+PiBhIHN0aWNr ZXIgZGVub3RpbmcgdGhlIG1vZGVsIG5hbWUgUzA3MFdWMjAtQ1QxNi4KPgo+Cj4gSnVkZ2luZyBm cm9tIHRoZSBjb2RlLCB0aGUgcmVhbCB2ZW5kb3Igc2hvdWxkIGJlIENEVGVjaC4KPiBUYWtlIGEg bG9vayBhdCB0aGVpciB3ZWJzaXRlOgo+IGh0dHA6Ly93d3cuY2R0ZWNoLWxjZC5jb20vZW4vc3Rh bmRhcmRzY3JlZW4uaHRtbAo+Cj4gSSBwb2ludCB5b3UgbXkgcGF0Y2ggZm9yIGluc2VydGluZyBh bm90aGVyIHNpbWlsYXIgcGFuZWw6Cj4gaHR0cHM6Ly9wYXRjaHdvcmsuZnJlZWRlc2t0b3Aub3Jn L3BhdGNoLzIxMTkxNC8KPgo+IE1heWJlIGl0IHdvdWxkIG1ha2Ugc2Vuc2UgdG8gdXNlIENEVGVj aCBhcyB0aGUgdmVuZG9yLAo+IGJlY2F1c2UgbWF5YmUgQmFuYW5hcGkgcmVzZWxscyBvbmx5IGl0 Lgo+IE9yIG1heWJlIGl0IGlzIGEgY3VzdG9tIHBhbmVsIGRvbmUgZm9yIHRoZW0sCj4gYnV0IHRo ZSBzYW1lIGlzIGZvciBvdGhlciBwYW5lbHMgSSd2ZSBzdWJtaXR0ZWQgcGF0Y2hlcy4KPiBNaWNy b25vdmEgc3JsIGN1c3RvbSwgYnV0IHZlbmRvciBpcyBDRFRlY2guCj4KPiBXaGF0IGRvIHlvdSB0 aGluaz8KClRoYXQgbWlnaHQgYmUgdHJ1ZS4gQnV0IGZvciBwZW9wbGUgd2l0aG91dCBhY2Nlc3Mg dG8gdGhlIHZlbmRvcnMsCnRoaXMgaXMgaG9ycmlibHkgaGFyZCB0byBmaWd1cmUgb3V0LiBQZW9w bGUgYXJlIG9ubHkgZ29pbmcgdG8gbG9vawphdCB3aGF0ZXZlciBtYXJraW5nIHRoZXJlIGlzIG9u IHRoZSBMQ0QgcGFuZWwsIGFuZCB3aGF0ZXZlciB0aGUKc2VsbGVyIHNheXMuIFRoaXMgcGFuZWwg aGFzIHRoZSBtb2RlbCBudW1iZXIgc3RpY2tlcmVkIG9uLCBidXQgdGhlClBDQiBhdHRhY2hlZCB0 byBpdCBvbmx5IGhhcyB0aGUgQmFuYW5hIFBpIGxvZ28uCgpBbmQgZ2l2ZW4gaXQncyBhIGN1c3Rv bSBwaWVjZSwgcHJvYmFibHkgT0VNIG9yIE9ETSwgdGhlIHJlYWwKbWFudWZhY3R1cmVyIG1hdHRl cnMgbGVzcy4gWW91IGRvbid0IG1lbnRpb24gIkZveGNvbm4iIGFzIHRoZQp2ZW5kb3Igb2YgdGhl IGlQaG9uZSwgZG8geW91PwoKQ2hlbll1Cgo+Cj4gLS0KPiBHaXVsaW8gQmVuZXR0aQo+IENUTwo+ Cj4gTUlDUk9OT1ZBIFNSTAo+IFNlZGU6IFZpYSBBLiBOaWVkZGEgMyAtIDM1MDEwIFZpZ29uemEg KFBEKQo+IFRlbC4gMDQ5Lzg5MzE1NjMgLSBGYXggMDQ5Lzg5MzEzNDYKPiBDb2QuRmlzY2FsZSAt IFAuSVZBIDAyNjYzNDIwMjg1Cj4gQ2FwaXRhbGUgU29jaWFsZSDigqwgMjYuMDAwIGkudi4KPiBJ c2NyaXR0YSBhbCBSZWcuIEltcHJlc2UgZGkgUGFkb3ZhIE4uIDAyNjYzNDIwMjg1Cj4gTnVtZXJv IFIuRS5BLiAyNTg2NDIKPgo+Cj4+Cj4+IFRoaXMgaXMgYSA3IiA4MDB4NDgwIHBhbmVsIGNvbm5l Y3RlZCB0aHJvdWdoIGEgMjQtYml0IFJHQiBpbnRlcmZhY2UuCj4+IEhvd2V2ZXIgdGhlIHBhbmVs IG9ubHkgZG9lcyAyNjJrIGNvbG9ycy4KPj4KPj4gU2lnbmVkLW9mZi1ieTogQ2hlbi1ZdSBUc2Fp IDx3ZW5zQGNzaWUub3JnPgo+PiAtLS0KPj4gICAuLi4vZGlzcGxheS9wYW5lbC9iYW5hbmFwaSxz MDcwd3YyMC1jdDE2LnR4dCAgfCAgNyArKysrKysKPj4gICBkcml2ZXJzL2dwdS9kcm0vcGFuZWwv cGFuZWwtc2ltcGxlLmMgICAgICAgICAgfCAyNSArKysrKysrKysrKysrKysrKysrCj4+ICAgMiBm aWxlcyBjaGFuZ2VkLCAzMiBpbnNlcnRpb25zKCspCj4+ICAgY3JlYXRlIG1vZGUgMTAwNjQ0Cj4+ IERvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9kaXNwbGF5L3BhbmVsL2JhbmFuYXBp LHMwNzB3djIwLWN0MTYudHh0Cj4+Cj4+IGRpZmYgLS1naXQKPj4gYS9Eb2N1bWVudGF0aW9uL2Rl dmljZXRyZWUvYmluZGluZ3MvZGlzcGxheS9wYW5lbC9iYW5hbmFwaSxzMDcwd3YyMC1jdDE2LnR4 dAo+PiBiL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9kaXNwbGF5L3BhbmVsL2Jh bmFuYXBpLHMwNzB3djIwLWN0MTYudHh0Cj4+IG5ldyBmaWxlIG1vZGUgMTAwNjQ0Cj4+IGluZGV4 IDAwMDAwMDAwMDAwMC4uMmVjMzVjZTM2ZTlhCj4+IC0tLSAvZGV2L251bGwKPj4gKysrCj4+IGIv RG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL2Rpc3BsYXkvcGFuZWwvYmFuYW5hcGks czA3MHd2MjAtY3QxNi50eHQKPj4gQEAgLTAsMCArMSw3IEBACj4+ICtCYW5hbmEgUGkgNyIgKFMw NzBXVjIwLUNUMTYpIFRGVCBMQ0QgUGFuZWwKPj4gKwo+PiArUmVxdWlyZWQgcHJvcGVydGllczoK Pj4gKy0gY29tcGF0aWJsZTogc2hvdWxkIGJlICJiYW5hbmFwaSxzMDcwd3YyMC1jdDE2Igo+PiAr Cj4+ICtUaGlzIGJpbmRpbmcgaXMgY29tcGF0aWJsZSB3aXRoIHRoZSBzaW1wbGUtcGFuZWwgYmlu ZGluZywgd2hpY2ggaXMKPj4gc3BlY2lmaWVkCj4+ICtpbiBzaW1wbGUtcGFuZWwudHh0IGluIHRo aXMgZGlyZWN0b3J5Lgo+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL3BhbmVsL3BhbmVs LXNpbXBsZS5jCj4+IGIvZHJpdmVycy9ncHUvZHJtL3BhbmVsL3BhbmVsLXNpbXBsZS5jCj4+IGlu ZGV4IGNiZjFhYjQwNGVlNy4uOWJjMDM3Zjc0ZDZjIDEwMDY0NAo+PiAtLS0gYS9kcml2ZXJzL2dw dS9kcm0vcGFuZWwvcGFuZWwtc2ltcGxlLmMKPj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL3BhbmVs L3BhbmVsLXNpbXBsZS5jCj4+IEBAIC03NDUsNiArNzQ1LDI4IEBAIHN0YXRpYyBjb25zdCBzdHJ1 Y3QgcGFuZWxfZGVzYyBhdmljX3RtMDcwZGRoMDMgPSB7Cj4+ICAgICAgICAgfSwKPj4gICB9Owo+ PiAgICtzdGF0aWMgY29uc3Qgc3RydWN0IGRybV9kaXNwbGF5X21vZGUgYmFuYW5hcGlfczA3MHd2 MjBfY3QxNl9tb2RlID0gewo+PiArICAgICAgIC5jbG9jayA9IDMwMDAwLAo+PiArICAgICAgIC5o ZGlzcGxheSA9IDgwMCwKPj4gKyAgICAgICAuaHN5bmNfc3RhcnQgPSA4MDAgKyA0MCwKPj4gKyAg ICAgICAuaHN5bmNfZW5kID0gODAwICsgNDAgKyA0OCwKPj4gKyAgICAgICAuaHRvdGFsID0gODAw ICsgNDAgKyA0OCArIDQwLAo+PiArICAgICAgIC52ZGlzcGxheSA9IDQ4MCwKPj4gKyAgICAgICAu dnN5bmNfc3RhcnQgPSA0ODAgKyAxMywKPj4gKyAgICAgICAudnN5bmNfZW5kID0gNDgwICsgMTMg KyAzLAo+PiArICAgICAgIC52dG90YWwgPSA0ODAgKyAxMyArIDMgKyAyOSwKPj4gK307Cj4+ICsK Pj4gK3N0YXRpYyBjb25zdCBzdHJ1Y3QgcGFuZWxfZGVzYyBiYW5hbmFwaV9zMDcwd3YyMF9jdDE2 ID0gewo+PiArICAgICAgIC5tb2RlcyA9ICZiYW5hbmFwaV9zMDcwd3YyMF9jdDE2X21vZGUsCj4+ ICsgICAgICAgLm51bV9tb2RlcyA9IDEsCj4+ICsgICAgICAgLmJwYyA9IDYsCj4+ICsgICAgICAg LnNpemUgPSB7Cj4+ICsgICAgICAgICAgICAgICAud2lkdGggPSAxNTQsCj4+ICsgICAgICAgICAg ICAgICAuaGVpZ2h0ID0gODYsCj4+ICsgICAgICAgfSwKPj4gK307Cj4+ICsKPj4gICBzdGF0aWMg Y29uc3Qgc3RydWN0IGRybV9kaXNwbGF5X21vZGUgYm9lX252MTAxd3htbjUxX21vZGVzW10gPSB7 Cj4+ICAgICAgICAgewo+PiAgICAgICAgICAgICAgICAgLmNsb2NrID0gNzE5MDAsCj4+IEBAIC0y MTEyLDYgKzIxMzQsOSBAQCBzdGF0aWMgY29uc3Qgc3RydWN0IG9mX2RldmljZV9pZCBwbGF0Zm9y bV9vZl9tYXRjaFtdCj4+ID0gewo+PiAgICAgICAgIH0sIHsKPj4gICAgICAgICAgICAgICAgIC5j b21wYXRpYmxlID0gImF2aWMsdG0wNzBkZGgwMyIsCj4+ICAgICAgICAgICAgICAgICAuZGF0YSA9 ICZhdmljX3RtMDcwZGRoMDMsCj4+ICsgICAgICAgfSwgewo+PiArICAgICAgICAgICAgICAgLmNv bXBhdGlibGUgPSAiYmFuYW5hcGksczA3MHd2MjAtY3QxNiIsCj4+ICsgICAgICAgICAgICAgICAu ZGF0YSA9ICZiYW5hbmFwaV9zMDcwd3YyMF9jdDE2LAo+PiAgICAgICAgIH0sIHsKPj4gICAgICAg ICAgICAgICAgIC5jb21wYXRpYmxlID0gImJvZSxudjEwMXd4bW41MSIsCj4+ICAgICAgICAgICAg ICAgICAuZGF0YSA9ICZib2VfbnYxMDF3eG1uNTEsCj4+Cj4KPgo+Cl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJp LWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: wens@csie.org (Chen-Yu Tsai) Date: Thu, 19 Apr 2018 20:45:14 +0800 Subject: [PATCH 4/6] drm/panel: simple: Add support for Banana Pi 7" S070WV20-CT16 panel In-Reply-To: <58ce9e3b-00ee-87d2-f05b-b9f1414d1cfa@micronovasrl.com> References: <20180419093225.614-1-wens@csie.org> <20180419093225.614-5-wens@csie.org> <58ce9e3b-00ee-87d2-f05b-b9f1414d1cfa@micronovasrl.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, Apr 19, 2018 at 8:31 PM, Giulio Benetti wrote: > Hi, > > Il 19/04/2018 11:32, Chen-Yu Tsai ha scritto: >> >> This panel is marketed as Banana Pi 7" LCD display. On the back is >> a sticker denoting the model name S070WV20-CT16. > > > Judging from the code, the real vendor should be CDTech. > Take a look at their website: > http://www.cdtech-lcd.com/en/standardscreen.html > > I point you my patch for inserting another similar panel: > https://patchwork.freedesktop.org/patch/211914/ > > Maybe it would make sense to use CDTech as the vendor, > because maybe Bananapi resells only it. > Or maybe it is a custom panel done for them, > but the same is for other panels I've submitted patches. > Micronova srl custom, but vendor is CDTech. > > What do you think? That might be true. But for people without access to the vendors, this is horribly hard to figure out. People are only going to look at whatever marking there is on the LCD panel, and whatever the seller says. This panel has the model number stickered on, but the PCB attached to it only has the Banana Pi logo. And given it's a custom piece, probably OEM or ODM, the real manufacturer matters less. You don't mention "Foxconn" as the vendor of the iPhone, do you? ChenYu > > -- > Giulio Benetti > CTO > > MICRONOVA SRL > Sede: Via A. Niedda 3 - 35010 Vigonza (PD) > Tel. 049/8931563 - Fax 049/8931346 > Cod.Fiscale - P.IVA 02663420285 > Capitale Sociale ? 26.000 i.v. > Iscritta al Reg. Imprese di Padova N. 02663420285 > Numero R.E.A. 258642 > > >> >> This is a 7" 800x480 panel connected through a 24-bit RGB interface. >> However the panel only does 262k colors. >> >> Signed-off-by: Chen-Yu Tsai >> --- >> .../display/panel/bananapi,s070wv20-ct16.txt | 7 ++++++ >> drivers/gpu/drm/panel/panel-simple.c | 25 +++++++++++++++++++ >> 2 files changed, 32 insertions(+) >> create mode 100644 >> Documentation/devicetree/bindings/display/panel/bananapi,s070wv20-ct16.txt >> >> diff --git >> a/Documentation/devicetree/bindings/display/panel/bananapi,s070wv20-ct16.txt >> b/Documentation/devicetree/bindings/display/panel/bananapi,s070wv20-ct16.txt >> new file mode 100644 >> index 000000000000..2ec35ce36e9a >> --- /dev/null >> +++ >> b/Documentation/devicetree/bindings/display/panel/bananapi,s070wv20-ct16.txt >> @@ -0,0 +1,7 @@ >> +Banana Pi 7" (S070WV20-CT16) TFT LCD Panel >> + >> +Required properties: >> +- compatible: should be "bananapi,s070wv20-ct16" >> + >> +This binding is compatible with the simple-panel binding, which is >> specified >> +in simple-panel.txt in this directory. >> diff --git a/drivers/gpu/drm/panel/panel-simple.c >> b/drivers/gpu/drm/panel/panel-simple.c >> index cbf1ab404ee7..9bc037f74d6c 100644 >> --- a/drivers/gpu/drm/panel/panel-simple.c >> +++ b/drivers/gpu/drm/panel/panel-simple.c >> @@ -745,6 +745,28 @@ static const struct panel_desc avic_tm070ddh03 = { >> }, >> }; >> +static const struct drm_display_mode bananapi_s070wv20_ct16_mode = { >> + .clock = 30000, >> + .hdisplay = 800, >> + .hsync_start = 800 + 40, >> + .hsync_end = 800 + 40 + 48, >> + .htotal = 800 + 40 + 48 + 40, >> + .vdisplay = 480, >> + .vsync_start = 480 + 13, >> + .vsync_end = 480 + 13 + 3, >> + .vtotal = 480 + 13 + 3 + 29, >> +}; >> + >> +static const struct panel_desc bananapi_s070wv20_ct16 = { >> + .modes = &bananapi_s070wv20_ct16_mode, >> + .num_modes = 1, >> + .bpc = 6, >> + .size = { >> + .width = 154, >> + .height = 86, >> + }, >> +}; >> + >> static const struct drm_display_mode boe_nv101wxmn51_modes[] = { >> { >> .clock = 71900, >> @@ -2112,6 +2134,9 @@ static const struct of_device_id platform_of_match[] >> = { >> }, { >> .compatible = "avic,tm070ddh03", >> .data = &avic_tm070ddh03, >> + }, { >> + .compatible = "bananapi,s070wv20-ct16", >> + .data = &bananapi_s070wv20_ct16, >> }, { >> .compatible = "boe,nv101wxmn51", >> .data = &boe_nv101wxmn51, >> > > >