From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932597AbdEDDYI (ORCPT ); Wed, 3 May 2017 23:24:08 -0400 Received: from smtp.csie.ntu.edu.tw ([140.112.30.61]:35880 "EHLO smtp.csie.ntu.edu.tw" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932550AbdEDDYA (ORCPT ); Wed, 3 May 2017 23:24:00 -0400 MIME-Version: 1.0 In-Reply-To: <27fcae13e64ef86d32001478f1923e9a02deb7b8.1493812478.git-series.maxime.ripard@free-electrons.com> References: <27fcae13e64ef86d32001478f1923e9a02deb7b8.1493812478.git-series.maxime.ripard@free-electrons.com> From: Chen-Yu Tsai Date: Thu, 4 May 2017 11:23:36 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 4/20] clk: sunxi-ng: mux: Don't just rely on the parent for CLK_SET_RATE_PARENT To: Maxime Ripard Cc: Mike Turquette , Stephen Boyd , Chen-Yu Tsai , Daniel Vetter , David Airlie , dri-devel , Mark Rutland , Rob Herring , devicetree , linux-arm-kernel , linux-clk , linux-kernel , linux-sunxi Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 3, 2017 at 7:59 PM, Maxime Ripard wrote: > The current code only rely on the parent to change its rate in the case > where CLK_SET_RATE_PARENT is set. > > However, some clock rates might be obtained only through a modification of > the parent and the clock divider. Just rely on the round rate of the clocks > to give us the best computation that might be achieved for a given rate. > > round_rate functions now need to honor CLK_SET_RATE_PARENT, but either the > functions already do that if they modify the parent, or don't modify the > praents at all. > > Signed-off-by: Maxime Ripard Acked-by: Chen-Yu Tsai From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chen-Yu Tsai Subject: Re: [PATCH v2 4/20] clk: sunxi-ng: mux: Don't just rely on the parent for CLK_SET_RATE_PARENT Date: Thu, 4 May 2017 11:23:36 +0800 Message-ID: References: <27fcae13e64ef86d32001478f1923e9a02deb7b8.1493812478.git-series.maxime.ripard@free-electrons.com> Reply-To: wens-jdAy2FN1RRM@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: Sender: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org In-Reply-To: <27fcae13e64ef86d32001478f1923e9a02deb7b8.1493812478.git-series.maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Maxime Ripard Cc: Mike Turquette , Stephen Boyd , Chen-Yu Tsai , Daniel Vetter , David Airlie , dri-devel , Mark Rutland , Rob Herring , devicetree , linux-arm-kernel , linux-clk , linux-kernel , linux-sunxi List-Id: devicetree@vger.kernel.org On Wed, May 3, 2017 at 7:59 PM, Maxime Ripard wrote: > The current code only rely on the parent to change its rate in the case > where CLK_SET_RATE_PARENT is set. > > However, some clock rates might be obtained only through a modification of > the parent and the clock divider. Just rely on the round rate of the clocks > to give us the best computation that might be achieved for a given rate. > > round_rate functions now need to honor CLK_SET_RATE_PARENT, but either the > functions already do that if they modify the parent, or don't modify the > praents at all. > > Signed-off-by: Maxime Ripard Acked-by: Chen-Yu Tsai From mboxrd@z Thu Jan 1 00:00:00 1970 From: wens@csie.org (Chen-Yu Tsai) Date: Thu, 4 May 2017 11:23:36 +0800 Subject: [PATCH v2 4/20] clk: sunxi-ng: mux: Don't just rely on the parent for CLK_SET_RATE_PARENT In-Reply-To: <27fcae13e64ef86d32001478f1923e9a02deb7b8.1493812478.git-series.maxime.ripard@free-electrons.com> References: <27fcae13e64ef86d32001478f1923e9a02deb7b8.1493812478.git-series.maxime.ripard@free-electrons.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, May 3, 2017 at 7:59 PM, Maxime Ripard wrote: > The current code only rely on the parent to change its rate in the case > where CLK_SET_RATE_PARENT is set. > > However, some clock rates might be obtained only through a modification of > the parent and the clock divider. Just rely on the round rate of the clocks > to give us the best computation that might be achieved for a given rate. > > round_rate functions now need to honor CLK_SET_RATE_PARENT, but either the > functions already do that if they modify the parent, or don't modify the > praents at all. > > Signed-off-by: Maxime Ripard Acked-by: Chen-Yu Tsai