From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5DE4DC6778A for ; Sat, 30 Jun 2018 01:10:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 20C2927365 for ; Sat, 30 Jun 2018 01:10:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 20C2927365 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=csie.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936726AbeF3BK1 convert rfc822-to-8bit (ORCPT ); Fri, 29 Jun 2018 21:10:27 -0400 Received: from mail-ed1-f67.google.com ([209.85.208.67]:38140 "EHLO mail-ed1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933615AbeF3BKW (ORCPT ); Fri, 29 Jun 2018 21:10:22 -0400 Received: by mail-ed1-f67.google.com with SMTP id a5-v6so8169482edt.5; Fri, 29 Jun 2018 18:10:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=B851uiW137F+Ir2WRxenTuEtm5kPvpqwRv9uzBn+S4A=; b=cB1n3BsGQOLk+2bmfaK00SdQORrKaQUSf/62/xLI46IDbiwhlxf1kViVlZx+mh1YTX hZlc3XePSg4eSCGgt8UImocyY9y92zyNVsXwm3SZ1jOYzx6iaUH+TpqlnkUMflzsFp5V DdP5wuY0M2xwKYUIzWGur2NKToVfxQS3wUNDFPJSHAe86BdqAebzbBC19swBtGET96kR Ez8Yy7S19nq55vwntE5TsShJZ48XbMafPoL5E98YxONRPHXy79lgunSyKOKJYdDfGXAF E8v7hPqVYouynspz7gpdkRlxdexWoc7uUo0wIAfq7qe2L14UUhr1DgPqIGCcweylCBlf lYFQ== X-Gm-Message-State: APt69E0Aj85P+vb89EctuBScC8Hbs6sQyW6L/BbnI5WKUU+aJbGPzEHr zXco1PJn036IHOgTKcRPZp0tGD/Y X-Google-Smtp-Source: AAOMgpeKtrYfsbGjKMBfdr2sjoR7LDcWh6Y5MrzCgAkQ/lr27FOc2hc/7oLSMF1u5yi4UspeGvK1ow== X-Received: by 2002:a50:e615:: with SMTP id y21-v6mr14846299edm.278.1530321021103; Fri, 29 Jun 2018 18:10:21 -0700 (PDT) Received: from mail-wm0-f41.google.com (mail-wm0-f41.google.com. [74.125.82.41]) by smtp.gmail.com with ESMTPSA id t3-v6sm4438893edq.50.2018.06.29.18.10.18 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 29 Jun 2018 18:10:19 -0700 (PDT) Received: by mail-wm0-f41.google.com with SMTP id v25-v6so2800429wmc.0; Fri, 29 Jun 2018 18:10:18 -0700 (PDT) X-Received: by 2002:a1c:6fdd:: with SMTP id c90-v6mr446798wmi.16.1530321018190; Fri, 29 Jun 2018 18:10:18 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:adf:a15a:0:0:0:0:0 with HTTP; Fri, 29 Jun 2018 18:09:57 -0700 (PDT) In-Reply-To: <3837144.KdEe8HRubn@jernej-laptop> References: <20180625120304.7543-1-jernej.skrabec@siol.net> <20180625120304.7543-7-jernej.skrabec@siol.net> <3837144.KdEe8HRubn@jernej-laptop> From: Chen-Yu Tsai Date: Sat, 30 Jun 2018 09:09:57 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [linux-sunxi] [PATCH v3 06/24] drm/sun4i: Fix releasing node when enumerating enpoints To: =?UTF-8?Q?Jernej_=C5=A0krabec?= Cc: Maxime Ripard , Rob Herring , David Airlie , Gustavo Padovan , Maarten Lankhorst , Sean Paul , Mark Rutland , dri-devel , devicetree , linux-arm-kernel , linux-kernel , linux-clk , linux-sunxi Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jun 30, 2018 at 3:15 AM, Jernej Škrabec wrote: > Dne četrtek, 28. junij 2018 ob 03:53:36 CEST je Chen-Yu Tsai napisal(a): >> On Mon, Jun 25, 2018 at 8:02 PM, Jernej Skrabec > wrote: >> > sun4i_drv_add_endpoints() has a memory leak since it uses of_node_put() >> > when remote is equal to NULL and does nothing when remote has a valid >> > pointer. >> > >> > Invert the logic to fix memory leak. >> > >> > Signed-off-by: Jernej Skrabec >> >> Given this is a fix, it should have Fixes and stable tags. > > How should be this handled given that the patch is already merged and cannot > be dropped? We can't. We'll have to manually submit it for stable once this lands in Linus' tree. ChenYu From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chen-Yu Tsai Subject: Re: [PATCH v3 06/24] drm/sun4i: Fix releasing node when enumerating enpoints Date: Sat, 30 Jun 2018 09:09:57 +0800 Message-ID: References: <20180625120304.7543-1-jernej.skrabec@siol.net> <20180625120304.7543-7-jernej.skrabec@siol.net> <3837144.KdEe8HRubn@jernej-laptop> Reply-To: wens-jdAy2FN1RRM@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Return-path: Sender: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org In-Reply-To: <3837144.KdEe8HRubn@jernej-laptop> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: =?UTF-8?Q?Jernej_=C5=A0krabec?= Cc: Maxime Ripard , Rob Herring , David Airlie , Gustavo Padovan , Maarten Lankhorst , Sean Paul , Mark Rutland , dri-devel , devicetree , linux-arm-kernel , linux-kernel , linux-clk , linux-sunxi List-Id: devicetree@vger.kernel.org On Sat, Jun 30, 2018 at 3:15 AM, Jernej =C5=A0krabec wrote: > Dne =C4=8Detrtek, 28. junij 2018 ob 03:53:36 CEST je Chen-Yu Tsai napisal= (a): >> On Mon, Jun 25, 2018 at 8:02 PM, Jernej Skrabec > wrote: >> > sun4i_drv_add_endpoints() has a memory leak since it uses of_node_put(= ) >> > when remote is equal to NULL and does nothing when remote has a valid >> > pointer. >> > >> > Invert the logic to fix memory leak. >> > >> > Signed-off-by: Jernej Skrabec >> >> Given this is a fix, it should have Fixes and stable tags. > > How should be this handled given that the patch is already merged and can= not > be dropped? We can't. We'll have to manually submit it for stable once this lands in Linus' tree. ChenYu --=20 You received this message because you are subscribed to the Google Groups "= linux-sunxi" group. To unsubscribe from this group and stop receiving emails from it, send an e= mail to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org For more options, visit https://groups.google.com/d/optout. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: MIME-Version: 1.0 In-Reply-To: <3837144.KdEe8HRubn@jernej-laptop> References: <20180625120304.7543-1-jernej.skrabec@siol.net> <20180625120304.7543-7-jernej.skrabec@siol.net> <3837144.KdEe8HRubn@jernej-laptop> From: Chen-Yu Tsai Date: Sat, 30 Jun 2018 09:09:57 +0800 Message-ID: Subject: Re: [linux-sunxi] [PATCH v3 06/24] drm/sun4i: Fix releasing node when enumerating enpoints To: =?UTF-8?Q?Jernej_=C5=A0krabec?= List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree , Maxime Ripard , Gustavo Padovan , Maarten Lankhorst , linux-kernel , dri-devel , David Airlie , linux-sunxi , Rob Herring , Sean Paul , linux-clk , linux-arm-kernel Content-Type: text/plain; charset="utf-8" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+mturquette=baylibre.com@lists.infradead.org List-ID: T24gU2F0LCBKdW4gMzAsIDIwMTggYXQgMzoxNSBBTSwgSmVybmVqIMWga3JhYmVjIDxqZXJuZWou c2tyYWJlY0BzaW9sLm5ldD4gd3JvdGU6Cj4gRG5lIMSNZXRydGVrLCAyOC4ganVuaWogMjAxOCBv YiAwMzo1MzozNiBDRVNUIGplIENoZW4tWXUgVHNhaSBuYXBpc2FsKGEpOgo+PiBPbiBNb24sIEp1 biAyNSwgMjAxOCBhdCA4OjAyIFBNLCBKZXJuZWogU2tyYWJlYyA8amVybmVqLnNrcmFiZWNAc2lv bC5uZXQ+Cj4gd3JvdGU6Cj4+ID4gc3VuNGlfZHJ2X2FkZF9lbmRwb2ludHMoKSBoYXMgYSBtZW1v cnkgbGVhayBzaW5jZSBpdCB1c2VzIG9mX25vZGVfcHV0KCkKPj4gPiB3aGVuIHJlbW90ZSBpcyBl cXVhbCB0byBOVUxMIGFuZCBkb2VzIG5vdGhpbmcgd2hlbiByZW1vdGUgaGFzIGEgdmFsaWQKPj4g PiBwb2ludGVyLgo+PiA+Cj4+ID4gSW52ZXJ0IHRoZSBsb2dpYyB0byBmaXggbWVtb3J5IGxlYWsu Cj4+ID4KPj4gPiBTaWduZWQtb2ZmLWJ5OiBKZXJuZWogU2tyYWJlYyA8amVybmVqLnNrcmFiZWNA c2lvbC5uZXQ+Cj4+Cj4+IEdpdmVuIHRoaXMgaXMgYSBmaXgsIGl0IHNob3VsZCBoYXZlIEZpeGVz IGFuZCBzdGFibGUgdGFncy4KPgo+IEhvdyBzaG91bGQgYmUgdGhpcyBoYW5kbGVkIGdpdmVuIHRo YXQgdGhlIHBhdGNoIGlzIGFscmVhZHkgbWVyZ2VkIGFuZCBjYW5ub3QKPiBiZSBkcm9wcGVkPwoK V2UgY2FuJ3QuIFdlJ2xsIGhhdmUgdG8gbWFudWFsbHkgc3VibWl0IGl0IGZvciBzdGFibGUgb25j ZSB0aGlzIGxhbmRzCmluIExpbnVzJyB0cmVlLgoKQ2hlbll1CgpfX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlz dApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJh ZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: wens@csie.org (Chen-Yu Tsai) Date: Sat, 30 Jun 2018 09:09:57 +0800 Subject: [linux-sunxi] [PATCH v3 06/24] drm/sun4i: Fix releasing node when enumerating enpoints In-Reply-To: <3837144.KdEe8HRubn@jernej-laptop> References: <20180625120304.7543-1-jernej.skrabec@siol.net> <20180625120304.7543-7-jernej.skrabec@siol.net> <3837144.KdEe8HRubn@jernej-laptop> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Sat, Jun 30, 2018 at 3:15 AM, Jernej ?krabec wrote: > Dne ?etrtek, 28. junij 2018 ob 03:53:36 CEST je Chen-Yu Tsai napisal(a): >> On Mon, Jun 25, 2018 at 8:02 PM, Jernej Skrabec > wrote: >> > sun4i_drv_add_endpoints() has a memory leak since it uses of_node_put() >> > when remote is equal to NULL and does nothing when remote has a valid >> > pointer. >> > >> > Invert the logic to fix memory leak. >> > >> > Signed-off-by: Jernej Skrabec >> >> Given this is a fix, it should have Fixes and stable tags. > > How should be this handled given that the patch is already merged and cannot > be dropped? We can't. We'll have to manually submit it for stable once this lands in Linus' tree. ChenYu