From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 451C5C433E6 for ; Mon, 18 Jan 2021 16:00:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1BA9D22C9C for ; Mon, 18 Jan 2021 16:00:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2406189AbhARQAS (ORCPT ); Mon, 18 Jan 2021 11:00:18 -0500 Received: from mail-lf1-f50.google.com ([209.85.167.50]:44019 "EHLO mail-lf1-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2406153AbhARP4Z (ORCPT ); Mon, 18 Jan 2021 10:56:25 -0500 Received: by mail-lf1-f50.google.com with SMTP id 23so24726357lfg.10 for ; Mon, 18 Jan 2021 07:56:07 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=3eG9WjyYerA7IMe+nqJfGvwMRUcLVhIdRjzA7l646S4=; b=gEebQfc77IYFzAn+yjOUV4cwGMvzz5WwkZzxhPzpP7PB0ezIUYZQMGFwgukkAXOr2K FXb3fLxQv61Y8+jYalI3H3YTaBIIcQxNrdYg1iw+npYFqKe/57kBMgFHE2oP7N90sA7v pPdm64lk/Yv6+iX03U6T9cPM4F030hZmc67q8vDat0cFfSYTCnfBRzFuciR9rAD76Ak3 fdPSojEbKowzwsd8wAuAKGvcHiJHmJ5Yo2PSBLxSwIlUOgtlbcqfv31adj9Jrzb1Ruat JpvqcmcnZ9aWKvu+exK98jdDHoML3nmI8V8Gjqwrry9xtXqXvNuhYXOosTkL8ObK7rfL CT/g== X-Gm-Message-State: AOAM533lrbJkC8BpmW0Udz5aI/EvE9D/4qw7wZ4UWsZMpVdOY1tTjkjV fSyOWlrpNL9lK/EvE9OK9pLZIuapba9Ckw== X-Google-Smtp-Source: ABdhPJzZyaeRNj8YaKcr7UKTODBoworH6UaDS3QljD3RnSIEcI7S4JRgMacjDcXezXFVCUMKrvAm5A== X-Received: by 2002:ac2:544d:: with SMTP id d13mr11158947lfn.397.1610985342052; Mon, 18 Jan 2021 07:55:42 -0800 (PST) Received: from mail-lf1-f43.google.com (mail-lf1-f43.google.com. [209.85.167.43]) by smtp.gmail.com with ESMTPSA id j26sm1935828lfh.251.2021.01.18.07.55.41 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 Jan 2021 07:55:41 -0800 (PST) Received: by mail-lf1-f43.google.com with SMTP id o13so24783789lfr.3 for ; Mon, 18 Jan 2021 07:55:41 -0800 (PST) X-Received: by 2002:a19:810:: with SMTP id 16mr11942847lfi.233.1610985341262; Mon, 18 Jan 2021 07:55:41 -0800 (PST) MIME-Version: 1.0 References: <20210118020848.11721-1-andre.przywara@arm.com> <20210118020848.11721-3-andre.przywara@arm.com> <20210118132854.yiwn7rnvcyexgqim@gilmour> <20210118155228.3bd0e909@slackpad.fritz.box> In-Reply-To: <20210118155228.3bd0e909@slackpad.fritz.box> From: Chen-Yu Tsai Date: Mon, 18 Jan 2021 23:55:29 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [linux-sunxi] Re: [PATCH v3 02/21] mmc: sunxi: add support for A100 mmc controller To: =?UTF-8?Q?Andr=C3=A9_Przywara?= Cc: Maxime Ripard , Jernej Skrabec , Icenowy Zheng , Linus Walleij , Rob Herring , =?UTF-8?B?Q2zDqW1lbnQgUMOpcm9u?= , Samuel Holland , Shuosheng Huang , Yangtao Li , linux-arm-kernel , linux-kernel , linux-sunxi , Ulf Hansson Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 18, 2021 at 11:53 PM Andre Przywara wrote: > > On Mon, 18 Jan 2021 14:28:54 +0100 > Maxime Ripard wrote: > > Hi Maxime, > > > On Mon, Jan 18, 2021 at 02:08:29AM +0000, Andre Przywara wrote: > > > From: Yangtao Li > > > > > > This patch adds support for A100 MMC controller, which use word > > > address for internal dma. > > > > > > Signed-off-by: Yangtao Li > > > Signed-off-by: Andre Przywara > > > > We should also disable the timings setup in probe to derive them from > > the DT. This is causing issues on some SoCs already, so it would be > > best to not make the situation worse > > But only for those new SoCs, where we have the speed modes in the DT > in every case (so only new ones)? And this disabling would be > SoC/compatible string dependent? Happy to send a patch later if that is > what you were thinking about. > > Also I was wondering about the voltage dependent speed modes: At the > moment the driver declares both MMC_CAP_1_8V_DDR and MMC_CAP_3_3V_DDR, > so I mimic this in the .dtsi. However in the eventual DTB this looks > somewhat dodgy, since most boards only support one of those voltages. Do > we ignore this, and rely on the vqmmc-supply to limit this choice? IIRC the DDR flags for separate voltages was added after we (I) added MMC DDR support to our driver. And yes, the core also checks vqmmc-supply before actually selecting the mode. ChenYu > Cheers, > Andre > > Btw: This patch is already in Ulf's -next tree, I just included it here > for the sake of completeness. Is that a problem? I don't think it > affects the build, so we don't care too much? > > -- > You received this message because you are subscribed to the Google Groups "linux-sunxi" group. > To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe@googlegroups.com. > To view this discussion on the web, visit https://groups.google.com/d/msgid/linux-sunxi/20210118155228.3bd0e909%40slackpad.fritz.box. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80596C433DB for ; Mon, 18 Jan 2021 15:57:05 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3CF5122472 for ; Mon, 18 Jan 2021 15:57:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3CF5122472 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=csie.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=GDbeTOUcPRz7gHziDVr8bUj9hkGPwKysZ4MHGoAo13g=; b=vg4l/hHMrPRT1E/4SDgm3nA1R PujEoa+uXiLophkuFID0DtoWaynehnd0p2I8RcUHttWn8gTF27VY45g1rztGcueePhzwJ6MRGXbUk vmft9vsMtj9/5V6ieevDQf6M0yFo6UbUKdGs3ygF0JntM3Apb+7k5eeRdjejoiCvkgMqQUL40NNyE 08rNm38fzUIQoS/hupt1alAcG1kL37x5nYhgJyaubfCRWShozotSVsWbnpzmlj9k+3vXInZ2ZsUO4 6v+RvHMKkMw2IMFvl8FjiT702Z9n0OKQ3CjvKvydxxZJzudHajBJCdA9xrzl+ZHlPLNny93CMLd26 rx4yjrU7g==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l1Wse-0000xo-ET; Mon, 18 Jan 2021 15:55:48 +0000 Received: from mail-lf1-f45.google.com ([209.85.167.45]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l1Wsa-0000vt-EW for linux-arm-kernel@lists.infradead.org; Mon, 18 Jan 2021 15:55:45 +0000 Received: by mail-lf1-f45.google.com with SMTP id s26so24722860lfc.8 for ; Mon, 18 Jan 2021 07:55:43 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=3eG9WjyYerA7IMe+nqJfGvwMRUcLVhIdRjzA7l646S4=; b=GjQkn5ltGUi4wkpt/HUu4UbpGqoagbXl8s8xuzzYUKle8LAejA49NyDCkvI9PfTVQQ bOj4A16FWnBnONkYnc4zMPyL/gbFplaBMaeXItSjRgoHEP+k2B5n2Ws4vE+m6qlbttc0 UJYX6KlsUqkDltTI60uNvTcNZvXCG0144XW7a8gO3XbJMPEEcI7K7ADa1+Od2Lm6zfHV hSYhHOA73uizwZCDQJQVBUzJ5ZEFdD4wAxcdGRe148BldbZlpPY6oVGaaOD+ElLkXvs6 guQQETBmxEYI3M5nB88MZ5UvpX/XWaEJzi+4mZlQzz0MHP4lCTgOJMVaEvi4Mr4K0T7o X7Zg== X-Gm-Message-State: AOAM531NR+zdNQVyCcxw4M5pBebSgAXYkzAl5qVcb8vuIuum4Hqh0q1u HQ5gwpGnjB+PR9K2fhC52vC/lcIf7iPWiQ== X-Google-Smtp-Source: ABdhPJxBsFbZtpHjWNE8WrN2FSXpD/MAgF9P8d0IiP/4znny95Rmjp2q2+Dtv7+VJGXTJxbghMdKrg== X-Received: by 2002:a19:644b:: with SMTP id b11mr11387860lfj.358.1610985342368; Mon, 18 Jan 2021 07:55:42 -0800 (PST) Received: from mail-lf1-f46.google.com (mail-lf1-f46.google.com. [209.85.167.46]) by smtp.gmail.com with ESMTPSA id l3sm1932472lfd.119.2021.01.18.07.55.41 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 Jan 2021 07:55:41 -0800 (PST) Received: by mail-lf1-f46.google.com with SMTP id h205so24719775lfd.5 for ; Mon, 18 Jan 2021 07:55:41 -0800 (PST) X-Received: by 2002:a19:810:: with SMTP id 16mr11942847lfi.233.1610985341262; Mon, 18 Jan 2021 07:55:41 -0800 (PST) MIME-Version: 1.0 References: <20210118020848.11721-1-andre.przywara@arm.com> <20210118020848.11721-3-andre.przywara@arm.com> <20210118132854.yiwn7rnvcyexgqim@gilmour> <20210118155228.3bd0e909@slackpad.fritz.box> In-Reply-To: <20210118155228.3bd0e909@slackpad.fritz.box> From: Chen-Yu Tsai Date: Mon, 18 Jan 2021 23:55:29 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [linux-sunxi] Re: [PATCH v3 02/21] mmc: sunxi: add support for A100 mmc controller To: =?UTF-8?Q?Andr=C3=A9_Przywara?= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210118_105544_508785_58BFBC9D X-CRM114-Status: GOOD ( 29.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jernej Skrabec , Samuel Holland , Yangtao Li , Linus Walleij , linux-kernel , linux-sunxi , =?UTF-8?B?Q2zDqW1lbnQgUMOpcm9u?= , Maxime Ripard , Shuosheng Huang , Ulf Hansson , linux-arm-kernel , Icenowy Zheng Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jan 18, 2021 at 11:53 PM Andre Przywara wrote: > > On Mon, 18 Jan 2021 14:28:54 +0100 > Maxime Ripard wrote: > > Hi Maxime, > > > On Mon, Jan 18, 2021 at 02:08:29AM +0000, Andre Przywara wrote: > > > From: Yangtao Li > > > > > > This patch adds support for A100 MMC controller, which use word > > > address for internal dma. > > > > > > Signed-off-by: Yangtao Li > > > Signed-off-by: Andre Przywara > > > > We should also disable the timings setup in probe to derive them from > > the DT. This is causing issues on some SoCs already, so it would be > > best to not make the situation worse > > But only for those new SoCs, where we have the speed modes in the DT > in every case (so only new ones)? And this disabling would be > SoC/compatible string dependent? Happy to send a patch later if that is > what you were thinking about. > > Also I was wondering about the voltage dependent speed modes: At the > moment the driver declares both MMC_CAP_1_8V_DDR and MMC_CAP_3_3V_DDR, > so I mimic this in the .dtsi. However in the eventual DTB this looks > somewhat dodgy, since most boards only support one of those voltages. Do > we ignore this, and rely on the vqmmc-supply to limit this choice? IIRC the DDR flags for separate voltages was added after we (I) added MMC DDR support to our driver. And yes, the core also checks vqmmc-supply before actually selecting the mode. ChenYu > Cheers, > Andre > > Btw: This patch is already in Ulf's -next tree, I just included it here > for the sake of completeness. Is that a problem? I don't think it > affects the build, so we don't care too much? > > -- > You received this message because you are subscribed to the Google Groups "linux-sunxi" group. > To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe@googlegroups.com. > To view this discussion on the web, visit https://groups.google.com/d/msgid/linux-sunxi/20210118155228.3bd0e909%40slackpad.fritz.box. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel