From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f175.google.com (mail-lj1-f175.google.com [209.85.208.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0BA8D3FCD for ; Wed, 1 Sep 2021 13:55:06 +0000 (UTC) Received: by mail-lj1-f175.google.com with SMTP id i28so5088506ljm.7 for ; Wed, 01 Sep 2021 06:55:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:reply-to :from:date:message-id:subject:to:cc; bh=1qbLir7t00tIXtsSOowis8wzBunbda5Sb7xAud87L5k=; b=uG/5F+o1v8/SIUcCtTARgam4bmRy8nw+0FXW+/SosC09XjMMhDoazsa7gvTxhU1nGi +rAfhvJdQA0iAw0a0Caz2lgIuqkbjQjPUpUlVmLLtEBU5sPlmAQCbT48H0zQvOiJgF2h Ev1yOTyf5fceZRGRBSL76irx+fidnYynkX+4WT6SPyMxvst0jM3lrU3Hp2m5Vy0hjQgS Lzvar/YfL7m7b7Erljbwhg/8COG5AQZdB4lJqytdgTv1nwWruCCTtHzPkcSRLN8KMkzm NP+jiiPNMEalhDwsVrFR6v/51Rkx1o/kJGjaYF6T0HKw+tRo7n9YSu+R7VAcJYaNAcBx rNyA== X-Gm-Message-State: AOAM530o6A5mtAixDA9LyROlemcHXVmjOJaOgkyy7OBg8qdS4PYcLZQY 8UPTXa1W9J1lu5Ne3DME7ZmEMRhemZS+GA== X-Google-Smtp-Source: ABdhPJw0X7MBea4lea9mlZ9geMKJem/jY2Qx9DUqDxrR0UBYHh8eMgQMbx8fbgWSL+tm7qhDrgtVRg== X-Received: by 2002:a2e:8e8f:: with SMTP id z15mr29024841ljk.121.1630504505001; Wed, 01 Sep 2021 06:55:05 -0700 (PDT) Received: from mail-lf1-f50.google.com (mail-lf1-f50.google.com. [209.85.167.50]) by smtp.gmail.com with ESMTPSA id w16sm1007565lfn.83.2021.09.01.06.55.03 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Sep 2021 06:55:04 -0700 (PDT) Received: by mail-lf1-f50.google.com with SMTP id k13so6625049lfv.2 for ; Wed, 01 Sep 2021 06:55:03 -0700 (PDT) X-Received: by 2002:a05:6512:3f89:: with SMTP id x9mr26306205lfa.233.1630504503566; Wed, 01 Sep 2021 06:55:03 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20210901050526.45673-1-samuel@sholland.org> <20210901050526.45673-6-samuel@sholland.org> In-Reply-To: <20210901050526.45673-6-samuel@sholland.org> Reply-To: wens@csie.org From: Chen-Yu Tsai Date: Wed, 1 Sep 2021 21:54:52 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 5/8] clk: sunxi-ng: Export symbols used by CCU drivers To: Samuel Holland Cc: Maxime Ripard , Jernej Skrabec , Michael Turquette , Stephen Boyd , linux-arm-kernel , linux-clk , linux-sunxi@lists.linux.dev, linux-kernel Content-Type: text/plain; charset="UTF-8" On Wed, Sep 1, 2021 at 1:05 PM Samuel Holland wrote: > > For the individual drivers to be built as modules, the ops structs and > callback registration functions must be exported. None of the helper > functions are exported, because they are only referenced from the > corresponding ops structs. of_sunxi_ccu_probe is not exported, because > it is only used for built-in early OF clock providers. > > Signed-off-by: Samuel Holland > --- > drivers/clk/sunxi-ng/ccu_common.c | 2 ++ > drivers/clk/sunxi-ng/ccu_div.c | 1 + > drivers/clk/sunxi-ng/ccu_gate.c | 1 + > drivers/clk/sunxi-ng/ccu_mp.c | 2 ++ > drivers/clk/sunxi-ng/ccu_mult.c | 1 + > drivers/clk/sunxi-ng/ccu_mux.c | 2 ++ > drivers/clk/sunxi-ng/ccu_nk.c | 1 + > drivers/clk/sunxi-ng/ccu_nkm.c | 1 + > drivers/clk/sunxi-ng/ccu_nkmp.c | 1 + > drivers/clk/sunxi-ng/ccu_nm.c | 1 + > drivers/clk/sunxi-ng/ccu_phase.c | 1 + > drivers/clk/sunxi-ng/ccu_reset.c | 1 + > 12 files changed, 15 insertions(+) > > diff --git a/drivers/clk/sunxi-ng/ccu_common.c b/drivers/clk/sunxi-ng/ccu_common.c > index 31af8b6b5286..3ab109582646 100644 > --- a/drivers/clk/sunxi-ng/ccu_common.c > +++ b/drivers/clk/sunxi-ng/ccu_common.c > @@ -83,6 +83,7 @@ int ccu_pll_notifier_register(struct ccu_pll_nb *pll_nb) > return clk_notifier_register(pll_nb->common->hw.clk, > &pll_nb->clk_nb); > } > +EXPORT_SYMBOL_GPL(ccu_pll_notifier_register); These symbol names aren't exactly specific to sunxi. Maybe we could apply symbol namespaces? ChenYu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F39C8C4320A for ; Wed, 1 Sep 2021 13:55:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CC73861053 for ; Wed, 1 Sep 2021 13:55:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244550AbhIAN4D (ORCPT ); Wed, 1 Sep 2021 09:56:03 -0400 Received: from mail-lf1-f45.google.com ([209.85.167.45]:42917 "EHLO mail-lf1-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229975AbhIAN4C (ORCPT ); Wed, 1 Sep 2021 09:56:02 -0400 Received: by mail-lf1-f45.google.com with SMTP id j4so6540460lfg.9; Wed, 01 Sep 2021 06:55:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:reply-to :from:date:message-id:subject:to:cc; bh=1qbLir7t00tIXtsSOowis8wzBunbda5Sb7xAud87L5k=; b=QJHFdFwOKDQb5JBqkff1XErqaxiXi7zRXZttRrX/7OAvy0XYZ2LAucXOd5lgdLY/w1 8rBqS6EVcmCe6bZaKZHoB5EoGydpr/IRejrfovqIb5KfBYJOtnV2YrpJd+mkif2HoE/t 2fV9su+Qgl4t3PxYYzKEHszG7SIvHxLU/utUkrRnaadWjzzXjcnqCmO4di1TCxtYHg7E PwRo5bGKiqg6xISmLGtL9i1/37QCET1YuMbLd2h8WqKDjDyx8kthTYJn6UCjTR4oVPyh 3gYLzRVBgO8pjt1prsEaanaDfwcVcOKql4EbqWrK3VVON3NktYJvCuOF3DsNnT07CrXT sHng== X-Gm-Message-State: AOAM531WtYQ/BSB9lQHz3FruOvJ4upSE0/tpCvQT5aS7+8zyS9Fk7nYX bKR/il+SYdJrYDiLNgtwmwbDb0YtFbTOBA== X-Google-Smtp-Source: ABdhPJxnqaiKpaUsD1/Wf7HVOpnXIwDiz/oQkQPofTMkFyItLkXYwvqnNuFAr7cr4G3mnvYqWtGMmQ== X-Received: by 2002:a19:f015:: with SMTP id p21mr25478146lfc.32.1630504504031; Wed, 01 Sep 2021 06:55:04 -0700 (PDT) Received: from mail-lf1-f43.google.com (mail-lf1-f43.google.com. [209.85.167.43]) by smtp.gmail.com with ESMTPSA id g21sm192581lfu.94.2021.09.01.06.55.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Sep 2021 06:55:03 -0700 (PDT) Received: by mail-lf1-f43.google.com with SMTP id l10so6587597lfg.4; Wed, 01 Sep 2021 06:55:03 -0700 (PDT) X-Received: by 2002:a05:6512:3f89:: with SMTP id x9mr26306205lfa.233.1630504503566; Wed, 01 Sep 2021 06:55:03 -0700 (PDT) MIME-Version: 1.0 References: <20210901050526.45673-1-samuel@sholland.org> <20210901050526.45673-6-samuel@sholland.org> In-Reply-To: <20210901050526.45673-6-samuel@sholland.org> Reply-To: wens@csie.org From: Chen-Yu Tsai Date: Wed, 1 Sep 2021 21:54:52 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 5/8] clk: sunxi-ng: Export symbols used by CCU drivers To: Samuel Holland Cc: Maxime Ripard , Jernej Skrabec , Michael Turquette , Stephen Boyd , linux-arm-kernel , linux-clk , linux-sunxi@lists.linux.dev, linux-kernel Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 1, 2021 at 1:05 PM Samuel Holland wrote: > > For the individual drivers to be built as modules, the ops structs and > callback registration functions must be exported. None of the helper > functions are exported, because they are only referenced from the > corresponding ops structs. of_sunxi_ccu_probe is not exported, because > it is only used for built-in early OF clock providers. > > Signed-off-by: Samuel Holland > --- > drivers/clk/sunxi-ng/ccu_common.c | 2 ++ > drivers/clk/sunxi-ng/ccu_div.c | 1 + > drivers/clk/sunxi-ng/ccu_gate.c | 1 + > drivers/clk/sunxi-ng/ccu_mp.c | 2 ++ > drivers/clk/sunxi-ng/ccu_mult.c | 1 + > drivers/clk/sunxi-ng/ccu_mux.c | 2 ++ > drivers/clk/sunxi-ng/ccu_nk.c | 1 + > drivers/clk/sunxi-ng/ccu_nkm.c | 1 + > drivers/clk/sunxi-ng/ccu_nkmp.c | 1 + > drivers/clk/sunxi-ng/ccu_nm.c | 1 + > drivers/clk/sunxi-ng/ccu_phase.c | 1 + > drivers/clk/sunxi-ng/ccu_reset.c | 1 + > 12 files changed, 15 insertions(+) > > diff --git a/drivers/clk/sunxi-ng/ccu_common.c b/drivers/clk/sunxi-ng/ccu_common.c > index 31af8b6b5286..3ab109582646 100644 > --- a/drivers/clk/sunxi-ng/ccu_common.c > +++ b/drivers/clk/sunxi-ng/ccu_common.c > @@ -83,6 +83,7 @@ int ccu_pll_notifier_register(struct ccu_pll_nb *pll_nb) > return clk_notifier_register(pll_nb->common->hw.clk, > &pll_nb->clk_nb); > } > +EXPORT_SYMBOL_GPL(ccu_pll_notifier_register); These symbol names aren't exactly specific to sunxi. Maybe we could apply symbol namespaces? ChenYu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8DEDC4320A for ; Wed, 1 Sep 2021 13:58:04 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8C1B061026 for ; Wed, 1 Sep 2021 13:58:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 8C1B061026 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=csie.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Reply-To:List-Subscribe:List-Help: List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date :From:In-Reply-To:References:MIME-Version:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=7s7TkWQ9hqCr8iKy2/Slxwcn15Kjbgl44/3ZrNnt2qs=; b=RDirzqXj0UcZiP 3LXNBd5A9/gcVdfextJueRPqtCFqOXb90xcqJxaxBv7TvzuYjDKh5EoLN0mNan4M5IZeEHBJJhZJ4 HkCmKAH1MZaKXVKBTZ7h1CNMgQbo1cuxHWZaKSgPSoy+TCOYzoZlbcm+sYZWCLJkB4i8ypvchIWpk y41n/Yv/+p+6cme9ex5BhL6n6AOQLSkdGEBUvSvkdzQtGaocS8nYPNuB2EjTMj8WUNaACECWFtiKf RjgAJrjPEniCJ5CjPbWyPa0xtnqeT2QXNs1aJagYmYroqNtqiFfhaSoAIUizQVU/hzkLAP0ysTZ15 1iYiFm/cQkWW6ItvBGyQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mLQhq-006CC7-Ik; Wed, 01 Sep 2021 13:55:10 +0000 Received: from mail-lj1-f174.google.com ([209.85.208.174]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mLQhm-006CBk-R6 for linux-arm-kernel@lists.infradead.org; Wed, 01 Sep 2021 13:55:08 +0000 Received: by mail-lj1-f174.google.com with SMTP id h1so5069991ljl.9 for ; Wed, 01 Sep 2021 06:55:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:reply-to :from:date:message-id:subject:to:cc; bh=1qbLir7t00tIXtsSOowis8wzBunbda5Sb7xAud87L5k=; b=mHOxtjjqOk5T44w2yDJJGyiWcYXBvrJTUWTx/hqF8uDbBYmc+nCZ6B9ig+pys6201I tKS+6XNZ622FFEFHFM8JGvxloaHqDGKbzPt6p2gswiHOAOUG4FoiOu/WJ0ECpVo52Qsk Jr5vcS/ahkkvyXB1Ih3lsNm4nPu1LBYlMLVGEN/NnSPhgBpR1aRuDC2f520EAYNgaRYf gfx0kvqTQHhMxpaskl+Kt/MDWnEw7Xlg1XHOZNKViqAjapllskhaAY1G41vN1WRusITk XLFBh1+s45D8CbJkGy2oy5y7yhbDeeujVzAqlzC0Wi3coC4eKQPpA/JiHdf8U4lmy6hf tgLw== X-Gm-Message-State: AOAM5333LcCm3rUH6X6Za4M/8IleDTkE7QV2FKqoNQ0bjhf0xg3dzfIh UqRODI31fPx7M9kXpzC4IV5g8tt1w7u9fA== X-Google-Smtp-Source: ABdhPJwEMMs7E0DLSN+boXTIYZwtQSy4qBbGVjKasU03V3p/bHf99AQbVFGXGWGZwrHSmBg1uwJcvQ== X-Received: by 2002:a2e:9803:: with SMTP id a3mr29542196ljj.423.1630504504785; Wed, 01 Sep 2021 06:55:04 -0700 (PDT) Received: from mail-lf1-f52.google.com (mail-lf1-f52.google.com. [209.85.167.52]) by smtp.gmail.com with ESMTPSA id d19sm2029883lfv.74.2021.09.01.06.55.03 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Sep 2021 06:55:04 -0700 (PDT) Received: by mail-lf1-f52.google.com with SMTP id l10so6587606lfg.4 for ; Wed, 01 Sep 2021 06:55:03 -0700 (PDT) X-Received: by 2002:a05:6512:3f89:: with SMTP id x9mr26306205lfa.233.1630504503566; Wed, 01 Sep 2021 06:55:03 -0700 (PDT) MIME-Version: 1.0 References: <20210901050526.45673-1-samuel@sholland.org> <20210901050526.45673-6-samuel@sholland.org> In-Reply-To: <20210901050526.45673-6-samuel@sholland.org> From: Chen-Yu Tsai Date: Wed, 1 Sep 2021 21:54:52 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 5/8] clk: sunxi-ng: Export symbols used by CCU drivers To: Samuel Holland Cc: Maxime Ripard , Jernej Skrabec , Michael Turquette , Stephen Boyd , linux-arm-kernel , linux-clk , linux-sunxi@lists.linux.dev, linux-kernel X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210901_065506_924721_303C0F39 X-CRM114-Status: GOOD ( 17.97 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: wens@csie.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Sep 1, 2021 at 1:05 PM Samuel Holland wrote: > > For the individual drivers to be built as modules, the ops structs and > callback registration functions must be exported. None of the helper > functions are exported, because they are only referenced from the > corresponding ops structs. of_sunxi_ccu_probe is not exported, because > it is only used for built-in early OF clock providers. > > Signed-off-by: Samuel Holland > --- > drivers/clk/sunxi-ng/ccu_common.c | 2 ++ > drivers/clk/sunxi-ng/ccu_div.c | 1 + > drivers/clk/sunxi-ng/ccu_gate.c | 1 + > drivers/clk/sunxi-ng/ccu_mp.c | 2 ++ > drivers/clk/sunxi-ng/ccu_mult.c | 1 + > drivers/clk/sunxi-ng/ccu_mux.c | 2 ++ > drivers/clk/sunxi-ng/ccu_nk.c | 1 + > drivers/clk/sunxi-ng/ccu_nkm.c | 1 + > drivers/clk/sunxi-ng/ccu_nkmp.c | 1 + > drivers/clk/sunxi-ng/ccu_nm.c | 1 + > drivers/clk/sunxi-ng/ccu_phase.c | 1 + > drivers/clk/sunxi-ng/ccu_reset.c | 1 + > 12 files changed, 15 insertions(+) > > diff --git a/drivers/clk/sunxi-ng/ccu_common.c b/drivers/clk/sunxi-ng/ccu_common.c > index 31af8b6b5286..3ab109582646 100644 > --- a/drivers/clk/sunxi-ng/ccu_common.c > +++ b/drivers/clk/sunxi-ng/ccu_common.c > @@ -83,6 +83,7 @@ int ccu_pll_notifier_register(struct ccu_pll_nb *pll_nb) > return clk_notifier_register(pll_nb->common->hw.clk, > &pll_nb->clk_nb); > } > +EXPORT_SYMBOL_GPL(ccu_pll_notifier_register); These symbol names aren't exactly specific to sunxi. Maybe we could apply symbol namespaces? ChenYu _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel