From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81A4DC35671 for ; Sun, 23 Feb 2020 04:04:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5F3AA2067D for ; Sun, 23 Feb 2020 04:04:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727183AbgBWEEA (ORCPT ); Sat, 22 Feb 2020 23:04:00 -0500 Received: from mail-ed1-f67.google.com ([209.85.208.67]:33787 "EHLO mail-ed1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726983AbgBWED7 (ORCPT ); Sat, 22 Feb 2020 23:03:59 -0500 Received: by mail-ed1-f67.google.com with SMTP id r21so7647530edq.0; Sat, 22 Feb 2020 20:03:58 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=BwEdqYydc8kdzSGTpNrqTMnSIQHLxOA+j53stoAmXIE=; b=AYn5m+1G10wSaRo1IWwIUeGU9gyPu6w0eVfT8R5p4QCPQNgyiLRYXfqC/natGksJ3R z4oA5oH2+OM7L02kX1Ug55K7cm0AhLmL33X0xe5E4augSwdECK7QkB2oleu/TrWIvt4a 0NbSbfMNQysYBSyQRyUPAyiXmWMDo+/HsWH4dg0dnSWNg4lueXxwr5eYtC5gDfM8HiVV ZEUqeAe3DH1j4MdD17N4PJl/x96FY7YyOryHcprI6Y2KdQphg2f7kmOxH1qCG7fHBxPi 8BPCLct1XZ0RH/YsuD/MkXXjSMdUZy0ku1Bmx06CPxaan7qZ2/9YwhDGuJd+0eaLawpx xQ0Q== X-Gm-Message-State: APjAAAV8PvCjCMjJVOxi/cVn3X74nJtxU7brEvOhVgIzWLDVIA95xydc z4AVwHDECfbb+KGOtA3raV4lI3no07s= X-Google-Smtp-Source: APXvYqzrGSKXsrUGEXvzayBJLLJsND9LjHZK33uvYbD3CrtB/5P33UQxvPC1QhwB/L2HmC6n3SNaAA== X-Received: by 2002:a17:906:b2c5:: with SMTP id cf5mr41763793ejb.325.1582430637215; Sat, 22 Feb 2020 20:03:57 -0800 (PST) Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com. [209.85.221.42]) by smtp.gmail.com with ESMTPSA id i11sm582047ejv.64.2020.02.22.20.03.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 22 Feb 2020 20:03:56 -0800 (PST) Received: by mail-wr1-f42.google.com with SMTP id n10so6439954wrm.1; Sat, 22 Feb 2020 20:03:56 -0800 (PST) X-Received: by 2002:a5d:640d:: with SMTP id z13mr55885217wru.181.1582430636158; Sat, 22 Feb 2020 20:03:56 -0800 (PST) MIME-Version: 1.0 References: <20200222223154.221632-1-megous@megous.com> <20200222223154.221632-2-megous@megous.com> In-Reply-To: From: Chen-Yu Tsai Date: Sun, 23 Feb 2020 12:03:46 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [linux-sunxi] [PATCH 1/4] ARM: dts: sun8i-a83t-tbs-a711: OOB WiFi interrupt doesn't work To: =?UTF-8?Q?Ond=C5=99ej_Jirman?= Cc: linux-sunxi , Maxime Ripard , Tomas Novotny , Rob Herring , Mark Rutland , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "moderated list:ARM/Allwinner sunXi SoC support" , open list , Arend van Spriel Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Feb 23, 2020 at 11:26 AM Chen-Yu Tsai wrote: > > Hi, > > > On Sun, Feb 23, 2020 at 6:32 AM Ondrej Jirman wrote: > > > > It just causes a constant rate of 5000 interrupts per second for both > > GPIO and MMC, even if nothing is happening. Rely on in-band interrupts > > instead. > > > > Fixes: 0e23372080def7bb ("arm: dts: sun8i: Add the TBS A711 tablet devicetree") > > Signed-off-by: Ondrej Jirman > > What WiFi chip/module does this use? It might be worth asking Broadcom > people to help with this and fix the driver. Based on the comments in the device tree file, it uses an AP6210, which is a BCM43362 inside for SDIO-based WiFi. There is a recent fix in 5.6-rc1 for this, 8c8e60fb86a9 brcmfmac: sdio: Fix OOB interrupt initialization on brcm43362 which seems to fix things for me. Could you try it on your end? ChenYu > ChenYu > > > --- > > arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts | 3 --- > > 1 file changed, 3 deletions(-) > > > > diff --git a/arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts b/arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts > > index 2fd31a0a0b344..ee5ce3556b2ad 100644 > > --- a/arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts > > +++ b/arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts > > @@ -214,9 +214,6 @@ &mmc1 { > > brcmf: wifi@1 { > > reg = <1>; > > compatible = "brcm,bcm4329-fmac"; > > - interrupt-parent = <&r_pio>; > > - interrupts = <0 3 IRQ_TYPE_LEVEL_LOW>; /* PL3 WL_WAKE_UP */ > > - interrupt-names = "host-wake"; > > }; > > }; > > > > -- > > 2.25.1 > > > > -- > > You received this message because you are subscribed to the Google Groups "linux-sunxi" group. > > To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe@googlegroups.com. > > To view this discussion on the web, visit https://groups.google.com/d/msgid/linux-sunxi/20200222223154.221632-2-megous%40megous.com. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 631FBC35670 for ; Sun, 23 Feb 2020 04:04:04 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3A26F2067D for ; Sun, 23 Feb 2020 04:04:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="fSEy0jSg" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3A26F2067D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=csie.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=3BFsMDfmZd3f8Feqle2CJY0n3kmFVlXTKbgJD9VEhl0=; b=fSEy0jSg3fp6Mk cshy4I1/3zaLLt9mKqZX7aTAxT8wg0PdQY1ajJ6grKah46sj92lnB1nNSEfkx9nk2QRkRNkiLdfqZ 3H0nRABcKLA7JujNXy6p5QSnP0IvQl6zhL9JDbOEGqhqDOH55G4DyWuTByHhuGswwE9p3aoWOD6kB ihkDiD1slHtTQ+oH1A5SlISa6AdtBC42Xv1jXmQQdZJTbQ03ApKmSH7VPUd7URm2Z1Tkg6uggJIVI YMbxC9p0HxmKG9kmS46UZkKB1fHdg6yuYK9qIe+tmqBldqESfas+O/ja5cXtl7fCg+9iYk95tnd0n rMdBKcmtqi8bLxVVd7Pg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j5iUt-0007fy-MR; Sun, 23 Feb 2020 04:04:03 +0000 Received: from mail-ed1-f68.google.com ([209.85.208.68]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1j5iUq-0007fB-Im for linux-arm-kernel@lists.infradead.org; Sun, 23 Feb 2020 04:04:02 +0000 Received: by mail-ed1-f68.google.com with SMTP id c7so7624434edu.2 for ; Sat, 22 Feb 2020 20:03:58 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=BwEdqYydc8kdzSGTpNrqTMnSIQHLxOA+j53stoAmXIE=; b=JfzJzJgOB6EFzs2y6pG7zJdHGHfwR20xBBumABy30a+37MXbabdBYY4CbmLyR72aJc XpPMh0FfdKIXl/I+EaJWNakpPOyQWKQDVs4A1DkS88sNKM8yuUsVVStcIe+fQFa3rIPV 1g7aPRQ8lle8DfazWnM+gNYfr/hHgEIVvHViXM88AkdsLxzy9Qb30Bl9n7Q2Kzd+CAYA bHO6lYg0o1I3P+aXAXmUW/IB4d2Uvp+bC8UnO1mLq96ZAH+A/ki8XbM+UfVTCNHu0Ay8 vDZH+mqZm7NgGBcH/31c5835aouwrEBuiSZuoFFZo92jlQiHDaHVPlWXfwh3QRuFwN55 7zMg== X-Gm-Message-State: APjAAAW9EK6Ha+/dmrVgqH59qEVf5H35Z8QxrJETwSOr7f82JOtzHtoZ RECMbqSyYjj6iBsz+hD0Yeexzu8Z0PM= X-Google-Smtp-Source: APXvYqzpVidQYGiMSK9bb5QhCBBhuOM6P6z/WzjHj3WfZHuS8y4lHZaM/vDXz5vbg/GL5i+fm6Wizg== X-Received: by 2002:a50:bf4b:: with SMTP id g11mr39024881edk.374.1582430636987; Sat, 22 Feb 2020 20:03:56 -0800 (PST) Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com. [209.85.221.51]) by smtp.gmail.com with ESMTPSA id f19sm595897ejb.7.2020.02.22.20.03.56 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 22 Feb 2020 20:03:56 -0800 (PST) Received: by mail-wr1-f51.google.com with SMTP id p18so2771385wre.9 for ; Sat, 22 Feb 2020 20:03:56 -0800 (PST) X-Received: by 2002:a5d:640d:: with SMTP id z13mr55885217wru.181.1582430636158; Sat, 22 Feb 2020 20:03:56 -0800 (PST) MIME-Version: 1.0 References: <20200222223154.221632-1-megous@megous.com> <20200222223154.221632-2-megous@megous.com> In-Reply-To: From: Chen-Yu Tsai Date: Sun, 23 Feb 2020 12:03:46 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [linux-sunxi] [PATCH 1/4] ARM: dts: sun8i-a83t-tbs-a711: OOB WiFi interrupt doesn't work To: =?UTF-8?Q?Ond=C5=99ej_Jirman?= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200222_200400_619933_1AC8DA30 X-CRM114-Status: GOOD ( 23.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Arend van Spriel , open list , Maxime Ripard , linux-sunxi , Rob Herring , Tomas Novotny , "moderated list:ARM/Allwinner sunXi SoC support" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, Feb 23, 2020 at 11:26 AM Chen-Yu Tsai wrote: > > Hi, > > > On Sun, Feb 23, 2020 at 6:32 AM Ondrej Jirman wrote: > > > > It just causes a constant rate of 5000 interrupts per second for both > > GPIO and MMC, even if nothing is happening. Rely on in-band interrupts > > instead. > > > > Fixes: 0e23372080def7bb ("arm: dts: sun8i: Add the TBS A711 tablet devicetree") > > Signed-off-by: Ondrej Jirman > > What WiFi chip/module does this use? It might be worth asking Broadcom > people to help with this and fix the driver. Based on the comments in the device tree file, it uses an AP6210, which is a BCM43362 inside for SDIO-based WiFi. There is a recent fix in 5.6-rc1 for this, 8c8e60fb86a9 brcmfmac: sdio: Fix OOB interrupt initialization on brcm43362 which seems to fix things for me. Could you try it on your end? ChenYu > ChenYu > > > --- > > arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts | 3 --- > > 1 file changed, 3 deletions(-) > > > > diff --git a/arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts b/arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts > > index 2fd31a0a0b344..ee5ce3556b2ad 100644 > > --- a/arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts > > +++ b/arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts > > @@ -214,9 +214,6 @@ &mmc1 { > > brcmf: wifi@1 { > > reg = <1>; > > compatible = "brcm,bcm4329-fmac"; > > - interrupt-parent = <&r_pio>; > > - interrupts = <0 3 IRQ_TYPE_LEVEL_LOW>; /* PL3 WL_WAKE_UP */ > > - interrupt-names = "host-wake"; > > }; > > }; > > > > -- > > 2.25.1 > > > > -- > > You received this message because you are subscribed to the Google Groups "linux-sunxi" group. > > To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe@googlegroups.com. > > To view this discussion on the web, visit https://groups.google.com/d/msgid/linux-sunxi/20200222223154.221632-2-megous%40megous.com. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel