From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756275AbeEAQYM (ORCPT ); Tue, 1 May 2018 12:24:12 -0400 Received: from mail-wm0-f66.google.com ([74.125.82.66]:54793 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755905AbeEAQYC (ORCPT ); Tue, 1 May 2018 12:24:02 -0400 X-Google-Smtp-Source: AB8JxZoj2S5+hpBQjKPa4hJ3apv7jpsz6fYie0eFAuxLcBEBiq7nTTfOoLcOSkKOtOVoxvCjB38j6A== MIME-Version: 1.0 In-Reply-To: <20180430114058.5061-4-jagan@amarulasolutions.com> References: <20180430114058.5061-1-jagan@amarulasolutions.com> <20180430114058.5061-4-jagan@amarulasolutions.com> From: Chen-Yu Tsai Date: Wed, 2 May 2018 00:23:38 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 03/21] clk: sunxi-ng: Enable DE2_CCU for Allwinner 64-bit SoCs To: Jagan Teki Cc: Maxime Ripard , Icenowy Zheng , Jernej Skrabec , Rob Herring , Mark Rutland , Catalin Marinas , Will Deacon , David Airlie , dri-devel , Michael Turquette , Stephen Boyd , linux-clk , Michael Trimarchi , linux-arm-kernel , devicetree , linux-kernel , linux-sunxi Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 30, 2018 at 7:40 PM, Jagan Teki wrote: > Allwinner 64-bit SoC like H5/A64 has DE2 CCU so enable them > as default. > > Signed-off-by: Jagan Teki > --- > drivers/clk/sunxi-ng/Kconfig | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/clk/sunxi-ng/Kconfig b/drivers/clk/sunxi-ng/Kconfig > index 79dfd296c3d1..1fffd3bf6ff3 100644 > --- a/drivers/clk/sunxi-ng/Kconfig > +++ b/drivers/clk/sunxi-ng/Kconfig > @@ -58,6 +58,8 @@ config SUN8I_V3S_CCU > > config SUN8I_DE2_CCU > bool "Support for the Allwinner SoCs DE2 CCU" > + default ARM64 && ARCH_SUNXI > + depends on (DRM_SUN4I && (ARM64 && ARCH_SUNXI)) || COMPILE_TEST There is no reason to depend on DRM_SUN4I. There is no compile dependency. Also, this is needed on SUN8I as well, pretty much anything with DE 2.0. So you shouldn't limit it to ARM64. That pretty much breaks things for people with A83T's or H3's. In fact you should enable it by default for these as well. ChenYu > > config SUN8I_R40_CCU > bool "Support for the Allwinner R40 CCU" > -- > 2.14.3 > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chen-Yu Tsai Subject: Re: [PATCH 03/21] clk: sunxi-ng: Enable DE2_CCU for Allwinner 64-bit SoCs Date: Wed, 2 May 2018 00:23:38 +0800 Message-ID: References: <20180430114058.5061-1-jagan@amarulasolutions.com> <20180430114058.5061-4-jagan@amarulasolutions.com> Reply-To: wens-jdAy2FN1RRM@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: Sender: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org In-Reply-To: <20180430114058.5061-4-jagan-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Jagan Teki Cc: Maxime Ripard , Icenowy Zheng , Jernej Skrabec , Rob Herring , Mark Rutland , Catalin Marinas , Will Deacon , David Airlie , dri-devel , Michael Turquette , Stephen Boyd , linux-clk , Michael Trimarchi , linux-arm-kernel , devicetree , linux-kernel , linux-sunxi List-Id: devicetree@vger.kernel.org On Mon, Apr 30, 2018 at 7:40 PM, Jagan Teki wrote: > Allwinner 64-bit SoC like H5/A64 has DE2 CCU so enable them > as default. > > Signed-off-by: Jagan Teki > --- > drivers/clk/sunxi-ng/Kconfig | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/clk/sunxi-ng/Kconfig b/drivers/clk/sunxi-ng/Kconfig > index 79dfd296c3d1..1fffd3bf6ff3 100644 > --- a/drivers/clk/sunxi-ng/Kconfig > +++ b/drivers/clk/sunxi-ng/Kconfig > @@ -58,6 +58,8 @@ config SUN8I_V3S_CCU > > config SUN8I_DE2_CCU > bool "Support for the Allwinner SoCs DE2 CCU" > + default ARM64 && ARCH_SUNXI > + depends on (DRM_SUN4I && (ARM64 && ARCH_SUNXI)) || COMPILE_TEST There is no reason to depend on DRM_SUN4I. There is no compile dependency. Also, this is needed on SUN8I as well, pretty much anything with DE 2.0. So you shouldn't limit it to ARM64. That pretty much breaks things for people with A83T's or H3's. In fact you should enable it by default for these as well. ChenYu > > config SUN8I_R40_CCU > bool "Support for the Allwinner R40 CCU" > -- > 2.14.3 > From mboxrd@z Thu Jan 1 00:00:00 1970 From: wens@csie.org (Chen-Yu Tsai) Date: Wed, 2 May 2018 00:23:38 +0800 Subject: [PATCH 03/21] clk: sunxi-ng: Enable DE2_CCU for Allwinner 64-bit SoCs In-Reply-To: <20180430114058.5061-4-jagan@amarulasolutions.com> References: <20180430114058.5061-1-jagan@amarulasolutions.com> <20180430114058.5061-4-jagan@amarulasolutions.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon, Apr 30, 2018 at 7:40 PM, Jagan Teki wrote: > Allwinner 64-bit SoC like H5/A64 has DE2 CCU so enable them > as default. > > Signed-off-by: Jagan Teki > --- > drivers/clk/sunxi-ng/Kconfig | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/clk/sunxi-ng/Kconfig b/drivers/clk/sunxi-ng/Kconfig > index 79dfd296c3d1..1fffd3bf6ff3 100644 > --- a/drivers/clk/sunxi-ng/Kconfig > +++ b/drivers/clk/sunxi-ng/Kconfig > @@ -58,6 +58,8 @@ config SUN8I_V3S_CCU > > config SUN8I_DE2_CCU > bool "Support for the Allwinner SoCs DE2 CCU" > + default ARM64 && ARCH_SUNXI > + depends on (DRM_SUN4I && (ARM64 && ARCH_SUNXI)) || COMPILE_TEST There is no reason to depend on DRM_SUN4I. There is no compile dependency. Also, this is needed on SUN8I as well, pretty much anything with DE 2.0. So you shouldn't limit it to ARM64. That pretty much breaks things for people with A83T's or H3's. In fact you should enable it by default for these as well. ChenYu > > config SUN8I_R40_CCU > bool "Support for the Allwinner R40 CCU" > -- > 2.14.3 >