From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751072AbdBUDQs (ORCPT <rfc822;w@1wt.eu>);
        Mon, 20 Feb 2017 22:16:48 -0500
Received: from smtp.csie.ntu.edu.tw ([140.112.30.61]:48368 "EHLO
        smtp.csie.ntu.edu.tw" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750979AbdBUDQr (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 20 Feb 2017 22:16:47 -0500
MIME-Version: 1.0
In-Reply-To: <112c3e4aa625ce2c550ae7ae4446a61d058455b5.1487428238.git.rask@formelder.dk>
References: <cover.1487428238.git.rask@formelder.dk> <112c3e4aa625ce2c550ae7ae4446a61d058455b5.1487428238.git.rask@formelder.dk>
From: Chen-Yu Tsai <wens@csie.org>
Date: Tue, 21 Feb 2017 11:16:21 +0800
X-Gmail-Original-Message-ID: <CAGb2v66RCFt9x1r16UNZDTow7R-Donix5oxtfjm4BG_58R1VCw@mail.gmail.com>
Message-ID: <CAGb2v66RCFt9x1r16UNZDTow7R-Donix5oxtfjm4BG_58R1VCw@mail.gmail.com>
Subject: Re: [PATCH 1/2] dts: mfd: axp20x: Add xpowers,master-mode property
 for AXP806 PMICs
To: Rask Ingemann Lambertsen <rask@formelder.dk>
Cc: Chen-Yu Tsai <wens@csie.org>, Lee Jones <lee.jones@linaro.org>,
        Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>,
        devicetree <devicetree@vger.kernel.org>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, Feb 19, 2017 at 3:51 AM, Rask Ingemann Lambertsen
<rask@formelder.dk> wrote:
> commit b101829a029a ("mfd: axp20x: Fix AXP806 access errors on cold boot")
> was intended to fix the case where a board uses an AXP806 in slave mode,
> but the boot loader leaves it in master mode for lack of AXP806 support.
> But now the driver breaks on boards where the PMIC is operating in master
> mode. To let the device tree describe which mode of operation is needed,
> this patch introduces a new property "xpowers,master-mode".
>
> Fixes: b101829a029a ("mfd: axp20x: Fix AXP806 access errors on cold boot")

I think this should point to the original commit that added support
for the AXP806.

Otherwise,

Acked-by: Chen-Yu Tsai <wens@csie.org>

> Signed-off-by: Rask Ingemann Lambertsen <rask@formelder.dk>
> ---
>  Documentation/devicetree/bindings/mfd/axp20x.txt | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mfd/axp20x.txt b/Documentation/devicetree/bindings/mfd/axp20x.txt
> index 86ae540..9af3457 100644
> --- a/Documentation/devicetree/bindings/mfd/axp20x.txt
> +++ b/Documentation/devicetree/bindings/mfd/axp20x.txt
> @@ -29,6 +29,9 @@ Optional properties:
>                   regulator to drive the OTG VBus, rather then as an input pin
>                   which signals whether the board is driving OTG VBus or not.
>
> +- x-powers,master-mode: Boolean (axp806 only). Set this when the PMIC is
> +                       wired for master mode. The default is slave mode.
> +
>  - <input>-supply: a phandle to the regulator supply node. May be omitted if
>                   inputs are unregulated, such as using the IPSOUT output
>                   from the PMIC.
> --
> 2.10.2
>

From mboxrd@z Thu Jan  1 00:00:00 1970
From: Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>
Subject: Re: [PATCH 1/2] dts: mfd: axp20x: Add xpowers,master-mode property
 for AXP806 PMICs
Date: Tue, 21 Feb 2017 11:16:21 +0800
Message-ID: <CAGb2v66RCFt9x1r16UNZDTow7R-Donix5oxtfjm4BG_58R1VCw@mail.gmail.com>
References: <cover.1487428238.git.rask@formelder.dk> <112c3e4aa625ce2c550ae7ae4446a61d058455b5.1487428238.git.rask@formelder.dk>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Return-path: <devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
In-Reply-To: <112c3e4aa625ce2c550ae7ae4446a61d058455b5.1487428238.git.rask-SivP7zSAdNDZaaYASwVUlg@public.gmane.org>
Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
To: Rask Ingemann Lambertsen <rask-SivP7zSAdNDZaaYASwVUlg@public.gmane.org>
Cc: Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>, Lee Jones <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>, Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>, Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>, devicetree <devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, linux-kernel <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, linux-arm-kernel <linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>
List-Id: devicetree@vger.kernel.org

On Sun, Feb 19, 2017 at 3:51 AM, Rask Ingemann Lambertsen
<rask-SivP7zSAdNDZaaYASwVUlg@public.gmane.org> wrote:
> commit b101829a029a ("mfd: axp20x: Fix AXP806 access errors on cold boot")
> was intended to fix the case where a board uses an AXP806 in slave mode,
> but the boot loader leaves it in master mode for lack of AXP806 support.
> But now the driver breaks on boards where the PMIC is operating in master
> mode. To let the device tree describe which mode of operation is needed,
> this patch introduces a new property "xpowers,master-mode".
>
> Fixes: b101829a029a ("mfd: axp20x: Fix AXP806 access errors on cold boot")

I think this should point to the original commit that added support
for the AXP806.

Otherwise,

Acked-by: Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>

> Signed-off-by: Rask Ingemann Lambertsen <rask-SivP7zSAdNDZaaYASwVUlg@public.gmane.org>
> ---
>  Documentation/devicetree/bindings/mfd/axp20x.txt | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mfd/axp20x.txt b/Documentation/devicetree/bindings/mfd/axp20x.txt
> index 86ae540..9af3457 100644
> --- a/Documentation/devicetree/bindings/mfd/axp20x.txt
> +++ b/Documentation/devicetree/bindings/mfd/axp20x.txt
> @@ -29,6 +29,9 @@ Optional properties:
>                   regulator to drive the OTG VBus, rather then as an input pin
>                   which signals whether the board is driving OTG VBus or not.
>
> +- x-powers,master-mode: Boolean (axp806 only). Set this when the PMIC is
> +                       wired for master mode. The default is slave mode.
> +
>  - <input>-supply: a phandle to the regulator supply node. May be omitted if
>                   inputs are unregulated, such as using the IPSOUT output
>                   from the PMIC.
> --
> 2.10.2
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

From mboxrd@z Thu Jan  1 00:00:00 1970
From: wens@csie.org (Chen-Yu Tsai)
Date: Tue, 21 Feb 2017 11:16:21 +0800
Subject: [PATCH 1/2] dts: mfd: axp20x: Add xpowers,master-mode property
 for AXP806 PMICs
In-Reply-To: <112c3e4aa625ce2c550ae7ae4446a61d058455b5.1487428238.git.rask@formelder.dk>
References: <cover.1487428238.git.rask@formelder.dk>
 <112c3e4aa625ce2c550ae7ae4446a61d058455b5.1487428238.git.rask@formelder.dk>
Message-ID: <CAGb2v66RCFt9x1r16UNZDTow7R-Donix5oxtfjm4BG_58R1VCw@mail.gmail.com>
To: linux-arm-kernel@lists.infradead.org
List-Id: linux-arm-kernel.lists.infradead.org

On Sun, Feb 19, 2017 at 3:51 AM, Rask Ingemann Lambertsen
<rask@formelder.dk> wrote:
> commit b101829a029a ("mfd: axp20x: Fix AXP806 access errors on cold boot")
> was intended to fix the case where a board uses an AXP806 in slave mode,
> but the boot loader leaves it in master mode for lack of AXP806 support.
> But now the driver breaks on boards where the PMIC is operating in master
> mode. To let the device tree describe which mode of operation is needed,
> this patch introduces a new property "xpowers,master-mode".
>
> Fixes: b101829a029a ("mfd: axp20x: Fix AXP806 access errors on cold boot")

I think this should point to the original commit that added support
for the AXP806.

Otherwise,

Acked-by: Chen-Yu Tsai <wens@csie.org>

> Signed-off-by: Rask Ingemann Lambertsen <rask@formelder.dk>
> ---
>  Documentation/devicetree/bindings/mfd/axp20x.txt | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mfd/axp20x.txt b/Documentation/devicetree/bindings/mfd/axp20x.txt
> index 86ae540..9af3457 100644
> --- a/Documentation/devicetree/bindings/mfd/axp20x.txt
> +++ b/Documentation/devicetree/bindings/mfd/axp20x.txt
> @@ -29,6 +29,9 @@ Optional properties:
>                   regulator to drive the OTG VBus, rather then as an input pin
>                   which signals whether the board is driving OTG VBus or not.
>
> +- x-powers,master-mode: Boolean (axp806 only). Set this when the PMIC is
> +                       wired for master mode. The default is slave mode.
> +
>  - <input>-supply: a phandle to the regulator supply node. May be omitted if
>                   inputs are unregulated, such as using the IPSOUT output
>                   from the PMIC.
> --
> 2.10.2
>