From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DFABEC3F2D0 for ; Wed, 11 Mar 2020 14:47:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 61546206EB for ; Wed, 11 Mar 2020 14:47:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583938021; bh=ruBwn5wDj74e/K+r4986L1gfq+eU0+k3w7VbVctWE10=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=0rp4q8rbm8SGyEMVBvMXypOEwua9glXbK+uMCnk9/LVIpHwgCrYzzOePa5uxrM+1J /aVS/EHPUqo5PfMWTV7emBq06Qm5hNug4rkixmoPbR40fsAVIpypTiFqluDpYxrEVN qxHEi515KcWrXSTS3rJxnmM7s5/XTlYS4AqQimms= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729943AbgCKOrB (ORCPT ); Wed, 11 Mar 2020 10:47:01 -0400 Received: from mail.kernel.org ([198.145.29.99]:59374 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729057AbgCKOrB (ORCPT ); Wed, 11 Mar 2020 10:47:01 -0400 Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 117C2206EB; Wed, 11 Mar 2020 14:46:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583938019; bh=ruBwn5wDj74e/K+r4986L1gfq+eU0+k3w7VbVctWE10=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=NzjBVMdxDd+Kl49LOjGaBd3WYnkCvYkNm1wU4P9GhVG5t0/K9oS+4AIwW69cVpoMV FPtGYDiYkuwXkUld5nRYYBRD3nWNrbrJGDY5/wC8JnVTMzsNRttYPblFKwfKsM7WD3 T0z2XFq1FUMLJpWJd+zpaTrZ9ieDU6xdTQqMWoJI= Received: by mail-wr1-f43.google.com with SMTP id d5so2619762wrc.2; Wed, 11 Mar 2020 07:47:00 -0700 (PDT) X-Gm-Message-State: ANhLgQ2VqtpSJHOVVtNYxMKjNo79jpup53wcZ/uPZnSk39/zha38kjTB pl8KiKyH5yaM7/UsDxZOJtX8Oe0Q2GEGsZzP8M8= X-Google-Smtp-Source: ADFU+vs8B8EgCnwrcFOwMq4EMagcV8OTKEEHRsPEaHmM1MNKm2z5pWXx/gJgkDDoe/YZ41fGgMvzQ6EnRqYtBNoKsaY= X-Received: by 2002:adf:97c1:: with SMTP id t1mr618684wrb.365.1583938018853; Wed, 11 Mar 2020 07:46:58 -0700 (PDT) MIME-Version: 1.0 References: <20200310174709.24174-1-wens@kernel.org> <20200310174709.24174-2-wens@kernel.org> <20200311105937.040cd947@donnerap.cambridge.arm.com> In-Reply-To: <20200311105937.040cd947@donnerap.cambridge.arm.com> From: Chen-Yu Tsai Date: Wed, 11 Mar 2020 22:46:49 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 1/3] ARM: dts: sun8i: r40: Move AHCI device node based on address order To: Andre Przywara Cc: Chen-Yu Tsai , Maxime Ripard , devicetree , linux-kernel , linux-arm-kernel Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 11, 2020 at 6:59 PM Andre Przywara wrote: > > On Wed, 11 Mar 2020 01:47:07 +0800 > Chen-Yu Tsai wrote: > > > From: Chen-Yu Tsai > > > > When the AHCI device node was added, it was added in the wrong location > > in the device tree file. The device nodes should be sorted by register > > address. > > > > Move the device node to before EHCI1, where it belongs. > > > > Fixes: 41c64d3318aa ("ARM: dts: sun8i: r40: add sata node") > > Signed-off-by: Chen-Yu Tsai > > --- > > arch/arm/boot/dts/sun8i-r40.dtsi | 22 +++++++++++----------- > > 1 file changed, 11 insertions(+), 11 deletions(-) > > > > diff --git a/arch/arm/boot/dts/sun8i-r40.dtsi b/arch/arm/boot/dts/sun8i-r40.dtsi > > index d5442b5b6fd2..b278686d0c22 100644 > > --- a/arch/arm/boot/dts/sun8i-r40.dtsi > > +++ b/arch/arm/boot/dts/sun8i-r40.dtsi > > @@ -307,6 +307,17 @@ crypto: crypto@1c15000 { > > resets = <&ccu RST_BUS_CE>; > > }; > > > > + ahci: sata@1c18000 { > > + compatible = "allwinner,sun8i-r40-ahci"; > > + reg = <0x01c18000 0x1000>; > > + interrupts = ; > > + clocks = <&ccu CLK_BUS_SATA>, <&ccu CLK_SATA>; > > + resets = <&ccu RST_BUS_SATA>; > > + reset-names = "ahci"; > > + status = "disabled"; > > + > > Did this empty line serve any particular purpose before? If not, you could remove it on the way. Can't say there is. Removed when applied. > With that fixed: > > Reviewed-by: Andre Przywara > > Thanks, > Andre. Thanks ChenYu > > + }; > > + > > ehci1: usb@1c19000 { > > compatible = "allwinner,sun8i-r40-ehci", "generic-ehci"; > > reg = <0x01c19000 0x100>; > > @@ -733,17 +744,6 @@ spi3: spi@1c0f000 { > > #size-cells = <0>; > > }; > > > > - ahci: sata@1c18000 { > > - compatible = "allwinner,sun8i-r40-ahci"; > > - reg = <0x01c18000 0x1000>; > > - interrupts = ; > > - clocks = <&ccu CLK_BUS_SATA>, <&ccu CLK_SATA>; > > - resets = <&ccu RST_BUS_SATA>; > > - reset-names = "ahci"; > > - status = "disabled"; > > - > > - }; > > - > > gmac: ethernet@1c50000 { > > compatible = "allwinner,sun8i-r40-gmac"; > > syscon = <&ccu>; > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2FDC7C10F27 for ; Wed, 11 Mar 2020 14:47:09 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A24E3206B1 for ; Wed, 11 Mar 2020 14:47:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="GU/xmoJq"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="NzjBVMdx" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A24E3206B1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=YWNJXIoJBgzXRRBmM22KlDYUyjVcY4bSPpSjWewlzJQ=; b=GU/xmoJqchU6Hr aIldNQDcOi8g7WvqhuWyrdkRPsYYOw1jnqS+wtk5WOIbls1zaXH2l/szP2YkAv59x2sAq5WavEXaK YIABQSuRrUJAvypFYpD+zMbmlcIziPMwTKIVl592lP28I2TQfzCBMlm+TICpuN/wDiaGFWL5zZrpk oxwZKt8oPOGQULMloTo3cfeIzcvn/hTonL8mTVBNPSgNs1rzqLB/LH2jQ943/laR54iwPf8bYyzoV emRs5U9LHpcdLUARE/MdblQVV42qd+5BLVbwwaxid/ei/WyOzsKQt+Psd/dfiLNsIK40fzbWPxdVP rqEFLcNZR7rWPSiRHKZQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jC2dW-0006st-6O; Wed, 11 Mar 2020 14:47:06 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jC2dR-0006qb-Pw for linux-arm-kernel@lists.infradead.org; Wed, 11 Mar 2020 14:47:03 +0000 Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 02B71206B1 for ; Wed, 11 Mar 2020 14:46:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583938019; bh=ruBwn5wDj74e/K+r4986L1gfq+eU0+k3w7VbVctWE10=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=NzjBVMdxDd+Kl49LOjGaBd3WYnkCvYkNm1wU4P9GhVG5t0/K9oS+4AIwW69cVpoMV FPtGYDiYkuwXkUld5nRYYBRD3nWNrbrJGDY5/wC8JnVTMzsNRttYPblFKwfKsM7WD3 T0z2XFq1FUMLJpWJd+zpaTrZ9ieDU6xdTQqMWoJI= Received: by mail-wr1-f50.google.com with SMTP id v9so2964363wrf.10 for ; Wed, 11 Mar 2020 07:47:00 -0700 (PDT) X-Gm-Message-State: ANhLgQ3CWRWL0c/b6OSsQtSi+nBEHVE8OXwJrsk8p+D6cSogtZwwUslP 3/Pkx/Hc7miarTBwLuYoF9sqCBoQKbsUTnZ6o7E= X-Google-Smtp-Source: ADFU+vs8B8EgCnwrcFOwMq4EMagcV8OTKEEHRsPEaHmM1MNKm2z5pWXx/gJgkDDoe/YZ41fGgMvzQ6EnRqYtBNoKsaY= X-Received: by 2002:adf:97c1:: with SMTP id t1mr618684wrb.365.1583938018853; Wed, 11 Mar 2020 07:46:58 -0700 (PDT) MIME-Version: 1.0 References: <20200310174709.24174-1-wens@kernel.org> <20200310174709.24174-2-wens@kernel.org> <20200311105937.040cd947@donnerap.cambridge.arm.com> In-Reply-To: <20200311105937.040cd947@donnerap.cambridge.arm.com> From: Chen-Yu Tsai Date: Wed, 11 Mar 2020 22:46:49 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 1/3] ARM: dts: sun8i: r40: Move AHCI device node based on address order To: Andre Przywara X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200311_074701_886164_AE9ACE13 X-CRM114-Status: GOOD ( 19.92 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-kernel , devicetree , Chen-Yu Tsai , linux-kernel , Maxime Ripard Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Mar 11, 2020 at 6:59 PM Andre Przywara wrote: > > On Wed, 11 Mar 2020 01:47:07 +0800 > Chen-Yu Tsai wrote: > > > From: Chen-Yu Tsai > > > > When the AHCI device node was added, it was added in the wrong location > > in the device tree file. The device nodes should be sorted by register > > address. > > > > Move the device node to before EHCI1, where it belongs. > > > > Fixes: 41c64d3318aa ("ARM: dts: sun8i: r40: add sata node") > > Signed-off-by: Chen-Yu Tsai > > --- > > arch/arm/boot/dts/sun8i-r40.dtsi | 22 +++++++++++----------- > > 1 file changed, 11 insertions(+), 11 deletions(-) > > > > diff --git a/arch/arm/boot/dts/sun8i-r40.dtsi b/arch/arm/boot/dts/sun8i-r40.dtsi > > index d5442b5b6fd2..b278686d0c22 100644 > > --- a/arch/arm/boot/dts/sun8i-r40.dtsi > > +++ b/arch/arm/boot/dts/sun8i-r40.dtsi > > @@ -307,6 +307,17 @@ crypto: crypto@1c15000 { > > resets = <&ccu RST_BUS_CE>; > > }; > > > > + ahci: sata@1c18000 { > > + compatible = "allwinner,sun8i-r40-ahci"; > > + reg = <0x01c18000 0x1000>; > > + interrupts = ; > > + clocks = <&ccu CLK_BUS_SATA>, <&ccu CLK_SATA>; > > + resets = <&ccu RST_BUS_SATA>; > > + reset-names = "ahci"; > > + status = "disabled"; > > + > > Did this empty line serve any particular purpose before? If not, you could remove it on the way. Can't say there is. Removed when applied. > With that fixed: > > Reviewed-by: Andre Przywara > > Thanks, > Andre. Thanks ChenYu > > + }; > > + > > ehci1: usb@1c19000 { > > compatible = "allwinner,sun8i-r40-ehci", "generic-ehci"; > > reg = <0x01c19000 0x100>; > > @@ -733,17 +744,6 @@ spi3: spi@1c0f000 { > > #size-cells = <0>; > > }; > > > > - ahci: sata@1c18000 { > > - compatible = "allwinner,sun8i-r40-ahci"; > > - reg = <0x01c18000 0x1000>; > > - interrupts = ; > > - clocks = <&ccu CLK_BUS_SATA>, <&ccu CLK_SATA>; > > - resets = <&ccu RST_BUS_SATA>; > > - reset-names = "ahci"; > > - status = "disabled"; > > - > > - }; > > - > > gmac: ethernet@1c50000 { > > compatible = "allwinner,sun8i-r40-gmac"; > > syscon = <&ccu>; > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel