From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751894AbcIBHBe (ORCPT ); Fri, 2 Sep 2016 03:01:34 -0400 Received: from smtp.csie.ntu.edu.tw ([140.112.30.61]:53596 "EHLO smtp.csie.ntu.edu.tw" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750939AbcIBHBd (ORCPT ); Fri, 2 Sep 2016 03:01:33 -0400 MIME-Version: 1.0 In-Reply-To: <20160901153204.11217-5-maxime.ripard@free-electrons.com> References: <20160901153204.11217-1-maxime.ripard@free-electrons.com> <20160901153204.11217-5-maxime.ripard@free-electrons.com> From: Chen-Yu Tsai Date: Fri, 2 Sep 2016 15:01:08 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 4/7] drm/panel: Add Sinlinx SinA33 7" panel To: Maxime Ripard Cc: Daniel Vetter , David Airlie , Thierry Reding , Chen-Yu Tsai , Rob Herring , dri-devel , linux-arm-kernel , linux-kernel , linux-sunxi , Thomas Petazzoni Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 1, 2016 at 11:32 PM, Maxime Ripard wrote: > The SinA33 has an unidentified panel. Add the timings for it under a new > compatible. > > Signed-off-by: Maxime Ripard > --- > drivers/gpu/drm/panel/panel-simple.c | 26 ++++++++++++++++++++++++++ > 1 file changed, 26 insertions(+) > > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c > index 85143d1b9b31..af142e804245 100644 > --- a/drivers/gpu/drm/panel/panel-simple.c > +++ b/drivers/gpu/drm/panel/panel-simple.c > @@ -1409,6 +1409,29 @@ static const struct panel_desc shelly_sca07010_bfn_lnn = { > .bus_format = MEDIA_BUS_FMT_RGB666_1X18, > }; > > +static const struct drm_display_mode sinlinx_sina33_lcd_7_mode = { Nit on the name: the lcd panel also works with sina31s. The only difference is the ribbon cable used to connect it to the board. Maybe sinlinx_sinaxx_lcd_7? Just a suggestion though, the patch looks fine. ChenYu > + .clock = 66000, > + .hdisplay = 1024, > + .hsync_start = 1024 + 160, > + .hsync_end = 1024 + 160 + 70, > + .htotal = 1024 + 160 + 70 + 90, > + .vdisplay = 600, > + .vsync_start = 600 + 127, > + .vsync_end = 600 + 127 + 20, > + .vtotal = 600 + 127 + 20 + 3, > + .vrefresh = 60, > +}; > + > +static const struct panel_desc sinlinx_sina33_lcd_7 = { > + .modes = &sinlinx_sina33_lcd_7_mode, > + .num_modes = 1, > + .size = { > + .width = 154, > + .height = 87, > + }, > + .bus_format = MEDIA_BUS_FMT_RGB666_1X18, > +}; > + > static const struct drm_display_mode starry_kr122ea0sra_mode = { > .clock = 147000, > .hdisplay = 1920, > @@ -1644,6 +1667,9 @@ static const struct of_device_id platform_of_match[] = { > .compatible = "shelly,sca07010-bfn-lnn", > .data = &shelly_sca07010_bfn_lnn, > }, { > + .compatible = "sinlinx,sina33-lcd-7", > + .data = &sinlinx_sina33_lcd_7, > + }, { > .compatible = "starry,kr122ea0sra", > .data = &starry_kr122ea0sra, > }, { > -- > 2.9.2 > From mboxrd@z Thu Jan 1 00:00:00 1970 From: wens@csie.org (Chen-Yu Tsai) Date: Fri, 2 Sep 2016 15:01:08 +0800 Subject: [PATCH 4/7] drm/panel: Add Sinlinx SinA33 7" panel In-Reply-To: <20160901153204.11217-5-maxime.ripard@free-electrons.com> References: <20160901153204.11217-1-maxime.ripard@free-electrons.com> <20160901153204.11217-5-maxime.ripard@free-electrons.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, Sep 1, 2016 at 11:32 PM, Maxime Ripard wrote: > The SinA33 has an unidentified panel. Add the timings for it under a new > compatible. > > Signed-off-by: Maxime Ripard > --- > drivers/gpu/drm/panel/panel-simple.c | 26 ++++++++++++++++++++++++++ > 1 file changed, 26 insertions(+) > > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c > index 85143d1b9b31..af142e804245 100644 > --- a/drivers/gpu/drm/panel/panel-simple.c > +++ b/drivers/gpu/drm/panel/panel-simple.c > @@ -1409,6 +1409,29 @@ static const struct panel_desc shelly_sca07010_bfn_lnn = { > .bus_format = MEDIA_BUS_FMT_RGB666_1X18, > }; > > +static const struct drm_display_mode sinlinx_sina33_lcd_7_mode = { Nit on the name: the lcd panel also works with sina31s. The only difference is the ribbon cable used to connect it to the board. Maybe sinlinx_sinaxx_lcd_7? Just a suggestion though, the patch looks fine. ChenYu > + .clock = 66000, > + .hdisplay = 1024, > + .hsync_start = 1024 + 160, > + .hsync_end = 1024 + 160 + 70, > + .htotal = 1024 + 160 + 70 + 90, > + .vdisplay = 600, > + .vsync_start = 600 + 127, > + .vsync_end = 600 + 127 + 20, > + .vtotal = 600 + 127 + 20 + 3, > + .vrefresh = 60, > +}; > + > +static const struct panel_desc sinlinx_sina33_lcd_7 = { > + .modes = &sinlinx_sina33_lcd_7_mode, > + .num_modes = 1, > + .size = { > + .width = 154, > + .height = 87, > + }, > + .bus_format = MEDIA_BUS_FMT_RGB666_1X18, > +}; > + > static const struct drm_display_mode starry_kr122ea0sra_mode = { > .clock = 147000, > .hdisplay = 1920, > @@ -1644,6 +1667,9 @@ static const struct of_device_id platform_of_match[] = { > .compatible = "shelly,sca07010-bfn-lnn", > .data = &shelly_sca07010_bfn_lnn, > }, { > + .compatible = "sinlinx,sina33-lcd-7", > + .data = &sinlinx_sina33_lcd_7, > + }, { > .compatible = "starry,kr122ea0sra", > .data = &starry_kr122ea0sra, > }, { > -- > 2.9.2 >