From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752952AbdLEPnH (ORCPT ); Tue, 5 Dec 2017 10:43:07 -0500 Received: from smtp.csie.ntu.edu.tw ([140.112.30.61]:40582 "EHLO smtp.csie.ntu.edu.tw" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752500AbdLEPnC (ORCPT ); Tue, 5 Dec 2017 10:43:02 -0500 X-Google-Smtp-Source: AGs4zMbueqmveZxM0rKs9D0ZHC23eojSHeXfiAqej4wuhb/raCDNhRnlSnQdustr2uCelTWwUoexiXXzLbvDyi09ioY= MIME-Version: 1.0 In-Reply-To: <1f2443c41082fc6e086570da38d20744c52fe636.1512486553.git-series.maxime.ripard@free-electrons.com> References: <1f2443c41082fc6e086570da38d20744c52fe636.1512486553.git-series.maxime.ripard@free-electrons.com> From: Chen-Yu Tsai Date: Tue, 5 Dec 2017 23:42:35 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 05/15] drm/sun4i: Fix error path handling To: Maxime Ripard Cc: Daniel Vetter , David Airlie , Chen-Yu Tsai , dri-devel , linux-kernel , Mark Rutland , Rob Herring , linux-arm-kernel , Priit Laes , Icenowy Zheng , Thomas Petazzoni , Jernej Skrabec , devicetree , stable Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 5, 2017 at 11:10 PM, Maxime Ripard wrote: > The commit 4c7f16d14a33 ("drm/sun4i: Fix TCON clock and regmap > initialization sequence") moved a bunch of logic around, but forgot to > update the gotos after the introduction of the err_free_dotclock label. > > It means that if we fail later that the one introduced in that commit, > we'll just to the old label which isn't free the clock we created. This > will result in a breakage as soon as someone tries to do something with > that clock, since its resources will have been long reclaimed. > > Cc: > Fixes: 4c7f16d14a33 ("drm/sun4i: Fix TCON clock and regmap initialization sequence") > Signed-off-by: Maxime Ripard Thanks. I think this was reported, or I noticed it after the patch was merged, but then I got busy with other stuff. Reviewed-by: Chen-Yu Tsai From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chen-Yu Tsai Subject: Re: [PATCH v3 05/15] drm/sun4i: Fix error path handling Date: Tue, 5 Dec 2017 23:42:35 +0800 Message-ID: References: <1f2443c41082fc6e086570da38d20744c52fe636.1512486553.git-series.maxime.ripard@free-electrons.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: <1f2443c41082fc6e086570da38d20744c52fe636.1512486553.git-series.maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Maxime Ripard Cc: Daniel Vetter , David Airlie , Chen-Yu Tsai , dri-devel , linux-kernel , Mark Rutland , Rob Herring , linux-arm-kernel , Priit Laes , Icenowy Zheng , Thomas Petazzoni , Jernej Skrabec , devicetree , stable List-Id: devicetree@vger.kernel.org On Tue, Dec 5, 2017 at 11:10 PM, Maxime Ripard wrote: > The commit 4c7f16d14a33 ("drm/sun4i: Fix TCON clock and regmap > initialization sequence") moved a bunch of logic around, but forgot to > update the gotos after the introduction of the err_free_dotclock label. > > It means that if we fail later that the one introduced in that commit, > we'll just to the old label which isn't free the clock we created. This > will result in a breakage as soon as someone tries to do something with > that clock, since its resources will have been long reclaimed. > > Cc: > Fixes: 4c7f16d14a33 ("drm/sun4i: Fix TCON clock and regmap initialization sequence") > Signed-off-by: Maxime Ripard Thanks. I think this was reported, or I noticed it after the patch was merged, but then I got busy with other stuff. Reviewed-by: Chen-Yu Tsai -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: wens@csie.org (Chen-Yu Tsai) Date: Tue, 5 Dec 2017 23:42:35 +0800 Subject: [PATCH v3 05/15] drm/sun4i: Fix error path handling In-Reply-To: <1f2443c41082fc6e086570da38d20744c52fe636.1512486553.git-series.maxime.ripard@free-electrons.com> References: <1f2443c41082fc6e086570da38d20744c52fe636.1512486553.git-series.maxime.ripard@free-electrons.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, Dec 5, 2017 at 11:10 PM, Maxime Ripard wrote: > The commit 4c7f16d14a33 ("drm/sun4i: Fix TCON clock and regmap > initialization sequence") moved a bunch of logic around, but forgot to > update the gotos after the introduction of the err_free_dotclock label. > > It means that if we fail later that the one introduced in that commit, > we'll just to the old label which isn't free the clock we created. This > will result in a breakage as soon as someone tries to do something with > that clock, since its resources will have been long reclaimed. > > Cc: > Fixes: 4c7f16d14a33 ("drm/sun4i: Fix TCON clock and regmap initialization sequence") > Signed-off-by: Maxime Ripard Thanks. I think this was reported, or I noticed it after the patch was merged, but then I got busy with other stuff. Reviewed-by: Chen-Yu Tsai