From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932505AbdESDCH (ORCPT ); Thu, 18 May 2017 23:02:07 -0400 Received: from smtp.csie.ntu.edu.tw ([140.112.30.61]:58874 "EHLO smtp.csie.ntu.edu.tw" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755299AbdESDCE (ORCPT ); Thu, 18 May 2017 23:02:04 -0400 MIME-Version: 1.0 In-Reply-To: <20170518071653.36561-10-icenowy@aosc.io> References: <20170518071653.36561-1-icenowy@aosc.io> <20170518071653.36561-10-icenowy@aosc.io> From: Chen-Yu Tsai Date: Fri, 19 May 2017 11:01:39 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [linux-sunxi] [PATCH v6 9/9] arm64: allwinner: a64: enable Wi-Fi for Pine64 To: Icenowy Zheng Cc: Thomas Gleixner , Jason Cooper , Marc Zyngier , Rob Herring , Maxime Ripard , Chen-Yu Tsai , Lee Jones , Liam Girdwood , Mark Brown , linux-kernel , devicetree , linux-arm-kernel , linux-sunxi Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Thu, May 18, 2017 at 3:16 PM, Icenowy Zheng wrote: > The Wi-Fi module of Pine64 is powered via DLDO4 and ELDO1 (the latter > one provides I/O voltage). > > Add device node for it. > > Although the Wi-Fi module is an external module which should be inserted > to a header, according to my personal talk with TL Lim, he does not want > this header to be used as GPIO (so it's with 2.0mm pitch, not 2.54mm as > other GPIO headers). The patch looks OK, but given the module is removable, I think it should be an overlay. The overlay would enable WiFi + Bluetooth, and all the peripherals needed to connect them. That way, if the module is not installed, we avoid confusing the user with unused peripherals, and avoid having live voltage on an unoccupied header. ChenYu From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chen-Yu Tsai Subject: Re: [PATCH v6 9/9] arm64: allwinner: a64: enable Wi-Fi for Pine64 Date: Fri, 19 May 2017 11:01:39 +0800 Message-ID: References: <20170518071653.36561-1-icenowy@aosc.io> <20170518071653.36561-10-icenowy@aosc.io> Reply-To: wens-jdAy2FN1RRM@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: Sender: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org In-Reply-To: <20170518071653.36561-10-icenowy-h8G6r0blFSE@public.gmane.org> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Icenowy Zheng Cc: Thomas Gleixner , Jason Cooper , Marc Zyngier , Rob Herring , Maxime Ripard , Chen-Yu Tsai , Lee Jones , Liam Girdwood , Mark Brown , linux-kernel , devicetree , linux-arm-kernel , linux-sunxi List-Id: devicetree@vger.kernel.org Hi, On Thu, May 18, 2017 at 3:16 PM, Icenowy Zheng wrote: > The Wi-Fi module of Pine64 is powered via DLDO4 and ELDO1 (the latter > one provides I/O voltage). > > Add device node for it. > > Although the Wi-Fi module is an external module which should be inserted > to a header, according to my personal talk with TL Lim, he does not want > this header to be used as GPIO (so it's with 2.0mm pitch, not 2.54mm as > other GPIO headers). The patch looks OK, but given the module is removable, I think it should be an overlay. The overlay would enable WiFi + Bluetooth, and all the peripherals needed to connect them. That way, if the module is not installed, we avoid confusing the user with unused peripherals, and avoid having live voltage on an unoccupied header. ChenYu From mboxrd@z Thu Jan 1 00:00:00 1970 From: wens@csie.org (Chen-Yu Tsai) Date: Fri, 19 May 2017 11:01:39 +0800 Subject: [linux-sunxi] [PATCH v6 9/9] arm64: allwinner: a64: enable Wi-Fi for Pine64 In-Reply-To: <20170518071653.36561-10-icenowy@aosc.io> References: <20170518071653.36561-1-icenowy@aosc.io> <20170518071653.36561-10-icenowy@aosc.io> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi, On Thu, May 18, 2017 at 3:16 PM, Icenowy Zheng wrote: > The Wi-Fi module of Pine64 is powered via DLDO4 and ELDO1 (the latter > one provides I/O voltage). > > Add device node for it. > > Although the Wi-Fi module is an external module which should be inserted > to a header, according to my personal talk with TL Lim, he does not want > this header to be used as GPIO (so it's with 2.0mm pitch, not 2.54mm as > other GPIO headers). The patch looks OK, but given the module is removable, I think it should be an overlay. The overlay would enable WiFi + Bluetooth, and all the peripherals needed to connect them. That way, if the module is not installed, we avoid confusing the user with unused peripherals, and avoid having live voltage on an unoccupied header. ChenYu