From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chen-Yu Tsai Date: Thu, 31 Aug 2017 09:31:20 +0800 Subject: [U-Boot] [linux-sunxi] Re: [PATCH 3/4] sunxi: dts: added emac node for nanopi m1 In-Reply-To: References: <1504053161-27814-1-git-send-email-embed3d@gmail.com> <1504053161-27814-4-git-send-email-embed3d@gmail.com> <422ebcc8-7add-9923-4a78-41ba305c6039@gmail.com> <1504103798.30330.1.camel@xff.cz> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: u-boot@lists.denx.de On Thu, Aug 31, 2017 at 7:10 AM, Philipp Rossak wrote: > > > On 30.08.2017 18:59, Jagan Teki wrote: >> >> On Wed, Aug 30, 2017 at 8:06 PM, Ondřej Jirman wrote: >>> >>> Hi, >>> >>> Jagan Teki píše v St 30. 08. 2017 v 19:48 +0530: >>>> >>>> On Wed, Aug 30, 2017 at 2:40 PM, Philipp Rossak >>>> wrote: >>>>> >>>>> >>>>> Am 30.08.2017 um 08:47 schrieb Jagan Teki: >>>>>> >>>>>> On Wed, Aug 30, 2017 at 6:02 AM, Philipp Rossak >>>>>> wrote: >>>>>>> >>>>>>> From: Philipp Rossak >>>>>>> >>>>>>> The sun8i emac hardware is present on the Nanopi M1. >>>>>>> It uses the internal PHY. >>>>>>> >>>>>>> Signed-off-by: Philipp Rossak >>>>>>> --- >>>>>>> arch/arm/dts/sun8i-h3-nanopi-m1.dts | 11 +++++++++++ >>>>>>> 1 file changed, 11 insertions(+) >>>>>>> >>>>>>> diff --git a/arch/arm/dts/sun8i-h3-nanopi-m1.dts >>>>>>> b/arch/arm/dts/sun8i-h3-nanopi-m1.dts >>>>>>> index ec63d10..9c1c380 100644 >>>>>>> --- a/arch/arm/dts/sun8i-h3-nanopi-m1.dts >>>>>>> +++ b/arch/arm/dts/sun8i-h3-nanopi-m1.dts >>>>>>> @@ -55,6 +55,17 @@ >>>>>>> status = "okay"; >>>>>>> }; >>>>>>> >>>>>>> +&emac { >>>>>>> + phy = <&phy1>; >>>>>>> + phy-mode = "mii"; >>>>>>> + allwinner,use-internal-phy; >>>>>>> + allwinner,leds-active-low; >>>>>>> + status = "okay"; >>>>>>> + phy1: ethernet-phy at 1 { >>>>>>> + reg = <1>; >>>>>>> + }; >>>>>>> +}; >>>>>> >>>>>> >>>>>> We usually sync Linux for dts changes and I've seen few patches on >>>>>> Linux, lets wait Linux to merge. >>>>>> >>>>>> thanks! >>>>>> >>>>> Ok thanks, I didn't know this. >>>>> >>>>> Are there also some plans to snyc the sun8i-dwmac driver? >>>> >>>> No such plan as of now. >>> >>> There's apritzel's work on this in this branch: >>> >>> https://github.com/apritzel/u-boot/commits/a64-pending >> >> OK, thanks for the info >> >> thanks! > > How shoud we proceed with this patch series? > > My linux mainline patches were rejected since the dwmac-sun8i bindings have > not stabilized yet: > http://www.spinics.net/lists/kernel/msg2592861.html You should wait until the bindings have stabilized, then resync the dts files from Linux to U-boot, and fix up the driver to support the new bindings. ChenYu