From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752016AbdHBDrX convert rfc822-to-8bit (ORCPT ); Tue, 1 Aug 2017 23:47:23 -0400 Received: from smtp.csie.ntu.edu.tw ([140.112.30.61]:51402 "EHLO smtp.csie.ntu.edu.tw" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751791AbdHBDrV (ORCPT ); Tue, 1 Aug 2017 23:47:21 -0400 MIME-Version: 1.0 In-Reply-To: <69ad9443-ff65-8e49-df68-7e5e6c812d45@rock-chips.com> References: <1501160156-30328-1-git-send-email-david.wu@rock-chips.com> <1501160540-30662-1-git-send-email-david.wu@rock-chips.com> <20170727134834.GD18666@lunn.ch> <65ae1747-4dff-b1d8-8aa3-684fc8c7809a@gmail.com> <69ad9443-ff65-8e49-df68-7e5e6c812d45@rock-chips.com> From: Chen-Yu Tsai Date: Wed, 2 Aug 2017 11:46:57 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 05/11] net: stmmac: dwmac-rk: Add internal phy support To: "David.Wu" Cc: Florian Fainelli , Andrew Lunn , Mark Rutland , Tao Huang , hwg@rock-chips.com, =?UTF-8?Q?Heiko_St=C3=BCbner?= , Arnd Bergmann , devicetree , Catalin Marinas , Will Deacon , Russell King , linux-kernel , "open list:ARM/Rockchip SoC..." , Rob Herring , netdev , Olof Johansson , Giuseppe Cavallaro , David Miller , linux-arm-kernel , alexandre.torgue@st.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi David, Florian, Andrew (resent in plain text) On Fri, Jul 28, 2017 at 2:56 PM, David.Wu wrote: > > Hi Florian, > > 在 2017/7/28 0:54, Florian Fainelli 写道: >> >> - if you need knowledge about this PHY connection type prior to binding >> the PHY device and its driver (that is, before of_phy_connect()) we >> could add a boolean property e.g: "phy-is-internal" that allows us to >> know that, or we can have a new phy-mode value, e.g: "internal-rmii" >> which describes that, either way would probably be fine, but the former >> scales better >> > > Using "phy-is-internal" is very helpful, but it is easy to confuse with > the real internal PHY, may we use the other words like phy is inlined. If "internal" is confusing, would "phy-is-integrated" in the MAC node work? Either way we would like to have a definitive solution to this. Our dwmac-sun8i driver is already in v4.13-rc1, with a somewhat flaky method of knowing whether the internal PHY is used (phy-mode = "mii"). We really want a fix for this release, otherwise we would be force to revert either the internal PHY part or the whole driver. ChenYu > >> Then again, using phy-mode = "internal" even though this is Reduced MII >> is not big of a deal IMHO as long as there is no loss of information and >> that internal de-facto means internal reduced MII for instance. >> -- > > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chen-Yu Tsai Subject: Re: [PATCH v2 05/11] net: stmmac: dwmac-rk: Add internal phy support Date: Wed, 2 Aug 2017 11:46:57 +0800 Message-ID: References: <1501160156-30328-1-git-send-email-david.wu@rock-chips.com> <1501160540-30662-1-git-send-email-david.wu@rock-chips.com> <20170727134834.GD18666@lunn.ch> <65ae1747-4dff-b1d8-8aa3-684fc8c7809a@gmail.com> <69ad9443-ff65-8e49-df68-7e5e6c812d45@rock-chips.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Cc: Florian Fainelli , Andrew Lunn , Mark Rutland , Tao Huang , hwg-TNX95d0MmH7DzftRWevZcw@public.gmane.org, =?UTF-8?Q?Heiko_St=C3=BCbner?= , Arnd Bergmann , devicetree , Catalin Marinas , Will Deacon , Russell King , linux-kernel , "open list:ARM/Rockchip SoC..." , Rob Herring , netdev , Olof Johansson , Giuseppe Cavallaro , David Miller , linux-arm-kernel , alex To: "David.Wu" Return-path: In-Reply-To: <69ad9443-ff65-8e49-df68-7e5e6c812d45-TNX95d0MmH7DzftRWevZcw@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: netdev.vger.kernel.org Hi David, Florian, Andrew (resent in plain text) On Fri, Jul 28, 2017 at 2:56 PM, David.Wu wrote: > > Hi Florian, > > 在 2017/7/28 0:54, Florian Fainelli 写道: >> >> - if you need knowledge about this PHY connection type prior to binding >> the PHY device and its driver (that is, before of_phy_connect()) we >> could add a boolean property e.g: "phy-is-internal" that allows us to >> know that, or we can have a new phy-mode value, e.g: "internal-rmii" >> which describes that, either way would probably be fine, but the former >> scales better >> > > Using "phy-is-internal" is very helpful, but it is easy to confuse with > the real internal PHY, may we use the other words like phy is inlined. If "internal" is confusing, would "phy-is-integrated" in the MAC node work? Either way we would like to have a definitive solution to this. Our dwmac-sun8i driver is already in v4.13-rc1, with a somewhat flaky method of knowing whether the internal PHY is used (phy-mode = "mii"). We really want a fix for this release, otherwise we would be force to revert either the internal PHY part or the whole driver. ChenYu > >> Then again, using phy-mode = "internal" even though this is Reduced MII >> is not big of a deal IMHO as long as there is no loss of information and >> that internal de-facto means internal reduced MII for instance. >> -- > > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: wens@csie.org (Chen-Yu Tsai) Date: Wed, 2 Aug 2017 11:46:57 +0800 Subject: [PATCH v2 05/11] net: stmmac: dwmac-rk: Add internal phy support In-Reply-To: <69ad9443-ff65-8e49-df68-7e5e6c812d45@rock-chips.com> References: <1501160156-30328-1-git-send-email-david.wu@rock-chips.com> <1501160540-30662-1-git-send-email-david.wu@rock-chips.com> <20170727134834.GD18666@lunn.ch> <65ae1747-4dff-b1d8-8aa3-684fc8c7809a@gmail.com> <69ad9443-ff65-8e49-df68-7e5e6c812d45@rock-chips.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi David, Florian, Andrew (resent in plain text) On Fri, Jul 28, 2017 at 2:56 PM, David.Wu wrote: > > Hi Florian, > > ? 2017/7/28 0:54, Florian Fainelli ??: >> >> - if you need knowledge about this PHY connection type prior to binding >> the PHY device and its driver (that is, before of_phy_connect()) we >> could add a boolean property e.g: "phy-is-internal" that allows us to >> know that, or we can have a new phy-mode value, e.g: "internal-rmii" >> which describes that, either way would probably be fine, but the former >> scales better >> > > Using "phy-is-internal" is very helpful, but it is easy to confuse with > the real internal PHY, may we use the other words like phy is inlined. If "internal" is confusing, would "phy-is-integrated" in the MAC node work? Either way we would like to have a definitive solution to this. Our dwmac-sun8i driver is already in v4.13-rc1, with a somewhat flaky method of knowing whether the internal PHY is used (phy-mode = "mii"). We really want a fix for this release, otherwise we would be force to revert either the internal PHY part or the whole driver. ChenYu > >> Then again, using phy-mode = "internal" even though this is Reduced MII >> is not big of a deal IMHO as long as there is no loss of information and >> that internal de-facto means internal reduced MII for instance. >> -- > > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel at lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel