All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chen-Yu Tsai <wens@kernel.org>
To: Michael Riesch <michael.riesch@wolfvision.net>
Cc: netdev <netdev@vger.kernel.org>,
	"moderated list:ARM/STM32 ARCHITECTURE" 
	<linux-stm32@st-md-mailman.stormreply.com>,
	"open list:ARM/Rockchip SoC..."
	<linux-rockchip@lists.infradead.org>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Giuseppe Cavallaro <peppe.cavallaro@st.com>,
	Alexandre Torgue <alexandre.torgue@foss.st.com>,
	Jose Abreu <joabreu@synopsys.com>,
	"David S . Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	Maxime Coquelin <mcoquelin.stm32@gmail.com>
Subject: Re: [PATCH] net: stmmac: dwmac-rk: fix unbalanced pm_runtime_enable warnings
Date: Mon, 30 Aug 2021 01:48:19 +0800	[thread overview]
Message-ID: <CAGb2v67Duk_56fOKVwZsYn2HKJ99o8WJ+d4jetD2UjDsAt9BcA@mail.gmail.com> (raw)
In-Reply-To: <20210823143754.14294-1-michael.riesch@wolfvision.net>

Hi,

On Mon, Aug 23, 2021 at 10:39 PM Michael Riesch
<michael.riesch@wolfvision.net> wrote:
>
> This reverts commit 2c896fb02e7f65299646f295a007bda043e0f382
> "net: stmmac: dwmac-rk: add pd_gmac support for rk3399" and fixes
> unbalanced pm_runtime_enable warnings.
>
> In the commit to be reverted, support for power management was
> introduced to the Rockchip glue code. Later, power management support
> was introduced to the stmmac core code, resulting in multiple
> invocations of pm_runtime_{enable,disable,get_sync,put_sync}.
>
> The multiple invocations happen in rk_gmac_powerup and
> stmmac_{dvr_probe, resume} as well as in rk_gmac_powerdown and
> stmmac_{dvr_remove, suspend}, respectively, which are always called
> in conjunction.
>
> Signed-off-by: Michael Riesch <michael.riesch@wolfvision.net>

I just found that Ethernet stopped working on my RK3399 devices,
and I bisected it down to this patch.

The symptom I see is no DHCP responses, either because the request
isn't getting sent over the wire, or the response isn't getting
received. The PHY seems to be working correctly.


ChenYu

WARNING: multiple messages have this Message-ID
From: Chen-Yu Tsai <wens@kernel.org>
To: Michael Riesch <michael.riesch@wolfvision.net>
Cc: netdev <netdev@vger.kernel.org>,
	"moderated list:ARM/STM32 ARCHITECTURE"
	<linux-stm32@st-md-mailman.stormreply.com>,
	 "open list:ARM/Rockchip SoC..."
	<linux-rockchip@lists.infradead.org>,
	 linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	 linux-kernel <linux-kernel@vger.kernel.org>,
	Giuseppe Cavallaro <peppe.cavallaro@st.com>,
	 Alexandre Torgue <alexandre.torgue@foss.st.com>,
	Jose Abreu <joabreu@synopsys.com>,
	 "David S . Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	 Maxime Coquelin <mcoquelin.stm32@gmail.com>
Subject: Re: [PATCH] net: stmmac: dwmac-rk: fix unbalanced pm_runtime_enable warnings
Date: Mon, 30 Aug 2021 01:48:19 +0800	[thread overview]
Message-ID: <CAGb2v67Duk_56fOKVwZsYn2HKJ99o8WJ+d4jetD2UjDsAt9BcA@mail.gmail.com> (raw)
In-Reply-To: <20210823143754.14294-1-michael.riesch@wolfvision.net>

Hi,

On Mon, Aug 23, 2021 at 10:39 PM Michael Riesch
<michael.riesch@wolfvision.net> wrote:
>
> This reverts commit 2c896fb02e7f65299646f295a007bda043e0f382
> "net: stmmac: dwmac-rk: add pd_gmac support for rk3399" and fixes
> unbalanced pm_runtime_enable warnings.
>
> In the commit to be reverted, support for power management was
> introduced to the Rockchip glue code. Later, power management support
> was introduced to the stmmac core code, resulting in multiple
> invocations of pm_runtime_{enable,disable,get_sync,put_sync}.
>
> The multiple invocations happen in rk_gmac_powerup and
> stmmac_{dvr_probe, resume} as well as in rk_gmac_powerdown and
> stmmac_{dvr_remove, suspend}, respectively, which are always called
> in conjunction.
>
> Signed-off-by: Michael Riesch <michael.riesch@wolfvision.net>

I just found that Ethernet stopped working on my RK3399 devices,
and I bisected it down to this patch.

The symptom I see is no DHCP responses, either because the request
isn't getting sent over the wire, or the response isn't getting
received. The PHY seems to be working correctly.


ChenYu

_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

WARNING: multiple messages have this Message-ID
From: Chen-Yu Tsai <wens@kernel.org>
To: Michael Riesch <michael.riesch@wolfvision.net>
Cc: netdev <netdev@vger.kernel.org>,
	"moderated list:ARM/STM32 ARCHITECTURE"
	<linux-stm32@st-md-mailman.stormreply.com>,
	 "open list:ARM/Rockchip SoC..."
	<linux-rockchip@lists.infradead.org>,
	 linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	 linux-kernel <linux-kernel@vger.kernel.org>,
	Giuseppe Cavallaro <peppe.cavallaro@st.com>,
	 Alexandre Torgue <alexandre.torgue@foss.st.com>,
	Jose Abreu <joabreu@synopsys.com>,
	 "David S . Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	 Maxime Coquelin <mcoquelin.stm32@gmail.com>
Subject: Re: [PATCH] net: stmmac: dwmac-rk: fix unbalanced pm_runtime_enable warnings
Date: Mon, 30 Aug 2021 01:48:19 +0800	[thread overview]
Message-ID: <CAGb2v67Duk_56fOKVwZsYn2HKJ99o8WJ+d4jetD2UjDsAt9BcA@mail.gmail.com> (raw)
In-Reply-To: <20210823143754.14294-1-michael.riesch@wolfvision.net>

Hi,

On Mon, Aug 23, 2021 at 10:39 PM Michael Riesch
<michael.riesch@wolfvision.net> wrote:
>
> This reverts commit 2c896fb02e7f65299646f295a007bda043e0f382
> "net: stmmac: dwmac-rk: add pd_gmac support for rk3399" and fixes
> unbalanced pm_runtime_enable warnings.
>
> In the commit to be reverted, support for power management was
> introduced to the Rockchip glue code. Later, power management support
> was introduced to the stmmac core code, resulting in multiple
> invocations of pm_runtime_{enable,disable,get_sync,put_sync}.
>
> The multiple invocations happen in rk_gmac_powerup and
> stmmac_{dvr_probe, resume} as well as in rk_gmac_powerdown and
> stmmac_{dvr_remove, suspend}, respectively, which are always called
> in conjunction.
>
> Signed-off-by: Michael Riesch <michael.riesch@wolfvision.net>

I just found that Ethernet stopped working on my RK3399 devices,
and I bisected it down to this patch.

The symptom I see is no DHCP responses, either because the request
isn't getting sent over the wire, or the response isn't getting
received. The PHY seems to be working correctly.


ChenYu

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2021-08-29 17:48 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-23 14:37 [PATCH] net: stmmac: dwmac-rk: fix unbalanced pm_runtime_enable warnings Michael Riesch
2021-08-23 14:37 ` Michael Riesch
2021-08-23 14:37 ` Michael Riesch
2021-08-23 16:44 ` Jakub Kicinski
2021-08-23 16:44   ` Jakub Kicinski
2021-08-23 16:44   ` Jakub Kicinski
2021-08-25  8:07   ` Michael Riesch
2021-08-25  8:07     ` Michael Riesch
2021-08-25  8:07     ` Michael Riesch
2021-08-25  9:50 ` patchwork-bot+netdevbpf
2021-08-25  9:50   ` patchwork-bot+netdevbpf
2021-08-25  9:50   ` patchwork-bot+netdevbpf
2021-08-29 17:48 ` Chen-Yu Tsai [this message]
2021-08-29 17:48   ` Chen-Yu Tsai
2021-08-29 17:48   ` Chen-Yu Tsai
2021-08-30  7:57   ` Michael Riesch
2021-08-30  7:57     ` Michael Riesch
2021-08-30  7:57     ` Michael Riesch
2021-08-30 13:49     ` Punit Agrawal
2021-08-30 13:49       ` Punit Agrawal
2021-08-30 13:49       ` Punit Agrawal
2021-08-30 14:10       ` Michael Riesch
2021-08-30 14:10         ` Michael Riesch
2021-08-30 14:10         ` Michael Riesch
2021-09-17  2:22         ` Qu Wenruo
2021-09-17  2:22           ` Qu Wenruo
2021-09-17  2:22           ` Qu Wenruo
2021-09-17  7:18           ` Punit Agrawal
2021-09-17  7:18             ` Punit Agrawal
2021-09-17  7:18             ` Punit Agrawal
2021-09-17  8:02             ` Qu Wenruo
2021-09-17  8:02               ` Qu Wenruo
2021-09-17  8:02               ` Qu Wenruo
2021-09-17 15:11               ` Punit Agrawal
2021-09-17 15:11                 ` Punit Agrawal
2021-09-17 15:11                 ` Punit Agrawal
2021-08-30 16:03     ` Chen-Yu Tsai
2021-08-30 16:03       ` Chen-Yu Tsai
2021-08-30 16:03       ` Chen-Yu Tsai
2021-08-30 19:22     ` Sasha Levin
2021-08-30 19:22       ` Sasha Levin
2021-08-30 19:22       ` Sasha Levin
2021-09-14  1:10 Ivan Babrou
2021-09-14 10:06 ` Michael Riesch
2021-09-14 10:06   ` Michael Riesch
2021-09-14 10:06   ` Michael Riesch
2021-09-14 13:39   ` Sebastian Döring
2021-09-14 13:39     ` Sebastian Döring
2021-09-14 13:39     ` Sebastian Döring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAGb2v67Duk_56fOKVwZsYn2HKJ99o8WJ+d4jetD2UjDsAt9BcA@mail.gmail.com \
    --to=wens@kernel.org \
    --cc=alexandre.torgue@foss.st.com \
    --cc=davem@davemloft.net \
    --cc=joabreu@synopsys.com \
    --cc=kuba@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=michael.riesch@wolfvision.net \
    --cc=netdev@vger.kernel.org \
    --cc=peppe.cavallaro@st.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.