From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E605C4320A for ; Sun, 29 Aug 2021 17:48:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D2F1360F4B for ; Sun, 29 Aug 2021 17:48:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231747AbhH2Rt1 (ORCPT ); Sun, 29 Aug 2021 13:49:27 -0400 Received: from mail.kernel.org ([198.145.29.99]:38874 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229665AbhH2RtZ (ORCPT ); Sun, 29 Aug 2021 13:49:25 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 5921360E97; Sun, 29 Aug 2021 17:48:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1630259313; bh=Ng8Nc7RPjC5XZnL4EXuDtogqZsofQfD04ok2tzTdyg0=; h=References:In-Reply-To:Reply-To:From:Date:Subject:To:Cc:From; b=WfLgDYhad3SWUz1Q4kjSXblwrfvtrwvQKrBBbqTsJgc9VEDQ7j0W46HWUbQGj6Q+K DZDilVD4HVaFbbPrRc8sjLPWJaCJC4+o6+hqJ5NSmlfeSgwh6w+Lyl0XGSun/MyOYS /kMm/O4VXOV2YzUvKbT/dhKfQ09ka2cwsUosXz3fBa7njXBw8QLnsVNX0+CVascDjS mzuavtotaNgLVb7fG/UEOXwC0XMAyhu8HtoU84+2E+RG7f9L53p2auRsy+l4OtyvGp al8f3KENJLJHQGaLVbQg3LBtb9vQdUIG7d2YiDYqdV/OB4oJVvFSk4n/agQFy6pSKd LBScUxJf9dl/A== Received: by mail-lf1-f42.google.com with SMTP id m28so26330194lfj.6; Sun, 29 Aug 2021 10:48:33 -0700 (PDT) X-Gm-Message-State: AOAM531+JW2guyzl/BpLcsrmyMz1azd4agHBm+iLivdlj3RueZpLlw5g M0wDuuWILenAgQpUh2s1g0HRtyQhUA7TzyWSIgg= X-Google-Smtp-Source: ABdhPJyB1nMr9MC5DfmQcKkSm3lO+DjPQnAw0j9giP2Ell6A/NFUpcvTKa18StEugRVNKMxhup/rEojB0Viq1QaPQ5w= X-Received: by 2002:a05:6512:3f89:: with SMTP id x9mr14794257lfa.233.1630259311683; Sun, 29 Aug 2021 10:48:31 -0700 (PDT) MIME-Version: 1.0 References: <20210823143754.14294-1-michael.riesch@wolfvision.net> In-Reply-To: <20210823143754.14294-1-michael.riesch@wolfvision.net> Reply-To: wens@kernel.org From: Chen-Yu Tsai Date: Mon, 30 Aug 2021 01:48:19 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] net: stmmac: dwmac-rk: fix unbalanced pm_runtime_enable warnings To: Michael Riesch Cc: netdev , "moderated list:ARM/STM32 ARCHITECTURE" , "open list:ARM/Rockchip SoC..." , linux-arm-kernel , linux-kernel , Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , "David S . Miller" , Jakub Kicinski , Maxime Coquelin Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Mon, Aug 23, 2021 at 10:39 PM Michael Riesch wrote: > > This reverts commit 2c896fb02e7f65299646f295a007bda043e0f382 > "net: stmmac: dwmac-rk: add pd_gmac support for rk3399" and fixes > unbalanced pm_runtime_enable warnings. > > In the commit to be reverted, support for power management was > introduced to the Rockchip glue code. Later, power management support > was introduced to the stmmac core code, resulting in multiple > invocations of pm_runtime_{enable,disable,get_sync,put_sync}. > > The multiple invocations happen in rk_gmac_powerup and > stmmac_{dvr_probe, resume} as well as in rk_gmac_powerdown and > stmmac_{dvr_remove, suspend}, respectively, which are always called > in conjunction. > > Signed-off-by: Michael Riesch I just found that Ethernet stopped working on my RK3399 devices, and I bisected it down to this patch. The symptom I see is no DHCP responses, either because the request isn't getting sent over the wire, or the response isn't getting received. The PHY seems to be working correctly. ChenYu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ABFFDC432BE for ; Sun, 29 Aug 2021 17:48:52 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4C62B601FD for ; Sun, 29 Aug 2021 17:48:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 4C62B601FD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Reply-To:List-Subscribe:List-Help: List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date :From:In-Reply-To:References:MIME-Version:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/edH0/Rm7UQ9Rf+64r/UcqIJXQgAiCFTBUmDzVdPeuI=; b=sDpX8JFAw0tL4g kd83NUw5qqcK1CeYU+EJK/pVJV8xqgFfJ7NlACm7/FSQuPWz9boP3YxqBB59V1j+WRj5ubCqzRDoZ zrD9hKENQcRT0CFSavgzIMxsoI/LpBdoknk6okXzV8WCW9e54z61OD1kXLDFanCxrdaGa9MLYbWCo kGLQjjf/UGH85qDfo8JRpikhujTykmDqiyLFLKDloitJpKbpqVfki929u8rWK0EwoAIt7vEmL9Hab i/HyNK2+wLBhHFKEVw6rgE3cd36e84hY3f4TOHEy9hsXATOtFbHIgU4jx6xhcCpNInWeZ8D+sxHan elGAUOM6MiYDro1KMiAA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mKOvH-00FpcQ-8P; Sun, 29 Aug 2021 17:48:47 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mKOv4-00FpbH-KZ; Sun, 29 Aug 2021 17:48:35 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 5E5A860F44; Sun, 29 Aug 2021 17:48:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1630259313; bh=Ng8Nc7RPjC5XZnL4EXuDtogqZsofQfD04ok2tzTdyg0=; h=References:In-Reply-To:Reply-To:From:Date:Subject:To:Cc:From; b=WfLgDYhad3SWUz1Q4kjSXblwrfvtrwvQKrBBbqTsJgc9VEDQ7j0W46HWUbQGj6Q+K DZDilVD4HVaFbbPrRc8sjLPWJaCJC4+o6+hqJ5NSmlfeSgwh6w+Lyl0XGSun/MyOYS /kMm/O4VXOV2YzUvKbT/dhKfQ09ka2cwsUosXz3fBa7njXBw8QLnsVNX0+CVascDjS mzuavtotaNgLVb7fG/UEOXwC0XMAyhu8HtoU84+2E+RG7f9L53p2auRsy+l4OtyvGp al8f3KENJLJHQGaLVbQg3LBtb9vQdUIG7d2YiDYqdV/OB4oJVvFSk4n/agQFy6pSKd LBScUxJf9dl/A== Received: by mail-lf1-f41.google.com with SMTP id bq28so26323950lfb.7; Sun, 29 Aug 2021 10:48:33 -0700 (PDT) X-Gm-Message-State: AOAM531oqXjbiN7Di9QELqMcJpOe4h4tVDdG5BzyihG8svmqxYDXHmnq IacBGoelD3aba01ieRmg7I+9b919h+QlU3Qdv6Q= X-Google-Smtp-Source: ABdhPJyB1nMr9MC5DfmQcKkSm3lO+DjPQnAw0j9giP2Ell6A/NFUpcvTKa18StEugRVNKMxhup/rEojB0Viq1QaPQ5w= X-Received: by 2002:a05:6512:3f89:: with SMTP id x9mr14794257lfa.233.1630259311683; Sun, 29 Aug 2021 10:48:31 -0700 (PDT) MIME-Version: 1.0 References: <20210823143754.14294-1-michael.riesch@wolfvision.net> In-Reply-To: <20210823143754.14294-1-michael.riesch@wolfvision.net> From: Chen-Yu Tsai Date: Mon, 30 Aug 2021 01:48:19 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] net: stmmac: dwmac-rk: fix unbalanced pm_runtime_enable warnings To: Michael Riesch Cc: netdev , "moderated list:ARM/STM32 ARCHITECTURE" , "open list:ARM/Rockchip SoC..." , linux-arm-kernel , linux-kernel , Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , "David S . Miller" , Jakub Kicinski , Maxime Coquelin X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210829_104834_736012_40A47004 X-CRM114-Status: GOOD ( 11.70 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: wens@kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org Hi, On Mon, Aug 23, 2021 at 10:39 PM Michael Riesch wrote: > > This reverts commit 2c896fb02e7f65299646f295a007bda043e0f382 > "net: stmmac: dwmac-rk: add pd_gmac support for rk3399" and fixes > unbalanced pm_runtime_enable warnings. > > In the commit to be reverted, support for power management was > introduced to the Rockchip glue code. Later, power management support > was introduced to the stmmac core code, resulting in multiple > invocations of pm_runtime_{enable,disable,get_sync,put_sync}. > > The multiple invocations happen in rk_gmac_powerup and > stmmac_{dvr_probe, resume} as well as in rk_gmac_powerdown and > stmmac_{dvr_remove, suspend}, respectively, which are always called > in conjunction. > > Signed-off-by: Michael Riesch I just found that Ethernet stopped working on my RK3399 devices, and I bisected it down to this patch. The symptom I see is no DHCP responses, either because the request isn't getting sent over the wire, or the response isn't getting received. The PHY seems to be working correctly. ChenYu _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 697A4C432BE for ; Sun, 29 Aug 2021 17:51:22 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1AF7A60E90 for ; Sun, 29 Aug 2021 17:51:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 1AF7A60E90 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Reply-To:List-Subscribe:List-Help: List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date :From:In-Reply-To:References:MIME-Version:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Nb8ntXYyb9Go5j4Jja1FnRODAxcvbJf3wtLDPqFK08c=; b=zmWNOmdPywwWde leYmBpSJ1WJIud29cKedcfkTbTdD/WHyQmjdzgkviMTsAJ1vdVjdW6zHGbGNbFx75u96nzjBtHX1B WhRdNSGn8GIN57kH6S3CsDo1I9DOtFuTX/znXwiEuUYVeXWZrRvDhxsQdwKPj5NZlOay5GQ7OtOA+ 3Uk6N8AOJlFPG2dsMwYtj9RxuDsPBU9XJ/JW/AV5S49tGCacO04eQyDp+u4Nkl/kfSP4SZ3WODpUB er2JbaRH51CZn9EgmQKdChywdek+FrhZujK7Vwqk8gWjG8CnJTU0g+EB8eIkFqN2JhUjghztaYXpI VMQDCW0sDZRnhjRkC5SQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mKOv8-00Fpbl-0z; Sun, 29 Aug 2021 17:48:38 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mKOv4-00FpbH-KZ; Sun, 29 Aug 2021 17:48:35 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 5E5A860F44; Sun, 29 Aug 2021 17:48:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1630259313; bh=Ng8Nc7RPjC5XZnL4EXuDtogqZsofQfD04ok2tzTdyg0=; h=References:In-Reply-To:Reply-To:From:Date:Subject:To:Cc:From; b=WfLgDYhad3SWUz1Q4kjSXblwrfvtrwvQKrBBbqTsJgc9VEDQ7j0W46HWUbQGj6Q+K DZDilVD4HVaFbbPrRc8sjLPWJaCJC4+o6+hqJ5NSmlfeSgwh6w+Lyl0XGSun/MyOYS /kMm/O4VXOV2YzUvKbT/dhKfQ09ka2cwsUosXz3fBa7njXBw8QLnsVNX0+CVascDjS mzuavtotaNgLVb7fG/UEOXwC0XMAyhu8HtoU84+2E+RG7f9L53p2auRsy+l4OtyvGp al8f3KENJLJHQGaLVbQg3LBtb9vQdUIG7d2YiDYqdV/OB4oJVvFSk4n/agQFy6pSKd LBScUxJf9dl/A== Received: by mail-lf1-f41.google.com with SMTP id bq28so26323950lfb.7; Sun, 29 Aug 2021 10:48:33 -0700 (PDT) X-Gm-Message-State: AOAM531oqXjbiN7Di9QELqMcJpOe4h4tVDdG5BzyihG8svmqxYDXHmnq IacBGoelD3aba01ieRmg7I+9b919h+QlU3Qdv6Q= X-Google-Smtp-Source: ABdhPJyB1nMr9MC5DfmQcKkSm3lO+DjPQnAw0j9giP2Ell6A/NFUpcvTKa18StEugRVNKMxhup/rEojB0Viq1QaPQ5w= X-Received: by 2002:a05:6512:3f89:: with SMTP id x9mr14794257lfa.233.1630259311683; Sun, 29 Aug 2021 10:48:31 -0700 (PDT) MIME-Version: 1.0 References: <20210823143754.14294-1-michael.riesch@wolfvision.net> In-Reply-To: <20210823143754.14294-1-michael.riesch@wolfvision.net> From: Chen-Yu Tsai Date: Mon, 30 Aug 2021 01:48:19 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] net: stmmac: dwmac-rk: fix unbalanced pm_runtime_enable warnings To: Michael Riesch Cc: netdev , "moderated list:ARM/STM32 ARCHITECTURE" , "open list:ARM/Rockchip SoC..." , linux-arm-kernel , linux-kernel , Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , "David S . Miller" , Jakub Kicinski , Maxime Coquelin X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210829_104834_736012_40A47004 X-CRM114-Status: GOOD ( 11.70 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: wens@kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On Mon, Aug 23, 2021 at 10:39 PM Michael Riesch wrote: > > This reverts commit 2c896fb02e7f65299646f295a007bda043e0f382 > "net: stmmac: dwmac-rk: add pd_gmac support for rk3399" and fixes > unbalanced pm_runtime_enable warnings. > > In the commit to be reverted, support for power management was > introduced to the Rockchip glue code. Later, power management support > was introduced to the stmmac core code, resulting in multiple > invocations of pm_runtime_{enable,disable,get_sync,put_sync}. > > The multiple invocations happen in rk_gmac_powerup and > stmmac_{dvr_probe, resume} as well as in rk_gmac_powerdown and > stmmac_{dvr_remove, suspend}, respectively, which are always called > in conjunction. > > Signed-off-by: Michael Riesch I just found that Ethernet stopped working on my RK3399 devices, and I bisected it down to this patch. The symptom I see is no DHCP responses, either because the request isn't getting sent over the wire, or the response isn't getting received. The PHY seems to be working correctly. ChenYu _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel