From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ua1-f51.google.com (mail-ua1-f51.google.com [209.85.222.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3461872 for ; Mon, 29 Nov 2021 17:16:45 +0000 (UTC) Received: by mail-ua1-f51.google.com with SMTP id i6so35538898uae.6 for ; Mon, 29 Nov 2021 09:16:45 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:reply-to :from:date:message-id:subject:to:cc; bh=fBdrgGv6tktc6qHM+QrJHNp1TEWCu/zp5THtBD27tLk=; b=rjxknCcPOAStnMDAQbKHyJI1aDfCMfIV9eJomig5cBf+LG/0xQsSwrsF1vLcAum1D2 UgYjwcV8HQOhIWxTJn6MOFUOoqecd7Z/mLgbmeLN6P/1bNbPG1aroYQ1B+wo551UHbnR SXyV1cjjMzRvmbuOefZWiEYqS0PbHSzdwxDnnnACMLOPtnP2KEchdcK6ZrpZfcqTyoLg 5ZPnb6+iHGFhUjbotSsy0cAoTr1AtpVd+cpeVBS+zQNAG0HTrVCVLanV8zsq2hPn2AON ZOf3+p6+8umNphCwvZvM10+pizxbyV9rAskDBYXKPT7zQEcJObXosWe3HvI0FwvLrsCA c4MQ== X-Gm-Message-State: AOAM533NBXisECoubhpVAJ3U109FJPIIr1ZWN7PgOWSs0YTfKHTi9km6 iMt2hGoWGNDtf8ZGm4ZlmPnR6S02BuWoew== X-Google-Smtp-Source: ABdhPJwhxHFlnMWt/DfLa2tYvxYePW3YouE4KTiHHbVI8bLnrIInn4+35cbW3j4JUujJjA54zrzW/g== X-Received: by 2002:a67:6bc6:: with SMTP id g189mr35537496vsc.63.1638206203981; Mon, 29 Nov 2021 09:16:43 -0800 (PST) Received: from mail-ua1-f45.google.com (mail-ua1-f45.google.com. [209.85.222.45]) by smtp.gmail.com with ESMTPSA id q20sm9608172uae.17.2021.11.29.09.16.43 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 29 Nov 2021 09:16:43 -0800 (PST) Received: by mail-ua1-f45.google.com with SMTP id ay21so35551712uab.12 for ; Mon, 29 Nov 2021 09:16:43 -0800 (PST) X-Received: by 2002:ab0:6d8c:: with SMTP id m12mr52235612uah.105.1638206203112; Mon, 29 Nov 2021 09:16:43 -0800 (PST) Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20211129165510.370717-1-jernej.skrabec@gmail.com> In-Reply-To: <20211129165510.370717-1-jernej.skrabec@gmail.com> Reply-To: wens@csie.org From: Chen-Yu Tsai Date: Tue, 30 Nov 2021 01:16:31 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2] ARM: dts: sun8i: Adjust power key nodes To: Jernej Skrabec Cc: Maxime Ripard , Rob Herring , devicetree , linux-arm-kernel , linux-sunxi@lists.linux.dev, linux-kernel , Michael Klein Content-Type: text/plain; charset="UTF-8" On Tue, Nov 30, 2021 at 12:55 AM Jernej Skrabec wrote: > > Several H3 and one H2+ board have power key nodes, which are slightly > off. Some are missing wakeup-source property and some have BTN_0 code > assigned instead of KEY_POWER. It might have been that after shutdown there was really no way to "power on" the board with these GPIO power keys, so we didn't use KEY_POWER for them? > Adjust them, so they can function as intended by designer. > > Co-developed-by: Michael Klein > Signed-off-by: Michael Klein > Signed-off-by: Jernej Skrabec Acked-by: Chen-Yu Tsai From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 88D1EC433FE for ; Mon, 29 Nov 2021 17:21:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Reply-To:List-Subscribe:List-Help: List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date :From:In-Reply-To:References:MIME-Version:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=fXtHQCndfQYac5akLGEmq/Ir7koz2m9c5rfGRADTZ2k=; b=1DlwmiLA3ZT8JM Jb9aiVWJ1yitpxJdrPKFiKJx8tvPta7Vc96bcU72n166D1bD4d+q5ysXRTVeJZJiyAyA5ISsN0LNM T30PnVSx9JYUN7pz78d8ptFon4QyxMqn+sT4pUjE8E5toCnPU0aR1KfENdvVFJqBpU17rQMnq4dp5 1HkeAq0/5AM1lCZFimdJzy17RXcA3KVgGUhqCKNJKhE1Pa18uOPABLaoNgyBhdYLcIijm8TfnFQ1n ZMkruF5hL24N+5aMna9mVgX9/jvSgdJ5jr2ebWkjmEcSEhipUgNGtCQzNzAhwhCVvDrcqrVtyvDo5 yDgCO72S31rpZJIfsIrQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mrkGn-001ZdJ-Cs; Mon, 29 Nov 2021 17:16:49 +0000 Received: from mail-ua1-f49.google.com ([209.85.222.49]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mrkGj-001ZcL-R5 for linux-arm-kernel@lists.infradead.org; Mon, 29 Nov 2021 17:16:47 +0000 Received: by mail-ua1-f49.google.com with SMTP id p37so35575457uae.8 for ; Mon, 29 Nov 2021 09:16:44 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:reply-to :from:date:message-id:subject:to:cc; bh=fBdrgGv6tktc6qHM+QrJHNp1TEWCu/zp5THtBD27tLk=; b=YcwZPt0xyUHGw58WfYG5Lx4e6uqsC8jTo+slr9neZ/QtK1SxORWAGqB1HLO4iJJyb/ y3au/rc+W1U0rHgW34pJRDy7uhajNL3t9dyobdR1TyBqH1Ae6HQJJSmB2YHk3P4uYCAP bGmPnsBb5QtPwiiozv8bcSrLhEDl0AFMtVfHGRFJylUGbzbv7B6K1lfPuZ/2Mx4WVmvD 32FdtwHJjUHz/JClTJ+V6nzDlQCZmsiGLKEY3X4gTG0vEGYUM4u0rMrN8OUrn8K1cImV BA7E0pclyrLSFlGv+KCrCDc7/9iS7pPsNjBZ+bhzjFmnLPMqQxy4UMqTiV4Z2XFZ5k0a R2Ww== X-Gm-Message-State: AOAM5319ECz5ru9MKo7H+/FlDxoJaXg1tiAaF2Jair6E31fnAFFWpSbp WEFaWS+vPG4NJAgoQWYtvxq14G+fRmt9eA== X-Google-Smtp-Source: ABdhPJyFNUPZfmc1SqA8de3Zw+uuKoO5ndmPUxxVQ79xVzw28WykP2FsSNeDZQpq73GIEQutjo+o2g== X-Received: by 2002:a67:ab4c:: with SMTP id k12mr34024334vsh.73.1638206203753; Mon, 29 Nov 2021 09:16:43 -0800 (PST) Received: from mail-ua1-f49.google.com (mail-ua1-f49.google.com. [209.85.222.49]) by smtp.gmail.com with ESMTPSA id q9sm8525865vkn.44.2021.11.29.09.16.43 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 29 Nov 2021 09:16:43 -0800 (PST) Received: by mail-ua1-f49.google.com with SMTP id az37so35543435uab.13 for ; Mon, 29 Nov 2021 09:16:43 -0800 (PST) X-Received: by 2002:ab0:6d8c:: with SMTP id m12mr52235612uah.105.1638206203112; Mon, 29 Nov 2021 09:16:43 -0800 (PST) MIME-Version: 1.0 References: <20211129165510.370717-1-jernej.skrabec@gmail.com> In-Reply-To: <20211129165510.370717-1-jernej.skrabec@gmail.com> From: Chen-Yu Tsai Date: Tue, 30 Nov 2021 01:16:31 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2] ARM: dts: sun8i: Adjust power key nodes To: Jernej Skrabec Cc: Maxime Ripard , Rob Herring , devicetree , linux-arm-kernel , linux-sunxi@lists.linux.dev, linux-kernel , Michael Klein X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211129_091645_898664_5752D3EB X-CRM114-Status: GOOD ( 12.88 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: wens@csie.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Nov 30, 2021 at 12:55 AM Jernej Skrabec wrote: > > Several H3 and one H2+ board have power key nodes, which are slightly > off. Some are missing wakeup-source property and some have BTN_0 code > assigned instead of KEY_POWER. It might have been that after shutdown there was really no way to "power on" the board with these GPIO power keys, so we didn't use KEY_POWER for them? > Adjust them, so they can function as intended by designer. > > Co-developed-by: Michael Klein > Signed-off-by: Michael Klein > Signed-off-by: Jernej Skrabec Acked-by: Chen-Yu Tsai _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel