From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 035CEC7619B for ; Mon, 17 Feb 2020 03:28:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D55E320659 for ; Mon, 17 Feb 2020 03:28:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727996AbgBQD20 (ORCPT ); Sun, 16 Feb 2020 22:28:26 -0500 Received: from mail-ed1-f66.google.com ([209.85.208.66]:44000 "EHLO mail-ed1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726672AbgBQD20 (ORCPT ); Sun, 16 Feb 2020 22:28:26 -0500 Received: by mail-ed1-f66.google.com with SMTP id dc19so18936309edb.10 for ; Sun, 16 Feb 2020 19:28:25 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=1Vf+s0xiHFIhPppg6jnzm8oEYQMOnPl6UhM4IxCWOkI=; b=d8XrT/PpEFtLqQMcqbVC4lJ9iMsyJ7ucf6yJGe6TJZYc8NunbTG3jLZ0PnYSCF3x7s eTba835O7ogTBjrMd18+M8JOcfw30Im4XquH5whRBJ5GSxO6PZOEugpK1N4HPpVkcoEa zPIrDnZ/OfGpKOPC92ivZcfeSdhFpZawmWUIeSjYD/m1XG4QgLnxel9IASgz8T/TVxZQ qhLnQ7cr8mDtYU4cNpQcgdhCQ5hXxXy4QGe/tcIcwrbI1xfU68usATYmDJh+2J2Be2MW q9d6KUdKvyXzDXtPyjicN7sQtSzBrTGu1/eIxGYpYORkJVeoTO2xrivB+n5/uUgqNuBO WxTg== X-Gm-Message-State: APjAAAUeSkw8HMoLYJdx2xlAyMFQ6QZi0jRKePnZ39ZcDwx2ltQUEVz7 KNIGwr9S05jfui/hJaoOvyx+5G8EqRs= X-Google-Smtp-Source: APXvYqz2rQdPnVbq6fNRmb0X38e3eVxbG/c+O8PeinhsztwIm01G1YZSi6vaghweWIE1g65NQD8l5A== X-Received: by 2002:a05:6402:1d28:: with SMTP id dh8mr12066144edb.383.1581910104172; Sun, 16 Feb 2020 19:28:24 -0800 (PST) Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com. [209.85.128.48]) by smtp.gmail.com with ESMTPSA id qw15sm810379ejb.92.2020.02.16.19.28.21 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 16 Feb 2020 19:28:23 -0800 (PST) Received: by mail-wm1-f48.google.com with SMTP id a6so16821310wme.2 for ; Sun, 16 Feb 2020 19:28:21 -0800 (PST) X-Received: by 2002:a1c:dc85:: with SMTP id t127mr20681900wmg.16.1581910101671; Sun, 16 Feb 2020 19:28:21 -0800 (PST) MIME-Version: 1.0 References: <20200217021813.53266-1-samuel@sholland.org> <20200217021813.53266-2-samuel@sholland.org> In-Reply-To: <20200217021813.53266-2-samuel@sholland.org> From: Chen-Yu Tsai Date: Mon, 17 Feb 2020 11:28:11 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 1/8] ASoC: sun50i-codec-analog: Fix duplicate use of ADC enable bits To: Samuel Holland Cc: Mark Brown , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Maxime Ripard , Vasily Khoruzhick , Luca Weiss , Linux-ALSA , linux-arm-kernel , linux-kernel , Ondrej Jirman Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 17, 2020 at 10:18 AM Samuel Holland wrote: > > The same enable bits are currently used for both the "Left/Right ADC" > and the "Left/Right ADC Mixer" widgets. This happens to work in practice > because the widgets are always enabled/disabled at the same time, but > each register bit should only be associated with a single widget. > > To keep symmetry with the DAC widgets, keep the bits on the ADC widgets, > and remove them from the ADC Mixer widgets. > > Fixes: 42371f327df0 ("ASoC: sunxi: Add new driver for Allwinner A64 codec's analog path controls") > Reported-by: Ondrej Jirman > Signed-off-by: Samuel Holland Acked-by: Chen-Yu Tsai From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F5B1C35242 for ; Mon, 17 Feb 2020 03:29:24 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9D41D20659 for ; Mon, 17 Feb 2020 03:29:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="Alg4H5eT" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9D41D20659 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=csie.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 05F6F829; Mon, 17 Feb 2020 04:28:32 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 05F6F829 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1581910162; bh=k3scjiPI9X3mZ3W7rEksvfq3n0aYlX9Ntu3gga5uSk8=; h=References:In-Reply-To:From:Date:To:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=Alg4H5eTWcGHhlYXC2WZ7Y558jH5vvJGxJrNDTUiAs4iM5CJ2/vjK7xnk9PtiVYg2 Z9TxXZcNL+lsT40As2/HyyPMqcoaMm/c1yQ6ftfNomasztA10El/dK8jN0zapzAlyI tb7bdaBmW8dsR0+3gyD1IrPBdgwA4bHQdO9YOB+s= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 7FF6FF80096; Mon, 17 Feb 2020 04:28:31 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id D13B8F80172; Mon, 17 Feb 2020 04:28:28 +0100 (CET) Received: from mail-ed1-f68.google.com (mail-ed1-f68.google.com [209.85.208.68]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 1C34DF800B6 for ; Mon, 17 Feb 2020 04:28:24 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 1C34DF800B6 Received: by mail-ed1-f68.google.com with SMTP id r21so19003235edq.0 for ; Sun, 16 Feb 2020 19:28:24 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=1Vf+s0xiHFIhPppg6jnzm8oEYQMOnPl6UhM4IxCWOkI=; b=PQ/msz70icM1DSyhgJ66wTIJptFB5Tnvjk/RXa3KoW7vtjOyUV5yZ2DENWNRLI07M1 Rvr/PshSOcAHozm4zDTYqU4QtymKlyPVzdiHlaPwGLwak9uKBxQYoioGe6TT50j23SoM ee4dWEj5ZTVD94o1CJXSKQIbQJgFweV89Yocirba6Kp3d7cYc9Wil8bHBqxgdMp+EwaV huc2FxvzgJGjHTRplJaqGRL3QEzWiDy9eJHJ3cbhg9r/ZC9TnTsrDMtWLb+WCG4ReNIu 8pjxkYdMwKORMwEZgU47k5lbSBc4FPK+cHXC81RckRsu3JiK+64Vavv8BcK+HzW16+K+ iZHA== X-Gm-Message-State: APjAAAVHSfK78Ve2re//OHDjMi/Xmi4N2wrr/SJ4D1Z2z+2GYO4eo9iE ruALMJbj8BKi/OhiyolDJOkuo5ft9PQ= X-Google-Smtp-Source: APXvYqxijx6unsr2kojVko02TDOhJzcCdA9TaJoDy/Wtfr11MMiapMFbmq2B5p4wz0bsVo5Q/DR1zA== X-Received: by 2002:a17:906:4a97:: with SMTP id x23mr12844149eju.66.1581910103536; Sun, 16 Feb 2020 19:28:23 -0800 (PST) Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com. [209.85.128.47]) by smtp.gmail.com with ESMTPSA id x6sm793271ejw.84.2020.02.16.19.28.21 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 16 Feb 2020 19:28:21 -0800 (PST) Received: by mail-wm1-f47.google.com with SMTP id a6so16821305wme.2 for ; Sun, 16 Feb 2020 19:28:21 -0800 (PST) X-Received: by 2002:a1c:dc85:: with SMTP id t127mr20681900wmg.16.1581910101671; Sun, 16 Feb 2020 19:28:21 -0800 (PST) MIME-Version: 1.0 References: <20200217021813.53266-1-samuel@sholland.org> <20200217021813.53266-2-samuel@sholland.org> In-Reply-To: <20200217021813.53266-2-samuel@sholland.org> From: Chen-Yu Tsai Date: Mon, 17 Feb 2020 11:28:11 +0800 X-Gmail-Original-Message-ID: Message-ID: To: Samuel Holland Cc: Ondrej Jirman , Luca Weiss , Linux-ALSA , linux-kernel , Takashi Iwai , Maxime Ripard , Liam Girdwood , Vasily Khoruzhick , Mark Brown , linux-arm-kernel Subject: Re: [alsa-devel] [PATCH 1/8] ASoC: sun50i-codec-analog: Fix duplicate use of ADC enable bits X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Mon, Feb 17, 2020 at 10:18 AM Samuel Holland wrote: > > The same enable bits are currently used for both the "Left/Right ADC" > and the "Left/Right ADC Mixer" widgets. This happens to work in practice > because the widgets are always enabled/disabled at the same time, but > each register bit should only be associated with a single widget. > > To keep symmetry with the DAC widgets, keep the bits on the ADC widgets, > and remove them from the ADC Mixer widgets. > > Fixes: 42371f327df0 ("ASoC: sunxi: Add new driver for Allwinner A64 codec's analog path controls") > Reported-by: Ondrej Jirman > Signed-off-by: Samuel Holland Acked-by: Chen-Yu Tsai _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/alsa-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8EBAC7619B for ; Mon, 17 Feb 2020 03:28:35 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B623921744 for ; Mon, 17 Feb 2020 03:28:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="VMiOu+S4" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B623921744 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=csie.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2EBblEucZE48hYo7TuUYU3cRO7TDB6GqLFRainh2Xjk=; b=VMiOu+S4JU/1mB monWzu8td6C4wtfhWTjrIErE016ZFiyRS0sGmxxIN2s+3xa0jeozyPhTROTUEAHgPP0GbSSUDK3Fv aAH17m9XttXlt7xqKZPov9ZIJgP4AwrZ5bIW4LOjmZNYNftWYqIFTQIp90UNEjCmvTw4ujWSgUIpH FOiNOdcT7cCmyVHB2ToG+u8Hzaz0owW0pJovM5b+dD2yWek+tXGP7kIMsYaSEPspMyrgHJopV7COm pY13CxU57hWfjTmFz0wqxV/YDJtN42k4/Nr9RoUkBSLyWZRd+vJeUC7hGLPjErgBGieG0M0VDafmQ gawr4JjL8+BT7vBrq91w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j3X5B-0000zf-3b; Mon, 17 Feb 2020 03:28:29 +0000 Received: from mail-ed1-f68.google.com ([209.85.208.68]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1j3X56-0000wM-Sj for linux-arm-kernel@lists.infradead.org; Mon, 17 Feb 2020 03:28:26 +0000 Received: by mail-ed1-f68.google.com with SMTP id p3so18978958edx.7 for ; Sun, 16 Feb 2020 19:28:24 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=1Vf+s0xiHFIhPppg6jnzm8oEYQMOnPl6UhM4IxCWOkI=; b=JKzwDZwytwv5j6Vk83hFYe5yJ66U+XdhNROcFMpahY7Jys4KsJ78eP0HtKxM1ciFdU wBv0u3DIbCjOVsBDgOTDM9tRQ239Dv8X/Q1/tHP+SejR1J94Cd3JmyhdQrM/VIUEXJB8 6HghmBf7aPU52ce4PCUvDxJcC5WlodyZgKPuiva4HTIIc+6K+BpDhYovf57P7VQlQDzp fKsH6XSvaHI5ekbMlHHnpzHtDCZyQNXFfv/00tDUM/c5hs+4gXzxqeNgXnas8CeXm9XB 2k2e4EsNUer5jo1vw2iMakkqYKUi/3pewqyrtuKzTrHswAmLg+q7GY2opc7lZmB+/d7O j1JA== X-Gm-Message-State: APjAAAWCVjPMelk/9sj4ROE9O00nslTVR/MAnqhIeLCYvnPjRo18SF/9 V5jZK4vmTOe1hA7KJIjjCqRbZ+/pzMY= X-Google-Smtp-Source: APXvYqw6s7wrsEzVak9m7OFEMuAC+6sZU2XOTsBqgjMimMCnibpm/Zi8oOsXyLVz7fS5xGD+txoDlA== X-Received: by 2002:a05:6402:12d2:: with SMTP id k18mr12560640edx.253.1581910102709; Sun, 16 Feb 2020 19:28:22 -0800 (PST) Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com. [209.85.128.44]) by smtp.gmail.com with ESMTPSA id m6sm814345ejb.51.2020.02.16.19.28.21 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 16 Feb 2020 19:28:22 -0800 (PST) Received: by mail-wm1-f44.google.com with SMTP id a9so16808114wmj.3 for ; Sun, 16 Feb 2020 19:28:21 -0800 (PST) X-Received: by 2002:a1c:dc85:: with SMTP id t127mr20681900wmg.16.1581910101671; Sun, 16 Feb 2020 19:28:21 -0800 (PST) MIME-Version: 1.0 References: <20200217021813.53266-1-samuel@sholland.org> <20200217021813.53266-2-samuel@sholland.org> In-Reply-To: <20200217021813.53266-2-samuel@sholland.org> From: Chen-Yu Tsai Date: Mon, 17 Feb 2020 11:28:11 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 1/8] ASoC: sun50i-codec-analog: Fix duplicate use of ADC enable bits To: Samuel Holland X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200216_192824_925129_39F98713 X-CRM114-Status: UNSURE ( 9.81 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ondrej Jirman , Luca Weiss , Linux-ALSA , linux-kernel , Takashi Iwai , Maxime Ripard , Liam Girdwood , Mark Brown , Jaroslav Kysela , linux-arm-kernel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Feb 17, 2020 at 10:18 AM Samuel Holland wrote: > > The same enable bits are currently used for both the "Left/Right ADC" > and the "Left/Right ADC Mixer" widgets. This happens to work in practice > because the widgets are always enabled/disabled at the same time, but > each register bit should only be associated with a single widget. > > To keep symmetry with the DAC widgets, keep the bits on the ADC widgets, > and remove them from the ADC Mixer widgets. > > Fixes: 42371f327df0 ("ASoC: sunxi: Add new driver for Allwinner A64 codec's analog path controls") > Reported-by: Ondrej Jirman > Signed-off-by: Samuel Holland Acked-by: Chen-Yu Tsai _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel