From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1CD0C4320A for ; Wed, 1 Sep 2021 03:13:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A18EC6101B for ; Wed, 1 Sep 2021 03:13:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241660AbhIADOO (ORCPT ); Tue, 31 Aug 2021 23:14:14 -0400 Received: from mail-lf1-f48.google.com ([209.85.167.48]:41668 "EHLO mail-lf1-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236106AbhIADOK (ORCPT ); Tue, 31 Aug 2021 23:14:10 -0400 Received: by mail-lf1-f48.google.com with SMTP id y34so3326540lfa.8; Tue, 31 Aug 2021 20:13:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:reply-to :from:date:message-id:subject:to:cc; bh=d55o8VRMccw0pmcvesAE8Rz9x+AqcwcttzF+pmxCfek=; b=E3BLgVvx+QOcTFO4S7s0rxlsuZ7TLLseKvuc3NCkzFENw07eXkgbCM+madxtJYH9PI WFGBEDRuaIU6T4La6kQMg2zzL1j5vkk1R+SglmjrVSJkn/970a5+XpNMV2sqfhi6FH+Y Vru2C8tG+VsJLwdExrR0ajywplEdUWr9aVSx27FXOhDfML3WnNpDj31oI17DU5Is3ObT 1xa6/Hwzn69LQidlp1vi7Cys/aSQ8Ty34jgMbhyimPPPWea27BlS40s/GL5nmK/I6Dmo 8F0o05NQv1d6gVPQZTRV6cLmI2ixiGGeXYAoXGvNabzc4vbHip7Ce/cuzijpNIM38rZ4 c6gg== X-Gm-Message-State: AOAM5301srTPIipdVR+SOWf0wjhVhD0VUWfT1BO4tMj+rRBFo4j2JECl vNKzsUuDeXLm/92pTMqNEnkOwaNCKMel/g== X-Google-Smtp-Source: ABdhPJwHLvqZyHza8PQP2FOiCndnruv1kADugN2L1a/jgRvlj4L9sgH/hDIblvQ+/wuVM753QFO1jA== X-Received: by 2002:a05:6512:4da:: with SMTP id w26mr10844837lfq.576.1630465993065; Tue, 31 Aug 2021 20:13:13 -0700 (PDT) Received: from mail-lf1-f46.google.com (mail-lf1-f46.google.com. [209.85.167.46]) by smtp.gmail.com with ESMTPSA id y35sm2403920lje.127.2021.08.31.20.13.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 31 Aug 2021 20:13:12 -0700 (PDT) Received: by mail-lf1-f46.google.com with SMTP id p38so3508818lfa.0; Tue, 31 Aug 2021 20:13:12 -0700 (PDT) X-Received: by 2002:a05:6512:3b27:: with SMTP id f39mr23258174lfv.303.1630465992483; Tue, 31 Aug 2021 20:13:12 -0700 (PDT) MIME-Version: 1.0 References: <20210831184819.93670-1-jernej.skrabec@gmail.com> In-Reply-To: <20210831184819.93670-1-jernej.skrabec@gmail.com> Reply-To: wens@csie.org From: Chen-Yu Tsai Date: Wed, 1 Sep 2021 11:13:01 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] drm/sun4i: Fix macros in sun8i_csc.h To: Jernej Skrabec Cc: Maxime Ripard , David Airlie , Daniel Vetter , dri-devel , linux-arm-kernel , linux-sunxi@lists.linux.dev, linux-kernel , stable , Roman Stratiienko Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 1, 2021 at 2:48 AM Jernej Skrabec wrote: > > Macros SUN8I_CSC_CTRL() and SUN8I_CSC_COEFF() don't follow usual > recommendation of having arguments enclosed in parenthesis. While that > didn't change anything for quiet sometime, it actually become important ^ Typo > after CSC code rework with commit ea067aee45a8 ("drm/sun4i: de2/de3: > Remove redundant CSC matrices"). > > Without this fix, colours are completely off for supported YVU formats > on SoCs with DE2 (A64, H3, R40, etc.). > > Fix the issue by enclosing macro arguments in parenthesis. > > Cc: stable@vger.kernel.org # 5.12+ > Fixes: 883029390550 ("drm/sun4i: Add DE2 CSC library") > Reported-by: Roman Stratiienko > Signed-off-by: Jernej Skrabec Otherwise, Reviewed-by: Chen-Yu Tsai From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f182.google.com (mail-lj1-f182.google.com [209.85.208.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6FBA23FC3 for ; Wed, 1 Sep 2021 03:13:15 +0000 (UTC) Received: by mail-lj1-f182.google.com with SMTP id s12so2470828ljg.0 for ; Tue, 31 Aug 2021 20:13:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:reply-to :from:date:message-id:subject:to:cc; bh=d55o8VRMccw0pmcvesAE8Rz9x+AqcwcttzF+pmxCfek=; b=U1Ea5WYjoZAIn9QFGPCHn+PBJwUexBiPBwHi/vglzhsV1E5f9ZfeK3tPzePbgCjgTP 0UVCaSuBjyp4/ojxtXAtIQtvppC8KsoI4Qwzel29hCe3Mo9PG2gF/LsImS1fQ6CYNi3z xcVKsGCs+AIqQVBnQNz7Pr05bP+o+urblnzPXhJpsCvC4gGnDCTHEOeFtBKjwQvTllkK 4/W/dTYMc5YIwtrTxUQe6X96YYpH72T+cT90Qkl7VfiCGgFCoFxMM6AGEgCFII7Hhqsr 1tFgYwznFMht/qKZLlEXjN6wefHkSQyOOlfM8Al28MyLv0srIvn3PtKjbgNJNZ9A5Z1k CyyQ== X-Gm-Message-State: AOAM532EIKwJaR29wLzQ4FYoKy3ndAUkTB5sa9RvIupalcCx1eweewJo 0wh+fo7zyi62Oz7EGuDVqgQhSEk3bCCzJQ== X-Google-Smtp-Source: ABdhPJymEsu7/F1R0XlR02TQb203wJuYbDqYEXFE2sv0Y8tD22gP4oAOkbrWFbzTtVvmaizVaDcFoA== X-Received: by 2002:a2e:750e:: with SMTP id q14mr5078212ljc.338.1630465993231; Tue, 31 Aug 2021 20:13:13 -0700 (PDT) Received: from mail-lf1-f45.google.com (mail-lf1-f45.google.com. [209.85.167.45]) by smtp.gmail.com with ESMTPSA id v12sm370775lfi.49.2021.08.31.20.13.12 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 31 Aug 2021 20:13:12 -0700 (PDT) Received: by mail-lf1-f45.google.com with SMTP id s10so3312399lfr.11 for ; Tue, 31 Aug 2021 20:13:12 -0700 (PDT) X-Received: by 2002:a05:6512:3b27:: with SMTP id f39mr23258174lfv.303.1630465992483; Tue, 31 Aug 2021 20:13:12 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20210831184819.93670-1-jernej.skrabec@gmail.com> In-Reply-To: <20210831184819.93670-1-jernej.skrabec@gmail.com> Reply-To: wens@csie.org From: Chen-Yu Tsai Date: Wed, 1 Sep 2021 11:13:01 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] drm/sun4i: Fix macros in sun8i_csc.h To: Jernej Skrabec Cc: Maxime Ripard , David Airlie , Daniel Vetter , dri-devel , linux-arm-kernel , linux-sunxi@lists.linux.dev, linux-kernel , stable , Roman Stratiienko Content-Type: text/plain; charset="UTF-8" On Wed, Sep 1, 2021 at 2:48 AM Jernej Skrabec wrote: > > Macros SUN8I_CSC_CTRL() and SUN8I_CSC_COEFF() don't follow usual > recommendation of having arguments enclosed in parenthesis. While that > didn't change anything for quiet sometime, it actually become important ^ Typo > after CSC code rework with commit ea067aee45a8 ("drm/sun4i: de2/de3: > Remove redundant CSC matrices"). > > Without this fix, colours are completely off for supported YVU formats > on SoCs with DE2 (A64, H3, R40, etc.). > > Fix the issue by enclosing macro arguments in parenthesis. > > Cc: stable@vger.kernel.org # 5.12+ > Fixes: 883029390550 ("drm/sun4i: Add DE2 CSC library") > Reported-by: Roman Stratiienko > Signed-off-by: Jernej Skrabec Otherwise, Reviewed-by: Chen-Yu Tsai From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58DB1C432BE for ; Wed, 1 Sep 2021 03:16:13 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1092760724 for ; Wed, 1 Sep 2021 03:16:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 1092760724 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=csie.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Reply-To:List-Subscribe:List-Help: List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date :From:In-Reply-To:References:MIME-Version:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0GepCiq7JYKPv67wkTTHigAK8VSRkgGeC/9fHgY5Jrc=; b=KTflp8sTAN94k+ ierPk7jTTFgvs1DMOECVJ3hd6vrEjJhgvbgzCCpi/H/DILYW61RzqE8UIqbGLPoSm3WptHQc9Fk0x EFArgAxrkDqP0+3JTRqpzDQ3foWhID52bjdeYRH5BlHUoCftU8b2Ei7LmiZsP2i6ueF+tgnVmDNN9 EBLCekr5JxtW905H3FqpHaamZq1VRHxuzWMnp5ww9xQhlFvDoPg5NkPNUHJGdxh5RayWwyKK0jmjf qug7S/ZbnEFClAXryAEvTD3BJetjbYq9eM0GzyFVtQXre4w5Zp09a0MxdIJ1X76FSpctch0IBjEYq /+sXamw5To5LwYyImqMQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mLGgj-003eHL-3z; Wed, 01 Sep 2021 03:13:21 +0000 Received: from mail-lf1-f46.google.com ([209.85.167.46]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mLGge-003eGf-EU for linux-arm-kernel@lists.infradead.org; Wed, 01 Sep 2021 03:13:17 +0000 Received: by mail-lf1-f46.google.com with SMTP id g13so3297382lfj.12 for ; Tue, 31 Aug 2021 20:13:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:reply-to :from:date:message-id:subject:to:cc; bh=d55o8VRMccw0pmcvesAE8Rz9x+AqcwcttzF+pmxCfek=; b=OZ7B2Z65CgsnHqQm9rjSfbPfaYM7Wt8Duz+lDK5w2XwVxyo15D0k2d/tVYR+3bk+yg ngpFWdJXOdQ5xpgUnIQ7daFJ7Rb+GERXxWD3wuJ4iogNch0L33qorD2OfG7Szl2siuB+ 1q1KgnWAy+DoVCSePnlwiRXSEd+tSFgF/Wuq4P/uRX6JmGPrs1drauWjOvWS4uZveBdL mMpDZBqtSz6sweQCSrqWjq45rByda5ia8JpRik+cTXLG1HLaEInyJUIptvbbn8CEjYO+ dQNqLMAa0JZvv51XMmmSnk6ubuLIDH49su3OY5LDN2Ghp6qnmjvr2XnZJKWQPmgO83eb Ntlw== X-Gm-Message-State: AOAM531gsTAyJ/pA4K+9xVrbNVC0eJutxL2FDi//EzSAwcZ1ND8Q8i99 741faDTrdbRABz0aZgN51WxGe+17ByV/SA== X-Google-Smtp-Source: ABdhPJy8/xIhkEqTRlW9FVEiY295r6hrZWwCpTVFlrXXqpdIrc4fjiH4OTrM4Sj4PjlwG8ZTCZNVuw== X-Received: by 2002:ac2:53a9:: with SMTP id j9mr23575278lfh.562.1630465993309; Tue, 31 Aug 2021 20:13:13 -0700 (PDT) Received: from mail-lf1-f41.google.com (mail-lf1-f41.google.com. [209.85.167.41]) by smtp.gmail.com with ESMTPSA id n9sm2385764ljp.93.2021.08.31.20.13.12 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 31 Aug 2021 20:13:12 -0700 (PDT) Received: by mail-lf1-f41.google.com with SMTP id t19so1501968lfe.13 for ; Tue, 31 Aug 2021 20:13:12 -0700 (PDT) X-Received: by 2002:a05:6512:3b27:: with SMTP id f39mr23258174lfv.303.1630465992483; Tue, 31 Aug 2021 20:13:12 -0700 (PDT) MIME-Version: 1.0 References: <20210831184819.93670-1-jernej.skrabec@gmail.com> In-Reply-To: <20210831184819.93670-1-jernej.skrabec@gmail.com> From: Chen-Yu Tsai Date: Wed, 1 Sep 2021 11:13:01 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] drm/sun4i: Fix macros in sun8i_csc.h To: Jernej Skrabec Cc: Maxime Ripard , David Airlie , Daniel Vetter , dri-devel , linux-arm-kernel , linux-sunxi@lists.linux.dev, linux-kernel , stable , Roman Stratiienko X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210831_201316_524349_0CFCCCDB X-CRM114-Status: GOOD ( 13.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: wens@csie.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Sep 1, 2021 at 2:48 AM Jernej Skrabec wrote: > > Macros SUN8I_CSC_CTRL() and SUN8I_CSC_COEFF() don't follow usual > recommendation of having arguments enclosed in parenthesis. While that > didn't change anything for quiet sometime, it actually become important ^ Typo > after CSC code rework with commit ea067aee45a8 ("drm/sun4i: de2/de3: > Remove redundant CSC matrices"). > > Without this fix, colours are completely off for supported YVU formats > on SoCs with DE2 (A64, H3, R40, etc.). > > Fix the issue by enclosing macro arguments in parenthesis. > > Cc: stable@vger.kernel.org # 5.12+ > Fixes: 883029390550 ("drm/sun4i: Add DE2 CSC library") > Reported-by: Roman Stratiienko > Signed-off-by: Jernej Skrabec Otherwise, Reviewed-by: Chen-Yu Tsai _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel