From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751120AbeC0Isb (ORCPT ); Tue, 27 Mar 2018 04:48:31 -0400 Received: from mail-wm0-f48.google.com ([74.125.82.48]:55569 "EHLO mail-wm0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750917AbeC0IsY (ORCPT ); Tue, 27 Mar 2018 04:48:24 -0400 X-Google-Smtp-Source: AG47ELvylVuTcsk1t9A8Gta7HKrruKp9LbIBoTfPKT9jjxZqOHQG2Ikzcfs8UYVgOhj8EQNzu7PIZg== MIME-Version: 1.0 In-Reply-To: <1522140259.1110.43.camel@bootlin.com> References: <20180321152904.22411-1-paul.kocialkowski@bootlin.com> <20180321152904.22411-3-paul.kocialkowski@bootlin.com> <20180323095529.5nptn5achjt3esog@flea> <1522137643.1110.4.camel@bootlin.com> <20180327081731.he3lhnvqffuimsi5@flea> <1522140259.1110.43.camel@bootlin.com> From: Chen-Yu Tsai Date: Tue, 27 Mar 2018 16:48:01 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 02/10] drm/sun4i: Disable YUV channel when using the frontend and set interlace To: Paul Kocialkowski Cc: Maxime Ripard , linux-kernel , dri-devel , linux-arm-kernel , David Airlie , Daniel Vetter , Gustavo Padovan , Sean Paul Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 27, 2018 at 4:44 PM, Paul Kocialkowski wrote: > Hi, > > On Tue, 2018-03-27 at 10:17 +0200, Maxime Ripard wrote: >> On Tue, Mar 27, 2018 at 10:00:43AM +0200, Paul Kocialkowski wrote: >> > Hi, >> > >> > On Fri, 2018-03-23 at 10:55 +0100, Maxime Ripard wrote: >> > > On Wed, Mar 21, 2018 at 04:28:56PM +0100, Paul Kocialkowski wrote: >> > > > The YUV channel was only disabled in >> > > > sun4i_backend_update_layer_formats, >> > > > which is not called when the frontend is selected. >> > > > >> > > > Thus, creating a layer with a YUV format handled by the backend >> > > > and >> > > > then >> > > > switching to a format that requires the frontend would keep the >> > > > YUV >> > > > channel enabled for the layer. >> > > > >> > > > This explicitly disables the YUV channel for the layer when >> > > > using >> > > > the >> > > > frontend as well. It also sets the relevant interlace bit, which >> > > > was >> > > > missing in the frontend path as well. >> > > >> > > This should be part of a separate patch. Usually, if you write "it >> > > also does..." at the end of your commit log, it's a pretty good >> > > indication that it should be another patch :) >> > >> > I must say, I figured that this part was missing in the frontend >> > path by >> > chance and couldn't really test the feature, so I'm also tempted to >> > drop >> > it altogether. What do you think? >> >> If you haven't been able to test it, then yeah, don't submit it. > > Alright, noted. > >> > Also, is interlacing actually used on any of the video outputs we >> > support? Perhaps RGB? >> >> Composite would be a better guess :) > > Oh and I was wondering what CVBS was about. Now I know! > It seems that we don't support it for now apparently, anyway. You could also try adding interlaced modes to HDMI. ChenYu From mboxrd@z Thu Jan 1 00:00:00 1970 From: wens@csie.org (Chen-Yu Tsai) Date: Tue, 27 Mar 2018 16:48:01 +0800 Subject: [PATCH 02/10] drm/sun4i: Disable YUV channel when using the frontend and set interlace In-Reply-To: <1522140259.1110.43.camel@bootlin.com> References: <20180321152904.22411-1-paul.kocialkowski@bootlin.com> <20180321152904.22411-3-paul.kocialkowski@bootlin.com> <20180323095529.5nptn5achjt3esog@flea> <1522137643.1110.4.camel@bootlin.com> <20180327081731.he3lhnvqffuimsi5@flea> <1522140259.1110.43.camel@bootlin.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, Mar 27, 2018 at 4:44 PM, Paul Kocialkowski wrote: > Hi, > > On Tue, 2018-03-27 at 10:17 +0200, Maxime Ripard wrote: >> On Tue, Mar 27, 2018 at 10:00:43AM +0200, Paul Kocialkowski wrote: >> > Hi, >> > >> > On Fri, 2018-03-23 at 10:55 +0100, Maxime Ripard wrote: >> > > On Wed, Mar 21, 2018 at 04:28:56PM +0100, Paul Kocialkowski wrote: >> > > > The YUV channel was only disabled in >> > > > sun4i_backend_update_layer_formats, >> > > > which is not called when the frontend is selected. >> > > > >> > > > Thus, creating a layer with a YUV format handled by the backend >> > > > and >> > > > then >> > > > switching to a format that requires the frontend would keep the >> > > > YUV >> > > > channel enabled for the layer. >> > > > >> > > > This explicitly disables the YUV channel for the layer when >> > > > using >> > > > the >> > > > frontend as well. It also sets the relevant interlace bit, which >> > > > was >> > > > missing in the frontend path as well. >> > > >> > > This should be part of a separate patch. Usually, if you write "it >> > > also does..." at the end of your commit log, it's a pretty good >> > > indication that it should be another patch :) >> > >> > I must say, I figured that this part was missing in the frontend >> > path by >> > chance and couldn't really test the feature, so I'm also tempted to >> > drop >> > it altogether. What do you think? >> >> If you haven't been able to test it, then yeah, don't submit it. > > Alright, noted. > >> > Also, is interlacing actually used on any of the video outputs we >> > support? Perhaps RGB? >> >> Composite would be a better guess :) > > Oh and I was wondering what CVBS was about. Now I know! > It seems that we don't support it for now apparently, anyway. You could also try adding interlaced modes to HDMI. ChenYu From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chen-Yu Tsai Subject: Re: [PATCH 02/10] drm/sun4i: Disable YUV channel when using the frontend and set interlace Date: Tue, 27 Mar 2018 16:48:01 +0800 Message-ID: References: <20180321152904.22411-1-paul.kocialkowski@bootlin.com> <20180321152904.22411-3-paul.kocialkowski@bootlin.com> <20180323095529.5nptn5achjt3esog@flea> <1522137643.1110.4.camel@bootlin.com> <20180327081731.he3lhnvqffuimsi5@flea> <1522140259.1110.43.camel@bootlin.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-f43.google.com (mail-wm0-f43.google.com [74.125.82.43]) by gabe.freedesktop.org (Postfix) with ESMTPS id 71E2F6E5A9 for ; Tue, 27 Mar 2018 08:48:24 +0000 (UTC) Received: by mail-wm0-f43.google.com with SMTP id l16so20209208wmh.3 for ; Tue, 27 Mar 2018 01:48:24 -0700 (PDT) Received: from mail-wr0-f170.google.com (mail-wr0-f170.google.com. [209.85.128.170]) by smtp.gmail.com with ESMTPSA id n11sm580164edi.12.2018.03.27.01.48.22 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 27 Mar 2018 01:48:22 -0700 (PDT) Received: by mail-wr0-f170.google.com with SMTP id u46so21524052wrc.11 for ; Tue, 27 Mar 2018 01:48:22 -0700 (PDT) In-Reply-To: <1522140259.1110.43.camel@bootlin.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Paul Kocialkowski Cc: Maxime Ripard , linux-kernel , dri-devel , David Airlie , Daniel Vetter , linux-arm-kernel List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCBNYXIgMjcsIDIwMTggYXQgNDo0NCBQTSwgUGF1bCBLb2NpYWxrb3dza2kKPHBhdWwu a29jaWFsa293c2tpQGJvb3RsaW4uY29tPiB3cm90ZToKPiBIaSwKPgo+IE9uIFR1ZSwgMjAxOC0w My0yNyBhdCAxMDoxNyArMDIwMCwgTWF4aW1lIFJpcGFyZCB3cm90ZToKPj4gT24gVHVlLCBNYXIg MjcsIDIwMTggYXQgMTA6MDA6NDNBTSArMDIwMCwgUGF1bCBLb2NpYWxrb3dza2kgd3JvdGU6Cj4+ ID4gSGksCj4+ID4KPj4gPiBPbiBGcmksIDIwMTgtMDMtMjMgYXQgMTA6NTUgKzAxMDAsIE1heGlt ZSBSaXBhcmQgd3JvdGU6Cj4+ID4gPiBPbiBXZWQsIE1hciAyMSwgMjAxOCBhdCAwNDoyODo1NlBN ICswMTAwLCBQYXVsIEtvY2lhbGtvd3NraSB3cm90ZToKPj4gPiA+ID4gVGhlIFlVViBjaGFubmVs IHdhcyBvbmx5IGRpc2FibGVkIGluCj4+ID4gPiA+IHN1bjRpX2JhY2tlbmRfdXBkYXRlX2xheWVy X2Zvcm1hdHMsCj4+ID4gPiA+IHdoaWNoIGlzIG5vdCBjYWxsZWQgd2hlbiB0aGUgZnJvbnRlbmQg aXMgc2VsZWN0ZWQuCj4+ID4gPiA+Cj4+ID4gPiA+IFRodXMsIGNyZWF0aW5nIGEgbGF5ZXIgd2l0 aCBhIFlVViBmb3JtYXQgaGFuZGxlZCBieSB0aGUgYmFja2VuZAo+PiA+ID4gPiBhbmQKPj4gPiA+ ID4gdGhlbgo+PiA+ID4gPiBzd2l0Y2hpbmcgdG8gYSBmb3JtYXQgdGhhdCByZXF1aXJlcyB0aGUg ZnJvbnRlbmQgd291bGQga2VlcCB0aGUKPj4gPiA+ID4gWVVWCj4+ID4gPiA+IGNoYW5uZWwgZW5h YmxlZCBmb3IgdGhlIGxheWVyLgo+PiA+ID4gPgo+PiA+ID4gPiBUaGlzIGV4cGxpY2l0bHkgZGlz YWJsZXMgdGhlIFlVViBjaGFubmVsIGZvciB0aGUgbGF5ZXIgd2hlbgo+PiA+ID4gPiB1c2luZwo+ PiA+ID4gPiB0aGUKPj4gPiA+ID4gZnJvbnRlbmQgYXMgd2VsbC4gSXQgYWxzbyBzZXRzIHRoZSBy ZWxldmFudCBpbnRlcmxhY2UgYml0LCB3aGljaAo+PiA+ID4gPiB3YXMKPj4gPiA+ID4gbWlzc2lu ZyBpbiB0aGUgZnJvbnRlbmQgcGF0aCBhcyB3ZWxsLgo+PiA+ID4KPj4gPiA+IFRoaXMgc2hvdWxk IGJlIHBhcnQgb2YgYSBzZXBhcmF0ZSBwYXRjaC4gVXN1YWxseSwgaWYgeW91IHdyaXRlICJpdAo+ PiA+ID4gYWxzbyBkb2VzLi4uIiBhdCB0aGUgZW5kIG9mIHlvdXIgY29tbWl0IGxvZywgaXQncyBh IHByZXR0eSBnb29kCj4+ID4gPiBpbmRpY2F0aW9uIHRoYXQgaXQgc2hvdWxkIGJlIGFub3RoZXIg cGF0Y2ggOikKPj4gPgo+PiA+IEkgbXVzdCBzYXksIEkgZmlndXJlZCB0aGF0IHRoaXMgcGFydCB3 YXMgbWlzc2luZyBpbiB0aGUgZnJvbnRlbmQKPj4gPiBwYXRoIGJ5Cj4+ID4gY2hhbmNlIGFuZCBj b3VsZG4ndCByZWFsbHkgdGVzdCB0aGUgZmVhdHVyZSwgc28gSSdtIGFsc28gdGVtcHRlZCB0bwo+ PiA+IGRyb3AKPj4gPiBpdCBhbHRvZ2V0aGVyLiBXaGF0IGRvIHlvdSB0aGluaz8KPj4KPj4gSWYg eW91IGhhdmVuJ3QgYmVlbiBhYmxlIHRvIHRlc3QgaXQsIHRoZW4geWVhaCwgZG9uJ3Qgc3VibWl0 IGl0Lgo+Cj4gQWxyaWdodCwgbm90ZWQuCj4KPj4gPiBBbHNvLCBpcyBpbnRlcmxhY2luZyBhY3R1 YWxseSB1c2VkIG9uIGFueSBvZiB0aGUgdmlkZW8gb3V0cHV0cyB3ZQo+PiA+IHN1cHBvcnQ/IFBl cmhhcHMgUkdCPwo+Pgo+PiBDb21wb3NpdGUgd291bGQgYmUgYSBiZXR0ZXIgZ3Vlc3MgOikKPgo+ IE9oIGFuZCBJIHdhcyB3b25kZXJpbmcgd2hhdCBDVkJTIHdhcyBhYm91dC4gTm93IEkga25vdyEK PiBJdCBzZWVtcyB0aGF0IHdlIGRvbid0IHN1cHBvcnQgaXQgZm9yIG5vdyBhcHBhcmVudGx5LCBh bnl3YXkuCgpZb3UgY291bGQgYWxzbyB0cnkgYWRkaW5nIGludGVybGFjZWQgbW9kZXMgdG8gSERN SS4KCkNoZW5ZdQpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcK aHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK