From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sverre Rabbelier Subject: Re: [PATCH 1/3] t9350: point out that refs are not updated correctly Date: Thu, 25 Oct 2012 00:50:58 -0700 Message-ID: References: <20121025042731.GA11243@elie.Belkin> <20121025052823.GB11243@elie.Belkin> <20121025073454.GB15790@elie.Belkin> <20121025074829.GD15790@elie.Belkin> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Cc: Felipe Contreras , Junio C Hamano , Jeff King , Git List , Daniel Barkalow , Ramkumar Ramachandra , Dmitry Ivankov , =?UTF-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= , Eric Herman , Fernando Vezzosi To: Jonathan Nieder , Johannes Schindelin X-From: git-owner@vger.kernel.org Thu Oct 25 09:51:52 2012 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TRIEJ-0003GJ-Qm for gcvg-git-2@plane.gmane.org; Thu, 25 Oct 2012 09:51:52 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932805Ab2JYHvk (ORCPT ); Thu, 25 Oct 2012 03:51:40 -0400 Received: from mail-qc0-f174.google.com ([209.85.216.174]:61001 "EHLO mail-qc0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756431Ab2JYHvj (ORCPT ); Thu, 25 Oct 2012 03:51:39 -0400 Received: by mail-qc0-f174.google.com with SMTP id o22so547099qcr.19 for ; Thu, 25 Oct 2012 00:51:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=iAeThhP6CBbV5+KTUVJT//722fjz2DRTY41Vjoxijus=; b=jpEEAJy3WGMf+Gg6o00Uj/YKH1gYTZLIBgR9W5rOa3H4xzEZps1moRVU2RfmBRW2Ws Eou/aERGmkArVYTQrS5I2uwfmPuwHkqf1fyPYNmFQtzMqcbmcAw2673bhSWlBhEeTEix V+YTwxSy0zse8QAiVpFHWcs5Uaqr0xLUB11kTScJd732XhxfS9zwNp98L04+vxh9b0Pb kNloFB2ZMRzIGu9jgA70rY3+RIUNhlFxv+bThqHGD6LVNWmsnnLEFmossukUlVFQ1Rnz 2eGgIjyIOKKH4xVgiNeaHNsNe2dQAE/8VKpk1ohuTR9f71Rbnc6RL7wXtCGMPGdxj8Ne mFPQ== Received: by 10.49.130.234 with SMTP id oh10mr10344051qeb.42.1351151498557; Thu, 25 Oct 2012 00:51:38 -0700 (PDT) Received: by 10.49.36.195 with HTTP; Thu, 25 Oct 2012 00:50:58 -0700 (PDT) In-Reply-To: <20121025074829.GD15790@elie.Belkin> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: On Thu, Oct 25, 2012 at 12:48 AM, Jonathan Nieder wrote: > Sverre Rabbelier wrote: > >> I know there was a reason why using UNINTERESTING didn't work >> (otherwise we could've used that to start with, instead of needing >> Junio's whence solution). I think all refs ended up being marked as >> UNINTERESTING or somesuch. > > True. Is it be possible to check UNINTERESTING in revs->cmdline > before the walk? That might work, maybe Dscho remembers why we did not go with that approach. -- Cheers, Sverre Rabbelier