All of lore.kernel.org
 help / color / mirror / Atom feed
From: Oleksandr Suvorov <cryosay@gmail.com>
To: Marcel Ziswiler <marcel.ziswiler@toradex.com>
Cc: "u-boot@lists.denx.de" <u-boot@lists.denx.de>,
	 "oleksandr.suvorov@foundries.io"
	<oleksandr.suvorov@foundries.io>,
	 Philippe Schenker <philippe.schenker@toradex.com>,
	"hs@denx.de" <hs@denx.de>,
	 "patrick.delaunay@foss.st.com" <patrick.delaunay@foss.st.com>,
	"sjg@chromium.org" <sjg@chromium.org>,
	 Max Krummenacher <max.krummenacher@toradex.com>,
	 "igor.opaniuk@gmail.com" <igor.opaniuk@gmail.com>
Subject: Re: [PATCH] apalis/colibri_imx6: move setting bootcmd to defconfig
Date: Thu, 16 Sep 2021 12:09:27 +0300	[thread overview]
Message-ID: <CAGgjyvEu+L5dKVsc8cMuHPwLy=AC9BbksawgL6tosc+P-qZmdA@mail.gmail.com> (raw)
In-Reply-To: <0e3cd2d07c7c0da6741ce90192db02eb7c578f14.camel@toradex.com>

Hi Marcel,

On Wed, Sep 15, 2021 at 11:12 PM Marcel Ziswiler
<marcel.ziswiler@toradex.com> wrote:
>
> Hi Oleksandr
>
> Thanks, just one minor nit-pick below.
>
> On Sun, 2021-09-12 at 22:39 +0300, Oleksandr Suvorov wrote:
> > Move setting the default boot command to the
> > apalis/colibri_imx6_defconfig. It allows replacing the command
> > without code modification.
> >
> > Signed-off-by: Oleksandr Suvorov <oleksandr.suvorov@foundries.io>
> > ---
> >
> >  configs/apalis_imx6_defconfig  | 1 +
> >  configs/colibri_imx6_defconfig | 1 +
> >  include/configs/apalis_imx6.h  | 4 ----
> >  include/configs/colibri_imx6.h | 4 ----
> >  4 files changed, 2 insertions(+), 8 deletions(-)
> >
> > diff --git a/configs/apalis_imx6_defconfig b/configs/apalis_imx6_defconfig
> > index a0e85ba23a4..a2e0f8e3936 100644
> > --- a/configs/apalis_imx6_defconfig
> > +++ b/configs/apalis_imx6_defconfig
> > @@ -23,6 +23,7 @@ CONFIG_DISTRO_DEFAULTS=y
> >  CONFIG_FIT=y
> >  CONFIG_SYS_EXTRA_OPTIONS="IMX_CONFIG=arch/arm/mach-imx/spl_sd.cfg"
> >  CONFIG_BOOTDELAY=1
> > +CONFIG_BOOTCOMMAND="run distro_bootcmd;usb start;setenv stdout serial,vidconsole;setenv stdin serial,usbkbd"
>
> I believe, usually we had a space after those semicolons, not?

Thanks! Fixed.

>
> >  # CONFIG_DISPLAY_BOARDINFO is not set
> >  CONFIG_DISPLAY_BOARDINFO_LATE=y
> >  CONFIG_BOARD_EARLY_INIT_F=y
> > diff --git a/configs/colibri_imx6_defconfig b/configs/colibri_imx6_defconfig
> > index 47b1cfb1917..bee4e7edd63 100644
> > --- a/configs/colibri_imx6_defconfig
> > +++ b/configs/colibri_imx6_defconfig
> > @@ -22,6 +22,7 @@ CONFIG_DISTRO_DEFAULTS=y
> >  CONFIG_FIT=y
> >  CONFIG_SYS_EXTRA_OPTIONS="IMX_CONFIG=arch/arm/mach-imx/spl_sd.cfg"
> >  CONFIG_BOOTDELAY=1
> > +CONFIG_BOOTCOMMAND="run distro_bootcmd;usb start;setenv stdout serial,vidconsole;setenv stdin serial,usbkbd"
>
> Ditto.
>
> >  # CONFIG_DISPLAY_BOARDINFO is not set
> >  CONFIG_DISPLAY_BOARDINFO_LATE=y
> >  CONFIG_BOARD_EARLY_INIT_F=y
> > diff --git a/include/configs/apalis_imx6.h b/include/configs/apalis_imx6.h
> > index 12de0105c6c..ade479cb943 100644
> > --- a/include/configs/apalis_imx6.h
> > +++ b/include/configs/apalis_imx6.h
> > @@ -133,10 +133,6 @@
> >  #endif
> >  #define CONFIG_EXTRA_ENV_SETTINGS \
> >         BOOTENV \
> > -       "bootcmd=run distro_bootcmd ; " \
> > -               "usb start ; " \
> > -               "setenv stdout serial,vidconsole; " \
> > -               "setenv stdin serial,usbkbd\0" \
>
> At least here we definitely did have them (;-p).
>
> >         "boot_file=zImage\0" \
> >         "console=ttymxc0\0" \
> >         "defargs=enable_wait_mode=off vmalloc=400M\0" \
> > diff --git a/include/configs/colibri_imx6.h b/include/configs/colibri_imx6.h
> > index 804a144a03e..f91d6b49ea8 100644
> > --- a/include/configs/colibri_imx6.h
> > +++ b/include/configs/colibri_imx6.h
> > @@ -115,10 +115,6 @@
> >  #define FDT_FILE "imx6dl-colibri-eval-v3.dtb"
> >  #define CONFIG_EXTRA_ENV_SETTINGS \
> >         BOOTENV \
> > -       "bootcmd=run distro_bootcmd; " \
> > -               "usb start ; " \
> > -               "setenv stdout serial,vidconsole; " \
> > -               "setenv stdin serial,usbkbd\0" \
> >         "boot_file=zImage\0" \
> >         "console=ttymxc0\0" \
> >         "defargs=enable_wait_mode=off galcore.contiguousSize=50331648\0" \
>
> Cheers
>
> Marcel



-- 
Best regards
Oleksandr

Oleksandr Suvorov
cryosay@gmail.com

      reply	other threads:[~2021-09-16  9:09 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-12 19:39 [PATCH] apalis/colibri_imx6: move setting bootcmd to defconfig Oleksandr Suvorov
2021-09-15  2:15 ` Peng Fan (OSS)
2021-09-15 16:06 ` Igor Opaniuk
2021-09-15 20:11 ` Marcel Ziswiler
2021-09-16  9:09   ` Oleksandr Suvorov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAGgjyvEu+L5dKVsc8cMuHPwLy=AC9BbksawgL6tosc+P-qZmdA@mail.gmail.com' \
    --to=cryosay@gmail.com \
    --cc=hs@denx.de \
    --cc=igor.opaniuk@gmail.com \
    --cc=marcel.ziswiler@toradex.com \
    --cc=max.krummenacher@toradex.com \
    --cc=oleksandr.suvorov@foundries.io \
    --cc=patrick.delaunay@foss.st.com \
    --cc=philippe.schenker@toradex.com \
    --cc=sjg@chromium.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.