From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6E4FC433EF for ; Mon, 27 Sep 2021 12:07:46 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0DEB960EE4 for ; Mon, 27 Sep 2021 12:07:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 0DEB960EE4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id B031383238; Mon, 27 Sep 2021 14:07:42 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="E1dvzemS"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id ADBEB835F5; Mon, 27 Sep 2021 14:07:40 +0200 (CEST) Received: from mail-pg1-x530.google.com (mail-pg1-x530.google.com [IPv6:2607:f8b0:4864:20::530]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 8C99283223 for ; Mon, 27 Sep 2021 14:07:36 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=cryosay@gmail.com Received: by mail-pg1-x530.google.com with SMTP id y186so6254463pgd.0 for ; Mon, 27 Sep 2021 05:07:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=/Ne/qlriyDhiKk0M9XK/zzLVa0iRUhYtZepl8fjXn2Q=; b=E1dvzemSpt/PbyahCtBN9ER3xyzXfITAKkt08xNnkYj4JXAtg3iYhsbPXY29m5JDNu CslBjw/86AjDlqGq1umBqvRVx82SgAZHfrUKBM76w2SJNcH0BMt3K1qu1mx72I2LAmJK 3Q8butwk3k42kBMmw4edkFC6xqzzwsg4YT4L6R2nDBuBuhrxxpkKSR93iMku6VTUMbkW Q9dzB+zl8YcY6dJaBoSJ3G3qs2Tc+p0GKNtxPeIUetnwrkKP/o9s/GqFbifshV10UIr+ 4yEqnt5PD1htvshL8pvAPF4Fo6yfiC0Yo7ptLdy6wCZbs9S6syCX+x0rxxwcNCOrhcrU fPsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/Ne/qlriyDhiKk0M9XK/zzLVa0iRUhYtZepl8fjXn2Q=; b=BT1axiNb5W2wcYkcW16Fq55GrFR9vpy8Z/fugCK/Z4wMRjCOpZsL4BWieWDcyTBaMi y7uRuAZSGF2iSyfOBgdWqsUsgBUo46vGmu1ZT90+viWr871k5g7cpH+nnCzwD2pAXBNL cliIv70Jmto54OpU47etEglxnb33LQg9xQATSCW0C00h2rTj5F05RKjp3VvtbhX4D1T0 5/XMGY4ASe2nFJTOY8pGJJil3O0FmW6LlurdKEOOF6hInXwSYz6BE+bqOU2UYyTDQhH0 /7OERR93YCu49SlFKQuIzGcFgIK1pvrjnFHjh4aaelO6kLBZ8g+KXZQfGjnb8jeWtwlR C5IQ== X-Gm-Message-State: AOAM531aBFDBzU4QVPv17F1Z6dTVKEBLET17vZKGb3khWZwbdiIBYi1b 5UYbjFyDU70S6ocWU/+8nYkdCxgWKRgCjn/wpKE= X-Google-Smtp-Source: ABdhPJwLCiNOe5finR0wTdGqM7bAa7k51LnjkhST0AT4Kqnyrmp19csuoMMmAC9Fqle0grZoLi5xwKAbiuLHekp+prQ= X-Received: by 2002:aa7:96d9:0:b0:44b:28ec:b07d with SMTP id h25-20020aa796d9000000b0044b28ecb07dmr23010069pfq.85.1632744454500; Mon, 27 Sep 2021 05:07:34 -0700 (PDT) MIME-Version: 1.0 References: <20210925102255.21620-1-oleksandr.suvorov@foundries.io> In-Reply-To: From: Oleksandr Suvorov Date: Mon, 27 Sep 2021 15:06:59 +0300 Message-ID: Subject: Re: [PATCH] board: rpi: always set fdt_addr if provided by firmware To: Matthias Brugger Cc: Oleksandr Suvorov , U-Boot Mailing List , Ricardo Salveti , "Ivan T. Ivanov" , Marek Szyprowski , Nicolas Saenz Julienne , Peter Robinson Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Hello Matthias, On Mon, Sep 27, 2021 at 3:01 PM Matthias Brugger wrote: > > Hi Oleksandr, > > Thanks for your patch. > > There was the very same patch posted already, please follow-up in that thread > for any comments from your side: > https://patchwork.ozlabs.org/project/uboot/patch/20210512123945.25649-1-m.salvini@koansoftware.com/ Thank you, I missed that patch. I'll follow up on that thread. > > Regards, > Matthias > > On 25/09/2021 12:22, Oleksandr Suvorov wrote: > > From: Ricardo Salveti > > > > Otherwise if the env gets saved with an incorrect or different > > fdt_addr (by moving sdcard between different rpi versions), it won't > > be able to boot with the correct address. > > > > This allows fdt_addr to always be in sync with what gets set by the > > firmware. > > > > Signed-off-by: Ricardo Salveti > > Signed-off-by: Oleksandr Suvorov > > --- > > > > board/raspberrypi/rpi/rpi.c | 3 --- > > 1 file changed, 3 deletions(-) > > > > diff --git a/board/raspberrypi/rpi/rpi.c b/board/raspberrypi/rpi/rpi.c > > index 372b26b6f2..e12f8c0c31 100644 > > --- a/board/raspberrypi/rpi/rpi.c > > +++ b/board/raspberrypi/rpi/rpi.c > > @@ -318,9 +318,6 @@ static void set_fdtfile(void) > > */ > > static void set_fdt_addr(void) > > { > > - if (env_get("fdt_addr")) > > - return; > > - > > if (fdt_magic(fw_dtb_pointer) != FDT_MAGIC) > > return; > > > > > -- Best regards Oleksandr Oleksandr Suvorov cryosay@gmail.com