From mboxrd@z Thu Jan 1 00:00:00 1970 From: Parav Pandit Subject: Re: [PATCH] net-next: ethtool: Added port speed macros. Date: Tue, 19 May 2015 22:11:05 +0530 Message-ID: References: <1431946907-7808-1-git-send-email-parav.pandit@avagotech.com> <20150518.114630.1938175226193925552.davem@davemloft.net> <20150519.123221.435329742945502707.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Cc: netdev@vger.kernel.org, bwh@kernel.org To: David Miller Return-path: Received: from mail-ie0-f177.google.com ([209.85.223.177]:32774 "EHLO mail-ie0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754529AbbESQlG (ORCPT ); Tue, 19 May 2015 12:41:06 -0400 Received: by iebgx4 with SMTP id gx4so18361752ieb.0 for ; Tue, 19 May 2015 09:41:05 -0700 (PDT) In-Reply-To: <20150519.123221.435329742945502707.davem@davemloft.net> Sender: netdev-owner@vger.kernel.org List-ID: On Tue, May 19, 2015 at 10:02 PM, David Miller wrote: > From: Parav Pandit > Date: Tue, 19 May 2015 10:15:49 +0530 > >> On Mon, May 18, 2015 at 9:16 PM, David Miller wrote: >>> From: Parav Pandit >>> Date: Mon, 18 May 2015 16:31:47 +0530 >>> >>>> Signed-off-by: Parav Pandit >>> >>> I thought we had decided that we weren't going to keep adding >>> convenience macros for new speeds, and were simply going to use >>> the appropriate constants in the future. >>> >> >> I added them to accommodate any speed/PHY interface specific >> configuration to make use of it. >> If convenience macros are not needed, I will provide the code cleanup >> patch to remove existing convenience macros. With that we will have >> unified code for old and new constants. >> I will anyway let Ben comment on it. > > You cannot remove the existing macros, because they are exported to > userspace and you'll break application compilation if you do that. Yes, didn't think about it before.