From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: MIME-Version: 1.0 In-Reply-To: References: <1498587806-24781-1-git-send-email-alcooperx@gmail.com> <1498587806-24781-3-git-send-email-alcooperx@gmail.com> <20170706141840.lanfxjdrkaqvv3vz@rob-hp-laptop> From: Al Cooper Date: Tue, 11 Jul 2017 15:47:43 -0400 Message-ID: Subject: Re: [PATCH 2/8] usb: bdc: Add Device Tree binding document for Broadcom BDC driver Content-Type: multipart/alternative; boundary="94eb2c11ac3a1feaba05540ff9ef" To: Rob Herring Cc: Al Cooper , "linux-kernel@vger.kernel.org" , Greg Kroah-Hartman , Mark Rutland , Felipe Balbi , yuan linyu , Florian Fainelli , "open list:USB SUBSYSTEM" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , BCM Kernel Feedback List-ID: --94eb2c11ac3a1feaba05540ff9ef Content-Type: text/plain; charset="UTF-8" On Fri, Jul 7, 2017 at 4:15 PM, Rob Herring wrote: > > >> > +==================================== > >> > + > >> > +Required properties: > >> > + > >> > +- compatible: must be one of: > >> > + "brcm,bdc-udc-v0.16" > >> > + "brcm,bdc-udc" > >> > >> Isn't "bdc-udc" redundant? > > > > > > I'll change the base name to "brcm-udc" > > Well, it should be "brcm," with the vendor prefix followed > by a comma. If the block is known as the BDC, then I'd use that. Actually I meant to say I'd change it to "brcm,udc". I thought that udc would be better than bdc because BDC stands for Broadcom Universal Device Controller, so the "b" seems redundant in "brcm,bdc" and I thought that at a glance more people would know what a "udc" driver was that what a "bdc" driver was. I you still think "brcm,bdc" is better, I'll change it to that. Thanks Al --94eb2c11ac3a1feaba05540ff9ef Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Fri, Jul 7, 2017 at 4:15 PM, Rob Herring <robh@kernel.org> wrote:>
> >> > +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
>= ; >> > +
> >> > +Required properties:
> >&= gt; > +
> >> > +- compatible: must be one of:
> >= ;> > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0"b= rcm,bdc-udc-v0.16"
> >> > + =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0"brcm,bdc-udc"
> >>
&g= t; >> Isn't "bdc-udc" redundant?
> >
> &= gt;
> > I'll change the base name to "brcm-udc"
&= gt;
> Well, it should be "brcm,<something>" with the = vendor prefix followed
> by a comma. If the block is known as the BDC= , then I'd use that.

Actually I meant to say I'd= change it to "brcm,udc". I thought that udc would be better than= bdc because BDC stands for Broadcom Universal Device Controller, so the &q= uot;b" seems redundant in "brcm,bdc" and I thought that at a= glance more people would know what a "udc" driver was that what = a "bdc" driver was. I you still think "brcm,bdc" is bet= ter, I'll change it to that.

Thanks
= Al

--94eb2c11ac3a1feaba05540ff9ef--