From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joachim Eastwood Subject: Re: [PATCH 08/11] clk: lpc18xx: add NXP specific common clock framework selection Date: Sun, 22 Nov 2015 21:38:08 +0100 Message-ID: References: <1447981511-29653-1-git-send-email-vz@mleia.com> <1447981511-29653-9-git-send-email-vz@mleia.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: <1447981511-29653-9-git-send-email-vz@mleia.com> Sender: linux-clk-owner@vger.kernel.org To: Vladimir Zapolskiy Cc: Rob Herring , Stephen Boyd , Michael Turquette , Arnd Bergmann , Russell King , Roland Stigge , linux-clk@vger.kernel.org, devicetree@vger.kernel.org, "linux-arm-kernel@lists.infradead.org" List-Id: devicetree@vger.kernel.org Hi Vladimir, On 20 November 2015 at 02:05, Vladimir Zapolskiy wrote: > The change adds COMMON_CLK_NXP configuration symbol and enables it for > NXP LPC18XX architecture, this is needed to reuse drivers/clk/nxp > folder for NXP common clock framework drivers other than LPC18XX one. > > Signed-off-by: Vladimir Zapolskiy > Cc: Joachim Eastwood > --- > arch/arm/Kconfig | 1 + > drivers/clk/Kconfig | 5 +++++ > drivers/clk/Makefile | 2 +- > 3 files changed, 7 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig > index 0365cbb..c318277 100644 > --- a/arch/arm/Kconfig > +++ b/arch/arm/Kconfig > @@ -952,6 +952,7 @@ config ARCH_LPC18XX > select ARCH_HAS_RESET_CONTROLLER > select ARM_AMBA > select CLKSRC_LPC32XX > + select COMMON_CLK COMMON_CLK is already selected by ARM_SINGLE_ARMV7M which ARCH_LPC18XX depends on so this hunk should not be necessary. > select PINCTRL > help > Support for NXP's LPC18xx Cortex-M3 and LPC43xx Cortex-M4 > diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig > index c3e3a02..7fc1eb9 100644 > --- a/drivers/clk/Kconfig > +++ b/drivers/clk/Kconfig > @@ -175,6 +175,11 @@ config COMMON_CLK_PWM > Adapter driver so that any PWM output can be (mis)used as clock signal > at 50% duty cycle. > > +config COMMON_CLK_NXP > + def_bool COMMON_CLK && ARCH_LPC18XX > + ---help--- > + Support for clock providers on NXP platforms. > + > config COMMON_CLK_PXA > def_bool COMMON_CLK && ARCH_PXA > ---help--- > diff --git a/drivers/clk/Makefile b/drivers/clk/Makefile > index 820714c..15603c1 100644 > --- a/drivers/clk/Makefile > +++ b/drivers/clk/Makefile > @@ -62,8 +62,8 @@ endif > obj-$(CONFIG_PLAT_ORION) += mvebu/ > obj-$(CONFIG_ARCH_MESON) += meson/ > obj-$(CONFIG_ARCH_MXS) += mxs/ > -obj-$(CONFIG_ARCH_LPC18XX) += nxp/ > obj-$(CONFIG_MACH_PISTACHIO) += pistachio/ > +obj-$(CONFIG_COMMON_CLK_NXP) += nxp/ > obj-$(CONFIG_COMMON_CLK_PXA) += pxa/ > obj-$(CONFIG_COMMON_CLK_QCOM) += qcom/ > obj-$(CONFIG_ARCH_ROCKCHIP) += rockchip/ > -- Other than the one comment above it looks good to me: Acked-by: Joachim Eastwood I'll try to find the time look through the other patches you have for lpc32xx. I also have a EA LPC3250 dev kit v2 (http://embeddedartists.com/products/kits/lpc3250_kit_v2.php) in my collection. regards, Joachim Eastwood From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: MIME-Version: 1.0 In-Reply-To: <1447981511-29653-9-git-send-email-vz@mleia.com> References: <1447981511-29653-1-git-send-email-vz@mleia.com> <1447981511-29653-9-git-send-email-vz@mleia.com> Date: Sun, 22 Nov 2015 21:38:08 +0100 Message-ID: Subject: Re: [PATCH 08/11] clk: lpc18xx: add NXP specific common clock framework selection From: Joachim Eastwood To: Vladimir Zapolskiy Cc: Rob Herring , Stephen Boyd , Michael Turquette , Arnd Bergmann , Russell King , Roland Stigge , linux-clk@vger.kernel.org, devicetree@vger.kernel.org, "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset=UTF-8 List-ID: Hi Vladimir, On 20 November 2015 at 02:05, Vladimir Zapolskiy wrote: > The change adds COMMON_CLK_NXP configuration symbol and enables it for > NXP LPC18XX architecture, this is needed to reuse drivers/clk/nxp > folder for NXP common clock framework drivers other than LPC18XX one. > > Signed-off-by: Vladimir Zapolskiy > Cc: Joachim Eastwood > --- > arch/arm/Kconfig | 1 + > drivers/clk/Kconfig | 5 +++++ > drivers/clk/Makefile | 2 +- > 3 files changed, 7 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig > index 0365cbb..c318277 100644 > --- a/arch/arm/Kconfig > +++ b/arch/arm/Kconfig > @@ -952,6 +952,7 @@ config ARCH_LPC18XX > select ARCH_HAS_RESET_CONTROLLER > select ARM_AMBA > select CLKSRC_LPC32XX > + select COMMON_CLK COMMON_CLK is already selected by ARM_SINGLE_ARMV7M which ARCH_LPC18XX depends on so this hunk should not be necessary. > select PINCTRL > help > Support for NXP's LPC18xx Cortex-M3 and LPC43xx Cortex-M4 > diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig > index c3e3a02..7fc1eb9 100644 > --- a/drivers/clk/Kconfig > +++ b/drivers/clk/Kconfig > @@ -175,6 +175,11 @@ config COMMON_CLK_PWM > Adapter driver so that any PWM output can be (mis)used as clock signal > at 50% duty cycle. > > +config COMMON_CLK_NXP > + def_bool COMMON_CLK && ARCH_LPC18XX > + ---help--- > + Support for clock providers on NXP platforms. > + > config COMMON_CLK_PXA > def_bool COMMON_CLK && ARCH_PXA > ---help--- > diff --git a/drivers/clk/Makefile b/drivers/clk/Makefile > index 820714c..15603c1 100644 > --- a/drivers/clk/Makefile > +++ b/drivers/clk/Makefile > @@ -62,8 +62,8 @@ endif > obj-$(CONFIG_PLAT_ORION) += mvebu/ > obj-$(CONFIG_ARCH_MESON) += meson/ > obj-$(CONFIG_ARCH_MXS) += mxs/ > -obj-$(CONFIG_ARCH_LPC18XX) += nxp/ > obj-$(CONFIG_MACH_PISTACHIO) += pistachio/ > +obj-$(CONFIG_COMMON_CLK_NXP) += nxp/ > obj-$(CONFIG_COMMON_CLK_PXA) += pxa/ > obj-$(CONFIG_COMMON_CLK_QCOM) += qcom/ > obj-$(CONFIG_ARCH_ROCKCHIP) += rockchip/ > -- Other than the one comment above it looks good to me: Acked-by: Joachim Eastwood I'll try to find the time look through the other patches you have for lpc32xx. I also have a EA LPC3250 dev kit v2 (http://embeddedartists.com/products/kits/lpc3250_kit_v2.php) in my collection. regards, Joachim Eastwood From mboxrd@z Thu Jan 1 00:00:00 1970 From: manabian@gmail.com (Joachim Eastwood) Date: Sun, 22 Nov 2015 21:38:08 +0100 Subject: [PATCH 08/11] clk: lpc18xx: add NXP specific common clock framework selection In-Reply-To: <1447981511-29653-9-git-send-email-vz@mleia.com> References: <1447981511-29653-1-git-send-email-vz@mleia.com> <1447981511-29653-9-git-send-email-vz@mleia.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Vladimir, On 20 November 2015 at 02:05, Vladimir Zapolskiy wrote: > The change adds COMMON_CLK_NXP configuration symbol and enables it for > NXP LPC18XX architecture, this is needed to reuse drivers/clk/nxp > folder for NXP common clock framework drivers other than LPC18XX one. > > Signed-off-by: Vladimir Zapolskiy > Cc: Joachim Eastwood > --- > arch/arm/Kconfig | 1 + > drivers/clk/Kconfig | 5 +++++ > drivers/clk/Makefile | 2 +- > 3 files changed, 7 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig > index 0365cbb..c318277 100644 > --- a/arch/arm/Kconfig > +++ b/arch/arm/Kconfig > @@ -952,6 +952,7 @@ config ARCH_LPC18XX > select ARCH_HAS_RESET_CONTROLLER > select ARM_AMBA > select CLKSRC_LPC32XX > + select COMMON_CLK COMMON_CLK is already selected by ARM_SINGLE_ARMV7M which ARCH_LPC18XX depends on so this hunk should not be necessary. > select PINCTRL > help > Support for NXP's LPC18xx Cortex-M3 and LPC43xx Cortex-M4 > diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig > index c3e3a02..7fc1eb9 100644 > --- a/drivers/clk/Kconfig > +++ b/drivers/clk/Kconfig > @@ -175,6 +175,11 @@ config COMMON_CLK_PWM > Adapter driver so that any PWM output can be (mis)used as clock signal > at 50% duty cycle. > > +config COMMON_CLK_NXP > + def_bool COMMON_CLK && ARCH_LPC18XX > + ---help--- > + Support for clock providers on NXP platforms. > + > config COMMON_CLK_PXA > def_bool COMMON_CLK && ARCH_PXA > ---help--- > diff --git a/drivers/clk/Makefile b/drivers/clk/Makefile > index 820714c..15603c1 100644 > --- a/drivers/clk/Makefile > +++ b/drivers/clk/Makefile > @@ -62,8 +62,8 @@ endif > obj-$(CONFIG_PLAT_ORION) += mvebu/ > obj-$(CONFIG_ARCH_MESON) += meson/ > obj-$(CONFIG_ARCH_MXS) += mxs/ > -obj-$(CONFIG_ARCH_LPC18XX) += nxp/ > obj-$(CONFIG_MACH_PISTACHIO) += pistachio/ > +obj-$(CONFIG_COMMON_CLK_NXP) += nxp/ > obj-$(CONFIG_COMMON_CLK_PXA) += pxa/ > obj-$(CONFIG_COMMON_CLK_QCOM) += qcom/ > obj-$(CONFIG_ARCH_ROCKCHIP) += rockchip/ > -- Other than the one comment above it looks good to me: Acked-by: Joachim Eastwood I'll try to find the time look through the other patches you have for lpc32xx. I also have a EA LPC3250 dev kit v2 (http://embeddedartists.com/products/kits/lpc3250_kit_v2.php) in my collection. regards, Joachim Eastwood