From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755190AbcCUMLi (ORCPT ); Mon, 21 Mar 2016 08:11:38 -0400 Received: from mail-ig0-f193.google.com ([209.85.213.193]:34715 "EHLO mail-ig0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753709AbcCUMLg (ORCPT ); Mon, 21 Mar 2016 08:11:36 -0400 MIME-Version: 1.0 In-Reply-To: References: <1458315428-10081-1-git-send-email-alexandre.torgue@gmail.com> <1458315428-10081-3-git-send-email-alexandre.torgue@gmail.com> Date: Mon, 21 Mar 2016 13:11:35 +0100 Message-ID: Subject: Re: [PATCH v5 2/4] Documentation: Bindings: Add STM32 DWMAC glue From: Joachim Eastwood To: Chen-Yu Tsai Cc: Alexandre Torgue , Maxime Coquelin , Giuseppe Cavallaro , netdev , devicetree , linux-kernel , linux-arm-kernel Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Chen-Yu, On 21 March 2016 at 12:08, Chen-Yu Tsai wrote: > On Mon, Mar 21, 2016 at 6:45 PM, Alexandre Torgue > wrote: >> Hi, >> >> 2016-03-18 17:00 GMT+01:00 Chen-Yu Tsai : >>> Hi, >>> >>> On Fri, Mar 18, 2016 at 11:37 PM, Alexandre TORGUE >>> wrote: >>>> Signed-off-by: Alexandre TORGUE >>>> >>>> diff --git a/Documentation/devicetree/bindings/net/stm32-dwmac.txt b/Documentation/devicetree/bindings/net/stm32-dwmac.txt >>>> new file mode 100644 >>>> index 0000000..ada2aa4 >>>> --- /dev/null >>>> +++ b/Documentation/devicetree/bindings/net/stm32-dwmac.txt >>>> @@ -0,0 +1,32 @@ >>>> +STMicroelectronics STM32 / MCU DWMAC glue layer controller >>>> + >>>> +This file documents platform glue layer for stmmac. >>>> +Please see stmmac.txt for the other unchanged properties. >>>> + >>>> +The device node has following properties. >>>> + >>>> +Required properties: >>>> +- compatible: Should be "st,stm32-dwmac" to select glue, and >>>> + "snps,dwmac-3.50a" to select IP vesrion. s/vesrion/version >>> >>> If you need have sort of hardware glue, then it is not compatible. >>> >> >> We could have the case where the glue is set by a bootloader. >> In this case, we will select IP version in compatible and we will use >> generic dwmac glue to probe stmmac driver. > > It seems most platforms using DWMAC follow this design set by > the original stmmac bindings. I'm arguing that the requirement > of setting up the glue makes them incompatible. > > What happens when the bootloader didn't setup the glue? And one > forgets to build the STM32 driver, only the generic one? The > generic driver even matches to some, but not all, version > strings. > > Maybe it would've been better if the versioned strings were > only used to indicate functionality, and not used to bind > the drivers. But the bindings were set some time ago. Since Alexandre has not added "snps,dwmac-3.50a" to dwmac-generic doesn't he use it as you suggest here? Note that we can not remove all the generic compatible strings from dwmac-generic because there is one platform that depend on one of them. (see arch/arm/boot/dts/exynos5440.dtsi:190) So we can not remove "snps,dwmac-3.70a" from the dwmac-generic driver if we want to keep backwards compatibility with exynos5440. But I guess we could remove the others if we want to. regards, Joachim Eastwood From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joachim Eastwood Subject: Re: [PATCH v5 2/4] Documentation: Bindings: Add STM32 DWMAC glue Date: Mon, 21 Mar 2016 13:11:35 +0100 Message-ID: References: <1458315428-10081-1-git-send-email-alexandre.torgue@gmail.com> <1458315428-10081-3-git-send-email-alexandre.torgue@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Cc: Alexandre Torgue , Maxime Coquelin , Giuseppe Cavallaro , netdev , devicetree , linux-kernel , linux-arm-kernel To: Chen-Yu Tsai Return-path: In-Reply-To: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: netdev.vger.kernel.org Hi Chen-Yu, On 21 March 2016 at 12:08, Chen-Yu Tsai wrote: > On Mon, Mar 21, 2016 at 6:45 PM, Alexandre Torgue > wrote: >> Hi, >> >> 2016-03-18 17:00 GMT+01:00 Chen-Yu Tsai : >>> Hi, >>> >>> On Fri, Mar 18, 2016 at 11:37 PM, Alexandre TORGUE >>> wrote: >>>> Signed-off-by: Alexandre TORGUE >>>> >>>> diff --git a/Documentation/devicetree/bindings/net/stm32-dwmac.txt b/Documentation/devicetree/bindings/net/stm32-dwmac.txt >>>> new file mode 100644 >>>> index 0000000..ada2aa4 >>>> --- /dev/null >>>> +++ b/Documentation/devicetree/bindings/net/stm32-dwmac.txt >>>> @@ -0,0 +1,32 @@ >>>> +STMicroelectronics STM32 / MCU DWMAC glue layer controller >>>> + >>>> +This file documents platform glue layer for stmmac. >>>> +Please see stmmac.txt for the other unchanged properties. >>>> + >>>> +The device node has following properties. >>>> + >>>> +Required properties: >>>> +- compatible: Should be "st,stm32-dwmac" to select glue, and >>>> + "snps,dwmac-3.50a" to select IP vesrion. s/vesrion/version >>> >>> If you need have sort of hardware glue, then it is not compatible. >>> >> >> We could have the case where the glue is set by a bootloader. >> In this case, we will select IP version in compatible and we will use >> generic dwmac glue to probe stmmac driver. > > It seems most platforms using DWMAC follow this design set by > the original stmmac bindings. I'm arguing that the requirement > of setting up the glue makes them incompatible. > > What happens when the bootloader didn't setup the glue? And one > forgets to build the STM32 driver, only the generic one? The > generic driver even matches to some, but not all, version > strings. > > Maybe it would've been better if the versioned strings were > only used to indicate functionality, and not used to bind > the drivers. But the bindings were set some time ago. Since Alexandre has not added "snps,dwmac-3.50a" to dwmac-generic doesn't he use it as you suggest here? Note that we can not remove all the generic compatible strings from dwmac-generic because there is one platform that depend on one of them. (see arch/arm/boot/dts/exynos5440.dtsi:190) So we can not remove "snps,dwmac-3.70a" from the dwmac-generic driver if we want to keep backwards compatibility with exynos5440. But I guess we could remove the others if we want to. regards, Joachim Eastwood -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: manabian@gmail.com (Joachim Eastwood) Date: Mon, 21 Mar 2016 13:11:35 +0100 Subject: [PATCH v5 2/4] Documentation: Bindings: Add STM32 DWMAC glue In-Reply-To: References: <1458315428-10081-1-git-send-email-alexandre.torgue@gmail.com> <1458315428-10081-3-git-send-email-alexandre.torgue@gmail.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Chen-Yu, On 21 March 2016 at 12:08, Chen-Yu Tsai wrote: > On Mon, Mar 21, 2016 at 6:45 PM, Alexandre Torgue > wrote: >> Hi, >> >> 2016-03-18 17:00 GMT+01:00 Chen-Yu Tsai : >>> Hi, >>> >>> On Fri, Mar 18, 2016 at 11:37 PM, Alexandre TORGUE >>> wrote: >>>> Signed-off-by: Alexandre TORGUE >>>> >>>> diff --git a/Documentation/devicetree/bindings/net/stm32-dwmac.txt b/Documentation/devicetree/bindings/net/stm32-dwmac.txt >>>> new file mode 100644 >>>> index 0000000..ada2aa4 >>>> --- /dev/null >>>> +++ b/Documentation/devicetree/bindings/net/stm32-dwmac.txt >>>> @@ -0,0 +1,32 @@ >>>> +STMicroelectronics STM32 / MCU DWMAC glue layer controller >>>> + >>>> +This file documents platform glue layer for stmmac. >>>> +Please see stmmac.txt for the other unchanged properties. >>>> + >>>> +The device node has following properties. >>>> + >>>> +Required properties: >>>> +- compatible: Should be "st,stm32-dwmac" to select glue, and >>>> + "snps,dwmac-3.50a" to select IP vesrion. s/vesrion/version >>> >>> If you need have sort of hardware glue, then it is not compatible. >>> >> >> We could have the case where the glue is set by a bootloader. >> In this case, we will select IP version in compatible and we will use >> generic dwmac glue to probe stmmac driver. > > It seems most platforms using DWMAC follow this design set by > the original stmmac bindings. I'm arguing that the requirement > of setting up the glue makes them incompatible. > > What happens when the bootloader didn't setup the glue? And one > forgets to build the STM32 driver, only the generic one? The > generic driver even matches to some, but not all, version > strings. > > Maybe it would've been better if the versioned strings were > only used to indicate functionality, and not used to bind > the drivers. But the bindings were set some time ago. Since Alexandre has not added "snps,dwmac-3.50a" to dwmac-generic doesn't he use it as you suggest here? Note that we can not remove all the generic compatible strings from dwmac-generic because there is one platform that depend on one of them. (see arch/arm/boot/dts/exynos5440.dtsi:190) So we can not remove "snps,dwmac-3.70a" from the dwmac-generic driver if we want to keep backwards compatibility with exynos5440. But I guess we could remove the others if we want to. regards, Joachim Eastwood