All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ramon Fried <rfried.dev@gmail.com>
To: Vladimir Oltean <vladimir.oltean@nxp.com>
Cc: Bin Meng <bmeng.cn@gmail.com>,
	"u-boot@lists.denx.de" <u-boot@lists.denx.de>
Subject: Re: [PATCH 1/3] net: dsa: Use true instead of 1 in the set_promisc() call
Date: Wed, 3 Nov 2021 09:13:03 +0200	[thread overview]
Message-ID: <CAGi-RU+4ZugYMqu=o-V_3TLaq_bNo_WjNBrSi-xioKqX+AQr7w@mail.gmail.com> (raw)
In-Reply-To: <20211031220442.qm3xtjjzsgnxcxyv@skbuf>

On Mon, Nov 1, 2021 at 12:04 AM Vladimir Oltean <vladimir.oltean@nxp.com> wrote:
>
> On Sat, Oct 30, 2021 at 04:31:48PM +0300, Ramon Fried wrote:
> > > > > > Ping for apply?
> > > > > I'll get to the patches today.
> > > > > thanks for waking me up :)
> > >
> > > Why don't you apply patches immediately after reviewing them?
> > It wouldn't make a difference. you were all working on the same file
> > in code, If I would have applied bin's patches before yours, then you
> > would need to rebase.
> > simple as that. Also the time when I'm applying and when I'm reviewing
> > is also meaningless because this problem would occur anyway.
>
> I know, I was reacting to the 'thanks for waking me up' part.
> Honestly I don't see the point of going through some patches, marking
> them as reviewed, then waiting for 2 more weeks to apply them (or even
> more in other cases). It slows down the process for a reason that I
> can't see.
>
> Maybe the thinking is along the lines of "I won't apply patches that
> haven't marinated for long enough". But my patches (the ones conflicting
> with Bin's) still had build warnings even after marinating for close to
> one month (fixes for which I've sent just now). During that time, I had
> also piled up a few non-critical fixes to those patches, but I wasn't
> going to modify the patch set already in flight anyway, for fear of
> waiting again for who knows how long. Incremental fixups are fine and
> surely are a valid way of doing development too, so that argument kinda
> falls off the table. What's left?
I do let patches marinate for a while, to give other people the
opportunity to review, test and comment.
After a few weeks, when the merge window is open, I pick-up all the
patches and apply them in turn.
That's my process, and I don't think there's anything wrong with it.

If you have a fix to a patch you already got reviewed-by, send the
patch again, and add reviewed-by.
That's the way it should work.

      reply	other threads:[~2021-11-03  7:13 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-29  5:50 [PATCH 1/3] net: dsa: Use true instead of 1 in the set_promisc() call Bin Meng
2021-09-29  5:50 ` [PATCH 2/3] net: fec_mxc: Declare 'promisc' as bool Bin Meng
2021-09-29 13:32   ` Vladimir Oltean
2021-10-16 18:26     ` Ramon Fried
2021-09-29  5:50 ` [PATCH 3/3] net: tsec: Make redundant_init() static Bin Meng
2021-09-29 13:44   ` Vladimir Oltean
2021-10-16 18:27   ` Ramon Fried
2021-09-29 13:32 ` [PATCH 1/3] net: dsa: Use true instead of 1 in the set_promisc() call Vladimir Oltean
2021-10-16 18:26   ` Ramon Fried
2021-10-27  2:18     ` Bin Meng
2021-10-28  4:53       ` Ramon Fried
2021-10-28 18:41         ` Ramon Fried
2021-10-28 19:29           ` Vladimir Oltean
2021-10-30 13:31             ` Ramon Fried
2021-10-30 13:37               ` Bin Meng
2021-10-30 14:39                 ` Ramon Fried
2021-10-31 22:04               ` Vladimir Oltean
2021-11-03  7:13                 ` Ramon Fried [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAGi-RU+4ZugYMqu=o-V_3TLaq_bNo_WjNBrSi-xioKqX+AQr7w@mail.gmail.com' \
    --to=rfried.dev@gmail.com \
    --cc=bmeng.cn@gmail.com \
    --cc=u-boot@lists.denx.de \
    --cc=vladimir.oltean@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.