All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ramon Fried <rfried.dev@gmail.com>
To: u-boot@lists.denx.de
Subject: [PATCH v4] net: tftp: Add client support for RFC 7440
Date: Sat, 23 May 2020 20:59:53 +0300	[thread overview]
Message-ID: <CAGi-RU+BNDnMvH1+QaEYGjNcF58as1Tujn_Ci-G4WWZiXHV6Tw@mail.gmail.com> (raw)
In-Reply-To: <b561df84-4557-3f2f-b732-fe595ecdc0ad@gmail.com>

On Sat, May 23, 2020 at 8:40 PM Matthias Brugger <matthias.bgg@gmail.com> wrote:
...
>
> I think it makes more sense to check:
> if (tftp_window_size_option > 1 && tftp_state == STATE_SEND_RRQ)
>
> Because I understand that the tftp_state will change while the
> tftp_window_size_option is set or at compile time or through the environment. So
> we can save the check of the tftp_state if we have the default value.
>
> Regards,
> Matthias
>
The tftp_state can be only STATE_SEND_RRQ or STATE_SEND_WRQ and it's checked
one time per transfer, it won't change in the middle of transfer.
This code is run one time per transfer.
Thanks,
Ramon

  reply	other threads:[~2020-05-23 17:59 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-19 19:25 [PATCH v4] net: tftp: Add client support for RFC 7440 Ramon Fried
2020-05-22  0:29 ` rahasij
2020-05-22 19:19   ` Ramon Fried
2020-05-23 17:39 ` Matthias Brugger
2020-05-23 17:59   ` Ramon Fried [this message]
2020-06-03  2:54 ` Ravik Hasija
2020-06-04 16:17   ` Ramon Fried
2020-06-04 17:51     ` Ravik Hasija

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAGi-RU+BNDnMvH1+QaEYGjNcF58as1Tujn_Ci-G4WWZiXHV6Tw@mail.gmail.com \
    --to=rfried.dev@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.