From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE068C433F5 for ; Tue, 14 Sep 2021 09:25:00 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7A36261056 for ; Tue, 14 Sep 2021 09:25:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 7A36261056 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 39DC583B08; Tue, 14 Sep 2021 11:24:50 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="GFE86xqj"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 93AD683143; Tue, 14 Sep 2021 11:24:34 +0200 (CEST) Received: from mail-oo1-xc32.google.com (mail-oo1-xc32.google.com [IPv6:2607:f8b0:4864:20::c32]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 1B9D982AC8 for ; Tue, 14 Sep 2021 11:24:26 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=rfried.dev@gmail.com Received: by mail-oo1-xc32.google.com with SMTP id y47-20020a4a9832000000b00290fb9f6d3fso4406224ooi.3 for ; Tue, 14 Sep 2021 02:24:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=dy3JoVzJdidYnQZRdL6Q0xUBi0wUdP1Lju1IxvyG1bM=; b=GFE86xqjiHO5OufZXcqBimZrVil0YPPTfvX3KRYgSakC9CUPvJwLobMCXa+ltVElHq BXAZfEKW7/NfSFQIc1lLnG/eQYWanYCmCLf93VXsGEhdWbLh1AuWHTg+anSiedp4/OoT uvTpwA4dUPbsEOsh+d/Vajp7mnPhHyh75dAit8kQhz/xX+yUPzKoGNLrOYs5koF5DAMY CvnvSGTZoq7r8QulbPSEspFlD64eRRCzLtxHv8B9N5JT1AEQDs/523yEImgkha6OtpNi vKKZTB9rs0awxB3SOYuzjjxOO/DTPjfQ6yQ2JRJSFcUWA5CIAWh04jezdYmO4N6wACFV vh/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=dy3JoVzJdidYnQZRdL6Q0xUBi0wUdP1Lju1IxvyG1bM=; b=eDUb0WfUc6kTlHI7K7KvOKaqfapqfDqXwNJrDRmhgbm6O6QJN4p5pRYqun/W15USgz q7QrTjvxFcc/8d0t6k7pCF+G1/WsJ9a1vsuIgYGOMMtfmEcLiJ3NkmLr/ezhM68QV9So dWJwOKXRU2g0KvcMGp0G4Vs70gxAdtxGzxh8nWWKFCnk5VrBtEAMnLwmowkArr+9jG1z 6CURYjnm4VeEnLENLouanpdyVyb3Kip7wxX9cd6MLPn0/WAghVzJWMUEmtArNOkD0qqx KhH0nM0IFv7n3zWsuHkgk+ONxbyrGLtJrMamQHwdjmutEMSwoGjHDLh3XhJ9kkZy+hWZ ncaw== X-Gm-Message-State: AOAM533m9ihpfnzc4Jcl4aNE9gM3QkGIsRZ2uBhCUBFW12OycGTe5AKo RwvU9G/4xT8TFEu7V6ogkSs9yjLEZeir//PUn38= X-Google-Smtp-Source: ABdhPJzEHP1Ocp8fiyd65SgaeP4TF1rho/6o1F+rvGQ6orMxzYqi+djHaZMoyH+Z6+Pk4ZksMe9D79K4+kBPTsAQeV8= X-Received: by 2002:a4a:3443:: with SMTP id n3mr13355149oof.27.1631611464707; Tue, 14 Sep 2021 02:24:24 -0700 (PDT) MIME-Version: 1.0 References: <20210824120043.3823931-1-vladimir.oltean@nxp.com> <20210824120043.3823931-7-vladimir.oltean@nxp.com> In-Reply-To: <20210824120043.3823931-7-vladimir.oltean@nxp.com> From: Ramon Fried Date: Tue, 14 Sep 2021 12:24:13 +0300 Message-ID: Subject: Re: [PATCH v2 6/6] net: dsa: felix: propagate the error code from phy_startup() To: Vladimir Oltean Cc: Joe Hershberger , U-Boot Mailing List , Claudiu Manoil , Michael Walle , Priyanka Jain Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Tue, Aug 24, 2021 at 3:01 PM Vladimir Oltean wrote: > > Make sure that the link status returned by phy_startup() is propagated > to the .start() method of struct eth_ops. > > Signed-off-by: Vladimir Oltean > Reviewed-by: Ramon Fried > Tested-by: Michael Walle > --- > drivers/net/mscc_eswitch/felix_switch.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/net/mscc_eswitch/felix_switch.c b/drivers/net/mscc_eswitch/felix_switch.c > index c8ecf4f19442..6aa79784460d 100644 > --- a/drivers/net/mscc_eswitch/felix_switch.c > +++ b/drivers/net/mscc_eswitch/felix_switch.c > @@ -352,9 +352,7 @@ static int felix_port_enable(struct udevice *dev, int port, > FELIX_QSYS_SYSTEM_SW_PORT_LOSSY | > FELIX_QSYS_SYSTEM_SW_PORT_SCH(1)); > > - phy_startup(phy); > - > - return 0; > + return phy_startup(phy); > } > > static void felix_port_disable(struct udevice *dev, int pidx, > -- > 2.25.1 > Applied to u-boot-net/network-master Thanks, Ramon.