From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B001C11F68 for ; Fri, 2 Jul 2021 09:42:11 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 245BB613EA for ; Fri, 2 Jul 2021 09:42:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 245BB613EA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id C6FB380C70; Fri, 2 Jul 2021 11:42:07 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="g9a3s5QF"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 2740280F4B; Fri, 2 Jul 2021 11:42:06 +0200 (CEST) Received: from mail-ot1-x334.google.com (mail-ot1-x334.google.com [IPv6:2607:f8b0:4864:20::334]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 17BF4803B9 for ; Fri, 2 Jul 2021 11:42:03 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=rfried.dev@gmail.com Received: by mail-ot1-x334.google.com with SMTP id o17-20020a9d76510000b02903eabfc221a9so9552569otl.0 for ; Fri, 02 Jul 2021 02:42:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=RuaSYbUES/zjZRnD4c9Gq7kY0hedI2TPf1QQSXg2A9A=; b=g9a3s5QFheYtiENGWhWOU8qGmYopRkHdLEvy2HHgJGILS1s490VWWX0HvaXuL5X2kr 8bs9FqyrLt/PNe+6e2EbFAyY0y7OJ7fwbelIWtAgVFq8xH1NmeC+spDdUsXKrcyEYGke 9Ag7AEkJTWmig/tT8DO2+AUolOVldNDY0GZ6ZbMyZK8hSTtJ3QdMHRncy1RdxMhCfQbJ BDaQODRQXBQV0wqw4yKXVXgkbg80fuKRJdtpaW5oEW1eGhYE71oD2LzT5PSXGbiuLWyc 7QGYH1KKL4S6eBI7v6qzkwOSPdL9Mot+wuYGav/HXXEY+B3Rm0PHzxHCGrtirkTM4xok F6SA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=RuaSYbUES/zjZRnD4c9Gq7kY0hedI2TPf1QQSXg2A9A=; b=In8zW0vm6vwY4OdJbLRvef8CLqomLYKrHstzXh0STQQpjJ2bxaaynb9gMKx70SPTUZ u2nELioGhodTVGRx6AJwWtA25tUwH+h3XZXbMeVJX7P7UAJsCzT46TwmQm3nLQyKeaK3 0g27AbVn+mkVIG+l42FovERIbCKpYiFZYaX48Ru2jevkHY6V8j22QB7PH43HUZB/2v0J 3TPBS0pjTJgvsyKIUoH5CGvL6BgmS3KCTpxc0CHNtsCTIYCvp18tOb80PkcV/ONoYKZQ 0oBhdiTsLgW+W76D7dpIRQCDpzC43UHa84q0bCNpcubuUpqqgk4PJNdr79yoP7hvGmXB nocw== X-Gm-Message-State: AOAM530IP4lb6TNl4TzHnwsayermJMhUqfMYa8XT0wcwDZerPAXO8o+I Y3ABwvs103NJiNgLSACGKLTlAlpu9XzeBb2tCL4= X-Google-Smtp-Source: ABdhPJyKK1DntVtlgasIZZKKBcpZpk8oAPVK7EvLGQ/BnY/DyfxM5Lhpv/NNoHaiTVfkDGxbd4a0ZIMFpoaRKqHLohA= X-Received: by 2002:a9d:7192:: with SMTP id o18mr3912299otj.370.1625218921717; Fri, 02 Jul 2021 02:42:01 -0700 (PDT) MIME-Version: 1.0 References: <20210623115602.5015-1-michael@walle.cc> <9d1873bbe6909811f6be546a0004030b@walle.cc> <20210630103456.6fwem735ue7r7dzg@skbuf> <568d9ce6ef5432ca6d7b8d08657b9b87@walle.cc> In-Reply-To: <568d9ce6ef5432ca6d7b8d08657b9b87@walle.cc> From: Ramon Fried Date: Fri, 2 Jul 2021 12:41:50 +0300 Message-ID: Subject: Re: [PATCH v2] board: sl28: add DSA support for variant 2 To: Michael Walle Cc: Vladimir Oltean , U-Boot Mailing List , Priyanka Jain Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Wed, Jun 30, 2021 at 2:21 PM Michael Walle wrote: > > Am 2021-06-30 12:34, schrieb Vladimir Oltean: > > On Wed, Jun 30, 2021 at 10:26:57AM +0200, Michael Walle wrote: > >> Can this please go through the net queue? > >> > >> By chance, I've seen this patch: > >> https://patchwork.ozlabs.org/project/uboot/patch/20210629175317.2607470-5-vladimir.oltean@nxp.com/ > >> > >> Now I'm lucky that I have the following chunk, otherwise the patch > >> wouldn't > >> work. > >> > >> +&enetc2 { > >> + status = "okay"; > >> +}; > > > > Why "lucky"? I remember you were pushing this device tree style in the > > first place. > > Thats correct, but in u-boot this device was still defaulting to > status = "okay", thus it would have been superfluous to still enable > it in the board dts. And tbh, I don't exactly know why I enabled > it nonetheless. Normally I keep things small ;) > > Its not about the change (which is good), but there seems to be > a disconnect between which patches goes through which queue and > you have to be lucky that a (newer) patch doesn't break your patch > which is sitting on another queue to be picked up while the newer > one is already pulled in. > > -- > -michael Applied to u-boot-net/master, Thanks ! Ramon