Re: [PATCH] net: tsec: mark tsec_set_promisc() as __maybe_unused

From: Ramon Fried <rfried.dev@gmail.com>
To: Vladimir Oltean <vladimir.oltean@nxp.com>
Cc: U-Boot Mailing List <u-boot@lists.denx.de>,
	Joe Hershberger <joe.hershberger@ni.com>,
	Bin Meng <bmeng.cn@gmail.com>
Subject: Re: [PATCH] net: tsec: mark tsec_set_promisc() as __maybe_unused
Date: Wed, 3 Nov 2021 08:57:45 +0200	[thread overview]
Message-ID: <CAGi-RU+PgvY-qZFE-80-g+1bw1J1K=pNaKO4bx_jdTRHD-3fsg@mail.gmail.com> (raw)
In-Reply-To: <20211031215158.4028047-1-vladimir.oltean@nxp.com>

On Sun, Oct 31, 2021 at 11:52 PM Vladimir Oltean
<vladimir.oltean@nxp.com> wrote:
>
> Since the tsec driver supports both configurations with and without
> DM_ETH, and since the eth_ops :: set_promisc() method is only provided
> for DM_ETH, the implication is that builds with DM_ETH disabled will
> result in a 'defined but not used' warning.
>
> To silence those, mark the function as __maybe_unused.
>
> Fixes: 79ba3435f43d ("net: tsec: add support for promiscuous mode")
> Reported-by: Ramon Fried <rfried.dev@gmail.com>
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
> ---
>  drivers/net/tsec.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/tsec.c b/drivers/net/tsec.c
> index 4354753cab9c..64bb42b0c006 100644
> --- a/drivers/net/tsec.c
> +++ b/drivers/net/tsec.c
> @@ -156,7 +156,7 @@ static int tsec_mcast_addr(struct udevice *dev, const u8 *mcast_mac, int join)
>         return 0;
>  }
>
> -static int tsec_set_promisc(struct udevice *dev, bool enable)
> +static int __maybe_unused tsec_set_promisc(struct udevice *dev, bool enable)
>  {
>         struct tsec_private *priv = dev_get_priv(dev);
>         struct tsec __iomem *regs = priv->regs;
> --
> 2.25.1
>
Hi.
I will alter your original patch with this addition, as it wasn't merged yet.
We should have all our commits pass compilation.
Thanks,
Ramon