From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ramon Fried Date: Thu, 29 Apr 2021 23:23:52 +0300 Subject: [PATCH v1 04/10] net: mvpp2: remove redundant SMI address configuration In-Reply-To: <20210427152713.v1.4.Ie579dd23cb40ead83e35c339c829b6a1537d5877@changeid> References: <20210427132718.645043-1-sr@denx.de> <20210427152713.v1.4.Ie579dd23cb40ead83e35c339c829b6a1537d5877@changeid> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Tue, Apr 27, 2021 at 4:28 PM Stefan Roese wrote: > > From: Marcin Wojtas > > Because the mvpp2 driver now relies on the PHYLIB and > the external MDIO driver, configuring low level > SMI bus settings is redundant. > > Signed-off-by: Marcin Wojtas > Tested-by: sa_ip-sw-jenkins > Reviewed-by: Kostya Porotchkin > Reviewed-by: Stefan Chulski > Signed-off-by: Stefan Roese > --- > > drivers/net/mvpp2.c | 12 ------------ > 1 file changed, 12 deletions(-) > > diff --git a/drivers/net/mvpp2.c b/drivers/net/mvpp2.c > index 847007d5b487..2043bdf10aa4 100644 > --- a/drivers/net/mvpp2.c > +++ b/drivers/net/mvpp2.c > @@ -5292,14 +5292,6 @@ static int mvpp2_write_hwaddr(struct udevice *dev) > return mvpp2_prs_update_mac_da(port, port->dev_addr); > } > > -static int mvpp22_smi_phy_addr_cfg(struct mvpp2_port *port) > -{ > - writel(port->phyaddr, port->priv->iface_base + > - MVPP22_SMI_PHY_ADDR_REG(port->gop_id)); > - > - return 0; > -} > - > static int mvpp2_base_probe(struct udevice *dev) > { > struct mvpp2 *priv = dev_get_priv(dev); > @@ -5422,10 +5414,6 @@ static int mvpp2_probe(struct udevice *dev) > port->base = priv->iface_base + MVPP22_PORT_BASE + > port->gop_id * MVPP22_PORT_OFFSET; > > - /* Set phy address of the port */ > - if (port->phyaddr < PHY_MAX_ADDR) > - mvpp22_smi_phy_addr_cfg(port); > - > /* GoP Init */ > gop_port_init(port); > } > -- > 2.31.1 > Reviewed-by: Ramon Fried