From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 453CFC433EF for ; Fri, 18 Mar 2022 07:54:53 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 5630A836B4; Fri, 18 Mar 2022 08:54:51 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="o4Sz2eHg"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 57186836B4; Fri, 18 Mar 2022 08:54:49 +0100 (CET) Received: from mail-ot1-x32e.google.com (mail-ot1-x32e.google.com [IPv6:2607:f8b0:4864:20::32e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 08D378366A for ; Fri, 18 Mar 2022 08:54:46 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=rfried.dev@gmail.com Received: by mail-ot1-x32e.google.com with SMTP id d15-20020a05683018ef00b005b2304fdeecso5127115otf.1 for ; Fri, 18 Mar 2022 00:54:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=yPyFWxuKQdk9KH++5xh0kfKCcR6fo05jRxTPPRXNrWo=; b=o4Sz2eHgH0atKEJq5oktsmVgAVN4EJef9wOeqwsgG+Y1prwMIf4UYRE1QhYp3pIEmF bwUL0ssl9KF010WgpGEs7bNn5XFHPzoihJNjvx6XRhH5EGbR6HzeMCEqVlXowu+v0+Uk tpDpcarOptoSv7jB+P9aX4mDQ9HxjqCVyo6spXD2gx+jUgwI4vtwH1GaP6TJac2YPAvA z55vHjpZzpskFgEmWIsJplvEhEGQ+bkBXJTbLseF9FA48pzBfwCjAEXu8d2a+bNlIPea UsZyaQLN7kiZt5jqtXsn19K6LxJLscIgz0MHHnK2RSriNk+OSPXp2lwFqlPUkIxUoRr1 YPhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=yPyFWxuKQdk9KH++5xh0kfKCcR6fo05jRxTPPRXNrWo=; b=uEG5MRRH2rOep9R5M0yhqRZtNxA9i7E/2Me1s+0AKFZecnw+MbEZTaeLSZK2i6OLh0 pQhaOKCstS/RANFGOB/jTnAf8AjjIhjrHTwnoG7S2kwGkzpR7JiAsc3a/lDuBFWCm2Dn gLtgI/nrMJVITcT0RjNgC63cQsRVB0uLm66jV57IPp7Ns6PtSEMvDg7E3aJGW8DS1l6Z 5Bw1ibZoIyGjVHbg8E9/9aHeEZ+w+chSUIVO6ADXxvx8DFvTRl7zyhEXcPNKEGK0rJks 0RRPf9fahVx5pSDuh6VPuDyBmEYumM1QKxQXhjQYZEzSLWRaUfzhyl7o4PaO6de6FFoY 3IVQ== X-Gm-Message-State: AOAM532P4s5EUYI0/UZB/uQuZfyU+F7cQiRTvLzGoxxaQOU55zFqAyZm PSkZltwVzRWzoMPJlVBd2aV+3riS15oN8hFf3TzZDtuqXf8= X-Google-Smtp-Source: ABdhPJwV732mfduQ2djt2c7nbi81rwptsxdv3TLSFfXlK1j605XehrTL9oEThS0jHhNiciqZOf83Q0o2AVTbXC7J8V4= X-Received: by 2002:a05:6830:2709:b0:5b0:196:dcf with SMTP id j9-20020a056830270900b005b001960dcfmr2961919otu.357.1647590084761; Fri, 18 Mar 2022 00:54:44 -0700 (PDT) MIME-Version: 1.0 References: <20220317124958.27921-1-kabel@kernel.org> <20220317124958.27921-2-kabel@kernel.org> In-Reply-To: <20220317124958.27921-2-kabel@kernel.org> From: Ramon Fried Date: Fri, 18 Mar 2022 09:54:33 +0200 Message-ID: Subject: Re: [PATCH u-boot-net 01/14] net: mdio-uclass: fix type for phy_mode_str and phy_handle_str To: =?UTF-8?B?TWFyZWsgQmVow7pu?= Cc: Joe Hershberger , U-Boot Mailing List , =?UTF-8?B?TWFyZWsgQmVow7pu?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On Thu, Mar 17, 2022 at 2:50 PM Marek Beh=C3=BAn wrote: > > From: Marek Beh=C3=BAn > > These global variables should both have type > static const char * const > > Signed-off-by: Marek Beh=C3=BAn > --- > net/mdio-uclass.c | 11 ++++++----- > 1 file changed, 6 insertions(+), 5 deletions(-) > > diff --git a/net/mdio-uclass.c b/net/mdio-uclass.c > index e74e34f78f..5735afe49e 100644 > --- a/net/mdio-uclass.c > +++ b/net/mdio-uclass.c > @@ -17,13 +17,14 @@ > > /* DT node properties for MAC-PHY interface */ > #define PHY_MODE_STR_CNT 2 > -static const char *phy_mode_str[PHY_MODE_STR_CNT] =3D { "phy-mode", > - "phy-connection-typ= e" }; > +static const char * const phy_mode_str[PHY_MODE_STR_CNT] =3D { > + "phy-mode", "phy-connection-type" > +}; > /* DT node properties that reference a PHY node */ > #define PHY_HANDLE_STR_CNT 3 > -const char *phy_handle_str[PHY_HANDLE_STR_CNT] =3D { "phy-handle", > - "phy", > - "phy-device" }; > +static const char * const phy_handle_str[PHY_HANDLE_STR_CNT] =3D { > + "phy-handle", "phy", "phy-device" > +}; > > void dm_mdio_probe_devices(void) > { > -- > 2.34.1 > Reviewed-by: Ramon Fried