From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 674F6C433EF for ; Sat, 16 Oct 2021 18:28:10 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BE47661152 for ; Sat, 16 Oct 2021 18:28:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org BE47661152 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 921EB83252; Sat, 16 Oct 2021 20:28:07 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="QrfAyQhY"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 5CE9C8326F; Sat, 16 Oct 2021 20:28:06 +0200 (CEST) Received: from mail-oi1-x236.google.com (mail-oi1-x236.google.com [IPv6:2607:f8b0:4864:20::236]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 20C63831FD for ; Sat, 16 Oct 2021 20:28:03 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=rfried.dev@gmail.com Received: by mail-oi1-x236.google.com with SMTP id m67so18205724oif.6 for ; Sat, 16 Oct 2021 11:28:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=eBqPtSjAnDRul088fDnEj5K+uhC1xUCKJyiIrPF2PzI=; b=QrfAyQhYn/kZiiP8/p+/moSz892igO3z/N/VCFKjc+YMM22ywdoyhCoYzBn0KO/PFU UdcEi0X0vvPw+9y8lv/PKXAdbx6JkhG1L2vIq33UlK915IjpzXSO8Z2XJBuib/cs7Jui TtXbYsmP6pCK0lNUnJlXNglLLSnnakAE6so3gD9G8kTyNDZDvV2Lu3th0FzlJgdXy2j6 KWCIm2ah578ItBt5kmW0dMg9hTsxSJJnAv+r7+MFG6InX2YtDio7wxxCVlAdS7j9KkXT EGyiUH5waEHHlg2ynFyqbH1AMs6HQ2xbLvx3nhpSPLOU/T9cu5JEyzr/Zzri0zpEMpu0 o/Mg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=eBqPtSjAnDRul088fDnEj5K+uhC1xUCKJyiIrPF2PzI=; b=Izq0F508s4bfxvsZrW8hJnILU4YWIRI2kNpssswsls4zKuRkfMbgOUFu+DN1ttO8mg Vo/eBqXLwh42ip6kAJa9lKza9l3TtJ5yUimAqzlkUt2OEewzMLPLNSwc+VUS69/xkS9A FuLMKeI0tB40hj7L3Fa9+xgI+5Pqu4FpP/j/QUurEKxcrlt7IejcIXcRbpVlUvghjL3w bnTZQoPk5r6w/SnROw1JZykW4QAPKdHyz9aHeGuzdxUITBcL6zqMrniue0ArNOQVtemm aFWb5iK8Ng8Vmwqf39/ERMmQ5k1INfoswr93kS9ZyS0ZM2cj1m4bE/yAR7dtNzJ1UwR9 vVhg== X-Gm-Message-State: AOAM530qWg+rnBwHON4q79hHomScf1gyp9eLSL5ThURuE2inqnaHF4QQ dM9c61eWMIlXqAMMP89BsaYiYoACL00OQe3bnrRESjXSeoOw+g== X-Google-Smtp-Source: ABdhPJxCSB+L48rlHqpRhqpyzxh3qpskujuZae2c663ZjWKr4fjl7AGMFtJQlP1LGj+dUgHRFij/9afJ9O3YpG7wcxA= X-Received: by 2002:aca:ebc7:: with SMTP id j190mr23112212oih.54.1634408881857; Sat, 16 Oct 2021 11:28:01 -0700 (PDT) MIME-Version: 1.0 References: <20210929055046.4326-1-bmeng.cn@gmail.com> <20210929055046.4326-3-bmeng.cn@gmail.com> In-Reply-To: <20210929055046.4326-3-bmeng.cn@gmail.com> From: Ramon Fried Date: Sat, 16 Oct 2021 21:27:50 +0300 Message-ID: Subject: Re: [PATCH 3/3] net: tsec: Make redundant_init() static To: Bin Meng Cc: U-Boot Mailing List , Vladimir Oltean Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Wed, Sep 29, 2021 at 8:50 AM Bin Meng wrote: > > redundant_init() is only called in the tsec driver. Make it static. > > Signed-off-by: Bin Meng > --- > > drivers/net/tsec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/tsec.c b/drivers/net/tsec.c > index ee820aae15..b433e411bd 100644 > --- a/drivers/net/tsec.c > +++ b/drivers/net/tsec.c > @@ -432,7 +432,7 @@ static void tsec_halt(struct udevice *dev) > * of the eTSEC port initialization sequence, > * the eTSEC Rx logic may not be properly initialized. > */ > -void redundant_init(struct tsec_private *priv) > +static void redundant_init(struct tsec_private *priv) > { > struct tsec __iomem *regs = priv->regs; > uint t, count = 0; > -- > 2.25.1 > Reviewed-by: Ramon Fried