From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6B1F3C433EF for ; Fri, 10 Dec 2021 23:11:14 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 2DC4D835A1; Sat, 11 Dec 2021 00:11:12 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="EVBn9wkf"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id B0D8D836C5; Sat, 11 Dec 2021 00:11:09 +0100 (CET) Received: from mail-oi1-x233.google.com (mail-oi1-x233.google.com [IPv6:2607:f8b0:4864:20::233]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 9EB3C835A1 for ; Sat, 11 Dec 2021 00:11:05 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=rfried.dev@gmail.com Received: by mail-oi1-x233.google.com with SMTP id bf8so15291438oib.6 for ; Fri, 10 Dec 2021 15:11:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=m/WZD4w4vUUzLeHl6+TaDD34tVjEsTqt/x5yZMETNno=; b=EVBn9wkfGIXJv8s6bUN7AfkUnAJakRRyrVbhjrWTurs5M2a+xydCeHhOUH9Cew5sS8 0iTTkn2Rg+UmEDctZXY2Ufwmz7lrcLiOLcc9947kUcxnOs1dPnzuSeJRlqtwgKMT/HAH OfJKxnXs7kM7R33RuO1jaKcLCdNn/KfTwHuF/R2P02jLsbGEYwsXczZs44J14RKLAYQp T84AGoIaKWNz463wFNFezD4yajdH6phs4ANTiRgKMOAbhRHtoMP7hgUjGyq6sZKbAyfR GY/56aXzFKXCTlV9fMVtIZgAXp28j9+qtdFU6Hm6gbNw4+x3XKweIZVJ5lSNB67h8/V2 1aRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=m/WZD4w4vUUzLeHl6+TaDD34tVjEsTqt/x5yZMETNno=; b=q3MA/H2pKd1xu4WR1YlGPWJ2qzt0Cu6NtAcwrzh1Gq/XifxXS30AyWA3lKXMdn+Sb6 xEqBL7dlsbBqlz8Q0rmzI37VqULFz7sHz428y0IPmJ4xxo0SInGFjLl0D4RkIXVzUCu7 fWH+vZn1EJBkc2SmafMJyqXhop3WkG2auhbLcxRNNWvylDOZH3KfAEB6tQb+5wMo8448 uT+6uBGKg+P+3PP/3yEARbAt7vMVQSjhFYgxz0odFKFg23HFWoJ51OxTEg61ibcnvaP0 HkNqa2DjUFYogEpiw/jsN1vG9Lg5VN25YM4q/PYGlYNsPGaj1DolLK7nb7ZWC7L+kC2H Oj3w== X-Gm-Message-State: AOAM530VbtgLq9kxkpCsOpDPZn3mb9wsgkB2ZFS2BM+4wPfkCiJLwmH8 /SN+Cf0IsKH8XVwH4aKa47cRSpxGSJ3HbNb/f98= X-Google-Smtp-Source: ABdhPJyN4vvq/xw+MU3g48KJH2fNYLddW2PNumBvldgaiJoy6w1/b1udnBEiRvlKFcH9vh5R14d+84ISL1kYUd90j2c= X-Received: by 2002:a05:6808:1885:: with SMTP id bi5mr16014458oib.54.1639177864376; Fri, 10 Dec 2021 15:11:04 -0800 (PST) MIME-Version: 1.0 References: <20211209021228.27597-1-dylan_hung@aspeedtech.com> <20211209021228.27597-6-dylan_hung@aspeedtech.com> In-Reply-To: <20211209021228.27597-6-dylan_hung@aspeedtech.com> From: Ramon Fried Date: Sat, 11 Dec 2021 01:10:53 +0200 Message-ID: Subject: Re: [next 5/5] clk: ast2600: Revise MII interface delay To: Dylan Hung Cc: chiawei_wang@aspeedtech.com, Lukasz Majewski , Sean Anderson , ryan_chen@aspeedtech.com, Joe Hershberger , U-Boot Mailing List , BMC-SW@aspeedtech.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.38 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Thu, Dec 9, 2021 at 4:12 AM Dylan Hung wrote: > > The clock delay of the RMII/RGMII interface is controlled by SCU340~35C. > These values are obtained by measurement and experiments so we simply > use macro to define them. > > Signed-off-by: Dylan Hung > --- > drivers/clk/aspeed/clk_ast2600.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/clk/aspeed/clk_ast2600.c b/drivers/clk/aspeed/clk_ast2600.c > index 3a92739f5cf5..6441fcbbbd4c 100644 > --- a/drivers/clk/aspeed/clk_ast2600.c > +++ b/drivers/clk/aspeed/clk_ast2600.c > @@ -19,11 +19,11 @@ DECLARE_GLOBAL_DATA_PTR; > #define CLKIN_25M 25000000UL > > /* MAC Clock Delay settings */ > -#define MAC12_DEF_DELAY_1G 0x0041b75d > -#define MAC12_DEF_DELAY_100M 0x00417410 > -#define MAC12_DEF_DELAY_10M 0x00417410 > -#define MAC34_DEF_DELAY_1G 0x0010438a > -#define MAC34_DEF_DELAY_100M 0x00104208 > +#define MAC12_DEF_DELAY_1G 0x0028a410 > +#define MAC12_DEF_DELAY_100M 0x00410410 > +#define MAC12_DEF_DELAY_10M 0x00410410 > +#define MAC34_DEF_DELAY_1G 0x00104208 > +#define MAC34_DEF_DELAY_100M 0x00104208 > #define MAC34_DEF_DELAY_10M 0x00104208 > > /* > -- > 2.25.1 > Reviewed-by: Ramon Fried