From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 682B4C433F5 for ; Fri, 18 Mar 2022 08:10:48 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 0719E82A53; Fri, 18 Mar 2022 09:10:46 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="YeXQvBNb"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id C3D4883110; Fri, 18 Mar 2022 09:10:43 +0100 (CET) Received: from mail-oo1-xc35.google.com (mail-oo1-xc35.google.com [IPv6:2607:f8b0:4864:20::c35]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id CED7881DDF for ; Fri, 18 Mar 2022 09:10:40 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=rfried.dev@gmail.com Received: by mail-oo1-xc35.google.com with SMTP id q1-20020a4a7d41000000b003211b63eb7bso9328191ooe.6 for ; Fri, 18 Mar 2022 01:10:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=186UHEk8uIZKZonOS1y2MPRuHDOUfGOoO9KisalzULI=; b=YeXQvBNb+T/A6lGO01kVsJw7XVkJsMvBqoMR+8TZF6+8KaNsKw0RwR9JLN3TN3hKTv z/+/N+RhwInW/jufTqvTj2KFLvhNabjlRxBFoYInz9ipeqc4ApjV5WpSHaaXr+U1kgrB 4cJNHHioqF+T1xLgdyv0IgtC4gcv+5GuTlmb9rh+XvEHWesLWnuQ2kEv27B3dx4E1seO litLZqS2UIlS9n9Vc9HtG3jnB/fTCIGG/FD18Np4sQXfsKdQz9cPuKh9jJG+emtw6oRm BH6JOyGrGnYhfEkqQ1OTG+s7+h3SlNJLBWA0yYgmqSuqcD4Dn9KqkdxBAsCx9DkKXVIj gDuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=186UHEk8uIZKZonOS1y2MPRuHDOUfGOoO9KisalzULI=; b=q/nmgfa3ob8N+F31ftvXgdnVryou7anF9K/onSXFPyh4Y+YSmiqvXI4xbk2QYQOeJG OYhZvjTzoHhvCrWvD519Xkz+jP/x6n1aNfzTlWg3glK6mCgEgWwrqJVjXJ7nSY6mo12m gFrBJ/nuP3v6xuGISz6+S637sUGIRGobNdDaFAzdDUcOc+6xUO+tV8Xya6rKs62jpv41 vL0W7avmJWfPRJH/7VSUdVXrFITDin4UUn4IDMY1HRWFWOo9i+g1pU3JD7Qg5MbxUd1V ZUuBDrM66fFEoyI7xLkOBqU5/4VfuUw3y4jMG82VdTE4R+GSwLoaEj2941sJPGlf1Bja szBQ== X-Gm-Message-State: AOAM531FFgcpklQSRB0iD8/T3NHMD50atZyS8JHDkpBfbPj3a0wRPQyo a4V/R85Y5wvO+60mwx2Ih3AlkD6NB5HuOsXSRmU= X-Google-Smtp-Source: ABdhPJyT21D/xR6kuCLMqx+fz2SpRuF9bSf8fb1Frdsd8Wp1lo7gA5DFETXHw8eTlNn5sCtnkBOimKFvTFh9R8mSA+s= X-Received: by 2002:a05:6870:581e:b0:da:ff48:bd98 with SMTP id r30-20020a056870581e00b000daff48bd98mr6710134oap.138.1647591039670; Fri, 18 Mar 2022 01:10:39 -0700 (PDT) MIME-Version: 1.0 References: <20220317124958.27921-1-kabel@kernel.org> <20220317124958.27921-14-kabel@kernel.org> In-Reply-To: <20220317124958.27921-14-kabel@kernel.org> From: Ramon Fried Date: Fri, 18 Mar 2022 10:10:28 +0200 Message-ID: Subject: Re: [PATCH u-boot-net 13/14] bcmgenet, sun8i_emac: Don't connect PHY two times To: =?UTF-8?B?TWFyZWsgQmVow7pu?= Cc: Joe Hershberger , U-Boot Mailing List , =?UTF-8?B?TWFyZWsgQmVow7pu?= , Andre Przywara , Heinrich Schuchardt , Samuel Holland , Wolfgang Denk Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On Thu, Mar 17, 2022 at 2:50 PM Marek Beh=C3=BAn wrote: > > From: Marek Beh=C3=BAn > > The bcmgenet and sun8i_emac drivers call phy_connect(), which finds / > creates the PHY and also connects it to the eth device via > phy_connect_dev(), then set some phydev members (bcmgenet only), and > then call phy_connect_dev() explicitly again. > > Drop the second phy_connect_dev(), since it is unnecesary. > > Signed-off-by: Marek Beh=C3=BAn > --- > drivers/net/bcmgenet.c | 2 -- > drivers/net/sun8i_emac.c | 2 -- > 2 files changed, 4 deletions(-) > > diff --git a/drivers/net/bcmgenet.c b/drivers/net/bcmgenet.c > index ef321f2839..4e1f8ed7a4 100644 > --- a/drivers/net/bcmgenet.c > +++ b/drivers/net/bcmgenet.c > @@ -526,8 +526,6 @@ static int bcmgenet_phy_init(struct bcmgenet_eth_priv= *priv, void *dev) > } > phydev->advertising =3D phydev->supported; > > - phy_connect_dev(phydev, dev); > - > priv->phydev =3D phydev; > phy_config(priv->phydev); > > diff --git a/drivers/net/sun8i_emac.c b/drivers/net/sun8i_emac.c > index 5943a5e3f0..906a8ec5d0 100644 > --- a/drivers/net/sun8i_emac.c > +++ b/drivers/net/sun8i_emac.c > @@ -391,8 +391,6 @@ static int sun8i_phy_init(struct emac_eth_dev *priv, = void *dev) > if (!phydev) > return -ENODEV; > > - phy_connect_dev(phydev, dev); > - > priv->phydev =3D phydev; > phy_config(priv->phydev); > > -- > 2.34.1 > Reviewed-by: Ramon Fried