From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F462C433F5 for ; Sun, 5 Sep 2021 13:35:23 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8D09860F5B for ; Sun, 5 Sep 2021 13:35:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 8D09860F5B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 8EC0B832D1; Sun, 5 Sep 2021 15:35:20 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="TJTV86MS"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id CE27B832D1; Sun, 5 Sep 2021 15:35:18 +0200 (CEST) Received: from mail-ot1-x32e.google.com (mail-ot1-x32e.google.com [IPv6:2607:f8b0:4864:20::32e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 5F36083205 for ; Sun, 5 Sep 2021 15:35:15 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=rfried.dev@gmail.com Received: by mail-ot1-x32e.google.com with SMTP id k12-20020a056830150c00b0051abe7f680bso5270027otp.1 for ; Sun, 05 Sep 2021 06:35:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=T57ahyeSUfr37JbPI0kCijDQTX/2GrLXe4kaL9rkLcQ=; b=TJTV86MS8BqvJeRPbEnnuSNbxMLA5rVssLYBjeC0eiXcIzH4uKjk/cgQ3uYZqAcv0q 4bdGK8DtZrj25JFz84YaXkgYNcTVV/h3No6aztOmIrNf12uusUwKAD6QnvbX7oHSdNUe 4rDJ9XBX1dO9v1rbVhuBl8xAAKi986LhYse5wN6ZpGBE3xp8PbzarWO9f8rrADeJ3WWK 2QLiSZPFVcM2uSsLZI0Mz3Ui2w9fliJphja4iHjRK+GljTOdlNLF48/XQiedp8OMorhw pAPatC6EwB8BQvFkVv9gore/HJB2dlk6XvRzrZYP6LXd63fzcP+urlqt/Ed8aRBNxX4q lFvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=T57ahyeSUfr37JbPI0kCijDQTX/2GrLXe4kaL9rkLcQ=; b=DPcisfN2hx4bwFKoWYLky+DalYCMBXE+PNnG8/mcXWbgPwwcUowyIIEHySph6d7EWR BBCtr81JKNw9NUk8VJ4vKcazJ76JZDd+N29n3PbFvtjz3MYMej/jVFhnbV+FxBmzsSim WNkbUcf27dc8g5wGNSJLqBhlLOjIho5IxIqt/pd4nIQFTy6o3zmzPZvOX656HtRXo1vJ EX67JXCFe4RcL97I/+0u/ivfXPTF0qyshF8Wqfo4DfxxNUMjQhUY3I38Qg3966zJk6ZB Exfe6trxdAfXtwLSzZNFwA7IILHgALrb+8Kxqm8EZKqZ0YgY99gq5j5QkiK22BmjMsjw 3IeA== X-Gm-Message-State: AOAM530Ocp3VNcrNMNrjvX5BGyavu8jVto7eD5WmHfm0zv4sxzay7UH4 Z4sN+h/9BWWTTKJ6DQ23suLLep7IM8DLx0PP9o0zuIEqlQ1qfg== X-Google-Smtp-Source: ABdhPJwR1Kj9vD8Zw06ecYolXbXtrO8cAadMkJeSkzcnyU/tWNi2il/r9c7CxjhJX+nWN6oLBJCKUSsoF+kvU8FiuSI= X-Received: by 2002:a05:6830:1b78:: with SMTP id d24mr7119317ote.197.1630848913879; Sun, 05 Sep 2021 06:35:13 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Ramon Fried Date: Sun, 5 Sep 2021 16:35:02 +0300 Message-ID: Subject: Re: Subject: [PATCH 3/6] pinctrl: qcom: add pinctrl and gpio drivers for SDM845 To: =?UTF-8?B?0JTQvNC40YLRgNC40Lkg0KHQsNC90LrQvtCy0YHQutC40Lk=?= Cc: U-Boot Mailing List Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Tue, Aug 31, 2021 at 11:44 AM =D0=94=D0=BC=D0=B8=D1=82=D1=80=D0=B8=D0=B9= =D0=A1=D0=B0=D0=BD=D0=BA=D0=BE=D0=B2=D1=81=D0=BA=D0=B8=D0=B9 wrote: > > From 520bc565a5a6f62c59f87bbd15a194ee61c103af Mon Sep 17 00:00:00 2001 > From: Dzmitry Sankouski > Date: Sun, 29 Aug 2021 21:53:40 +0300 > Subject: [PATCH 3/6] pinctrl: qcom: add pinctrl and gpio drivers for SDM8= 45 > SoC > > Signed-off-by: Dzmitry Sankouski > Cc: Ramon Fried > --- > arch/arm/mach-snapdragon/pinctrl-sdm845.c | 44 +++++++++++++++++++ > arch/arm/mach-snapdragon/pinctrl-snapdragon.c | 1 + > arch/arm/mach-snapdragon/pinctrl-snapdragon.h | 1 + > drivers/gpio/msm_gpio.c | 1 + > drivers/gpio/pm8916_gpio.c | 8 ++-- > 5 files changed, 52 insertions(+), 3 deletions(-) > create mode 100644 arch/arm/mach-snapdragon/pinctrl-sdm845.c > > diff --git a/arch/arm/mach-snapdragon/pinctrl-sdm845.c b/arch/arm/mach-sn= apdragon/pinctrl-sdm845.c > new file mode 100644 > index 0000000000..6d66582aa6 > --- /dev/null > +++ b/arch/arm/mach-snapdragon/pinctrl-sdm845.c > @@ -0,0 +1,44 @@ > +// SPDX-License-Identifier: GPL-2.0+ > +/* > + * Qualcomm SDM845 pinctrl > + * > + * (C) Copyright 2021 Dzmitry Sankouski > + * > + */ > + > +#include "pinctrl-snapdragon.h" > +#include > + > +#define MAX_PIN_NAME_LEN 32 > +static char pin_name[MAX_PIN_NAME_LEN]; > + > +static const struct pinctrl_function msm_pinctrl_functions[] =3D { > + {"qup9", 1}, > + {"gpio", 0}, > +}; > + > +static const char *sdm845_get_function_name(struct udevice *dev, > + unsigned int selector) > +{ > + return msm_pinctrl_functions[selector].name; > +} > + > +static const char *sdm845_get_pin_name(struct udevice *dev, > + unsigned int selector) > +{ > + snprintf(pin_name, MAX_PIN_NAME_LEN, "GPIO_%u", selector); > + return pin_name; > +} > + > +static unsigned int sdm845_get_function_mux(unsigned int selector) > +{ > + return msm_pinctrl_functions[selector].val; > +} > + > +struct msm_pinctrl_data sdm845_data =3D { > + .pin_count =3D 150, > + .functions_count =3D ARRAY_SIZE(msm_pinctrl_functions), > + .get_function_name =3D sdm845_get_function_name, > + .get_function_mux =3D sdm845_get_function_mux, > + .get_pin_name =3D sdm845_get_pin_name, > +}; > diff --git a/arch/arm/mach-snapdragon/pinctrl-snapdragon.c b/arch/arm/mac= h-snapdragon/pinctrl-snapdragon.c > index e6b87c3573..c0ed943036 100644 > --- a/arch/arm/mach-snapdragon/pinctrl-snapdragon.c > +++ b/arch/arm/mach-snapdragon/pinctrl-snapdragon.c > @@ -116,6 +116,7 @@ static struct pinctrl_ops msm_pinctrl_ops =3D { > static const struct udevice_id msm_pinctrl_ids[] =3D { > { .compatible =3D "qcom,tlmm-apq8016", .data =3D (ulong)&apq8016_data }= , > { .compatible =3D "qcom,tlmm-apq8096", .data =3D (ulong)&apq8096_data }= , > + { .compatible =3D "qcom,tlmm-sdm845", .data =3D (ulong)&sdm845_data }, > { } > }; > > diff --git a/arch/arm/mach-snapdragon/pinctrl-snapdragon.h b/arch/arm/mac= h-snapdragon/pinctrl-snapdragon.h > index 61d466f4d8..ea524312a0 100644 > --- a/arch/arm/mach-snapdragon/pinctrl-snapdragon.h > +++ b/arch/arm/mach-snapdragon/pinctrl-snapdragon.h > @@ -27,5 +27,6 @@ struct pinctrl_function { > > extern struct msm_pinctrl_data apq8016_data; > extern struct msm_pinctrl_data apq8096_data; > +extern struct msm_pinctrl_data sdm845_data; > > #endif > diff --git a/drivers/gpio/msm_gpio.c b/drivers/gpio/msm_gpio.c > index e1ff84c1c0..a3c3cd7824 100644 > --- a/drivers/gpio/msm_gpio.c > +++ b/drivers/gpio/msm_gpio.c > @@ -120,6 +120,7 @@ static const struct udevice_id msm_gpio_ids[] =3D { > { .compatible =3D "qcom,msm8916-pinctrl" }, > { .compatible =3D "qcom,apq8016-pinctrl" }, > { .compatible =3D "qcom,ipq4019-pinctrl" }, > + { .compatible =3D "qcom,sdm845-pinctrl" }, > { } > }; > > diff --git a/drivers/gpio/pm8916_gpio.c b/drivers/gpio/pm8916_gpio.c > index 40b0f2578b..7ad95784a8 100644 > --- a/drivers/gpio/pm8916_gpio.c > +++ b/drivers/gpio/pm8916_gpio.c > @@ -202,6 +202,7 @@ static int pm8916_gpio_of_to_plat(struct udevice *dev= ) > static const struct udevice_id pm8916_gpio_ids[] =3D { > { .compatible =3D "qcom,pm8916-gpio" }, > { .compatible =3D "qcom,pm8994-gpio" }, /* 22 GPIO's */ > + { .compatible =3D "qcom,pm8998-gpio" }, > { } > }; > > @@ -266,7 +267,7 @@ static int pm8941_pwrkey_probe(struct udevice *dev) > return log_msg_ret("bad type", -ENXIO); > > reg =3D pmic_reg_read(dev->parent, priv->pid + REG_SUBTYPE); > - if (reg !=3D 0x1) > + if ((reg & 0x5) =3D=3D 0) > return log_msg_ret("bad subtype", -ENXIO); > > return 0; > @@ -287,11 +288,12 @@ static int pm8941_pwrkey_of_to_plat(struct udevice = *dev) > static const struct udevice_id pm8941_pwrkey_ids[] =3D { > { .compatible =3D "qcom,pm8916-pwrkey" }, > { .compatible =3D "qcom,pm8994-pwrkey" }, > + { .compatible =3D "qcom,pm8998-pwrkey" }, > { } > }; > > -U_BOOT_DRIVER(pwrkey_pm8941) =3D { > - .name =3D "pwrkey_pm8916", > +U_BOOT_DRIVER(pwrkey_pm89xx) =3D { > + .name =3D "pwrkey_pm89xx", > .id =3D UCLASS_GPIO, > .of_match =3D pm8941_pwrkey_ids, > .of_to_plat =3D pm8941_pwrkey_of_to_plat, > -- > 2.20.1 > Reviewed-by: Ramon Fried