From: Ramon Fried <rfried.dev@gmail.com>
To: Adam Ford <aford173@gmail.com>
Cc: Joe Hershberger <joe.hershberger@ni.com>,
Tim Harvey <tharvey@gateworks.com>,
u-boot <u-boot@lists.denx.de>,
Sean Anderson <sean.anderson@seco.com>
Subject: Re: [PATCH 1/2] net: fec: prevent undesired de-assertion of phy-reset on request
Date: Sun, 10 Apr 2022 08:05:03 +0300 [thread overview]
Message-ID: <CAGi-RUJNqAPsGubtCxwbdNxzak-hKTrSeSMgMby8jp4Zm0w7Yw@mail.gmail.com> (raw)
In-Reply-To: <CAGi-RU+24zpHHkqMBJe8a+1=dfG=PY9GU92KLGq=-X2eVHPhGg@mail.gmail.com>
On Thu, Mar 3, 2022 at 9:55 AM Ramon Fried <rfried.dev@gmail.com> wrote:
>
> On Wed, Mar 2, 2022 at 3:58 AM Adam Ford <aford173@gmail.com> wrote:
> >
> > On Tue, Mar 1, 2022 at 2:38 PM Joe Hershberger <joe.hershberger@ni.com> wrote:
> > >
> > > On Tue, Mar 1, 2022 at 2:15 PM Tim Harvey <tharvey@gateworks.com> wrote:
> > > >
> > > > When gpio_request_by_name allocates a gpio output it by default will
> > > > de-assert the gpio which for phy-reset will take the PHY out of reset.
> > > > As this occurs before fec_gpio_reset is called to assert the reset
> > > > line it can cause undesired affects if reset timings are not properly
> > > > met.
> > > >
> > > > Configure the gpio with GPIOD_IS_OUT_ACTIVE so that reset is kept active
> > > > (reset asserted) to avoid this.
> > > >
> > > > Cc: Sean Anderson <sean.anderson@seco.com>
> > > > Signed-off-by: Tim Harvey <tharvey@gateworks.com>
> > >
> > > Acked-by: Joe Hershberger <joe.hershberger@ni.com>
> >
> > Tested-by: Adam Ford <aford173@gmail.com> #imx8mm-beacon
> Reviewed-by: Ramon Fried <rfried.dev@gmail.com>
Applied to u-boot-net/next
Thanks,
Ramon
next prev parent reply other threads:[~2022-04-10 5:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-01 20:15 [PATCH 0/2] prevent undesired de-assertion of phy-reset Tim Harvey
2022-03-01 20:15 ` [PATCH 1/2] net: fec: prevent undesired de-assertion of phy-reset on request Tim Harvey
2022-03-01 20:38 ` Joe Hershberger
2022-03-02 1:58 ` Adam Ford
2022-03-03 7:55 ` Ramon Fried
2022-04-10 5:05 ` Ramon Fried [this message]
2022-03-01 20:15 ` [PATCH 2/2] net: eth-phy: " Tim Harvey
2022-03-01 20:38 ` Joe Hershberger
2022-03-03 7:55 ` Ramon Fried
2022-04-10 5:05 ` Ramon Fried
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGi-RUJNqAPsGubtCxwbdNxzak-hKTrSeSMgMby8jp4Zm0w7Yw@mail.gmail.com \
--to=rfried.dev@gmail.com \
--cc=aford173@gmail.com \
--cc=joe.hershberger@ni.com \
--cc=sean.anderson@seco.com \
--cc=tharvey@gateworks.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.