From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3D85C433F5 for ; Mon, 13 Sep 2021 18:41:20 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C53E260F9F for ; Mon, 13 Sep 2021 18:41:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org C53E260F9F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id A48D483215; Mon, 13 Sep 2021 20:41:17 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="q6FztU7w"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 186B482C89; Mon, 13 Sep 2021 20:41:15 +0200 (CEST) Received: from mail-ot1-x32e.google.com (mail-ot1-x32e.google.com [IPv6:2607:f8b0:4864:20::32e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 9280582C89 for ; Mon, 13 Sep 2021 20:41:06 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=rfried.dev@gmail.com Received: by mail-ot1-x32e.google.com with SMTP id x10-20020a056830408a00b004f26cead745so14649832ott.10 for ; Mon, 13 Sep 2021 11:41:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=L/PS5yoYFEbCX5+423qi68Hy4L5tUngF9c2lDE6KjVo=; b=q6FztU7wCTMQngARUT180WGyRdOHMk6vkIpy/NOnLvlgfGn0YyDB20f6svh8CIoM9a pggow545gT4jVC76J/YpkdnvQ5PbsWh1oCuOhUcp0Llwq+y6yQ4IsAHps5bo4BvNimU5 +8ZLWiXeGpmOObh+aKdzRS0nnmVq19SO5yj2zU5SbS9EafN2vdhBGjrK7qzqM7aJmSPI 33qqjoFwu6cXcf6Ax22M531jFSmA3b3loU7/4tFnOSR1BTdiACfD/rr5GQ5NN0+C9jSj OBiLUAg7M6FUa7bpzyAKmm/0B33wS9Ha5yI6/7I6JFjtB96WraOOa6Oy3RbBYXZykpy0 2GlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=L/PS5yoYFEbCX5+423qi68Hy4L5tUngF9c2lDE6KjVo=; b=SurEE1LhVkYAvc49Qh+e3mlOwFGj1v+WIUDI2vb0EVaH528PtgON6Cm7+Qrl7ojxkL SRvJ6NNCSjaWNn/6PLtOS2ij3YStMtAR6rnECaQIGuxpcI8bXGh8mwCSWJcn/hBq6BrE p45RhxLAgyO4ZZmqoRxUQvbKVLJXri2+QurNUvAtZ+6sA1GVaUYLTHZ7va1xwj73l262 VeuFlTc+6Z3INQaom6Yqkbl829u0dKD78/HW17pYsuOV4LX/JUcKDSnpsHjdlfaZl3Rf jpMuphrt/J7XdiCmTaPK4pd7nRjpzdphle0Bxxc7xKce96ZRTbU71jQ4DDGu1vg1vQcf Rb0g== X-Gm-Message-State: AOAM531WIR4CE3opyTLP20kkL0hAOMJqSFnGHOIlOhQNgJWc6+ypLaL+ 4lviMB3Gl5joK/gft7Vge7F/krdqxYLpcBwBm6Y= X-Google-Smtp-Source: ABdhPJzMsLUoHQSx4E9/7c5QFtA9iW4YUAO6Gsss+PGYgQ3ABojPwro+mUjH+DnhjiKTEhv5hDOsZslC+RGjA4651xA= X-Received: by 2002:a05:6830:1d69:: with SMTP id l9mr10938904oti.154.1631558465040; Mon, 13 Sep 2021 11:41:05 -0700 (PDT) MIME-Version: 1.0 References: <20210912031516.24885-1-bmeng.cn@gmail.com> <20210912031516.24885-7-bmeng.cn@gmail.com> In-Reply-To: <20210912031516.24885-7-bmeng.cn@gmail.com> From: Ramon Fried Date: Mon, 13 Sep 2021 21:40:53 +0300 Message-ID: Subject: Re: [PATCH 7/9] net: macb: Fix -Wint-to-pointer-cast warnings To: Bin Meng Cc: Simon Glass , Rick Chen , Leo Yu-Chi Liang , U-Boot Mailing List Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Sun, Sep 12, 2021 at 6:16 AM Bin Meng wrote: > > The following warning is seen in macb.c in a 32-bit build: > > warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] > > Change to use dev_read_addr_index_ptr(), or cast with uintptr_t. > > Signed-off-by: Bin Meng > --- > > drivers/net/macb.c | 11 +++-------- > 1 file changed, 3 insertions(+), 8 deletions(-) > > diff --git a/drivers/net/macb.c b/drivers/net/macb.c > index 57ea45e2dc..fe14027b31 100644 > --- a/drivers/net/macb.c > +++ b/drivers/net/macb.c > @@ -574,14 +574,9 @@ static int macb_phy_find(struct macb_device *macb, const char *name) > #ifdef CONFIG_DM_ETH > static int macb_sifive_clk_init(struct udevice *dev, ulong rate) > { > - fdt_addr_t addr; > void *gemgxl_regs; > > - addr = dev_read_addr_index(dev, 1); > - if (addr == FDT_ADDR_T_NONE) > - return -ENODEV; > - > - gemgxl_regs = (void __iomem *)addr; > + gemgxl_regs = dev_read_addr_index_ptr(dev, 1); > if (!gemgxl_regs) > return -ENODEV; > > @@ -1383,7 +1378,7 @@ static int macb_eth_probe(struct udevice *dev) > macb->phy_addr = ofnode_read_u32_default(phandle_args.node, > "reg", -1); > > - macb->regs = (void *)pdata->iobase; > + macb->regs = (void *)(uintptr_t)pdata->iobase; > > macb->is_big_endian = (cpu_to_be32(0x12345678) == 0x12345678); > > @@ -1444,7 +1439,7 @@ static int macb_eth_of_to_plat(struct udevice *dev) > { > struct eth_pdata *pdata = dev_get_plat(dev); > > - pdata->iobase = (phys_addr_t)dev_remap_addr(dev); > + pdata->iobase = (uintptr_t)dev_remap_addr(dev); > if (!pdata->iobase) > return -EINVAL; > > -- > 2.25.1 > Reviewed-by: Ramon Fried