From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD5D0C11F67 for ; Tue, 29 Jun 2021 22:57:04 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1F73E61D00 for ; Tue, 29 Jun 2021 22:57:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1F73E61D00 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 7691E831EC; Wed, 30 Jun 2021 00:57:01 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="eigT7q75"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 8B19F831F9; Wed, 30 Jun 2021 00:56:59 +0200 (CEST) Received: from mail-oo1-xc35.google.com (mail-oo1-xc35.google.com [IPv6:2607:f8b0:4864:20::c35]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 47AA0831BF for ; Wed, 30 Jun 2021 00:56:56 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=rfried.dev@gmail.com Received: by mail-oo1-xc35.google.com with SMTP id b17-20020a4aba110000b029024c219a3d83so96593oop.10 for ; Tue, 29 Jun 2021 15:56:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=dS6HUlH7/wM8kqjPMa4mHoVxn9RzkDNIjnqnVTM3IAY=; b=eigT7q75W99YZfNMJXZ9Q9Gi/5F337HRnuDhpelXOnAisaLFXx9zaw68jqtXRfOgZw Sf9UAsGEh+xFLm2qs/iG5vZC4evjNMCDU/qEL+YYsBI/r+e/3OVaCi0iC8GNPd7mHqXw wJ7GrZ4/Aoe0VWRIZB7FqEgmlguwrIjfAptCVXr05ev+x9k8ooE7tL77cwsbOOGPqoPn PKAizxfuqTx7O1mzzsUx5t0xKO8khMoiBxtCqEIVv+End7O658/DBSwRCnP1tgCNg5Ch CPi9PifZrgZbIuxJFfKuKm1vckWM1ynFLg/ofoXG6uZVWvEjvTC1BAFkiMpCGeMGO8tS CrOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=dS6HUlH7/wM8kqjPMa4mHoVxn9RzkDNIjnqnVTM3IAY=; b=GKdLAcJPL5sY5TXrGAl/xcJeeKep9inPztKk8perMGNeaD/DYcyq76W9zvDXOe+q5/ LEvE6yNr4oSQ09lcsv5dMC58dQxX9g6mlHSQkeaDrN+Vetb48r7p1wEAsfKW39Ya9wG+ C/jq0gx5/TgwaqSChNR7kT58E1ggPvEfOyDFYJ6d7BTs768ipGAaFo2HPR+u2kTggmUK 7ReVS/l1+v6zUIIWfvJa07ZqAlWEjA7nMcX+gPiHwy/FuWRkWWAVnGUilv6FTuRyuJ30 9t3s/MXY6z49lMzRBnZ042URIy2EJS59lGrwOtx8mvFRz1I5vjlqSMSf0a2r0ChmsOKz 5knQ== X-Gm-Message-State: AOAM532rz0goYJGntNnm0ANUZ8m+xy+/joI4RFkNDlI7DT9XrkSI3ah6 Mz7ONZpl4AtGkOwaZw8pGm/DR+VWNXI5Zg0MDdY= X-Google-Smtp-Source: ABdhPJzBcnwNXYuuJP9y7qV1MRnQJSCsAd85Ety7KMcCCnlIO3jUuw94w2u98B+mvUAorY4BbZQr9z6DjJEX/o7/vVo= X-Received: by 2002:a4a:b60b:: with SMTP id z11mr5970045oon.57.1625007415005; Tue, 29 Jun 2021 15:56:55 -0700 (PDT) MIME-Version: 1.0 References: <20210617222604.2563375-1-vladimir.oltean@nxp.com> <20210617222604.2563375-2-vladimir.oltean@nxp.com> In-Reply-To: <20210617222604.2563375-2-vladimir.oltean@nxp.com> From: Ramon Fried Date: Wed, 30 Jun 2021 01:56:44 +0300 Message-ID: Subject: Re: [PATCH v2 1/6] arm: dts: ls1028a: enable the switch CPU port for the LS1028A-QDS To: Vladimir Oltean Cc: Joe Hershberger , U-Boot Mailing List , Claudiu Manoil , Priyanka Jain , Bin Meng Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Fri, Jun 18, 2021 at 1:26 AM Vladimir Oltean wrote: > > Due to an upstream change, the ls1028a.dtsi bindings for the mscc_felix > switch got accepted with all ports disabled by default and with no link > to the DSA master - this needs to be done on a per board basis. > > Note that enetc-2 is not currently disabled in the ls1028a.dtsi, but > presumably at some point it might become. Explicitly enable it in the > QDS device trees anyway, to proactively avoid issues when that happens. > > Fixes: a7fdac7e2a2a ("arm: dts: ls1028a: define QDS networking protocol combinations") > Signed-off-by: Vladimir Oltean > --- > v1->v2: none > > arch/arm/dts/fsl-ls1028a-qds-7777-sch-30841.dtsi | 9 +++++++++ > arch/arm/dts/fsl-ls1028a-qds-7xx7-sch-30841R.dtsi | 9 +++++++++ > arch/arm/dts/fsl-ls1028a-qds-9999-sch-24801-LBRW.dtsi | 9 +++++++++ > arch/arm/dts/fsl-ls1028a-qds-9999-sch-24801.dtsi | 9 +++++++++ > arch/arm/dts/fsl-ls1028a-qds-x3xx-sch-30841-LBRW.dtsi | 9 +++++++++ > arch/arm/dts/fsl-ls1028a-qds-x5xx-sch-28021-LBRW.dtsi | 9 +++++++++ > arch/arm/dts/fsl-ls1028a-qds-x7xx-sch-30842.dtsi | 9 +++++++++ > arch/arm/dts/fsl-ls1028a-qds-xx7x-sch-30842.dtsi | 9 +++++++++ > 8 files changed, 72 insertions(+) > > diff --git a/arch/arm/dts/fsl-ls1028a-qds-7777-sch-30841.dtsi b/arch/arm/dts/fsl-ls1028a-qds-7777-sch-30841.dtsi > index fb1836a8aef3..5a0f060c16e5 100644 > --- a/arch/arm/dts/fsl-ls1028a-qds-7777-sch-30841.dtsi > +++ b/arch/arm/dts/fsl-ls1028a-qds-7777-sch-30841.dtsi > @@ -20,6 +20,10 @@ > #include "fsl-sch-30841.dtsi" > }; > > +&enetc2 { > + status = "okay"; > +}; > + > &mscc_felix { > status = "okay"; > }; > @@ -47,3 +51,8 @@ > phy-mode = "sgmii-2500"; > phy-handle = <&{/i2c@2000000/fpga@66/mux-mdio@54/mdio@40/phy@03}>; > }; > + > +&mscc_felix_port4 { > + ethernet = <&enetc2>; > + status = "okay"; > +}; > diff --git a/arch/arm/dts/fsl-ls1028a-qds-7xx7-sch-30841R.dtsi b/arch/arm/dts/fsl-ls1028a-qds-7xx7-sch-30841R.dtsi > index 1d02a3e11def..39a83e10c4ce 100644 > --- a/arch/arm/dts/fsl-ls1028a-qds-7xx7-sch-30841R.dtsi > +++ b/arch/arm/dts/fsl-ls1028a-qds-7xx7-sch-30841R.dtsi > @@ -9,6 +9,10 @@ > #include "fsl-sch-30841.dtsi" > }; > > +&enetc2 { > + status = "okay"; > +}; > + > &mscc_felix { > status = "okay"; > }; > @@ -24,3 +28,8 @@ > phy-mode = "sgmii-2500"; > phy-handle = <&{/i2c@2000000/fpga@66/mux-mdio@54/mdio@40/phy@03}>; > }; > + > +&mscc_felix_port4 { > + ethernet = <&enetc2>; > + status = "okay"; > +}; > diff --git a/arch/arm/dts/fsl-ls1028a-qds-9999-sch-24801-LBRW.dtsi b/arch/arm/dts/fsl-ls1028a-qds-9999-sch-24801-LBRW.dtsi > index c92dd1bd2e95..021fe3fbc67a 100644 > --- a/arch/arm/dts/fsl-ls1028a-qds-9999-sch-24801-LBRW.dtsi > +++ b/arch/arm/dts/fsl-ls1028a-qds-9999-sch-24801-LBRW.dtsi > @@ -34,6 +34,10 @@ > #include "fsl-sch-24801.dtsi" > }; > > +&enetc2 { > + status = "okay"; > +}; > + > &mscc_felix { > status = "okay"; > }; > @@ -61,3 +65,8 @@ > phy-mode = "sgmii"; > phy-handle = <&{/i2c@2000000/fpga@66/mux-mdio@54/mdio@40/phy@1f}>; > }; > + > +&mscc_felix_port4 { > + ethernet = <&enetc2>; > + status = "okay"; > +}; > diff --git a/arch/arm/dts/fsl-ls1028a-qds-9999-sch-24801.dtsi b/arch/arm/dts/fsl-ls1028a-qds-9999-sch-24801.dtsi > index 941f7472eb09..b6704d8089a8 100644 > --- a/arch/arm/dts/fsl-ls1028a-qds-9999-sch-24801.dtsi > +++ b/arch/arm/dts/fsl-ls1028a-qds-9999-sch-24801.dtsi > @@ -19,6 +19,10 @@ > #include "fsl-sch-24801.dtsi" > }; > > +&enetc2 { > + status = "okay"; > +}; > + > &mscc_felix { > status = "okay"; > }; > @@ -46,3 +50,8 @@ > phy-mode = "sgmii"; > phy-handle = <&{/i2c@2000000/fpga@66/mux-mdio@54/mdio@40/phy@1f}>; > }; > + > +&mscc_felix_port4 { > + ethernet = <&enetc2>; > + status = "okay"; > +}; > diff --git a/arch/arm/dts/fsl-ls1028a-qds-x3xx-sch-30841-LBRW.dtsi b/arch/arm/dts/fsl-ls1028a-qds-x3xx-sch-30841-LBRW.dtsi > index 7e483e656e28..8c10897e565c 100644 > --- a/arch/arm/dts/fsl-ls1028a-qds-x3xx-sch-30841-LBRW.dtsi > +++ b/arch/arm/dts/fsl-ls1028a-qds-x3xx-sch-30841-LBRW.dtsi > @@ -19,6 +19,10 @@ > #include "fsl-sch-30841.dtsi" > }; > > +&enetc2 { > + status = "okay"; > +}; > + > &mscc_felix { > status = "okay"; > }; > @@ -46,3 +50,8 @@ > phy-mode = "usxgmii"; > phy-handle = <&{/i2c@2000000/fpga@66/mux-mdio@54/mdio@50/phy@03}>; > }; > + > +&mscc_felix_port4 { > + ethernet = <&enetc2>; > + status = "okay"; > +}; > diff --git a/arch/arm/dts/fsl-ls1028a-qds-x5xx-sch-28021-LBRW.dtsi b/arch/arm/dts/fsl-ls1028a-qds-x5xx-sch-28021-LBRW.dtsi > index 49fffdb9cb2a..1d800dacef89 100644 > --- a/arch/arm/dts/fsl-ls1028a-qds-x5xx-sch-28021-LBRW.dtsi > +++ b/arch/arm/dts/fsl-ls1028a-qds-x5xx-sch-28021-LBRW.dtsi > @@ -13,6 +13,10 @@ > #include "fsl-sch-28021.dtsi" > }; > > +&enetc2 { > + status = "okay"; > +}; > + > &mscc_felix { > status = "okay"; > }; > @@ -40,3 +44,8 @@ > phy-mode = "qsgmii"; > phy-handle = <&{/i2c@2000000/fpga@66/mux-mdio@54/mdio@50/phy@0b}>; > }; > + > +&mscc_felix_port4 { > + ethernet = <&enetc2>; > + status = "okay"; > +}; > diff --git a/arch/arm/dts/fsl-ls1028a-qds-x7xx-sch-30842.dtsi b/arch/arm/dts/fsl-ls1028a-qds-x7xx-sch-30842.dtsi > index 8347462f4cb0..1fb2cdf0c244 100644 > --- a/arch/arm/dts/fsl-ls1028a-qds-x7xx-sch-30842.dtsi > +++ b/arch/arm/dts/fsl-ls1028a-qds-x7xx-sch-30842.dtsi > @@ -9,6 +9,10 @@ > #include "fsl-sch-30842.dtsi" > }; > > +&enetc2 { > + status = "okay"; > +}; > + > &mscc_felix { > status = "okay"; > }; > @@ -18,3 +22,8 @@ > phy-mode = "sgmii-2500"; > phy-handle = <&{/i2c@2000000/fpga@66/mux-mdio@54/mdio@50/phy@02}>; > }; > + > +&mscc_felix_port4 { > + ethernet = <&enetc2>; > + status = "okay"; > +}; > diff --git a/arch/arm/dts/fsl-ls1028a-qds-xx7x-sch-30842.dtsi b/arch/arm/dts/fsl-ls1028a-qds-xx7x-sch-30842.dtsi > index 6be3b5094c81..2333f74e5ae1 100644 > --- a/arch/arm/dts/fsl-ls1028a-qds-xx7x-sch-30842.dtsi > +++ b/arch/arm/dts/fsl-ls1028a-qds-xx7x-sch-30842.dtsi > @@ -9,6 +9,10 @@ > #include "fsl-sch-30842.dtsi" > }; > > +&enetc2 { > + status = "okay"; > +}; > + > &mscc_felix { > status = "okay"; > }; > @@ -18,3 +22,8 @@ > phy-mode = "sgmii-2500"; > phy-handle = <&{/i2c@2000000/fpga@66/mux-mdio@54/mdio@60/phy@02}>; > }; > + > +&mscc_felix_port4 { > + ethernet = <&enetc2>; > + status = "okay"; > +}; > -- > 2.25.1 > Applied to u-boot-net/master, Thanks ! Ramon